Skip to content

feat(project): add CDK Toolkit adapter - #2057

Merged
tejaskash merged 2 commits into
refactorfrom
feat/project-cdk-toolkit
Aug 24, 2026
Merged

feat(project): add CDK Toolkit adapter#2057
tejaskash merged 2 commits into
refactorfrom
feat/project-cdk-toolkit

Conversation

@notgitika

@notgitikanotgitika commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a backend-local adapter for @aws-cdk/toolkit-lib
  • load the Toolkit lazily and route notifications through the existing logger at debug level
  • keep the Toolkit external in the npm bundle
  • add direct adapter tests without activating deployment

Stack

This is PR 3 of 4 decomposing #2001. The adapter is backend-local rather than part of shared io. Review and merge bottom-up.

  1. refactor(project): move build behind a project backend #2055 - backend build boundary
  2. feat(project): add deploy command contract #2056 - deploy command contract
  3. feat(project): add CDK Toolkit adapter #2057 - CDK Toolkit adapter (this PR)
  4. feat(project): implement safe CDK deployment #2058 - safe deployment implementation

typecheck, lint, format, test all pass

@github-actionsgithub-actionsBot added the size/xl PR size: XL label Aug 20, 2026
@github-actionsgithub-actionsBot added agentcore-harness-reviewing AgentCore Harness review in progress size/xl PR size: XL and removed size/xl PR size: XL agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 20, 2026
@notgitika
notgitika marked this pull request as ready for review August 20, 2026 04:12
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from a3da8e2 to 000e3b8CompareAugust 20, 2026 04:19
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 20, 2026
@notgitika
notgitika marked this pull request as draft August 20, 2026 04:19
@notgitika
notgitika marked this pull request as ready for review August 20, 2026 04:24
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 20, 2026
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from 000e3b8 to ef1f731CompareAugust 20, 2026 17:06
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 20, 2026
Comment threadsrc/core/project/backends/cdk/toolkit.ts
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from ef1f731 to c4723b3CompareAugust 21, 2026 16:01
@codecov-commenter

codecov-commenter commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.26%. Comparing base (fee25e2) to head (9750c4e).

Additional details and impacted files
@@ Coverage Diff @@## refactor #2057 +/- ##
=========================================
Coverage 97.25% 97.26% =========================================
Files 397 398 +1 Lines 24125 24192 +67 =========================================
+ Hits 23463 23530 +67 
Misses 662 662 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from c4723b3 to 6c52205CompareAugust 21, 2026 16:16
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from 6c52205 to 8b9d408CompareAugust 21, 2026 17:41
Comment threadscripts/build.ts
Comment threadsrc/core/project/backends/cdk/toolkit.ts
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from 8b9d408 to 33e58a0CompareAugust 21, 2026 18:12
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from 33e58a0 to d5e69ffCompareAugust 21, 2026 18:21
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from d5e69ff to 5cc76e5CompareAugust 24, 2026 14:59
Base automatically changed from feat/project-deploy-contract to refactorAugust 24, 2026 16:01
PATTERN_MUST_MATCH_SINGLE throws unless the pattern matches exactly one
stack, so an absent result was never "no match". The Toolkit skips a
stack whose synthesized template has no resources, and deletes it if a
stack of that name already exists — both return normally with no stacks.
`?? {}` turned that into a successful deploy with no outputs, so a caller
expecting RuntimeArn got undefined with nothing explaining why.
Assert exactly one stack and name both possibilities in the error,
keeping `?? {}` only for a stack that deployed but declares no outputs.
Both paths are now covered; the fake toolkit takes the stack list so the
resource-less case is reachable from a test.
Also narrows the `external` comment in scripts/build.ts: it describes the
npm bundle only. compile() cannot mark the Toolkit external because a
standalone binary ships no node_modules, so Bun inlines it and rewrites
__dirname to the build machine's path — which resolves on the builder and
fails everywhere else.
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from 5cc76e5 to 9750c4eCompareAugust 24, 2026 16:01
}

/** Loads the Toolkit only when a deploy operation needs it. */
export const loadCdkToolkit: CdkToolkitLoader = async (ioHost, region) => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how this is loaded lazily.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I had my agent test the latency with the static import and it was quite a bit higher. thanks!

@tejaskash
tejaskash merged commit 1a297be into refactorAug 24, 2026
11 checks passed
@tejaskash
tejaskash deleted the feat/project-cdk-toolkit branch August 24, 2026 17:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xlPR size: XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@notgitika@codecov-commenter@Hweinstock@tejaskash
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
feat(project): add CDK Toolkit adapter by notgitika · Pull Request #2057 · aws/agentcore-cli · GitHub
Skip to content

feat(project): add CDK Toolkit adapter - #2057

Merged
tejaskash merged 2 commits into
refactorfrom
feat/project-cdk-toolkit
Aug 24, 2026
Merged

feat(project): add CDK Toolkit adapter#2057
tejaskash merged 2 commits into
refactorfrom
feat/project-cdk-toolkit

Conversation

@notgitika

@notgitikanotgitika commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a backend-local adapter for @aws-cdk/toolkit-lib
  • load the Toolkit lazily and route notifications through the existing logger at debug level
  • keep the Toolkit external in the npm bundle
  • add direct adapter tests without activating deployment

Stack

This is PR 3 of 4 decomposing #2001. The adapter is backend-local rather than part of shared io. Review and merge bottom-up.

  1. refactor(project): move build behind a project backend #2055 - backend build boundary
  2. feat(project): add deploy command contract #2056 - deploy command contract
  3. feat(project): add CDK Toolkit adapter #2057 - CDK Toolkit adapter (this PR)
  4. feat(project): implement safe CDK deployment #2058 - safe deployment implementation

typecheck, lint, format, test all pass

@github-actionsgithub-actionsBot added the size/xl PR size: XL label Aug 20, 2026
@github-actionsgithub-actionsBot added agentcore-harness-reviewing AgentCore Harness review in progress size/xl PR size: XL and removed size/xl PR size: XL agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 20, 2026
@notgitika
notgitika marked this pull request as ready for review August 20, 2026 04:12
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from a3da8e2 to 000e3b8CompareAugust 20, 2026 04:19
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 20, 2026
@notgitika
notgitika marked this pull request as draft August 20, 2026 04:19
@notgitika
notgitika marked this pull request as ready for review August 20, 2026 04:24
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 20, 2026
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from 000e3b8 to ef1f731CompareAugust 20, 2026 17:06
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 20, 2026
Comment threadsrc/core/project/backends/cdk/toolkit.ts
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from ef1f731 to c4723b3CompareAugust 21, 2026 16:01
@codecov-commenter

codecov-commenter commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.26%. Comparing base (fee25e2) to head (9750c4e).

Additional details and impacted files
@@ Coverage Diff @@## refactor #2057 +/- ##
=========================================
Coverage 97.25% 97.26% =========================================
Files 397 398 +1 Lines 24125 24192 +67 =========================================
+ Hits 23463 23530 +67 
Misses 662 662 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from c4723b3 to 6c52205CompareAugust 21, 2026 16:16
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from 6c52205 to 8b9d408CompareAugust 21, 2026 17:41
Comment threadscripts/build.ts
Comment threadsrc/core/project/backends/cdk/toolkit.ts
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from 8b9d408 to 33e58a0CompareAugust 21, 2026 18:12
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from 33e58a0 to d5e69ffCompareAugust 21, 2026 18:21
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from d5e69ff to 5cc76e5CompareAugust 24, 2026 14:59
Base automatically changed from feat/project-deploy-contract to refactorAugust 24, 2026 16:01
PATTERN_MUST_MATCH_SINGLE throws unless the pattern matches exactly one
stack, so an absent result was never "no match". The Toolkit skips a
stack whose synthesized template has no resources, and deletes it if a
stack of that name already exists — both return normally with no stacks.
`?? {}` turned that into a successful deploy with no outputs, so a caller
expecting RuntimeArn got undefined with nothing explaining why.
Assert exactly one stack and name both possibilities in the error,
keeping `?? {}` only for a stack that deployed but declares no outputs.
Both paths are now covered; the fake toolkit takes the stack list so the
resource-less case is reachable from a test.
Also narrows the `external` comment in scripts/build.ts: it describes the
npm bundle only. compile() cannot mark the Toolkit external because a
standalone binary ships no node_modules, so Bun inlines it and rewrites
__dirname to the build machine's path — which resolves on the builder and
fails everywhere else.
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from 5cc76e5 to 9750c4eCompareAugust 24, 2026 16:01
}

/** Loads the Toolkit only when a deploy operation needs it. */
export const loadCdkToolkit: CdkToolkitLoader = async (ioHost, region) => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how this is loaded lazily.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I had my agent test the latency with the static import and it was quite a bit higher. thanks!

@tejaskash
tejaskash merged commit 1a297be into refactorAug 24, 2026
11 checks passed
@tejaskash
tejaskash deleted the feat/project-cdk-toolkit branch August 24, 2026 17:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xlPR size: XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@notgitika@codecov-commenter@Hweinstock@tejaskash
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(project): add CDK Toolkit adapter by notgitika · Pull Request #2057 · aws/agentcore-cli · GitHub
Skip to content

feat(project): add CDK Toolkit adapter - #2057

Merged
tejaskash merged 2 commits into
refactorfrom
feat/project-cdk-toolkit
Aug 24, 2026
Merged

feat(project): add CDK Toolkit adapter#2057
tejaskash merged 2 commits into
refactorfrom
feat/project-cdk-toolkit

Conversation

@notgitika

@notgitikanotgitika commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a backend-local adapter for @aws-cdk/toolkit-lib
  • load the Toolkit lazily and route notifications through the existing logger at debug level
  • keep the Toolkit external in the npm bundle
  • add direct adapter tests without activating deployment

Stack

This is PR 3 of 4 decomposing #2001. The adapter is backend-local rather than part of shared io. Review and merge bottom-up.

  1. refactor(project): move build behind a project backend #2055 - backend build boundary
  2. feat(project): add deploy command contract #2056 - deploy command contract
  3. feat(project): add CDK Toolkit adapter #2057 - CDK Toolkit adapter (this PR)
  4. feat(project): implement safe CDK deployment #2058 - safe deployment implementation

typecheck, lint, format, test all pass

@github-actionsgithub-actionsBot added the size/xl PR size: XL label Aug 20, 2026
@github-actionsgithub-actionsBot added agentcore-harness-reviewing AgentCore Harness review in progress size/xl PR size: XL and removed size/xl PR size: XL agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 20, 2026
@notgitika
notgitika marked this pull request as ready for review August 20, 2026 04:12
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from a3da8e2 to 000e3b8CompareAugust 20, 2026 04:19
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 20, 2026
@notgitika
notgitika marked this pull request as draft August 20, 2026 04:19
@notgitika
notgitika marked this pull request as ready for review August 20, 2026 04:24
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 20, 2026
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from 000e3b8 to ef1f731CompareAugust 20, 2026 17:06
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 20, 2026
Comment threadsrc/core/project/backends/cdk/toolkit.ts
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from ef1f731 to c4723b3CompareAugust 21, 2026 16:01
@codecov-commenter

codecov-commenter commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.26%. Comparing base (fee25e2) to head (9750c4e).

Additional details and impacted files
@@ Coverage Diff @@## refactor #2057 +/- ##
=========================================
Coverage 97.25% 97.26% =========================================
Files 397 398 +1 Lines 24125 24192 +67 =========================================
+ Hits 23463 23530 +67 
Misses 662 662 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from c4723b3 to 6c52205CompareAugust 21, 2026 16:16
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from 6c52205 to 8b9d408CompareAugust 21, 2026 17:41
Comment threadscripts/build.ts
Comment threadsrc/core/project/backends/cdk/toolkit.ts
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from 8b9d408 to 33e58a0CompareAugust 21, 2026 18:12
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from 33e58a0 to d5e69ffCompareAugust 21, 2026 18:21
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from d5e69ff to 5cc76e5CompareAugust 24, 2026 14:59
Base automatically changed from feat/project-deploy-contract to refactorAugust 24, 2026 16:01
PATTERN_MUST_MATCH_SINGLE throws unless the pattern matches exactly one
stack, so an absent result was never "no match". The Toolkit skips a
stack whose synthesized template has no resources, and deletes it if a
stack of that name already exists — both return normally with no stacks.
`?? {}` turned that into a successful deploy with no outputs, so a caller
expecting RuntimeArn got undefined with nothing explaining why.
Assert exactly one stack and name both possibilities in the error,
keeping `?? {}` only for a stack that deployed but declares no outputs.
Both paths are now covered; the fake toolkit takes the stack list so the
resource-less case is reachable from a test.
Also narrows the `external` comment in scripts/build.ts: it describes the
npm bundle only. compile() cannot mark the Toolkit external because a
standalone binary ships no node_modules, so Bun inlines it and rewrites
__dirname to the build machine's path — which resolves on the builder and
fails everywhere else.
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from 5cc76e5 to 9750c4eCompareAugust 24, 2026 16:01
}

/** Loads the Toolkit only when a deploy operation needs it. */
export const loadCdkToolkit: CdkToolkitLoader = async (ioHost, region) => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how this is loaded lazily.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I had my agent test the latency with the static import and it was quite a bit higher. thanks!

@tejaskash
tejaskash merged commit 1a297be into refactorAug 24, 2026
11 checks passed
@tejaskash
tejaskash deleted the feat/project-cdk-toolkit branch August 24, 2026 17:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xlPR size: XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@notgitika@codecov-commenter@Hweinstock@tejaskash
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(project): add CDK Toolkit adapter by notgitika · Pull Request #2057 · aws/agentcore-cli · GitHub
Skip to content

feat(project): add CDK Toolkit adapter - #2057

Merged
tejaskash merged 2 commits into
refactorfrom
feat/project-cdk-toolkit
Aug 24, 2026
Merged

feat(project): add CDK Toolkit adapter#2057
tejaskash merged 2 commits into
refactorfrom
feat/project-cdk-toolkit

Conversation

@notgitika

@notgitikanotgitika commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a backend-local adapter for @aws-cdk/toolkit-lib
  • load the Toolkit lazily and route notifications through the existing logger at debug level
  • keep the Toolkit external in the npm bundle
  • add direct adapter tests without activating deployment

Stack

This is PR 3 of 4 decomposing #2001. The adapter is backend-local rather than part of shared io. Review and merge bottom-up.

  1. refactor(project): move build behind a project backend #2055 - backend build boundary
  2. feat(project): add deploy command contract #2056 - deploy command contract
  3. feat(project): add CDK Toolkit adapter #2057 - CDK Toolkit adapter (this PR)
  4. feat(project): implement safe CDK deployment #2058 - safe deployment implementation

typecheck, lint, format, test all pass

@github-actionsgithub-actionsBot added the size/xl PR size: XL label Aug 20, 2026
@github-actionsgithub-actionsBot added agentcore-harness-reviewing AgentCore Harness review in progress size/xl PR size: XL and removed size/xl PR size: XL agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 20, 2026
@notgitika
notgitika marked this pull request as ready for review August 20, 2026 04:12
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from a3da8e2 to 000e3b8CompareAugust 20, 2026 04:19
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 20, 2026
@notgitika
notgitika marked this pull request as draft August 20, 2026 04:19
@notgitika
notgitika marked this pull request as ready for review August 20, 2026 04:24
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 20, 2026
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from 000e3b8 to ef1f731CompareAugust 20, 2026 17:06
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 20, 2026
Comment threadsrc/core/project/backends/cdk/toolkit.ts
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from ef1f731 to c4723b3CompareAugust 21, 2026 16:01
@codecov-commenter

codecov-commenter commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.26%. Comparing base (fee25e2) to head (9750c4e).

Additional details and impacted files
@@ Coverage Diff @@## refactor #2057 +/- ##
=========================================
Coverage 97.25% 97.26% =========================================
Files 397 398 +1 Lines 24125 24192 +67 =========================================
+ Hits 23463 23530 +67 
Misses 662 662 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from c4723b3 to 6c52205CompareAugust 21, 2026 16:16
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from 6c52205 to 8b9d408CompareAugust 21, 2026 17:41
Comment threadscripts/build.ts
Comment threadsrc/core/project/backends/cdk/toolkit.ts
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from 8b9d408 to 33e58a0CompareAugust 21, 2026 18:12
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from 33e58a0 to d5e69ffCompareAugust 21, 2026 18:21
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from d5e69ff to 5cc76e5CompareAugust 24, 2026 14:59
Base automatically changed from feat/project-deploy-contract to refactorAugust 24, 2026 16:01
PATTERN_MUST_MATCH_SINGLE throws unless the pattern matches exactly one
stack, so an absent result was never "no match". The Toolkit skips a
stack whose synthesized template has no resources, and deletes it if a
stack of that name already exists — both return normally with no stacks.
`?? {}` turned that into a successful deploy with no outputs, so a caller
expecting RuntimeArn got undefined with nothing explaining why.
Assert exactly one stack and name both possibilities in the error,
keeping `?? {}` only for a stack that deployed but declares no outputs.
Both paths are now covered; the fake toolkit takes the stack list so the
resource-less case is reachable from a test.
Also narrows the `external` comment in scripts/build.ts: it describes the
npm bundle only. compile() cannot mark the Toolkit external because a
standalone binary ships no node_modules, so Bun inlines it and rewrites
__dirname to the build machine's path — which resolves on the builder and
fails everywhere else.
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from 5cc76e5 to 9750c4eCompareAugust 24, 2026 16:01
}

/** Loads the Toolkit only when a deploy operation needs it. */
export const loadCdkToolkit: CdkToolkitLoader = async (ioHost, region) => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how this is loaded lazily.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I had my agent test the latency with the static import and it was quite a bit higher. thanks!

@tejaskash
tejaskash merged commit 1a297be into refactorAug 24, 2026
11 checks passed
@tejaskash
tejaskash deleted the feat/project-cdk-toolkit branch August 24, 2026 17:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xlPR size: XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@notgitika@codecov-commenter@Hweinstock@tejaskash
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' feat(project): add CDK Toolkit adapter by notgitika · Pull Request #2057 · aws/agentcore-cli · GitHub
Skip to content

feat(project): add CDK Toolkit adapter - #2057

Merged
tejaskash merged 2 commits into
refactorfrom
feat/project-cdk-toolkit
Aug 24, 2026
Merged

feat(project): add CDK Toolkit adapter#2057
tejaskash merged 2 commits into
refactorfrom
feat/project-cdk-toolkit

Conversation

@notgitika

@notgitikanotgitika commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a backend-local adapter for @aws-cdk/toolkit-lib
  • load the Toolkit lazily and route notifications through the existing logger at debug level
  • keep the Toolkit external in the npm bundle
  • add direct adapter tests without activating deployment

Stack

This is PR 3 of 4 decomposing #2001. The adapter is backend-local rather than part of shared io. Review and merge bottom-up.

  1. refactor(project): move build behind a project backend #2055 - backend build boundary
  2. feat(project): add deploy command contract #2056 - deploy command contract
  3. feat(project): add CDK Toolkit adapter #2057 - CDK Toolkit adapter (this PR)
  4. feat(project): implement safe CDK deployment #2058 - safe deployment implementation

typecheck, lint, format, test all pass

@github-actionsgithub-actionsBot added the size/xl PR size: XL label Aug 20, 2026
@github-actionsgithub-actionsBot added agentcore-harness-reviewing AgentCore Harness review in progress size/xl PR size: XL and removed size/xl PR size: XL agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 20, 2026
@notgitika
notgitika marked this pull request as ready for review August 20, 2026 04:12
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from a3da8e2 to 000e3b8CompareAugust 20, 2026 04:19
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 20, 2026
@notgitika
notgitika marked this pull request as draft August 20, 2026 04:19
@notgitika
notgitika marked this pull request as ready for review August 20, 2026 04:24
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 20, 2026
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from 000e3b8 to ef1f731CompareAugust 20, 2026 17:06
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 20, 2026
Comment threadsrc/core/project/backends/cdk/toolkit.ts
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from ef1f731 to c4723b3CompareAugust 21, 2026 16:01
@codecov-commenter

codecov-commenter commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.26%. Comparing base (fee25e2) to head (9750c4e).

Additional details and impacted files
@@ Coverage Diff @@## refactor #2057 +/- ##
=========================================
Coverage 97.25% 97.26% =========================================
Files 397 398 +1 Lines 24125 24192 +67 =========================================
+ Hits 23463 23530 +67 
Misses 662 662 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from c4723b3 to 6c52205CompareAugust 21, 2026 16:16
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from 6c52205 to 8b9d408CompareAugust 21, 2026 17:41
Comment threadscripts/build.ts
Comment threadsrc/core/project/backends/cdk/toolkit.ts
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from 8b9d408 to 33e58a0CompareAugust 21, 2026 18:12
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from 33e58a0 to d5e69ffCompareAugust 21, 2026 18:21
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from d5e69ff to 5cc76e5CompareAugust 24, 2026 14:59
Base automatically changed from feat/project-deploy-contract to refactorAugust 24, 2026 16:01
PATTERN_MUST_MATCH_SINGLE throws unless the pattern matches exactly one
stack, so an absent result was never "no match". The Toolkit skips a
stack whose synthesized template has no resources, and deletes it if a
stack of that name already exists — both return normally with no stacks.
`?? {}` turned that into a successful deploy with no outputs, so a caller
expecting RuntimeArn got undefined with nothing explaining why.
Assert exactly one stack and name both possibilities in the error,
keeping `?? {}` only for a stack that deployed but declares no outputs.
Both paths are now covered; the fake toolkit takes the stack list so the
resource-less case is reachable from a test.
Also narrows the `external` comment in scripts/build.ts: it describes the
npm bundle only. compile() cannot mark the Toolkit external because a
standalone binary ships no node_modules, so Bun inlines it and rewrites
__dirname to the build machine's path — which resolves on the builder and
fails everywhere else.
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from 5cc76e5 to 9750c4eCompareAugust 24, 2026 16:01
}

/** Loads the Toolkit only when a deploy operation needs it. */
export const loadCdkToolkit: CdkToolkitLoader = async (ioHost, region) => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how this is loaded lazily.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I had my agent test the latency with the static import and it was quite a bit higher. thanks!

@tejaskash
tejaskash merged commit 1a297be into refactorAug 24, 2026
11 checks passed
@tejaskash
tejaskash deleted the feat/project-cdk-toolkit branch August 24, 2026 17:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xlPR size: XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@notgitika@codecov-commenter@Hweinstock@tejaskash
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(project): add CDK Toolkit adapter by notgitika · Pull Request #2057 · aws/agentcore-cli · GitHub
Skip to content

feat(project): add CDK Toolkit adapter - #2057

Merged
tejaskash merged 2 commits into
refactorfrom
feat/project-cdk-toolkit
Aug 24, 2026
Merged

feat(project): add CDK Toolkit adapter#2057
tejaskash merged 2 commits into
refactorfrom
feat/project-cdk-toolkit

Conversation

@notgitika

@notgitikanotgitika commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a backend-local adapter for @aws-cdk/toolkit-lib
  • load the Toolkit lazily and route notifications through the existing logger at debug level
  • keep the Toolkit external in the npm bundle
  • add direct adapter tests without activating deployment

Stack

This is PR 3 of 4 decomposing #2001. The adapter is backend-local rather than part of shared io. Review and merge bottom-up.

  1. refactor(project): move build behind a project backend #2055 - backend build boundary
  2. feat(project): add deploy command contract #2056 - deploy command contract
  3. feat(project): add CDK Toolkit adapter #2057 - CDK Toolkit adapter (this PR)
  4. feat(project): implement safe CDK deployment #2058 - safe deployment implementation

typecheck, lint, format, test all pass

@github-actionsgithub-actionsBot added the size/xl PR size: XL label Aug 20, 2026
@github-actionsgithub-actionsBot added agentcore-harness-reviewing AgentCore Harness review in progress size/xl PR size: XL and removed size/xl PR size: XL agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 20, 2026
@notgitika
notgitika marked this pull request as ready for review August 20, 2026 04:12
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from a3da8e2 to 000e3b8CompareAugust 20, 2026 04:19
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 20, 2026
@notgitika
notgitika marked this pull request as draft August 20, 2026 04:19
@notgitika
notgitika marked this pull request as ready for review August 20, 2026 04:24
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 20, 2026
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from 000e3b8 to ef1f731CompareAugust 20, 2026 17:06
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 20, 2026
Comment threadsrc/core/project/backends/cdk/toolkit.ts
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from ef1f731 to c4723b3CompareAugust 21, 2026 16:01
@codecov-commenter

codecov-commenter commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.26%. Comparing base (fee25e2) to head (9750c4e).

Additional details and impacted files
@@ Coverage Diff @@## refactor #2057 +/- ##
=========================================
Coverage 97.25% 97.26% =========================================
Files 397 398 +1 Lines 24125 24192 +67 =========================================
+ Hits 23463 23530 +67 
Misses 662 662 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from c4723b3 to 6c52205CompareAugust 21, 2026 16:16
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from 6c52205 to 8b9d408CompareAugust 21, 2026 17:41
Comment threadscripts/build.ts
Comment threadsrc/core/project/backends/cdk/toolkit.ts
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from 8b9d408 to 33e58a0CompareAugust 21, 2026 18:12
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from 33e58a0 to d5e69ffCompareAugust 21, 2026 18:21
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from d5e69ff to 5cc76e5CompareAugust 24, 2026 14:59
Base automatically changed from feat/project-deploy-contract to refactorAugust 24, 2026 16:01
PATTERN_MUST_MATCH_SINGLE throws unless the pattern matches exactly one
stack, so an absent result was never "no match". The Toolkit skips a
stack whose synthesized template has no resources, and deletes it if a
stack of that name already exists — both return normally with no stacks.
`?? {}` turned that into a successful deploy with no outputs, so a caller
expecting RuntimeArn got undefined with nothing explaining why.
Assert exactly one stack and name both possibilities in the error,
keeping `?? {}` only for a stack that deployed but declares no outputs.
Both paths are now covered; the fake toolkit takes the stack list so the
resource-less case is reachable from a test.
Also narrows the `external` comment in scripts/build.ts: it describes the
npm bundle only. compile() cannot mark the Toolkit external because a
standalone binary ships no node_modules, so Bun inlines it and rewrites
__dirname to the build machine's path — which resolves on the builder and
fails everywhere else.
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from 5cc76e5 to 9750c4eCompareAugust 24, 2026 16:01
}

/** Loads the Toolkit only when a deploy operation needs it. */
export const loadCdkToolkit: CdkToolkitLoader = async (ioHost, region) => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how this is loaded lazily.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I had my agent test the latency with the static import and it was quite a bit higher. thanks!

@tejaskash
tejaskash merged commit 1a297be into refactorAug 24, 2026
11 checks passed
@tejaskash
tejaskash deleted the feat/project-cdk-toolkit branch August 24, 2026 17:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xlPR size: XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@notgitika@codecov-commenter@Hweinstock@tejaskash
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(project): add CDK Toolkit adapter by notgitika · Pull Request #2057 · aws/agentcore-cli · GitHub
Skip to content

feat(project): add CDK Toolkit adapter - #2057

Merged
tejaskash merged 2 commits into
refactorfrom
feat/project-cdk-toolkit
Aug 24, 2026
Merged

feat(project): add CDK Toolkit adapter#2057
tejaskash merged 2 commits into
refactorfrom
feat/project-cdk-toolkit

Conversation

@notgitika

@notgitikanotgitika commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a backend-local adapter for @aws-cdk/toolkit-lib
  • load the Toolkit lazily and route notifications through the existing logger at debug level
  • keep the Toolkit external in the npm bundle
  • add direct adapter tests without activating deployment

Stack

This is PR 3 of 4 decomposing #2001. The adapter is backend-local rather than part of shared io. Review and merge bottom-up.

  1. refactor(project): move build behind a project backend #2055 - backend build boundary
  2. feat(project): add deploy command contract #2056 - deploy command contract
  3. feat(project): add CDK Toolkit adapter #2057 - CDK Toolkit adapter (this PR)
  4. feat(project): implement safe CDK deployment #2058 - safe deployment implementation

typecheck, lint, format, test all pass

@github-actionsgithub-actionsBot added the size/xl PR size: XL label Aug 20, 2026
@github-actionsgithub-actionsBot added agentcore-harness-reviewing AgentCore Harness review in progress size/xl PR size: XL and removed size/xl PR size: XL agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 20, 2026
@notgitika
notgitika marked this pull request as ready for review August 20, 2026 04:12
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from a3da8e2 to 000e3b8CompareAugust 20, 2026 04:19
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 20, 2026
@notgitika
notgitika marked this pull request as draft August 20, 2026 04:19
@notgitika
notgitika marked this pull request as ready for review August 20, 2026 04:24
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 20, 2026
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from 000e3b8 to ef1f731CompareAugust 20, 2026 17:06
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 20, 2026
Comment threadsrc/core/project/backends/cdk/toolkit.ts
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from ef1f731 to c4723b3CompareAugust 21, 2026 16:01
@codecov-commenter

codecov-commenter commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.26%. Comparing base (fee25e2) to head (9750c4e).

Additional details and impacted files
@@ Coverage Diff @@## refactor #2057 +/- ##
=========================================
Coverage 97.25% 97.26% =========================================
Files 397 398 +1 Lines 24125 24192 +67 =========================================
+ Hits 23463 23530 +67 
Misses 662 662 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from c4723b3 to 6c52205CompareAugust 21, 2026 16:16
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from 6c52205 to 8b9d408CompareAugust 21, 2026 17:41
Comment threadscripts/build.ts
Comment threadsrc/core/project/backends/cdk/toolkit.ts
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from 8b9d408 to 33e58a0CompareAugust 21, 2026 18:12
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from 33e58a0 to d5e69ffCompareAugust 21, 2026 18:21
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from d5e69ff to 5cc76e5CompareAugust 24, 2026 14:59
Base automatically changed from feat/project-deploy-contract to refactorAugust 24, 2026 16:01
PATTERN_MUST_MATCH_SINGLE throws unless the pattern matches exactly one
stack, so an absent result was never "no match". The Toolkit skips a
stack whose synthesized template has no resources, and deletes it if a
stack of that name already exists — both return normally with no stacks.
`?? {}` turned that into a successful deploy with no outputs, so a caller
expecting RuntimeArn got undefined with nothing explaining why.
Assert exactly one stack and name both possibilities in the error,
keeping `?? {}` only for a stack that deployed but declares no outputs.
Both paths are now covered; the fake toolkit takes the stack list so the
resource-less case is reachable from a test.
Also narrows the `external` comment in scripts/build.ts: it describes the
npm bundle only. compile() cannot mark the Toolkit external because a
standalone binary ships no node_modules, so Bun inlines it and rewrites
__dirname to the build machine's path — which resolves on the builder and
fails everywhere else.
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from 5cc76e5 to 9750c4eCompareAugust 24, 2026 16:01
}

/** Loads the Toolkit only when a deploy operation needs it. */
export const loadCdkToolkit: CdkToolkitLoader = async (ioHost, region) => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how this is loaded lazily.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I had my agent test the latency with the static import and it was quite a bit higher. thanks!

@tejaskash
tejaskash merged commit 1a297be into refactorAug 24, 2026
11 checks passed
@tejaskash
tejaskash deleted the feat/project-cdk-toolkit branch August 24, 2026 17:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xlPR size: XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@notgitika@codecov-commenter@Hweinstock@tejaskash
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); feat(project): add CDK Toolkit adapter by notgitika · Pull Request #2057 · aws/agentcore-cli · GitHub
Skip to content

feat(project): add CDK Toolkit adapter - #2057

Merged
tejaskash merged 2 commits into
refactorfrom
feat/project-cdk-toolkit
Aug 24, 2026
Merged

feat(project): add CDK Toolkit adapter#2057
tejaskash merged 2 commits into
refactorfrom
feat/project-cdk-toolkit

Conversation

@notgitika

@notgitikanotgitika commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a backend-local adapter for @aws-cdk/toolkit-lib
  • load the Toolkit lazily and route notifications through the existing logger at debug level
  • keep the Toolkit external in the npm bundle
  • add direct adapter tests without activating deployment

Stack

This is PR 3 of 4 decomposing #2001. The adapter is backend-local rather than part of shared io. Review and merge bottom-up.

  1. refactor(project): move build behind a project backend #2055 - backend build boundary
  2. feat(project): add deploy command contract #2056 - deploy command contract
  3. feat(project): add CDK Toolkit adapter #2057 - CDK Toolkit adapter (this PR)
  4. feat(project): implement safe CDK deployment #2058 - safe deployment implementation

typecheck, lint, format, test all pass

@github-actionsgithub-actionsBot added the size/xl PR size: XL label Aug 20, 2026
@github-actionsgithub-actionsBot added agentcore-harness-reviewing AgentCore Harness review in progress size/xl PR size: XL and removed size/xl PR size: XL agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 20, 2026
@notgitika
notgitika marked this pull request as ready for review August 20, 2026 04:12
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from a3da8e2 to 000e3b8CompareAugust 20, 2026 04:19
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 20, 2026
@notgitika
notgitika marked this pull request as draft August 20, 2026 04:19
@notgitika
notgitika marked this pull request as ready for review August 20, 2026 04:24
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 20, 2026
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from 000e3b8 to ef1f731CompareAugust 20, 2026 17:06
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 20, 2026
Comment threadsrc/core/project/backends/cdk/toolkit.ts
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from ef1f731 to c4723b3CompareAugust 21, 2026 16:01
@codecov-commenter

codecov-commenter commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.26%. Comparing base (fee25e2) to head (9750c4e).

Additional details and impacted files
@@ Coverage Diff @@## refactor #2057 +/- ##
=========================================
Coverage 97.25% 97.26% =========================================
Files 397 398 +1 Lines 24125 24192 +67 =========================================
+ Hits 23463 23530 +67 
Misses 662 662 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from c4723b3 to 6c52205CompareAugust 21, 2026 16:16
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from 6c52205 to 8b9d408CompareAugust 21, 2026 17:41
Comment threadscripts/build.ts
Comment threadsrc/core/project/backends/cdk/toolkit.ts
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from 8b9d408 to 33e58a0CompareAugust 21, 2026 18:12
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from 33e58a0 to d5e69ffCompareAugust 21, 2026 18:21
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from d5e69ff to 5cc76e5CompareAugust 24, 2026 14:59
Base automatically changed from feat/project-deploy-contract to refactorAugust 24, 2026 16:01
PATTERN_MUST_MATCH_SINGLE throws unless the pattern matches exactly one
stack, so an absent result was never "no match". The Toolkit skips a
stack whose synthesized template has no resources, and deletes it if a
stack of that name already exists — both return normally with no stacks.
`?? {}` turned that into a successful deploy with no outputs, so a caller
expecting RuntimeArn got undefined with nothing explaining why.
Assert exactly one stack and name both possibilities in the error,
keeping `?? {}` only for a stack that deployed but declares no outputs.
Both paths are now covered; the fake toolkit takes the stack list so the
resource-less case is reachable from a test.
Also narrows the `external` comment in scripts/build.ts: it describes the
npm bundle only. compile() cannot mark the Toolkit external because a
standalone binary ships no node_modules, so Bun inlines it and rewrites
__dirname to the build machine's path — which resolves on the builder and
fails everywhere else.
@notgitika
notgitikaforce-pushed the feat/project-cdk-toolkit branch from 5cc76e5 to 9750c4eCompareAugust 24, 2026 16:01
}

/** Loads the Toolkit only when a deploy operation needs it. */
export const loadCdkToolkit: CdkToolkitLoader = async (ioHost, region) => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how this is loaded lazily.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I had my agent test the latency with the static import and it was quite a bit higher. thanks!

@tejaskash
tejaskash merged commit 1a297be into refactorAug 24, 2026
11 checks passed
@tejaskash
tejaskash deleted the feat/project-cdk-toolkit branch August 24, 2026 17:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xlPR size: XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@notgitika@codecov-commenter@Hweinstock@tejaskash