Skip to content

feat(eval): ondemand simulate — replay a dataset, evaluate synchronously - #2071

Merged
jariy17 merged 6 commits into
refactorfrom
feat/eval-ondemand-simulate
Aug 31, 2026
Merged

feat(eval): ondemand simulate — replay a dataset, evaluate synchronously#2071
jariy17 merged 6 commits into
refactorfrom
feat/eval-ondemand-simulate

Conversation

@jariy17

@jariy17jariy17 commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

What

eval ondemand simulate — replay a dataset against a runtime, then evaluate the sessions synchronously, client-side (scores print inline). The on-demand twin of batch-evaluation simulate.

Pipeline: invokeDataset (replay) → getTracesForAgent (CloudWatch) → evaluate (Evaluate API).

Follows the batch-evaluation simulate pattern

  • Same invoke flags + --ingestion-wait-ms (default 180000; 0 to skip)
  • Same SIGINT abort + invokeDataset composition
  • Refuses when 0 invoked, naming the first failure (failures[0])
  • Output adds sessions[] (exampleId ↔ sessionId) + failures[]

Differs by design: no --name / --kms-key-arn (no async job); output is inline scores, not a job id.

Output

{
"sessionsEvaluated": 1,
"results": [ { "evaluatorId": "Builtin.Helpfulness", "value": 0.83, "label": "Very Helpful", "explanation": "", "tokenUsage": {} } ],
"examplesInvoked": 1,
"examplesFailed": 0,
"sessions": [ { "exampleId": "greet", "sessionId": "" } ],
"failures": []
}

Tests (batch pattern)

  • Edge testsondemand.test.tsx (TestCoreClient): required-flag validation, refuse-when-nothing-invoked, --ingestion-wait-ms passthrough.
  • Fixture goldenondemand.fixture.test.tsx: real invoke → CloudWatch traces → Evaluate, recorded against a live agent, replayed offline via matchGolden. Deterministic via the injected newSessionId seam plus a now() clock seam — on-demand's trace-query window is otherwise Date.now()-based, so its StartQuery fixture key would drift between record and replay (batch has no client query; evaluate pins an explicit --start-time/--end-time).
  • Live-validated across 10 dataset scenarios against a real agent in the EXPLORE account (all real Builtin.Helpfulness scores; edge/negative paths handled).

Notes

  • Builtin.Helpfulness ignores ground-truth refs (ignoredReferenceInputFields); the handler still forwards them (adapter exercised).
  • Rebased onto current refactor (was stacked on the pre-merge batch-simulate work).

@github-actionsgithub-actionsBot added size/m PR size: M agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 22, 2026
@codecov-commenter

codecov-commenter commented Aug 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.16%. Comparing base (f2b73d6) to head (0cfacfe).

Additional details and impacted files
@@ Coverage Diff @@## refactor #2071 +/- ##
============================================
+ Coverage 97.14% 97.16% +0.02% 
============================================
Files 494 495 +1 Lines 32550 32676 +126 ============================================
+ Hits 31622 31751 +129 + Misses 928 925 -3 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from 634f6f9 to 94a16acCompareAugust 22, 2026 16:23
Base automatically changed from feat/eval-invoke-dataset-pr to refactorAugust 24, 2026 22:48
@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from 94a16ac to 623bbfcCompareAugust 27, 2026 20:53
@github-actionsgithub-actionsBot added size/m PR size: M and removed size/m PR size: M labels Aug 27, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/m PR size: M labels Aug 27, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 27, 2026
@jariy17
jariy17 marked this pull request as ready for review August 27, 2026 21:16
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from ec6636c to f6776ccCompareAugust 27, 2026 21:17
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 27, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from f6776cc to c29ad31CompareAugust 27, 2026 21:20
@github-actionsgithub-actionsBot removed the size/xl PR size: XL label Aug 27, 2026
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/xl PR size: XL labels Aug 28, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 28, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 28, 2026
jariy17 pushed a commit that referenced this pull request Aug 31, 2026
… expectedResponse as a reference input
Addresses review on #2071: swap the hand-rolled SIGINT/AbortController for the shared
withUserCancellation helper, and include per-turn expectedResponse in the Evaluate
reference inputs so an expected-response-only dataset still contributes ground truth.
@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from 1b0ca37 to 2c20882CompareAugust 31, 2026 15:47
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/l PR size: L labels Aug 31, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
jariy17 added 6 commits August 31, 2026 17:17
… expectedResponse as a reference input
Addresses review on #2071: swap the hand-rolled SIGINT/AbortController for the shared
withUserCancellation helper, and include per-turn expectedResponse in the Evaluate
reference inputs so an expected-response-only dataset still contributes ground truth.
…late turn→traceId)
Bug bash against a live agent showed the Evaluate API rejects expectedResponse under a
session-only context. Correlate each turn's expectedResponse to its trace id instead, and
extend the fixture golden dataset with an expected_response turn graded by Builtin.Correctness
so the real Evaluate call validates the mapping at record time.
@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from 2c20882 to 0cfacfeCompareAugust 31, 2026 17:18
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/l PR size: L labels Aug 31, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
@jariy17
jariy17 merged commit f431dce into refactorAug 31, 2026
21 checks passed
@jariy17
jariy17 deleted the feat/eval-ondemand-simulate branch August 31, 2026 17:40
),
flag("header", "an ordered application header (repeatable)", z.array(z.string()).optional()),
flag(
"bearer-token",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this and --header should be marked sensitive

jariy17 pushed a commit that referenced this pull request Aug 31, 2026
Follow-up to #2071. These flags carry secrets (CUSTOM_JWT bearer token,
auth headers) but were logged in cleartext by the withLogging debug
middleware. The canonical 'runtime invoke' handler already marks both
sensitive; apply the same to the on-demand and batch-evaluation simulate
handlers.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/lPR size: L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jariy17@codecov-commenter@notgitika@nborges-aws
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
feat(eval): ondemand simulate — replay a dataset, evaluate synchronously by jariy17 · Pull Request #2071 · aws/agentcore-cli · GitHub
Skip to content

feat(eval): ondemand simulate — replay a dataset, evaluate synchronously - #2071

Merged
jariy17 merged 6 commits into
refactorfrom
feat/eval-ondemand-simulate
Aug 31, 2026
Merged

feat(eval): ondemand simulate — replay a dataset, evaluate synchronously#2071
jariy17 merged 6 commits into
refactorfrom
feat/eval-ondemand-simulate

Conversation

@jariy17

@jariy17jariy17 commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

What

eval ondemand simulate — replay a dataset against a runtime, then evaluate the sessions synchronously, client-side (scores print inline). The on-demand twin of batch-evaluation simulate.

Pipeline: invokeDataset (replay) → getTracesForAgent (CloudWatch) → evaluate (Evaluate API).

Follows the batch-evaluation simulate pattern

  • Same invoke flags + --ingestion-wait-ms (default 180000; 0 to skip)
  • Same SIGINT abort + invokeDataset composition
  • Refuses when 0 invoked, naming the first failure (failures[0])
  • Output adds sessions[] (exampleId ↔ sessionId) + failures[]

Differs by design: no --name / --kms-key-arn (no async job); output is inline scores, not a job id.

Output

{
"sessionsEvaluated": 1,
"results": [ { "evaluatorId": "Builtin.Helpfulness", "value": 0.83, "label": "Very Helpful", "explanation": "", "tokenUsage": {} } ],
"examplesInvoked": 1,
"examplesFailed": 0,
"sessions": [ { "exampleId": "greet", "sessionId": "" } ],
"failures": []
}

Tests (batch pattern)

  • Edge testsondemand.test.tsx (TestCoreClient): required-flag validation, refuse-when-nothing-invoked, --ingestion-wait-ms passthrough.
  • Fixture goldenondemand.fixture.test.tsx: real invoke → CloudWatch traces → Evaluate, recorded against a live agent, replayed offline via matchGolden. Deterministic via the injected newSessionId seam plus a now() clock seam — on-demand's trace-query window is otherwise Date.now()-based, so its StartQuery fixture key would drift between record and replay (batch has no client query; evaluate pins an explicit --start-time/--end-time).
  • Live-validated across 10 dataset scenarios against a real agent in the EXPLORE account (all real Builtin.Helpfulness scores; edge/negative paths handled).

Notes

  • Builtin.Helpfulness ignores ground-truth refs (ignoredReferenceInputFields); the handler still forwards them (adapter exercised).
  • Rebased onto current refactor (was stacked on the pre-merge batch-simulate work).

@github-actionsgithub-actionsBot added size/m PR size: M agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 22, 2026
@codecov-commenter

codecov-commenter commented Aug 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.16%. Comparing base (f2b73d6) to head (0cfacfe).

Additional details and impacted files
@@ Coverage Diff @@## refactor #2071 +/- ##
============================================
+ Coverage 97.14% 97.16% +0.02% 
============================================
Files 494 495 +1 Lines 32550 32676 +126 ============================================
+ Hits 31622 31751 +129 + Misses 928 925 -3 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from 634f6f9 to 94a16acCompareAugust 22, 2026 16:23
Base automatically changed from feat/eval-invoke-dataset-pr to refactorAugust 24, 2026 22:48
@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from 94a16ac to 623bbfcCompareAugust 27, 2026 20:53
@github-actionsgithub-actionsBot added size/m PR size: M and removed size/m PR size: M labels Aug 27, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/m PR size: M labels Aug 27, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 27, 2026
@jariy17
jariy17 marked this pull request as ready for review August 27, 2026 21:16
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from ec6636c to f6776ccCompareAugust 27, 2026 21:17
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 27, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from f6776cc to c29ad31CompareAugust 27, 2026 21:20
@github-actionsgithub-actionsBot removed the size/xl PR size: XL label Aug 27, 2026
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/xl PR size: XL labels Aug 28, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 28, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 28, 2026
jariy17 pushed a commit that referenced this pull request Aug 31, 2026
… expectedResponse as a reference input
Addresses review on #2071: swap the hand-rolled SIGINT/AbortController for the shared
withUserCancellation helper, and include per-turn expectedResponse in the Evaluate
reference inputs so an expected-response-only dataset still contributes ground truth.
@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from 1b0ca37 to 2c20882CompareAugust 31, 2026 15:47
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/l PR size: L labels Aug 31, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
jariy17 added 6 commits August 31, 2026 17:17
… expectedResponse as a reference input
Addresses review on #2071: swap the hand-rolled SIGINT/AbortController for the shared
withUserCancellation helper, and include per-turn expectedResponse in the Evaluate
reference inputs so an expected-response-only dataset still contributes ground truth.
…late turn→traceId)
Bug bash against a live agent showed the Evaluate API rejects expectedResponse under a
session-only context. Correlate each turn's expectedResponse to its trace id instead, and
extend the fixture golden dataset with an expected_response turn graded by Builtin.Correctness
so the real Evaluate call validates the mapping at record time.
@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from 2c20882 to 0cfacfeCompareAugust 31, 2026 17:18
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/l PR size: L labels Aug 31, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
@jariy17
jariy17 merged commit f431dce into refactorAug 31, 2026
21 checks passed
@jariy17
jariy17 deleted the feat/eval-ondemand-simulate branch August 31, 2026 17:40
),
flag("header", "an ordered application header (repeatable)", z.array(z.string()).optional()),
flag(
"bearer-token",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this and --header should be marked sensitive

jariy17 pushed a commit that referenced this pull request Aug 31, 2026
Follow-up to #2071. These flags carry secrets (CUSTOM_JWT bearer token,
auth headers) but were logged in cleartext by the withLogging debug
middleware. The canonical 'runtime invoke' handler already marks both
sensitive; apply the same to the on-demand and batch-evaluation simulate
handlers.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/lPR size: L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jariy17@codecov-commenter@notgitika@nborges-aws
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(eval): ondemand simulate — replay a dataset, evaluate synchronously by jariy17 · Pull Request #2071 · aws/agentcore-cli · GitHub
Skip to content

feat(eval): ondemand simulate — replay a dataset, evaluate synchronously - #2071

Merged
jariy17 merged 6 commits into
refactorfrom
feat/eval-ondemand-simulate
Aug 31, 2026
Merged

feat(eval): ondemand simulate — replay a dataset, evaluate synchronously#2071
jariy17 merged 6 commits into
refactorfrom
feat/eval-ondemand-simulate

Conversation

@jariy17

@jariy17jariy17 commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

What

eval ondemand simulate — replay a dataset against a runtime, then evaluate the sessions synchronously, client-side (scores print inline). The on-demand twin of batch-evaluation simulate.

Pipeline: invokeDataset (replay) → getTracesForAgent (CloudWatch) → evaluate (Evaluate API).

Follows the batch-evaluation simulate pattern

  • Same invoke flags + --ingestion-wait-ms (default 180000; 0 to skip)
  • Same SIGINT abort + invokeDataset composition
  • Refuses when 0 invoked, naming the first failure (failures[0])
  • Output adds sessions[] (exampleId ↔ sessionId) + failures[]

Differs by design: no --name / --kms-key-arn (no async job); output is inline scores, not a job id.

Output

{
"sessionsEvaluated": 1,
"results": [ { "evaluatorId": "Builtin.Helpfulness", "value": 0.83, "label": "Very Helpful", "explanation": "", "tokenUsage": {} } ],
"examplesInvoked": 1,
"examplesFailed": 0,
"sessions": [ { "exampleId": "greet", "sessionId": "" } ],
"failures": []
}

Tests (batch pattern)

  • Edge testsondemand.test.tsx (TestCoreClient): required-flag validation, refuse-when-nothing-invoked, --ingestion-wait-ms passthrough.
  • Fixture goldenondemand.fixture.test.tsx: real invoke → CloudWatch traces → Evaluate, recorded against a live agent, replayed offline via matchGolden. Deterministic via the injected newSessionId seam plus a now() clock seam — on-demand's trace-query window is otherwise Date.now()-based, so its StartQuery fixture key would drift between record and replay (batch has no client query; evaluate pins an explicit --start-time/--end-time).
  • Live-validated across 10 dataset scenarios against a real agent in the EXPLORE account (all real Builtin.Helpfulness scores; edge/negative paths handled).

Notes

  • Builtin.Helpfulness ignores ground-truth refs (ignoredReferenceInputFields); the handler still forwards them (adapter exercised).
  • Rebased onto current refactor (was stacked on the pre-merge batch-simulate work).

@github-actionsgithub-actionsBot added size/m PR size: M agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 22, 2026
@codecov-commenter

codecov-commenter commented Aug 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.16%. Comparing base (f2b73d6) to head (0cfacfe).

Additional details and impacted files
@@ Coverage Diff @@## refactor #2071 +/- ##
============================================
+ Coverage 97.14% 97.16% +0.02% 
============================================
Files 494 495 +1 Lines 32550 32676 +126 ============================================
+ Hits 31622 31751 +129 + Misses 928 925 -3 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from 634f6f9 to 94a16acCompareAugust 22, 2026 16:23
Base automatically changed from feat/eval-invoke-dataset-pr to refactorAugust 24, 2026 22:48
@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from 94a16ac to 623bbfcCompareAugust 27, 2026 20:53
@github-actionsgithub-actionsBot added size/m PR size: M and removed size/m PR size: M labels Aug 27, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/m PR size: M labels Aug 27, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 27, 2026
@jariy17
jariy17 marked this pull request as ready for review August 27, 2026 21:16
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from ec6636c to f6776ccCompareAugust 27, 2026 21:17
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 27, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from f6776cc to c29ad31CompareAugust 27, 2026 21:20
@github-actionsgithub-actionsBot removed the size/xl PR size: XL label Aug 27, 2026
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/xl PR size: XL labels Aug 28, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 28, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 28, 2026
jariy17 pushed a commit that referenced this pull request Aug 31, 2026
… expectedResponse as a reference input
Addresses review on #2071: swap the hand-rolled SIGINT/AbortController for the shared
withUserCancellation helper, and include per-turn expectedResponse in the Evaluate
reference inputs so an expected-response-only dataset still contributes ground truth.
@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from 1b0ca37 to 2c20882CompareAugust 31, 2026 15:47
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/l PR size: L labels Aug 31, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
jariy17 added 6 commits August 31, 2026 17:17
… expectedResponse as a reference input
Addresses review on #2071: swap the hand-rolled SIGINT/AbortController for the shared
withUserCancellation helper, and include per-turn expectedResponse in the Evaluate
reference inputs so an expected-response-only dataset still contributes ground truth.
…late turn→traceId)
Bug bash against a live agent showed the Evaluate API rejects expectedResponse under a
session-only context. Correlate each turn's expectedResponse to its trace id instead, and
extend the fixture golden dataset with an expected_response turn graded by Builtin.Correctness
so the real Evaluate call validates the mapping at record time.
@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from 2c20882 to 0cfacfeCompareAugust 31, 2026 17:18
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/l PR size: L labels Aug 31, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
@jariy17
jariy17 merged commit f431dce into refactorAug 31, 2026
21 checks passed
@jariy17
jariy17 deleted the feat/eval-ondemand-simulate branch August 31, 2026 17:40
),
flag("header", "an ordered application header (repeatable)", z.array(z.string()).optional()),
flag(
"bearer-token",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this and --header should be marked sensitive

jariy17 pushed a commit that referenced this pull request Aug 31, 2026
Follow-up to #2071. These flags carry secrets (CUSTOM_JWT bearer token,
auth headers) but were logged in cleartext by the withLogging debug
middleware. The canonical 'runtime invoke' handler already marks both
sensitive; apply the same to the on-demand and batch-evaluation simulate
handlers.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/lPR size: L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jariy17@codecov-commenter@notgitika@nborges-aws
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(eval): ondemand simulate — replay a dataset, evaluate synchronously by jariy17 · Pull Request #2071 · aws/agentcore-cli · GitHub
Skip to content

feat(eval): ondemand simulate — replay a dataset, evaluate synchronously - #2071

Merged
jariy17 merged 6 commits into
refactorfrom
feat/eval-ondemand-simulate
Aug 31, 2026
Merged

feat(eval): ondemand simulate — replay a dataset, evaluate synchronously#2071
jariy17 merged 6 commits into
refactorfrom
feat/eval-ondemand-simulate

Conversation

@jariy17

@jariy17jariy17 commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

What

eval ondemand simulate — replay a dataset against a runtime, then evaluate the sessions synchronously, client-side (scores print inline). The on-demand twin of batch-evaluation simulate.

Pipeline: invokeDataset (replay) → getTracesForAgent (CloudWatch) → evaluate (Evaluate API).

Follows the batch-evaluation simulate pattern

  • Same invoke flags + --ingestion-wait-ms (default 180000; 0 to skip)
  • Same SIGINT abort + invokeDataset composition
  • Refuses when 0 invoked, naming the first failure (failures[0])
  • Output adds sessions[] (exampleId ↔ sessionId) + failures[]

Differs by design: no --name / --kms-key-arn (no async job); output is inline scores, not a job id.

Output

{
"sessionsEvaluated": 1,
"results": [ { "evaluatorId": "Builtin.Helpfulness", "value": 0.83, "label": "Very Helpful", "explanation": "", "tokenUsage": {} } ],
"examplesInvoked": 1,
"examplesFailed": 0,
"sessions": [ { "exampleId": "greet", "sessionId": "" } ],
"failures": []
}

Tests (batch pattern)

  • Edge testsondemand.test.tsx (TestCoreClient): required-flag validation, refuse-when-nothing-invoked, --ingestion-wait-ms passthrough.
  • Fixture goldenondemand.fixture.test.tsx: real invoke → CloudWatch traces → Evaluate, recorded against a live agent, replayed offline via matchGolden. Deterministic via the injected newSessionId seam plus a now() clock seam — on-demand's trace-query window is otherwise Date.now()-based, so its StartQuery fixture key would drift between record and replay (batch has no client query; evaluate pins an explicit --start-time/--end-time).
  • Live-validated across 10 dataset scenarios against a real agent in the EXPLORE account (all real Builtin.Helpfulness scores; edge/negative paths handled).

Notes

  • Builtin.Helpfulness ignores ground-truth refs (ignoredReferenceInputFields); the handler still forwards them (adapter exercised).
  • Rebased onto current refactor (was stacked on the pre-merge batch-simulate work).

@github-actionsgithub-actionsBot added size/m PR size: M agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 22, 2026
@codecov-commenter

codecov-commenter commented Aug 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.16%. Comparing base (f2b73d6) to head (0cfacfe).

Additional details and impacted files
@@ Coverage Diff @@## refactor #2071 +/- ##
============================================
+ Coverage 97.14% 97.16% +0.02% 
============================================
Files 494 495 +1 Lines 32550 32676 +126 ============================================
+ Hits 31622 31751 +129 + Misses 928 925 -3 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from 634f6f9 to 94a16acCompareAugust 22, 2026 16:23
Base automatically changed from feat/eval-invoke-dataset-pr to refactorAugust 24, 2026 22:48
@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from 94a16ac to 623bbfcCompareAugust 27, 2026 20:53
@github-actionsgithub-actionsBot added size/m PR size: M and removed size/m PR size: M labels Aug 27, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/m PR size: M labels Aug 27, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 27, 2026
@jariy17
jariy17 marked this pull request as ready for review August 27, 2026 21:16
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from ec6636c to f6776ccCompareAugust 27, 2026 21:17
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 27, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from f6776cc to c29ad31CompareAugust 27, 2026 21:20
@github-actionsgithub-actionsBot removed the size/xl PR size: XL label Aug 27, 2026
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/xl PR size: XL labels Aug 28, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 28, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 28, 2026
jariy17 pushed a commit that referenced this pull request Aug 31, 2026
… expectedResponse as a reference input
Addresses review on #2071: swap the hand-rolled SIGINT/AbortController for the shared
withUserCancellation helper, and include per-turn expectedResponse in the Evaluate
reference inputs so an expected-response-only dataset still contributes ground truth.
@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from 1b0ca37 to 2c20882CompareAugust 31, 2026 15:47
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/l PR size: L labels Aug 31, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
jariy17 added 6 commits August 31, 2026 17:17
… expectedResponse as a reference input
Addresses review on #2071: swap the hand-rolled SIGINT/AbortController for the shared
withUserCancellation helper, and include per-turn expectedResponse in the Evaluate
reference inputs so an expected-response-only dataset still contributes ground truth.
…late turn→traceId)
Bug bash against a live agent showed the Evaluate API rejects expectedResponse under a
session-only context. Correlate each turn's expectedResponse to its trace id instead, and
extend the fixture golden dataset with an expected_response turn graded by Builtin.Correctness
so the real Evaluate call validates the mapping at record time.
@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from 2c20882 to 0cfacfeCompareAugust 31, 2026 17:18
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/l PR size: L labels Aug 31, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
@jariy17
jariy17 merged commit f431dce into refactorAug 31, 2026
21 checks passed
@jariy17
jariy17 deleted the feat/eval-ondemand-simulate branch August 31, 2026 17:40
),
flag("header", "an ordered application header (repeatable)", z.array(z.string()).optional()),
flag(
"bearer-token",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this and --header should be marked sensitive

jariy17 pushed a commit that referenced this pull request Aug 31, 2026
Follow-up to #2071. These flags carry secrets (CUSTOM_JWT bearer token,
auth headers) but were logged in cleartext by the withLogging debug
middleware. The canonical 'runtime invoke' handler already marks both
sensitive; apply the same to the on-demand and batch-evaluation simulate
handlers.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/lPR size: L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jariy17@codecov-commenter@notgitika@nborges-aws
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' feat(eval): ondemand simulate — replay a dataset, evaluate synchronously by jariy17 · Pull Request #2071 · aws/agentcore-cli · GitHub
Skip to content

feat(eval): ondemand simulate — replay a dataset, evaluate synchronously - #2071

Merged
jariy17 merged 6 commits into
refactorfrom
feat/eval-ondemand-simulate
Aug 31, 2026
Merged

feat(eval): ondemand simulate — replay a dataset, evaluate synchronously#2071
jariy17 merged 6 commits into
refactorfrom
feat/eval-ondemand-simulate

Conversation

@jariy17

@jariy17jariy17 commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

What

eval ondemand simulate — replay a dataset against a runtime, then evaluate the sessions synchronously, client-side (scores print inline). The on-demand twin of batch-evaluation simulate.

Pipeline: invokeDataset (replay) → getTracesForAgent (CloudWatch) → evaluate (Evaluate API).

Follows the batch-evaluation simulate pattern

  • Same invoke flags + --ingestion-wait-ms (default 180000; 0 to skip)
  • Same SIGINT abort + invokeDataset composition
  • Refuses when 0 invoked, naming the first failure (failures[0])
  • Output adds sessions[] (exampleId ↔ sessionId) + failures[]

Differs by design: no --name / --kms-key-arn (no async job); output is inline scores, not a job id.

Output

{
"sessionsEvaluated": 1,
"results": [ { "evaluatorId": "Builtin.Helpfulness", "value": 0.83, "label": "Very Helpful", "explanation": "", "tokenUsage": {} } ],
"examplesInvoked": 1,
"examplesFailed": 0,
"sessions": [ { "exampleId": "greet", "sessionId": "" } ],
"failures": []
}

Tests (batch pattern)

  • Edge testsondemand.test.tsx (TestCoreClient): required-flag validation, refuse-when-nothing-invoked, --ingestion-wait-ms passthrough.
  • Fixture goldenondemand.fixture.test.tsx: real invoke → CloudWatch traces → Evaluate, recorded against a live agent, replayed offline via matchGolden. Deterministic via the injected newSessionId seam plus a now() clock seam — on-demand's trace-query window is otherwise Date.now()-based, so its StartQuery fixture key would drift between record and replay (batch has no client query; evaluate pins an explicit --start-time/--end-time).
  • Live-validated across 10 dataset scenarios against a real agent in the EXPLORE account (all real Builtin.Helpfulness scores; edge/negative paths handled).

Notes

  • Builtin.Helpfulness ignores ground-truth refs (ignoredReferenceInputFields); the handler still forwards them (adapter exercised).
  • Rebased onto current refactor (was stacked on the pre-merge batch-simulate work).

@github-actionsgithub-actionsBot added size/m PR size: M agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 22, 2026
@codecov-commenter

codecov-commenter commented Aug 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.16%. Comparing base (f2b73d6) to head (0cfacfe).

Additional details and impacted files
@@ Coverage Diff @@## refactor #2071 +/- ##
============================================
+ Coverage 97.14% 97.16% +0.02% 
============================================
Files 494 495 +1 Lines 32550 32676 +126 ============================================
+ Hits 31622 31751 +129 + Misses 928 925 -3 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from 634f6f9 to 94a16acCompareAugust 22, 2026 16:23
Base automatically changed from feat/eval-invoke-dataset-pr to refactorAugust 24, 2026 22:48
@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from 94a16ac to 623bbfcCompareAugust 27, 2026 20:53
@github-actionsgithub-actionsBot added size/m PR size: M and removed size/m PR size: M labels Aug 27, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/m PR size: M labels Aug 27, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 27, 2026
@jariy17
jariy17 marked this pull request as ready for review August 27, 2026 21:16
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from ec6636c to f6776ccCompareAugust 27, 2026 21:17
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 27, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from f6776cc to c29ad31CompareAugust 27, 2026 21:20
@github-actionsgithub-actionsBot removed the size/xl PR size: XL label Aug 27, 2026
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/xl PR size: XL labels Aug 28, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 28, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 28, 2026
jariy17 pushed a commit that referenced this pull request Aug 31, 2026
… expectedResponse as a reference input
Addresses review on #2071: swap the hand-rolled SIGINT/AbortController for the shared
withUserCancellation helper, and include per-turn expectedResponse in the Evaluate
reference inputs so an expected-response-only dataset still contributes ground truth.
@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from 1b0ca37 to 2c20882CompareAugust 31, 2026 15:47
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/l PR size: L labels Aug 31, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
jariy17 added 6 commits August 31, 2026 17:17
… expectedResponse as a reference input
Addresses review on #2071: swap the hand-rolled SIGINT/AbortController for the shared
withUserCancellation helper, and include per-turn expectedResponse in the Evaluate
reference inputs so an expected-response-only dataset still contributes ground truth.
…late turn→traceId)
Bug bash against a live agent showed the Evaluate API rejects expectedResponse under a
session-only context. Correlate each turn's expectedResponse to its trace id instead, and
extend the fixture golden dataset with an expected_response turn graded by Builtin.Correctness
so the real Evaluate call validates the mapping at record time.
@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from 2c20882 to 0cfacfeCompareAugust 31, 2026 17:18
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/l PR size: L labels Aug 31, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
@jariy17
jariy17 merged commit f431dce into refactorAug 31, 2026
21 checks passed
@jariy17
jariy17 deleted the feat/eval-ondemand-simulate branch August 31, 2026 17:40
),
flag("header", "an ordered application header (repeatable)", z.array(z.string()).optional()),
flag(
"bearer-token",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this and --header should be marked sensitive

jariy17 pushed a commit that referenced this pull request Aug 31, 2026
Follow-up to #2071. These flags carry secrets (CUSTOM_JWT bearer token,
auth headers) but were logged in cleartext by the withLogging debug
middleware. The canonical 'runtime invoke' handler already marks both
sensitive; apply the same to the on-demand and batch-evaluation simulate
handlers.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/lPR size: L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jariy17@codecov-commenter@notgitika@nborges-aws
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(eval): ondemand simulate — replay a dataset, evaluate synchronously by jariy17 · Pull Request #2071 · aws/agentcore-cli · GitHub
Skip to content

feat(eval): ondemand simulate — replay a dataset, evaluate synchronously - #2071

Merged
jariy17 merged 6 commits into
refactorfrom
feat/eval-ondemand-simulate
Aug 31, 2026
Merged

feat(eval): ondemand simulate — replay a dataset, evaluate synchronously#2071
jariy17 merged 6 commits into
refactorfrom
feat/eval-ondemand-simulate

Conversation

@jariy17

@jariy17jariy17 commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

What

eval ondemand simulate — replay a dataset against a runtime, then evaluate the sessions synchronously, client-side (scores print inline). The on-demand twin of batch-evaluation simulate.

Pipeline: invokeDataset (replay) → getTracesForAgent (CloudWatch) → evaluate (Evaluate API).

Follows the batch-evaluation simulate pattern

  • Same invoke flags + --ingestion-wait-ms (default 180000; 0 to skip)
  • Same SIGINT abort + invokeDataset composition
  • Refuses when 0 invoked, naming the first failure (failures[0])
  • Output adds sessions[] (exampleId ↔ sessionId) + failures[]

Differs by design: no --name / --kms-key-arn (no async job); output is inline scores, not a job id.

Output

{
"sessionsEvaluated": 1,
"results": [ { "evaluatorId": "Builtin.Helpfulness", "value": 0.83, "label": "Very Helpful", "explanation": "", "tokenUsage": {} } ],
"examplesInvoked": 1,
"examplesFailed": 0,
"sessions": [ { "exampleId": "greet", "sessionId": "" } ],
"failures": []
}

Tests (batch pattern)

  • Edge testsondemand.test.tsx (TestCoreClient): required-flag validation, refuse-when-nothing-invoked, --ingestion-wait-ms passthrough.
  • Fixture goldenondemand.fixture.test.tsx: real invoke → CloudWatch traces → Evaluate, recorded against a live agent, replayed offline via matchGolden. Deterministic via the injected newSessionId seam plus a now() clock seam — on-demand's trace-query window is otherwise Date.now()-based, so its StartQuery fixture key would drift between record and replay (batch has no client query; evaluate pins an explicit --start-time/--end-time).
  • Live-validated across 10 dataset scenarios against a real agent in the EXPLORE account (all real Builtin.Helpfulness scores; edge/negative paths handled).

Notes

  • Builtin.Helpfulness ignores ground-truth refs (ignoredReferenceInputFields); the handler still forwards them (adapter exercised).
  • Rebased onto current refactor (was stacked on the pre-merge batch-simulate work).

@github-actionsgithub-actionsBot added size/m PR size: M agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 22, 2026
@codecov-commenter

codecov-commenter commented Aug 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.16%. Comparing base (f2b73d6) to head (0cfacfe).

Additional details and impacted files
@@ Coverage Diff @@## refactor #2071 +/- ##
============================================
+ Coverage 97.14% 97.16% +0.02% 
============================================
Files 494 495 +1 Lines 32550 32676 +126 ============================================
+ Hits 31622 31751 +129 + Misses 928 925 -3 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from 634f6f9 to 94a16acCompareAugust 22, 2026 16:23
Base automatically changed from feat/eval-invoke-dataset-pr to refactorAugust 24, 2026 22:48
@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from 94a16ac to 623bbfcCompareAugust 27, 2026 20:53
@github-actionsgithub-actionsBot added size/m PR size: M and removed size/m PR size: M labels Aug 27, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/m PR size: M labels Aug 27, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 27, 2026
@jariy17
jariy17 marked this pull request as ready for review August 27, 2026 21:16
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from ec6636c to f6776ccCompareAugust 27, 2026 21:17
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 27, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from f6776cc to c29ad31CompareAugust 27, 2026 21:20
@github-actionsgithub-actionsBot removed the size/xl PR size: XL label Aug 27, 2026
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/xl PR size: XL labels Aug 28, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 28, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 28, 2026
jariy17 pushed a commit that referenced this pull request Aug 31, 2026
… expectedResponse as a reference input
Addresses review on #2071: swap the hand-rolled SIGINT/AbortController for the shared
withUserCancellation helper, and include per-turn expectedResponse in the Evaluate
reference inputs so an expected-response-only dataset still contributes ground truth.
@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from 1b0ca37 to 2c20882CompareAugust 31, 2026 15:47
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/l PR size: L labels Aug 31, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
jariy17 added 6 commits August 31, 2026 17:17
… expectedResponse as a reference input
Addresses review on #2071: swap the hand-rolled SIGINT/AbortController for the shared
withUserCancellation helper, and include per-turn expectedResponse in the Evaluate
reference inputs so an expected-response-only dataset still contributes ground truth.
…late turn→traceId)
Bug bash against a live agent showed the Evaluate API rejects expectedResponse under a
session-only context. Correlate each turn's expectedResponse to its trace id instead, and
extend the fixture golden dataset with an expected_response turn graded by Builtin.Correctness
so the real Evaluate call validates the mapping at record time.
@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from 2c20882 to 0cfacfeCompareAugust 31, 2026 17:18
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/l PR size: L labels Aug 31, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
@jariy17
jariy17 merged commit f431dce into refactorAug 31, 2026
21 checks passed
@jariy17
jariy17 deleted the feat/eval-ondemand-simulate branch August 31, 2026 17:40
),
flag("header", "an ordered application header (repeatable)", z.array(z.string()).optional()),
flag(
"bearer-token",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this and --header should be marked sensitive

jariy17 pushed a commit that referenced this pull request Aug 31, 2026
Follow-up to #2071. These flags carry secrets (CUSTOM_JWT bearer token,
auth headers) but were logged in cleartext by the withLogging debug
middleware. The canonical 'runtime invoke' handler already marks both
sensitive; apply the same to the on-demand and batch-evaluation simulate
handlers.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/lPR size: L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jariy17@codecov-commenter@notgitika@nborges-aws
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(eval): ondemand simulate — replay a dataset, evaluate synchronously by jariy17 · Pull Request #2071 · aws/agentcore-cli · GitHub
Skip to content

feat(eval): ondemand simulate — replay a dataset, evaluate synchronously - #2071

Merged
jariy17 merged 6 commits into
refactorfrom
feat/eval-ondemand-simulate
Aug 31, 2026
Merged

feat(eval): ondemand simulate — replay a dataset, evaluate synchronously#2071
jariy17 merged 6 commits into
refactorfrom
feat/eval-ondemand-simulate

Conversation

@jariy17

@jariy17jariy17 commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

What

eval ondemand simulate — replay a dataset against a runtime, then evaluate the sessions synchronously, client-side (scores print inline). The on-demand twin of batch-evaluation simulate.

Pipeline: invokeDataset (replay) → getTracesForAgent (CloudWatch) → evaluate (Evaluate API).

Follows the batch-evaluation simulate pattern

  • Same invoke flags + --ingestion-wait-ms (default 180000; 0 to skip)
  • Same SIGINT abort + invokeDataset composition
  • Refuses when 0 invoked, naming the first failure (failures[0])
  • Output adds sessions[] (exampleId ↔ sessionId) + failures[]

Differs by design: no --name / --kms-key-arn (no async job); output is inline scores, not a job id.

Output

{
"sessionsEvaluated": 1,
"results": [ { "evaluatorId": "Builtin.Helpfulness", "value": 0.83, "label": "Very Helpful", "explanation": "", "tokenUsage": {} } ],
"examplesInvoked": 1,
"examplesFailed": 0,
"sessions": [ { "exampleId": "greet", "sessionId": "" } ],
"failures": []
}

Tests (batch pattern)

  • Edge testsondemand.test.tsx (TestCoreClient): required-flag validation, refuse-when-nothing-invoked, --ingestion-wait-ms passthrough.
  • Fixture goldenondemand.fixture.test.tsx: real invoke → CloudWatch traces → Evaluate, recorded against a live agent, replayed offline via matchGolden. Deterministic via the injected newSessionId seam plus a now() clock seam — on-demand's trace-query window is otherwise Date.now()-based, so its StartQuery fixture key would drift between record and replay (batch has no client query; evaluate pins an explicit --start-time/--end-time).
  • Live-validated across 10 dataset scenarios against a real agent in the EXPLORE account (all real Builtin.Helpfulness scores; edge/negative paths handled).

Notes

  • Builtin.Helpfulness ignores ground-truth refs (ignoredReferenceInputFields); the handler still forwards them (adapter exercised).
  • Rebased onto current refactor (was stacked on the pre-merge batch-simulate work).

@github-actionsgithub-actionsBot added size/m PR size: M agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 22, 2026
@codecov-commenter

codecov-commenter commented Aug 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.16%. Comparing base (f2b73d6) to head (0cfacfe).

Additional details and impacted files
@@ Coverage Diff @@## refactor #2071 +/- ##
============================================
+ Coverage 97.14% 97.16% +0.02% 
============================================
Files 494 495 +1 Lines 32550 32676 +126 ============================================
+ Hits 31622 31751 +129 + Misses 928 925 -3 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from 634f6f9 to 94a16acCompareAugust 22, 2026 16:23
Base automatically changed from feat/eval-invoke-dataset-pr to refactorAugust 24, 2026 22:48
@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from 94a16ac to 623bbfcCompareAugust 27, 2026 20:53
@github-actionsgithub-actionsBot added size/m PR size: M and removed size/m PR size: M labels Aug 27, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/m PR size: M labels Aug 27, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 27, 2026
@jariy17
jariy17 marked this pull request as ready for review August 27, 2026 21:16
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from ec6636c to f6776ccCompareAugust 27, 2026 21:17
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 27, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from f6776cc to c29ad31CompareAugust 27, 2026 21:20
@github-actionsgithub-actionsBot removed the size/xl PR size: XL label Aug 27, 2026
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/xl PR size: XL labels Aug 28, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 28, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 28, 2026
jariy17 pushed a commit that referenced this pull request Aug 31, 2026
… expectedResponse as a reference input
Addresses review on #2071: swap the hand-rolled SIGINT/AbortController for the shared
withUserCancellation helper, and include per-turn expectedResponse in the Evaluate
reference inputs so an expected-response-only dataset still contributes ground truth.
@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from 1b0ca37 to 2c20882CompareAugust 31, 2026 15:47
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/l PR size: L labels Aug 31, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
jariy17 added 6 commits August 31, 2026 17:17
… expectedResponse as a reference input
Addresses review on #2071: swap the hand-rolled SIGINT/AbortController for the shared
withUserCancellation helper, and include per-turn expectedResponse in the Evaluate
reference inputs so an expected-response-only dataset still contributes ground truth.
…late turn→traceId)
Bug bash against a live agent showed the Evaluate API rejects expectedResponse under a
session-only context. Correlate each turn's expectedResponse to its trace id instead, and
extend the fixture golden dataset with an expected_response turn graded by Builtin.Correctness
so the real Evaluate call validates the mapping at record time.
@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from 2c20882 to 0cfacfeCompareAugust 31, 2026 17:18
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/l PR size: L labels Aug 31, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
@jariy17
jariy17 merged commit f431dce into refactorAug 31, 2026
21 checks passed
@jariy17
jariy17 deleted the feat/eval-ondemand-simulate branch August 31, 2026 17:40
),
flag("header", "an ordered application header (repeatable)", z.array(z.string()).optional()),
flag(
"bearer-token",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this and --header should be marked sensitive

jariy17 pushed a commit that referenced this pull request Aug 31, 2026
Follow-up to #2071. These flags carry secrets (CUSTOM_JWT bearer token,
auth headers) but were logged in cleartext by the withLogging debug
middleware. The canonical 'runtime invoke' handler already marks both
sensitive; apply the same to the on-demand and batch-evaluation simulate
handlers.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/lPR size: L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jariy17@codecov-commenter@notgitika@nborges-aws
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); feat(eval): ondemand simulate — replay a dataset, evaluate synchronously by jariy17 · Pull Request #2071 · aws/agentcore-cli · GitHub
Skip to content

feat(eval): ondemand simulate — replay a dataset, evaluate synchronously - #2071

Merged
jariy17 merged 6 commits into
refactorfrom
feat/eval-ondemand-simulate
Aug 31, 2026
Merged

feat(eval): ondemand simulate — replay a dataset, evaluate synchronously#2071
jariy17 merged 6 commits into
refactorfrom
feat/eval-ondemand-simulate

Conversation

@jariy17

@jariy17jariy17 commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

What

eval ondemand simulate — replay a dataset against a runtime, then evaluate the sessions synchronously, client-side (scores print inline). The on-demand twin of batch-evaluation simulate.

Pipeline: invokeDataset (replay) → getTracesForAgent (CloudWatch) → evaluate (Evaluate API).

Follows the batch-evaluation simulate pattern

  • Same invoke flags + --ingestion-wait-ms (default 180000; 0 to skip)
  • Same SIGINT abort + invokeDataset composition
  • Refuses when 0 invoked, naming the first failure (failures[0])
  • Output adds sessions[] (exampleId ↔ sessionId) + failures[]

Differs by design: no --name / --kms-key-arn (no async job); output is inline scores, not a job id.

Output

{
"sessionsEvaluated": 1,
"results": [ { "evaluatorId": "Builtin.Helpfulness", "value": 0.83, "label": "Very Helpful", "explanation": "", "tokenUsage": {} } ],
"examplesInvoked": 1,
"examplesFailed": 0,
"sessions": [ { "exampleId": "greet", "sessionId": "" } ],
"failures": []
}

Tests (batch pattern)

  • Edge testsondemand.test.tsx (TestCoreClient): required-flag validation, refuse-when-nothing-invoked, --ingestion-wait-ms passthrough.
  • Fixture goldenondemand.fixture.test.tsx: real invoke → CloudWatch traces → Evaluate, recorded against a live agent, replayed offline via matchGolden. Deterministic via the injected newSessionId seam plus a now() clock seam — on-demand's trace-query window is otherwise Date.now()-based, so its StartQuery fixture key would drift between record and replay (batch has no client query; evaluate pins an explicit --start-time/--end-time).
  • Live-validated across 10 dataset scenarios against a real agent in the EXPLORE account (all real Builtin.Helpfulness scores; edge/negative paths handled).

Notes

  • Builtin.Helpfulness ignores ground-truth refs (ignoredReferenceInputFields); the handler still forwards them (adapter exercised).
  • Rebased onto current refactor (was stacked on the pre-merge batch-simulate work).

@github-actionsgithub-actionsBot added size/m PR size: M agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 22, 2026
@codecov-commenter

codecov-commenter commented Aug 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.16%. Comparing base (f2b73d6) to head (0cfacfe).

Additional details and impacted files
@@ Coverage Diff @@## refactor #2071 +/- ##
============================================
+ Coverage 97.14% 97.16% +0.02% 
============================================
Files 494 495 +1 Lines 32550 32676 +126 ============================================
+ Hits 31622 31751 +129 + Misses 928 925 -3 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from 634f6f9 to 94a16acCompareAugust 22, 2026 16:23
Base automatically changed from feat/eval-invoke-dataset-pr to refactorAugust 24, 2026 22:48
@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from 94a16ac to 623bbfcCompareAugust 27, 2026 20:53
@github-actionsgithub-actionsBot added size/m PR size: M and removed size/m PR size: M labels Aug 27, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/m PR size: M labels Aug 27, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 27, 2026
@jariy17
jariy17 marked this pull request as ready for review August 27, 2026 21:16
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from ec6636c to f6776ccCompareAugust 27, 2026 21:17
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 27, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026
@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from f6776cc to c29ad31CompareAugust 27, 2026 21:20
@github-actionsgithub-actionsBot removed the size/xl PR size: XL label Aug 27, 2026
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/xl PR size: XL labels Aug 28, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 28, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 28, 2026
jariy17 pushed a commit that referenced this pull request Aug 31, 2026
… expectedResponse as a reference input
Addresses review on #2071: swap the hand-rolled SIGINT/AbortController for the shared
withUserCancellation helper, and include per-turn expectedResponse in the Evaluate
reference inputs so an expected-response-only dataset still contributes ground truth.
@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from 1b0ca37 to 2c20882CompareAugust 31, 2026 15:47
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/l PR size: L labels Aug 31, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
jariy17 added 6 commits August 31, 2026 17:17
… expectedResponse as a reference input
Addresses review on #2071: swap the hand-rolled SIGINT/AbortController for the shared
withUserCancellation helper, and include per-turn expectedResponse in the Evaluate
reference inputs so an expected-response-only dataset still contributes ground truth.
…late turn→traceId)
Bug bash against a live agent showed the Evaluate API rejects expectedResponse under a
session-only context. Correlate each turn's expectedResponse to its trace id instead, and
extend the fixture golden dataset with an expected_response turn graded by Builtin.Correctness
so the real Evaluate call validates the mapping at record time.
@jariy17
jariy17force-pushed the feat/eval-ondemand-simulate branch from 2c20882 to 0cfacfeCompareAugust 31, 2026 17:18
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/l PR size: L labels Aug 31, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
@jariy17
jariy17 merged commit f431dce into refactorAug 31, 2026
21 checks passed
@jariy17
jariy17 deleted the feat/eval-ondemand-simulate branch August 31, 2026 17:40
),
flag("header", "an ordered application header (repeatable)", z.array(z.string()).optional()),
flag(
"bearer-token",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this and --header should be marked sensitive

jariy17 pushed a commit that referenced this pull request Aug 31, 2026
Follow-up to #2071. These flags carry secrets (CUSTOM_JWT bearer token,
auth headers) but were logged in cleartext by the withLogging debug
middleware. The canonical 'runtime invoke' handler already marks both
sensitive; apply the same to the on-demand and batch-evaluation simulate
handlers.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/lPR size: L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jariy17@codecov-commenter@notgitika@nborges-aws