Skip to content

fix(eval): mark --header and --bearer-token sensitive in eval simulate - #2148

Merged
jariy17 merged 1 commit into
refactorfrom
follow-up/eval-simulate-sensitive-flags
Aug 31, 2026
Merged

fix(eval): mark --header and --bearer-token sensitive in eval simulate#2148
jariy17 merged 1 commit into
refactorfrom
follow-up/eval-simulate-sensitive-flags

Conversation

@jariy17

Copy link
Copy Markdown
Contributor

What

Follow-up to #2071. Mark --header and --bearer-token as sensitive on both eval ondemand simulate and eval batch-evaluation simulate, so the withLogging debug middleware redacts them instead of logging the CUSTOM_JWT bearer token and application headers in cleartext.

Addresses nborges-aws's review comment on #2071: "this and --header should be marked sensitive."

Why

The canonical runtime invoke handler already marks both flags sensitive (src/handlers/runtime/invoke/index.tsx). The two simulate twins accept the identical secret-carrying flags but omitted the annotation, so a --debug run would leak the token/headers. Fixed both twins for consistency — leaving the batch one would be half a fix for the same secret.

Already done in #2071 (not re-addressed here)

The other two review commitments landed before #2071 merged:

  • withUserCancellation shared helper — already used
  • expectedResponse reference inputs — already handled by toReferenceInputs

Test

bun test for both simulate handlers: 25 pass / 0 fail. bun run typecheck clean.

@github-actionsgithub-actionsBot added the size/m PR size: M label Aug 31, 2026
@agentcore-devx-automationagentcore-devx-automationBot added agentcore-harness-reviewing AgentCore Harness review in progress claude-security-reviewing Claude Code /security-review in progress labels Aug 31, 2026
Follow-up to #2071. These flags carry secrets (CUSTOM_JWT bearer token,
auth headers) but were logged in cleartext by the withLogging debug
middleware. The canonical 'runtime invoke' handler already marks both
sensitive; apply the same to the on-demand and batch-evaluation simulate
handlers.
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
@jariy17
jariy17force-pushed the follow-up/eval-simulate-sensitive-flags branch from 8717cfd to 93de6fbCompareAugust 31, 2026 18:10
@github-actionsgithub-actionsBot added size/xs PR size: XS and removed size/m PR size: M labels Aug 31, 2026

@agentcore-devx-automationagentcore-devx-automationBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AgentCore Harness Review

Verdict: Looks good

The functional change is small and correct: --header and --bearer-token in src/handlers/eval/batch-evaluation/simulate/index.tsx and src/handlers/eval/ondemand/simulate/index.tsx are now marked sensitive: true, matching the canonical runtime invoke handler and ensuring withLogging redacts these values.

One thing worth double-checking before merging — the bun.lock diff is much larger than the fix itself and includes changes that look unrelated:

  • lockfileVersion drops from 3 to 1, suggesting the lockfile was regenerated with an older Bun.
  • The explicit overrides entry for @aws-cdk/toolkit-libyaml: ^1 (added intentionally in commit 0565ca89 fix(deps): record the nested toolkit-lib yaml override in bun.lock) is removed from the lockfile's overrides block. The pin is still functionally in place because package.json retains the override and the resolved @aws-cdk/toolkit-lib/yaml → yaml@1.10.3 entry still appears in the lockfile, so this isn't a correctness bug — but it partly undoes what 0565ca89 was trying to record.
  • eslint bumps 9.39.5 → 10.9.1 (major) with a cascade of transitive dev-dep changes, which has nothing to do with marking flags sensitive.

Options for the author:

  1. Regenerate bun.lock on the same Bun version as main (keeping lockfileVersion: 3 and the explicit toolkit-lib override) so this PR only touches the two .tsx files.
  2. Or, if the lockfile drift is intentional, split it into a separate PR so this fix stays focused.

Not blocking on this if the team is comfortable with the lockfile churn.

Minor: other handlers (e.g. gateway/invoke/invoke.test.tsx) have a small test asserting flags().find(...).sensitive === true. Adding equivalent assertions here would prevent future regressions, but runtime/invoke doesn't have one either, so it's consistent as-is.

@agentcore-devx-automationagentcore-devx-automationBot added claude-security-reviewing Claude Code /security-review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 31, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.16%. Comparing base (f431dce) to head (93de6fb).

Additional details and impacted files
@@ Coverage Diff @@## refactor #2148 +/- ##
=========================================
Coverage 97.16% 97.16% =========================================
Files 495 495 Lines 32676 32682 +6 =========================================
+ Hits 31751 31757 +6 
Misses 925 925 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jariy17
jariy17 merged commit 23714d3 into refactorAug 31, 2026
22 checks passed
@jariy17
jariy17 deleted the follow-up/eval-simulate-sensitive-flags branch August 31, 2026 18:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xsPR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jariy17@codecov-commenter@nborges-aws
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(eval): mark --header and --bearer-token sensitive in eval simulate by jariy17 · Pull Request #2148 · aws/agentcore-cli · GitHub
Skip to content

fix(eval): mark --header and --bearer-token sensitive in eval simulate - #2148

Merged
jariy17 merged 1 commit into
refactorfrom
follow-up/eval-simulate-sensitive-flags
Aug 31, 2026
Merged

fix(eval): mark --header and --bearer-token sensitive in eval simulate#2148
jariy17 merged 1 commit into
refactorfrom
follow-up/eval-simulate-sensitive-flags

Conversation

@jariy17

Copy link
Copy Markdown
Contributor

What

Follow-up to #2071. Mark --header and --bearer-token as sensitive on both eval ondemand simulate and eval batch-evaluation simulate, so the withLogging debug middleware redacts them instead of logging the CUSTOM_JWT bearer token and application headers in cleartext.

Addresses nborges-aws's review comment on #2071: "this and --header should be marked sensitive."

Why

The canonical runtime invoke handler already marks both flags sensitive (src/handlers/runtime/invoke/index.tsx). The two simulate twins accept the identical secret-carrying flags but omitted the annotation, so a --debug run would leak the token/headers. Fixed both twins for consistency — leaving the batch one would be half a fix for the same secret.

Already done in #2071 (not re-addressed here)

The other two review commitments landed before #2071 merged:

  • withUserCancellation shared helper — already used
  • expectedResponse reference inputs — already handled by toReferenceInputs

Test

bun test for both simulate handlers: 25 pass / 0 fail. bun run typecheck clean.

@github-actionsgithub-actionsBot added the size/m PR size: M label Aug 31, 2026
@agentcore-devx-automationagentcore-devx-automationBot added agentcore-harness-reviewing AgentCore Harness review in progress claude-security-reviewing Claude Code /security-review in progress labels Aug 31, 2026
Follow-up to #2071. These flags carry secrets (CUSTOM_JWT bearer token,
auth headers) but were logged in cleartext by the withLogging debug
middleware. The canonical 'runtime invoke' handler already marks both
sensitive; apply the same to the on-demand and batch-evaluation simulate
handlers.
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
@jariy17
jariy17force-pushed the follow-up/eval-simulate-sensitive-flags branch from 8717cfd to 93de6fbCompareAugust 31, 2026 18:10
@github-actionsgithub-actionsBot added size/xs PR size: XS and removed size/m PR size: M labels Aug 31, 2026

@agentcore-devx-automationagentcore-devx-automationBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AgentCore Harness Review

Verdict: Looks good

The functional change is small and correct: --header and --bearer-token in src/handlers/eval/batch-evaluation/simulate/index.tsx and src/handlers/eval/ondemand/simulate/index.tsx are now marked sensitive: true, matching the canonical runtime invoke handler and ensuring withLogging redacts these values.

One thing worth double-checking before merging — the bun.lock diff is much larger than the fix itself and includes changes that look unrelated:

  • lockfileVersion drops from 3 to 1, suggesting the lockfile was regenerated with an older Bun.
  • The explicit overrides entry for @aws-cdk/toolkit-libyaml: ^1 (added intentionally in commit 0565ca89 fix(deps): record the nested toolkit-lib yaml override in bun.lock) is removed from the lockfile's overrides block. The pin is still functionally in place because package.json retains the override and the resolved @aws-cdk/toolkit-lib/yaml → yaml@1.10.3 entry still appears in the lockfile, so this isn't a correctness bug — but it partly undoes what 0565ca89 was trying to record.
  • eslint bumps 9.39.5 → 10.9.1 (major) with a cascade of transitive dev-dep changes, which has nothing to do with marking flags sensitive.

Options for the author:

  1. Regenerate bun.lock on the same Bun version as main (keeping lockfileVersion: 3 and the explicit toolkit-lib override) so this PR only touches the two .tsx files.
  2. Or, if the lockfile drift is intentional, split it into a separate PR so this fix stays focused.

Not blocking on this if the team is comfortable with the lockfile churn.

Minor: other handlers (e.g. gateway/invoke/invoke.test.tsx) have a small test asserting flags().find(...).sensitive === true. Adding equivalent assertions here would prevent future regressions, but runtime/invoke doesn't have one either, so it's consistent as-is.

@agentcore-devx-automationagentcore-devx-automationBot added claude-security-reviewing Claude Code /security-review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 31, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.16%. Comparing base (f431dce) to head (93de6fb).

Additional details and impacted files
@@ Coverage Diff @@## refactor #2148 +/- ##
=========================================
Coverage 97.16% 97.16% =========================================
Files 495 495 Lines 32676 32682 +6 =========================================
+ Hits 31751 31757 +6 
Misses 925 925 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jariy17
jariy17 merged commit 23714d3 into refactorAug 31, 2026
22 checks passed
@jariy17
jariy17 deleted the follow-up/eval-simulate-sensitive-flags branch August 31, 2026 18:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xsPR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jariy17@codecov-commenter@nborges-aws
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(eval): mark --header and --bearer-token sensitive in eval simulate by jariy17 · Pull Request #2148 · aws/agentcore-cli · GitHub
Skip to content

fix(eval): mark --header and --bearer-token sensitive in eval simulate - #2148

Merged
jariy17 merged 1 commit into
refactorfrom
follow-up/eval-simulate-sensitive-flags
Aug 31, 2026
Merged

fix(eval): mark --header and --bearer-token sensitive in eval simulate#2148
jariy17 merged 1 commit into
refactorfrom
follow-up/eval-simulate-sensitive-flags

Conversation

@jariy17

Copy link
Copy Markdown
Contributor

What

Follow-up to #2071. Mark --header and --bearer-token as sensitive on both eval ondemand simulate and eval batch-evaluation simulate, so the withLogging debug middleware redacts them instead of logging the CUSTOM_JWT bearer token and application headers in cleartext.

Addresses nborges-aws's review comment on #2071: "this and --header should be marked sensitive."

Why

The canonical runtime invoke handler already marks both flags sensitive (src/handlers/runtime/invoke/index.tsx). The two simulate twins accept the identical secret-carrying flags but omitted the annotation, so a --debug run would leak the token/headers. Fixed both twins for consistency — leaving the batch one would be half a fix for the same secret.

Already done in #2071 (not re-addressed here)

The other two review commitments landed before #2071 merged:

  • withUserCancellation shared helper — already used
  • expectedResponse reference inputs — already handled by toReferenceInputs

Test

bun test for both simulate handlers: 25 pass / 0 fail. bun run typecheck clean.

@github-actionsgithub-actionsBot added the size/m PR size: M label Aug 31, 2026
@agentcore-devx-automationagentcore-devx-automationBot added agentcore-harness-reviewing AgentCore Harness review in progress claude-security-reviewing Claude Code /security-review in progress labels Aug 31, 2026
Follow-up to #2071. These flags carry secrets (CUSTOM_JWT bearer token,
auth headers) but were logged in cleartext by the withLogging debug
middleware. The canonical 'runtime invoke' handler already marks both
sensitive; apply the same to the on-demand and batch-evaluation simulate
handlers.
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
@jariy17
jariy17force-pushed the follow-up/eval-simulate-sensitive-flags branch from 8717cfd to 93de6fbCompareAugust 31, 2026 18:10
@github-actionsgithub-actionsBot added size/xs PR size: XS and removed size/m PR size: M labels Aug 31, 2026

@agentcore-devx-automationagentcore-devx-automationBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AgentCore Harness Review

Verdict: Looks good

The functional change is small and correct: --header and --bearer-token in src/handlers/eval/batch-evaluation/simulate/index.tsx and src/handlers/eval/ondemand/simulate/index.tsx are now marked sensitive: true, matching the canonical runtime invoke handler and ensuring withLogging redacts these values.

One thing worth double-checking before merging — the bun.lock diff is much larger than the fix itself and includes changes that look unrelated:

  • lockfileVersion drops from 3 to 1, suggesting the lockfile was regenerated with an older Bun.
  • The explicit overrides entry for @aws-cdk/toolkit-libyaml: ^1 (added intentionally in commit 0565ca89 fix(deps): record the nested toolkit-lib yaml override in bun.lock) is removed from the lockfile's overrides block. The pin is still functionally in place because package.json retains the override and the resolved @aws-cdk/toolkit-lib/yaml → yaml@1.10.3 entry still appears in the lockfile, so this isn't a correctness bug — but it partly undoes what 0565ca89 was trying to record.
  • eslint bumps 9.39.5 → 10.9.1 (major) with a cascade of transitive dev-dep changes, which has nothing to do with marking flags sensitive.

Options for the author:

  1. Regenerate bun.lock on the same Bun version as main (keeping lockfileVersion: 3 and the explicit toolkit-lib override) so this PR only touches the two .tsx files.
  2. Or, if the lockfile drift is intentional, split it into a separate PR so this fix stays focused.

Not blocking on this if the team is comfortable with the lockfile churn.

Minor: other handlers (e.g. gateway/invoke/invoke.test.tsx) have a small test asserting flags().find(...).sensitive === true. Adding equivalent assertions here would prevent future regressions, but runtime/invoke doesn't have one either, so it's consistent as-is.

@agentcore-devx-automationagentcore-devx-automationBot added claude-security-reviewing Claude Code /security-review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 31, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.16%. Comparing base (f431dce) to head (93de6fb).

Additional details and impacted files
@@ Coverage Diff @@## refactor #2148 +/- ##
=========================================
Coverage 97.16% 97.16% =========================================
Files 495 495 Lines 32676 32682 +6 =========================================
+ Hits 31751 31757 +6 
Misses 925 925 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jariy17
jariy17 merged commit 23714d3 into refactorAug 31, 2026
22 checks passed
@jariy17
jariy17 deleted the follow-up/eval-simulate-sensitive-flags branch August 31, 2026 18:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xsPR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jariy17@codecov-commenter@nborges-aws
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(eval): mark --header and --bearer-token sensitive in eval simulate by jariy17 · Pull Request #2148 · aws/agentcore-cli · GitHub
Skip to content

fix(eval): mark --header and --bearer-token sensitive in eval simulate - #2148

Merged
jariy17 merged 1 commit into
refactorfrom
follow-up/eval-simulate-sensitive-flags
Aug 31, 2026
Merged

fix(eval): mark --header and --bearer-token sensitive in eval simulate#2148
jariy17 merged 1 commit into
refactorfrom
follow-up/eval-simulate-sensitive-flags

Conversation

@jariy17

Copy link
Copy Markdown
Contributor

What

Follow-up to #2071. Mark --header and --bearer-token as sensitive on both eval ondemand simulate and eval batch-evaluation simulate, so the withLogging debug middleware redacts them instead of logging the CUSTOM_JWT bearer token and application headers in cleartext.

Addresses nborges-aws's review comment on #2071: "this and --header should be marked sensitive."

Why

The canonical runtime invoke handler already marks both flags sensitive (src/handlers/runtime/invoke/index.tsx). The two simulate twins accept the identical secret-carrying flags but omitted the annotation, so a --debug run would leak the token/headers. Fixed both twins for consistency — leaving the batch one would be half a fix for the same secret.

Already done in #2071 (not re-addressed here)

The other two review commitments landed before #2071 merged:

  • withUserCancellation shared helper — already used
  • expectedResponse reference inputs — already handled by toReferenceInputs

Test

bun test for both simulate handlers: 25 pass / 0 fail. bun run typecheck clean.

@github-actionsgithub-actionsBot added the size/m PR size: M label Aug 31, 2026
@agentcore-devx-automationagentcore-devx-automationBot added agentcore-harness-reviewing AgentCore Harness review in progress claude-security-reviewing Claude Code /security-review in progress labels Aug 31, 2026
Follow-up to #2071. These flags carry secrets (CUSTOM_JWT bearer token,
auth headers) but were logged in cleartext by the withLogging debug
middleware. The canonical 'runtime invoke' handler already marks both
sensitive; apply the same to the on-demand and batch-evaluation simulate
handlers.
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
@jariy17
jariy17force-pushed the follow-up/eval-simulate-sensitive-flags branch from 8717cfd to 93de6fbCompareAugust 31, 2026 18:10
@github-actionsgithub-actionsBot added size/xs PR size: XS and removed size/m PR size: M labels Aug 31, 2026

@agentcore-devx-automationagentcore-devx-automationBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AgentCore Harness Review

Verdict: Looks good

The functional change is small and correct: --header and --bearer-token in src/handlers/eval/batch-evaluation/simulate/index.tsx and src/handlers/eval/ondemand/simulate/index.tsx are now marked sensitive: true, matching the canonical runtime invoke handler and ensuring withLogging redacts these values.

One thing worth double-checking before merging — the bun.lock diff is much larger than the fix itself and includes changes that look unrelated:

  • lockfileVersion drops from 3 to 1, suggesting the lockfile was regenerated with an older Bun.
  • The explicit overrides entry for @aws-cdk/toolkit-libyaml: ^1 (added intentionally in commit 0565ca89 fix(deps): record the nested toolkit-lib yaml override in bun.lock) is removed from the lockfile's overrides block. The pin is still functionally in place because package.json retains the override and the resolved @aws-cdk/toolkit-lib/yaml → yaml@1.10.3 entry still appears in the lockfile, so this isn't a correctness bug — but it partly undoes what 0565ca89 was trying to record.
  • eslint bumps 9.39.5 → 10.9.1 (major) with a cascade of transitive dev-dep changes, which has nothing to do with marking flags sensitive.

Options for the author:

  1. Regenerate bun.lock on the same Bun version as main (keeping lockfileVersion: 3 and the explicit toolkit-lib override) so this PR only touches the two .tsx files.
  2. Or, if the lockfile drift is intentional, split it into a separate PR so this fix stays focused.

Not blocking on this if the team is comfortable with the lockfile churn.

Minor: other handlers (e.g. gateway/invoke/invoke.test.tsx) have a small test asserting flags().find(...).sensitive === true. Adding equivalent assertions here would prevent future regressions, but runtime/invoke doesn't have one either, so it's consistent as-is.

@agentcore-devx-automationagentcore-devx-automationBot added claude-security-reviewing Claude Code /security-review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 31, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.16%. Comparing base (f431dce) to head (93de6fb).

Additional details and impacted files
@@ Coverage Diff @@## refactor #2148 +/- ##
=========================================
Coverage 97.16% 97.16% =========================================
Files 495 495 Lines 32676 32682 +6 =========================================
+ Hits 31751 31757 +6 
Misses 925 925 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jariy17
jariy17 merged commit 23714d3 into refactorAug 31, 2026
22 checks passed
@jariy17
jariy17 deleted the follow-up/eval-simulate-sensitive-flags branch August 31, 2026 18:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xsPR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jariy17@codecov-commenter@nborges-aws
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' fix(eval): mark --header and --bearer-token sensitive in eval simulate by jariy17 · Pull Request #2148 · aws/agentcore-cli · GitHub
Skip to content

fix(eval): mark --header and --bearer-token sensitive in eval simulate - #2148

Merged
jariy17 merged 1 commit into
refactorfrom
follow-up/eval-simulate-sensitive-flags
Aug 31, 2026
Merged

fix(eval): mark --header and --bearer-token sensitive in eval simulate#2148
jariy17 merged 1 commit into
refactorfrom
follow-up/eval-simulate-sensitive-flags

Conversation

@jariy17

Copy link
Copy Markdown
Contributor

What

Follow-up to #2071. Mark --header and --bearer-token as sensitive on both eval ondemand simulate and eval batch-evaluation simulate, so the withLogging debug middleware redacts them instead of logging the CUSTOM_JWT bearer token and application headers in cleartext.

Addresses nborges-aws's review comment on #2071: "this and --header should be marked sensitive."

Why

The canonical runtime invoke handler already marks both flags sensitive (src/handlers/runtime/invoke/index.tsx). The two simulate twins accept the identical secret-carrying flags but omitted the annotation, so a --debug run would leak the token/headers. Fixed both twins for consistency — leaving the batch one would be half a fix for the same secret.

Already done in #2071 (not re-addressed here)

The other two review commitments landed before #2071 merged:

  • withUserCancellation shared helper — already used
  • expectedResponse reference inputs — already handled by toReferenceInputs

Test

bun test for both simulate handlers: 25 pass / 0 fail. bun run typecheck clean.

@github-actionsgithub-actionsBot added the size/m PR size: M label Aug 31, 2026
@agentcore-devx-automationagentcore-devx-automationBot added agentcore-harness-reviewing AgentCore Harness review in progress claude-security-reviewing Claude Code /security-review in progress labels Aug 31, 2026
Follow-up to #2071. These flags carry secrets (CUSTOM_JWT bearer token,
auth headers) but were logged in cleartext by the withLogging debug
middleware. The canonical 'runtime invoke' handler already marks both
sensitive; apply the same to the on-demand and batch-evaluation simulate
handlers.
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
@jariy17
jariy17force-pushed the follow-up/eval-simulate-sensitive-flags branch from 8717cfd to 93de6fbCompareAugust 31, 2026 18:10
@github-actionsgithub-actionsBot added size/xs PR size: XS and removed size/m PR size: M labels Aug 31, 2026

@agentcore-devx-automationagentcore-devx-automationBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AgentCore Harness Review

Verdict: Looks good

The functional change is small and correct: --header and --bearer-token in src/handlers/eval/batch-evaluation/simulate/index.tsx and src/handlers/eval/ondemand/simulate/index.tsx are now marked sensitive: true, matching the canonical runtime invoke handler and ensuring withLogging redacts these values.

One thing worth double-checking before merging — the bun.lock diff is much larger than the fix itself and includes changes that look unrelated:

  • lockfileVersion drops from 3 to 1, suggesting the lockfile was regenerated with an older Bun.
  • The explicit overrides entry for @aws-cdk/toolkit-libyaml: ^1 (added intentionally in commit 0565ca89 fix(deps): record the nested toolkit-lib yaml override in bun.lock) is removed from the lockfile's overrides block. The pin is still functionally in place because package.json retains the override and the resolved @aws-cdk/toolkit-lib/yaml → yaml@1.10.3 entry still appears in the lockfile, so this isn't a correctness bug — but it partly undoes what 0565ca89 was trying to record.
  • eslint bumps 9.39.5 → 10.9.1 (major) with a cascade of transitive dev-dep changes, which has nothing to do with marking flags sensitive.

Options for the author:

  1. Regenerate bun.lock on the same Bun version as main (keeping lockfileVersion: 3 and the explicit toolkit-lib override) so this PR only touches the two .tsx files.
  2. Or, if the lockfile drift is intentional, split it into a separate PR so this fix stays focused.

Not blocking on this if the team is comfortable with the lockfile churn.

Minor: other handlers (e.g. gateway/invoke/invoke.test.tsx) have a small test asserting flags().find(...).sensitive === true. Adding equivalent assertions here would prevent future regressions, but runtime/invoke doesn't have one either, so it's consistent as-is.

@agentcore-devx-automationagentcore-devx-automationBot added claude-security-reviewing Claude Code /security-review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 31, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.16%. Comparing base (f431dce) to head (93de6fb).

Additional details and impacted files
@@ Coverage Diff @@## refactor #2148 +/- ##
=========================================
Coverage 97.16% 97.16% =========================================
Files 495 495 Lines 32676 32682 +6 =========================================
+ Hits 31751 31757 +6 
Misses 925 925 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jariy17
jariy17 merged commit 23714d3 into refactorAug 31, 2026
22 checks passed
@jariy17
jariy17 deleted the follow-up/eval-simulate-sensitive-flags branch August 31, 2026 18:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xsPR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jariy17@codecov-commenter@nborges-aws
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(eval): mark --header and --bearer-token sensitive in eval simulate by jariy17 · Pull Request #2148 · aws/agentcore-cli · GitHub
Skip to content

fix(eval): mark --header and --bearer-token sensitive in eval simulate - #2148

Merged
jariy17 merged 1 commit into
refactorfrom
follow-up/eval-simulate-sensitive-flags
Aug 31, 2026
Merged

fix(eval): mark --header and --bearer-token sensitive in eval simulate#2148
jariy17 merged 1 commit into
refactorfrom
follow-up/eval-simulate-sensitive-flags

Conversation

@jariy17

Copy link
Copy Markdown
Contributor

What

Follow-up to #2071. Mark --header and --bearer-token as sensitive on both eval ondemand simulate and eval batch-evaluation simulate, so the withLogging debug middleware redacts them instead of logging the CUSTOM_JWT bearer token and application headers in cleartext.

Addresses nborges-aws's review comment on #2071: "this and --header should be marked sensitive."

Why

The canonical runtime invoke handler already marks both flags sensitive (src/handlers/runtime/invoke/index.tsx). The two simulate twins accept the identical secret-carrying flags but omitted the annotation, so a --debug run would leak the token/headers. Fixed both twins for consistency — leaving the batch one would be half a fix for the same secret.

Already done in #2071 (not re-addressed here)

The other two review commitments landed before #2071 merged:

  • withUserCancellation shared helper — already used
  • expectedResponse reference inputs — already handled by toReferenceInputs

Test

bun test for both simulate handlers: 25 pass / 0 fail. bun run typecheck clean.

@github-actionsgithub-actionsBot added the size/m PR size: M label Aug 31, 2026
@agentcore-devx-automationagentcore-devx-automationBot added agentcore-harness-reviewing AgentCore Harness review in progress claude-security-reviewing Claude Code /security-review in progress labels Aug 31, 2026
Follow-up to #2071. These flags carry secrets (CUSTOM_JWT bearer token,
auth headers) but were logged in cleartext by the withLogging debug
middleware. The canonical 'runtime invoke' handler already marks both
sensitive; apply the same to the on-demand and batch-evaluation simulate
handlers.
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
@jariy17
jariy17force-pushed the follow-up/eval-simulate-sensitive-flags branch from 8717cfd to 93de6fbCompareAugust 31, 2026 18:10
@github-actionsgithub-actionsBot added size/xs PR size: XS and removed size/m PR size: M labels Aug 31, 2026

@agentcore-devx-automationagentcore-devx-automationBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AgentCore Harness Review

Verdict: Looks good

The functional change is small and correct: --header and --bearer-token in src/handlers/eval/batch-evaluation/simulate/index.tsx and src/handlers/eval/ondemand/simulate/index.tsx are now marked sensitive: true, matching the canonical runtime invoke handler and ensuring withLogging redacts these values.

One thing worth double-checking before merging — the bun.lock diff is much larger than the fix itself and includes changes that look unrelated:

  • lockfileVersion drops from 3 to 1, suggesting the lockfile was regenerated with an older Bun.
  • The explicit overrides entry for @aws-cdk/toolkit-libyaml: ^1 (added intentionally in commit 0565ca89 fix(deps): record the nested toolkit-lib yaml override in bun.lock) is removed from the lockfile's overrides block. The pin is still functionally in place because package.json retains the override and the resolved @aws-cdk/toolkit-lib/yaml → yaml@1.10.3 entry still appears in the lockfile, so this isn't a correctness bug — but it partly undoes what 0565ca89 was trying to record.
  • eslint bumps 9.39.5 → 10.9.1 (major) with a cascade of transitive dev-dep changes, which has nothing to do with marking flags sensitive.

Options for the author:

  1. Regenerate bun.lock on the same Bun version as main (keeping lockfileVersion: 3 and the explicit toolkit-lib override) so this PR only touches the two .tsx files.
  2. Or, if the lockfile drift is intentional, split it into a separate PR so this fix stays focused.

Not blocking on this if the team is comfortable with the lockfile churn.

Minor: other handlers (e.g. gateway/invoke/invoke.test.tsx) have a small test asserting flags().find(...).sensitive === true. Adding equivalent assertions here would prevent future regressions, but runtime/invoke doesn't have one either, so it's consistent as-is.

@agentcore-devx-automationagentcore-devx-automationBot added claude-security-reviewing Claude Code /security-review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 31, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.16%. Comparing base (f431dce) to head (93de6fb).

Additional details and impacted files
@@ Coverage Diff @@## refactor #2148 +/- ##
=========================================
Coverage 97.16% 97.16% =========================================
Files 495 495 Lines 32676 32682 +6 =========================================
+ Hits 31751 31757 +6 
Misses 925 925 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jariy17
jariy17 merged commit 23714d3 into refactorAug 31, 2026
22 checks passed
@jariy17
jariy17 deleted the follow-up/eval-simulate-sensitive-flags branch August 31, 2026 18:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xsPR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jariy17@codecov-commenter@nborges-aws
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(eval): mark --header and --bearer-token sensitive in eval simulate by jariy17 · Pull Request #2148 · aws/agentcore-cli · GitHub
Skip to content

fix(eval): mark --header and --bearer-token sensitive in eval simulate - #2148

Merged
jariy17 merged 1 commit into
refactorfrom
follow-up/eval-simulate-sensitive-flags
Aug 31, 2026
Merged

fix(eval): mark --header and --bearer-token sensitive in eval simulate#2148
jariy17 merged 1 commit into
refactorfrom
follow-up/eval-simulate-sensitive-flags

Conversation

@jariy17

Copy link
Copy Markdown
Contributor

What

Follow-up to #2071. Mark --header and --bearer-token as sensitive on both eval ondemand simulate and eval batch-evaluation simulate, so the withLogging debug middleware redacts them instead of logging the CUSTOM_JWT bearer token and application headers in cleartext.

Addresses nborges-aws's review comment on #2071: "this and --header should be marked sensitive."

Why

The canonical runtime invoke handler already marks both flags sensitive (src/handlers/runtime/invoke/index.tsx). The two simulate twins accept the identical secret-carrying flags but omitted the annotation, so a --debug run would leak the token/headers. Fixed both twins for consistency — leaving the batch one would be half a fix for the same secret.

Already done in #2071 (not re-addressed here)

The other two review commitments landed before #2071 merged:

  • withUserCancellation shared helper — already used
  • expectedResponse reference inputs — already handled by toReferenceInputs

Test

bun test for both simulate handlers: 25 pass / 0 fail. bun run typecheck clean.

@github-actionsgithub-actionsBot added the size/m PR size: M label Aug 31, 2026
@agentcore-devx-automationagentcore-devx-automationBot added agentcore-harness-reviewing AgentCore Harness review in progress claude-security-reviewing Claude Code /security-review in progress labels Aug 31, 2026
Follow-up to #2071. These flags carry secrets (CUSTOM_JWT bearer token,
auth headers) but were logged in cleartext by the withLogging debug
middleware. The canonical 'runtime invoke' handler already marks both
sensitive; apply the same to the on-demand and batch-evaluation simulate
handlers.
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
@jariy17
jariy17force-pushed the follow-up/eval-simulate-sensitive-flags branch from 8717cfd to 93de6fbCompareAugust 31, 2026 18:10
@github-actionsgithub-actionsBot added size/xs PR size: XS and removed size/m PR size: M labels Aug 31, 2026

@agentcore-devx-automationagentcore-devx-automationBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AgentCore Harness Review

Verdict: Looks good

The functional change is small and correct: --header and --bearer-token in src/handlers/eval/batch-evaluation/simulate/index.tsx and src/handlers/eval/ondemand/simulate/index.tsx are now marked sensitive: true, matching the canonical runtime invoke handler and ensuring withLogging redacts these values.

One thing worth double-checking before merging — the bun.lock diff is much larger than the fix itself and includes changes that look unrelated:

  • lockfileVersion drops from 3 to 1, suggesting the lockfile was regenerated with an older Bun.
  • The explicit overrides entry for @aws-cdk/toolkit-libyaml: ^1 (added intentionally in commit 0565ca89 fix(deps): record the nested toolkit-lib yaml override in bun.lock) is removed from the lockfile's overrides block. The pin is still functionally in place because package.json retains the override and the resolved @aws-cdk/toolkit-lib/yaml → yaml@1.10.3 entry still appears in the lockfile, so this isn't a correctness bug — but it partly undoes what 0565ca89 was trying to record.
  • eslint bumps 9.39.5 → 10.9.1 (major) with a cascade of transitive dev-dep changes, which has nothing to do with marking flags sensitive.

Options for the author:

  1. Regenerate bun.lock on the same Bun version as main (keeping lockfileVersion: 3 and the explicit toolkit-lib override) so this PR only touches the two .tsx files.
  2. Or, if the lockfile drift is intentional, split it into a separate PR so this fix stays focused.

Not blocking on this if the team is comfortable with the lockfile churn.

Minor: other handlers (e.g. gateway/invoke/invoke.test.tsx) have a small test asserting flags().find(...).sensitive === true. Adding equivalent assertions here would prevent future regressions, but runtime/invoke doesn't have one either, so it's consistent as-is.

@agentcore-devx-automationagentcore-devx-automationBot added claude-security-reviewing Claude Code /security-review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 31, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.16%. Comparing base (f431dce) to head (93de6fb).

Additional details and impacted files
@@ Coverage Diff @@## refactor #2148 +/- ##
=========================================
Coverage 97.16% 97.16% =========================================
Files 495 495 Lines 32676 32682 +6 =========================================
+ Hits 31751 31757 +6 
Misses 925 925 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jariy17
jariy17 merged commit 23714d3 into refactorAug 31, 2026
22 checks passed
@jariy17
jariy17 deleted the follow-up/eval-simulate-sensitive-flags branch August 31, 2026 18:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xsPR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jariy17@codecov-commenter@nborges-aws
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); fix(eval): mark --header and --bearer-token sensitive in eval simulate by jariy17 · Pull Request #2148 · aws/agentcore-cli · GitHub
Skip to content

fix(eval): mark --header and --bearer-token sensitive in eval simulate - #2148

Merged
jariy17 merged 1 commit into
refactorfrom
follow-up/eval-simulate-sensitive-flags
Aug 31, 2026
Merged

fix(eval): mark --header and --bearer-token sensitive in eval simulate#2148
jariy17 merged 1 commit into
refactorfrom
follow-up/eval-simulate-sensitive-flags

Conversation

@jariy17

Copy link
Copy Markdown
Contributor

What

Follow-up to #2071. Mark --header and --bearer-token as sensitive on both eval ondemand simulate and eval batch-evaluation simulate, so the withLogging debug middleware redacts them instead of logging the CUSTOM_JWT bearer token and application headers in cleartext.

Addresses nborges-aws's review comment on #2071: "this and --header should be marked sensitive."

Why

The canonical runtime invoke handler already marks both flags sensitive (src/handlers/runtime/invoke/index.tsx). The two simulate twins accept the identical secret-carrying flags but omitted the annotation, so a --debug run would leak the token/headers. Fixed both twins for consistency — leaving the batch one would be half a fix for the same secret.

Already done in #2071 (not re-addressed here)

The other two review commitments landed before #2071 merged:

  • withUserCancellation shared helper — already used
  • expectedResponse reference inputs — already handled by toReferenceInputs

Test

bun test for both simulate handlers: 25 pass / 0 fail. bun run typecheck clean.

@github-actionsgithub-actionsBot added the size/m PR size: M label Aug 31, 2026
@agentcore-devx-automationagentcore-devx-automationBot added agentcore-harness-reviewing AgentCore Harness review in progress claude-security-reviewing Claude Code /security-review in progress labels Aug 31, 2026
Follow-up to #2071. These flags carry secrets (CUSTOM_JWT bearer token,
auth headers) but were logged in cleartext by the withLogging debug
middleware. The canonical 'runtime invoke' handler already marks both
sensitive; apply the same to the on-demand and batch-evaluation simulate
handlers.
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
@jariy17
jariy17force-pushed the follow-up/eval-simulate-sensitive-flags branch from 8717cfd to 93de6fbCompareAugust 31, 2026 18:10
@github-actionsgithub-actionsBot added size/xs PR size: XS and removed size/m PR size: M labels Aug 31, 2026

@agentcore-devx-automationagentcore-devx-automationBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AgentCore Harness Review

Verdict: Looks good

The functional change is small and correct: --header and --bearer-token in src/handlers/eval/batch-evaluation/simulate/index.tsx and src/handlers/eval/ondemand/simulate/index.tsx are now marked sensitive: true, matching the canonical runtime invoke handler and ensuring withLogging redacts these values.

One thing worth double-checking before merging — the bun.lock diff is much larger than the fix itself and includes changes that look unrelated:

  • lockfileVersion drops from 3 to 1, suggesting the lockfile was regenerated with an older Bun.
  • The explicit overrides entry for @aws-cdk/toolkit-libyaml: ^1 (added intentionally in commit 0565ca89 fix(deps): record the nested toolkit-lib yaml override in bun.lock) is removed from the lockfile's overrides block. The pin is still functionally in place because package.json retains the override and the resolved @aws-cdk/toolkit-lib/yaml → yaml@1.10.3 entry still appears in the lockfile, so this isn't a correctness bug — but it partly undoes what 0565ca89 was trying to record.
  • eslint bumps 9.39.5 → 10.9.1 (major) with a cascade of transitive dev-dep changes, which has nothing to do with marking flags sensitive.

Options for the author:

  1. Regenerate bun.lock on the same Bun version as main (keeping lockfileVersion: 3 and the explicit toolkit-lib override) so this PR only touches the two .tsx files.
  2. Or, if the lockfile drift is intentional, split it into a separate PR so this fix stays focused.

Not blocking on this if the team is comfortable with the lockfile churn.

Minor: other handlers (e.g. gateway/invoke/invoke.test.tsx) have a small test asserting flags().find(...).sensitive === true. Adding equivalent assertions here would prevent future regressions, but runtime/invoke doesn't have one either, so it's consistent as-is.

@agentcore-devx-automationagentcore-devx-automationBot added claude-security-reviewing Claude Code /security-review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 31, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 31, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.16%. Comparing base (f431dce) to head (93de6fb).

Additional details and impacted files
@@ Coverage Diff @@## refactor #2148 +/- ##
=========================================
Coverage 97.16% 97.16% =========================================
Files 495 495 Lines 32676 32682 +6 =========================================
+ Hits 31751 31757 +6 
Misses 925 925 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jariy17
jariy17 merged commit 23714d3 into refactorAug 31, 2026
22 checks passed
@jariy17
jariy17 deleted the follow-up/eval-simulate-sensitive-flags branch August 31, 2026 18:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xsPR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jariy17@codecov-commenter@nborges-aws