Uh oh!
There was an error while loading. Please reload this page.
refactor(cli)!: unify naming without backward-compat aliases - #705
Merged
Conversation
The CLI command was 'add identity', the config key was 'credentials', and the resource types were ApiKeyCredentialProvider / OAuthCredentialProvider. Three different names for the same concept. This unifies everything under 'credential' — CLI commands, resource type, labels, validation, and docs. The old 'identity' command name is preserved as a hidden alias for backward compatibility. Constraint: Must maintain backward compat for existing scripts using 'agentcore add identity' Rejected: Keep 'identity' as primary | 'credential' is already the config term and more precise Confidence: high Scope-risk: moderate
deploy uses -y, --yes while remove uses --force. These mean the same thing (skip interactive confirmation) but used different names. Now -y/--yes is the primary flag everywhere. --force is preserved as an alias on remove commands for backward compatibility. Constraint: Must not break existing scripts using --force on remove Rejected: Use --force everywhere | --yes is the conventional flag name for confirmation skip Confidence: high Scope-risk: narrow
deploy uses --plan while create and remove use --dry-run. Same concept, different names. Now --dry-run is the primary flag on deploy. --plan is preserved as an alias for backward compatibility. Output message updated from 'Plan complete' to 'Dry run complete'. Constraint: Must not break existing scripts using --plan on deploy Rejected: Use --plan everywhere | --dry-run is the standard convention Confidence: high Scope-risk: narrow
The article was 'an' for the old 'identity' label but 'credential' takes 'a'. This fixes help text like "Remove an credential" → "Remove a credential". Confidence: high Scope-risk: narrow
BREAKING CHANGE: Remove all backward-compatibility aliases: - `agentcore add identity` no longer works (use `agentcore add credential`) - `--force` flag removed from remove commands (use `-y` or `--yes`) - `--plan` flag removed from deploy command (use `--dry-run`) This is the clean-break alternative to the alias-preserving PR. Confidence: high Scope-risk: moderate
jesseturner21had a problem deploying
to
e2e-testing
March 27, 2026 16:22 — with 
GitHub Actions
Failure
jesseturner21had a problem deploying
to
e2e-testing
March 27, 2026 16:22 — with GitHub Actions
Failure
The --plan alias was removed in the breaking change commit. Confidence: high Scope-risk: narrow
…emoval Integration tests were still using `add identity` and `remove identity` commands which no longer exist without the backward-compat aliases. Confidence: high Scope-risk: narrow
jesseturner21had a problem deploying
to
e2e-testing
March 27, 2026 16:36 — with GitHub Actions
Failure
jesseturner21had a problem deploying
to
e2e-testing
March 27, 2026 16:36 — with GitHub Actions
Failure
Hweinstock
previously approved these changes
Mar 27, 2026
Hweinstock
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
when reading this, credential sounded slightly strange instead of credentials, but I guess its correct since we're referring to a single instance of credentials? I'm aligned if we think singular makes sense.
Uh oh!
There was an error while loading. Please reload this page.
Contributor
Coverage Report
|
jesseturner21had a problem deploying
to
e2e-testing
March 27, 2026 17:09 — with GitHub Actions
Failure
jesseturner21had a problem deploying
to
e2e-testing
March 27, 2026 17:09 — with GitHub Actions
Failure
aidandaly24
approved these changes
Mar 27, 2026
Uh oh!
There was an error while loading. Please reload this page.
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 27, 2026
- Remove `type` fields from agent, memory, evaluator, online-eval-config examples and field tables (removed in aws#709) - Remove `modelProvider` from agent spec (removed in aws#709) - Rename credential `type` to `authorizerType` (renamed in aws#709) - Rename `add identity` to `add credential` everywhere (aws#705) - Replace `--force` with `-y/--yes` on remove commands (aws#705) - Replace `--plan` with `--dry-run` on deploy command (aws#705) - Update snapshot for src/assets/README.md change
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 27, 2026
- Remove `type` fields from agent, memory, evaluator, online-eval-config examples and field tables (removed in aws#709) - Remove `modelProvider` from agent spec (removed in aws#709) - Rename credential `type` to `authorizerType` (renamed in aws#709) - Rename `add identity` to `add credential` everywhere (aws#705) - Replace `--force` with `-y/--yes` on remove commands (aws#705) - Replace `--plan` with `--dry-run` on deploy command (aws#705) - Update snapshot for src/assets/README.md change
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 27, 2026
- Remove `type` fields from agent, memory, evaluator, online-eval-config examples and field tables (removed in aws#709) - Remove `modelProvider` from agent spec (removed in aws#709) - Rename credential `type` to `authorizerType` (renamed in aws#709) - Rename `add identity` to `add credential` everywhere (aws#705) - Replace `--force` with `-y/--yes` on remove commands (aws#705) - Replace `--plan` with `--dry-run` on deploy command (aws#705) - Update snapshot for src/assets/README.md change
15 tasks
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 28, 2026
- Remove `type` fields from agent, memory, evaluator, online-eval-config examples and field tables (removed in aws#709) - Remove `modelProvider` from agent spec (removed in aws#709) - Rename credential `type` to `authorizerType` (renamed in aws#709) - Rename `add identity` to `add credential` everywhere (aws#705) - Replace `--force` with `-y/--yes` on remove commands (aws#705) - Replace `--plan` with `--dry-run` on deploy command (aws#705) - Update snapshot for src/assets/README.md change
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 28, 2026
- Remove `type` fields from agent, memory, evaluator, online-eval-config examples and field tables (removed in aws#709) - Remove `modelProvider` from agent spec (removed in aws#709) - Rename credential `type` to `authorizerType` (renamed in aws#709) - Rename `add identity` to `add credential` everywhere (aws#705) - Replace `--force` with `-y/--yes` on remove commands (aws#705) - Replace `--plan` with `--dry-run` on deploy command (aws#705) - Update snapshot for src/assets/README.md change
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 28, 2026
- Rename --agent-client-id → --client-id, --agent-client-secret → --client-secret in gateway docs (naming unification aws#705) - Add missing flags to add agent: --authorizer-type, --discovery-url, --allowed-audience, --allowed-clients, --allowed-scopes, --custom-claims, --client-id, --client-secret, --idle-timeout, --max-lifetime - Add missing flags to create: --idle-timeout, --max-lifetime - Add missing flags to add gateway: --runtimes, --custom-claims, --policy-engine, --policy-engine-mode - Fix --exception-level values: NONE/ALL (was undocumented) Confidence: high Scope-risk: narrow
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 28, 2026
- Remove `type` fields from agent, memory, evaluator, online-eval-config examples and field tables (removed in aws#709) - Remove `modelProvider` from agent spec (removed in aws#709) - Rename credential `type` to `authorizerType` (renamed in aws#709) - Rename `add identity` to `add credential` everywhere (aws#705) - Replace `--force` with `-y/--yes` on remove commands (aws#705) - Replace `--plan` with `--dry-run` on deploy command (aws#705) - Update snapshot for src/assets/README.md change
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 28, 2026
- Rename --agent-client-id → --client-id, --agent-client-secret → --client-secret in gateway docs (naming unification aws#705) - Add missing flags to add agent: --authorizer-type, --discovery-url, --allowed-audience, --allowed-clients, --allowed-scopes, --custom-claims, --client-id, --client-secret, --idle-timeout, --max-lifetime - Add missing flags to create: --idle-timeout, --max-lifetime - Add missing flags to add gateway: --runtimes, --custom-claims, --policy-engine, --policy-engine-mode - Fix --exception-level values: NONE/ALL (was undocumented) Confidence: high Scope-risk: narrow
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Apr 8, 2026
- Remove `type` fields from agent, memory, evaluator, online-eval-config examples and field tables (removed in aws#709) - Remove `modelProvider` from agent spec (removed in aws#709) - Rename credential `type` to `authorizerType` (renamed in aws#709) - Rename `add identity` to `add credential` everywhere (aws#705) - Replace `--force` with `-y/--yes` on remove commands (aws#705) - Replace `--plan` with `--dry-run` on deploy command (aws#705) - Update snapshot for src/assets/README.md change
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Apr 8, 2026
- Rename --agent-client-id → --client-id, --agent-client-secret → --client-secret in gateway docs (naming unification aws#705) - Add missing flags to add agent: --authorizer-type, --discovery-url, --allowed-audience, --allowed-clients, --allowed-scopes, --custom-claims, --client-id, --client-secret, --idle-timeout, --max-lifetime - Add missing flags to create: --idle-timeout, --max-lifetime - Add missing flags to add gateway: --runtimes, --custom-claims, --policy-engine, --policy-engine-mode - Fix --exception-level values: NONE/ALL (was undocumented) Confidence: high Scope-risk: narrow
aidandaly24 added a commit
that referenced
this pull request
Apr 9, 2026
) * docs: fix 30 documentation inaccuracies found by source code audit - configuration.md: fix networkMode PRIVATE→VPC, remove stale mcp.json section, add 7 missing AgentEnvSpec fields, add Node.js runtimes, fix gateway name max 63→100, list all 6 targetType values, fix memory strategies wording, fix deployed-state.json path, add missing project fields, fix CUSTOM_JWT field requirements, add customClaims field - README.md: add CrewAI framework, update all 4 default model IDs, add missing command sections - frameworks.md: add CrewAI with model providers, add protocol compatibility matrix (HTTP/MCP/A2A) - commands.md: fix agent name max 64→48 chars, add fetch access section, add policy-engine/policy to status --type, remove ghost --tool-filter-description flag, fix model ID date - gateway.md: add enableSemanticSearch/exceptionLevel config options, fix mcp.json→agentcore.json, remove api-key from MCP Server auth - transaction_search.md: fix traces command syntax - container-builds.md: remove nonexistent --progress flag - evals.md: fix model date 20250929→20250514 - local-development.md: fix mcp.json→agentcore.json - AGENTS.md: remove AutoGen, remove stale mcp.json reference - src/assets/README.md: add CrewAI to template list - src/assets/agents/AGENTS.md: remove AutoGen Constraint: All fixes verified against Zod schemas and CLI runtime Constraint: CLI --help text bugs left for separate agent Confidence: high Scope-risk: narrow * style: run prettier on documentation files * test: update asset snapshots for edited README.md and AGENTS.md * ci: trigger build workflow * docs: update docs for upstream schema refactor and naming unification - Remove `type` fields from agent, memory, evaluator, online-eval-config examples and field tables (removed in #709) - Remove `modelProvider` from agent spec (removed in #709) - Rename credential `type` to `authorizerType` (renamed in #709) - Rename `add identity` to `add credential` everywhere (#705) - Replace `--force` with `-y/--yes` on remove commands (#705) - Replace `--plan` with `--dry-run` on deploy command (#705) - Update snapshot for src/assets/README.md change * docs: fix stale agents reference in gateway example Update `"agents": [...]` to `"runtimes": [...]` in the gateway configuration example to match the schema rename in #706. * docs: rename --agent flags to --runtime and remove stale type fields Update all documentation to reflect upstream renames: - --agent → --runtime, -a → -r across all commands - --agent-arn → --runtime-arn, --agent-runtime-id → --runtime-id - Remove stale "type" fields from JSON examples in evals.md, memory.md, and container-builds.md Constraint: --agent-id, --agent-alias-id, --agent-client-id, --agent-client-secret are unchanged (different semantics) Constraint: --type agent filter value in status/fetch stays as-is Confidence: high Scope-risk: narrow * docs: add missing flags and fix --lines → --limit - Add -H, --header flag to dev and invoke commands - Add --bearer-token flag to invoke command - Fix --lines → --limit in evals.md logs evals section Confidence: high Scope-risk: narrow * docs: fix stale gateway flags and add missing CLI flags - Rename --agent-client-id → --client-id, --agent-client-secret → --client-secret in gateway docs (naming unification #705) - Add missing flags to add agent: --authorizer-type, --discovery-url, --allowed-audience, --allowed-clients, --allowed-scopes, --custom-claims, --client-id, --client-secret, --idle-timeout, --max-lifetime - Add missing flags to create: --idle-timeout, --max-lifetime - Add missing flags to add gateway: --runtimes, --custom-claims, --policy-engine, --policy-engine-mode - Fix --exception-level values: NONE/ALL (was undocumented) Confidence: high Scope-risk: narrow * docs: fix --exception-level valid values to NONE/DEBUG The CLI help text says ALL but the schema (GatewayExceptionLevelSchema) defines the valid values as NONE and DEBUG. Aligns commands.md with gateway.md and the Zod schema. * docs: fix stale fields and add flags from upstream v0.5–v0.7 - Remove stale "type": "AgentCoreMemory" from memory streaming example - Add memory streaming flags: --delivery-type, --data-stream-arn, --stream-content-level, --stream-delivery-resources - Add --exec to dev command flag table (Container agents) - Add --skip-install to create command flag table - Add --identity-name to fetch access flag table
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BREAKING CHANGE — Same naming unification as #702 but without backward-compatibility aliases.
add identity→add credential: Noidentityalias. Old command stops working.--forceremoved from remove: Only-y, --yesworks. No--forcealias.--planremoved from deploy: Only--dry-runworks. No--planalias.This is the clean-break alternative to #702 (which preserves aliases). Choose one to merge.
Changes from #702
The first 4 commits are cherry-picked from #702 (credential rename, --yes standardization, --dry-run standardization, article fix). The final commit removes all aliases:
.alias('identity')from credential command--forceoption fromBasePrimitive.registerRemoveSubcommand()andremove all--planoption fromdeploy--yesinstead of--forceTesting
npm test)tsc --noEmit)agentcore add --helpshows onlycredential(noidentityalias)agentcore deploy --helpshows only--dry-run(no--plan)agentcore remove agent --helpshows only-y, --yes(no--force)Test plan
npm test— all 3076 tests passtsc --noEmit— clean typecheck