refactor(schema): remove type fields from resource schemas and rename credential discriminator - #709

Merged
jesseturner21 merged 1 commit into
mainfrom
refactor/remove-type-fields-rename-credential-discriminator
Mar 27, 2026
Merged

refactor(schema): remove type fields from resource schemas and rename credential discriminator#709
jesseturner21 merged 1 commit into
mainfrom
refactor/remove-type-fields-rename-credential-discriminator

Conversation

@jesseturner21

@jesseturner21jesseturner21 commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

Description

Remove redundant type fields from all resource schemas and rename the credential discriminator from type to authorizerType.

Changes:

  • Remove type field from agent (AgentEnvSpecSchema), memory, evaluator, and online-eval-config schemas
  • Rename credential discriminated union key from type to authorizerType (values ApiKeyCredentialProvider and OAuthCredentialProvider unchanged)
  • Remove modelProvider from agent env schema (AgentEnvSpecSchema)
  • Update all consuming source files, primitives, operations, TUI components, and CLI commands
  • Regenerate agentcore.schema.v1.json
  • Update LLM-compacted schema documentation

Companion PR: aws/agentcore-l3-cdk-constructs (same branch name)

Related Issue

N/A — schema cleanup task

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Testing

TypeScript compilation: Both packages compile clean (tsc --noEmit passes)

Unit tests (CLI): 217/218 test files pass, 3112/3114 tests pass

  • 2 pre-existing PTY test failures (unrelated to this change)

Unit tests (CDK): 11/11 test files pass, 132/132 tests pass

JSON schema regeneration:node scripts/generate-schema.mjs succeeds, output committed

Specific test evidence:

  • Schema validation tests updated and passing for all resource types

  • Credential discriminated union tests verify authorizerType as discriminator

  • OnlineEvalConfigSchema tests pass without type field

  • AgentEnvSpecSchema tests pass without type and modelProvider

  • MemorySchema tests pass without type field

  • All credential operation tests (credential-ops, resolve-credential-strategy, pre-deploy-identity, fetch-gateway-token) pass with authorizerType

  • ResourceGraph component tests pass with updated credential rendering

  • Import/merge tests pass with updated schemas

  • Status command tests pass with authorizerType references

  • I ran npm run test:unit and npm run test:integ

  • I ran npm run typecheck

  • I ran npm run lint

  • If I modified src/assets/, I ran npm run test:update-snapshots and committed the updated snapshots

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.

@jesseturner21@claude
refactor(schema): remove type fields from resource schemas and rename…
52b1239
… credential discriminator
- Remove `type` field from agent, memory, evaluator, online-eval-config schemas
- Rename credential discriminator from `type` to `authorizerType`
- Remove `modelProvider` from agent env schema
- Update all source files, tests, and generated JSON schema
- Regenerate agentcore.schema.v1.json
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jesseturner21
jesseturner21 requested a review from a teamMarch 27, 2026 20:35
@github-actionsgithub-actionsBot added the size/m PR size: M label Mar 27, 2026
@github-actions

github-actionsBot commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

Package Tarball

aws-agentcore-0.3.0-preview.9.0.tgz

How to install

npm install https://github.com/aws/agentcore-cli/releases/download/pr-709-tarball/aws-agentcore-0.3.0-preview.9.0.tgz

@github-actions

github-actionsBot commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

StatusCategoryPercentageCovered / Total
🔵Lines46.06%6568 / 14258
🔵Statements45.63%6980 / 15296
🔵Functions44.8%1182 / 2638
🔵Branches46.15%4341 / 9405
Generated in workflow #1464 for commit 52b1239 by the Vitest Coverage Report Action

@jesseturner21

jesseturner21 commented Mar 27, 2026

Copy link
Copy Markdown
ContributorAuthor

E2E Test Evidence

Successfully tested end-to-end with the modified CLI and CDK packages:

1. Project creation

agentcore create --name TestRmType --framework Strands --defaults --skip-git --skip-python-setup

✅ Project created with no type fields in agentcore.json

2. Validation

agentcore validate

✅ Config validates successfully

3. Add credential (authorizerType flow)

agentcore add credential --name TestApiKey --type api-key --api-key fake-key-12345 --json

✅ Credential saved with authorizerType: "ApiKeyCredentialProvider" (not type)

4. Deploy

agentcore deploy --yes --json

✅ Deployed successfully to us-west-2:

  • Stack: AgentCore-TestRmType-default
  • Runtime ARN: arn:aws:bedrock-agentcore:us-west-2:325335451438:runtime/TestRmType_TestRmType-rthjn281qL

5. Invoke

agentcore invoke --agent TestRmType --prompt "Say hello" --json

✅ Agent responded: "Hello! 👋 How can I help you today?"

6. Status

agentcore status --json

✅ Agent shows deploymentState: "deployed", detail: "READY"

Unit test summary

  • CLI: 217/218 files pass, 3112/3114 tests pass (2 pre-existing PTY failures)
  • CDK: 11/11 files pass, 132/132 tests pass
  • TypeScript: Both packages compile clean

@jesseturner21jesseturner21 changed the title refactor(schema): remove type fields and rename credential discriminatorrefactor(schema): remove type fields from resource schemas and rename credential discriminatorMar 27, 2026
jesseturner21
jesseturner21 commented Mar 27, 2026
View reviewed changes
Comment threadschemas/agentcore.schema.v1.json
notgitika
notgitika approved these changes Mar 27, 2026
View reviewed changes

@notgitikanotgitika left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some redundant tests + dead code but we can fix those in a followup.
There is just a question around why the regex pattern was changed here and if this would break something otherwise LGTM

Comment threadschemas/agentcore.schema.v1.json
@jesseturner21
jesseturner21 merged commit 48dadfd into mainMar 27, 2026
22 of 25 checks passed
@jesseturner21
jesseturner21 deleted the refactor/remove-type-fields-rename-credential-discriminator branch March 27, 2026 21:55
aidandaly24 added a commit to aidandaly24/agentcore-cli that referenced this pull request Mar 27, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
17c34ed
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
@jesseturner21jesseturner21 mentioned this pull request Mar 27, 2026
Merged
15 tasks
aidandaly24 added a commit to aidandaly24/agentcore-cli that referenced this pull request Mar 27, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
bd319cf
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
aidandaly24 added a commit to aidandaly24/agentcore-cli that referenced this pull request Mar 27, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
abac34e
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
@aidandaly24aidandaly24 mentioned this pull request Mar 28, 2026
Merged
15 tasks
aidandaly24 added a commit to aidandaly24/agentcore-cli that referenced this pull request Mar 28, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
ff51ae2
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
aidandaly24 added a commit to aidandaly24/agentcore-cli that referenced this pull request Mar 28, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
c39f516
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
aidandaly24 added a commit to aidandaly24/agentcore-cli that referenced this pull request Mar 28, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
0c88152
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
aidandaly24 added a commit to aidandaly24/agentcore-cli that referenced this pull request Apr 8, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
89ac395
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
aidandaly24 added a commit that referenced this pull request Apr 9, 2026
@aidandaly24
docs: fix 30 documentation inaccuracies found by source code audit (#697
767fd4c
)
* docs: fix 30 documentation inaccuracies found by source code audit
- configuration.md: fix networkMode PRIVATE→VPC, remove stale mcp.json
section, add 7 missing AgentEnvSpec fields, add Node.js runtimes,
fix gateway name max 63→100, list all 6 targetType values, fix memory
strategies wording, fix deployed-state.json path, add missing project
fields, fix CUSTOM_JWT field requirements, add customClaims field
- README.md: add CrewAI framework, update all 4 default model IDs,
add missing command sections
- frameworks.md: add CrewAI with model providers, add protocol
compatibility matrix (HTTP/MCP/A2A)
- commands.md: fix agent name max 64→48 chars, add fetch access section,
add policy-engine/policy to status --type, remove ghost
--tool-filter-description flag, fix model ID date
- gateway.md: add enableSemanticSearch/exceptionLevel config options,
fix mcp.json→agentcore.json, remove api-key from MCP Server auth
- transaction_search.md: fix traces command syntax
- container-builds.md: remove nonexistent --progress flag
- evals.md: fix model date 20250929→20250514
- local-development.md: fix mcp.json→agentcore.json
- AGENTS.md: remove AutoGen, remove stale mcp.json reference
- src/assets/README.md: add CrewAI to template list
- src/assets/agents/AGENTS.md: remove AutoGen
Constraint: All fixes verified against Zod schemas and CLI runtime
Constraint: CLI --help text bugs left for separate agent
Confidence: high
Scope-risk: narrow
* style: run prettier on documentation files
* test: update asset snapshots for edited README.md and AGENTS.md
* ci: trigger build workflow
* docs: update docs for upstream schema refactor and naming unification
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in #709)
- Remove `modelProvider` from agent spec (removed in #709)
- Rename credential `type` to `authorizerType` (renamed in #709)
- Rename `add identity` to `add credential` everywhere (#705)
- Replace `--force` with `-y/--yes` on remove commands (#705)
- Replace `--plan` with `--dry-run` on deploy command (#705)
- Update snapshot for src/assets/README.md change
* docs: fix stale agents reference in gateway example
Update `"agents": [...]` to `"runtimes": [...]` in the gateway
configuration example to match the schema rename in #706.
* docs: rename --agent flags to --runtime and remove stale type fields
Update all documentation to reflect upstream renames:
- --agent → --runtime, -a → -r across all commands
- --agent-arn → --runtime-arn, --agent-runtime-id → --runtime-id
- Remove stale "type" fields from JSON examples in evals.md,
memory.md, and container-builds.md
Constraint: --agent-id, --agent-alias-id, --agent-client-id,
--agent-client-secret are unchanged (different semantics)
Constraint: --type agent filter value in status/fetch stays as-is
Confidence: high
Scope-risk: narrow
* docs: add missing flags and fix --lines → --limit
- Add -H, --header flag to dev and invoke commands
- Add --bearer-token flag to invoke command
- Fix --lines → --limit in evals.md logs evals section
Confidence: high
Scope-risk: narrow
* docs: fix stale gateway flags and add missing CLI flags
- Rename --agent-client-id → --client-id, --agent-client-secret →
--client-secret in gateway docs (naming unification #705)
- Add missing flags to add agent: --authorizer-type, --discovery-url,
--allowed-audience, --allowed-clients, --allowed-scopes,
--custom-claims, --client-id, --client-secret, --idle-timeout,
--max-lifetime
- Add missing flags to create: --idle-timeout, --max-lifetime
- Add missing flags to add gateway: --runtimes, --custom-claims,
--policy-engine, --policy-engine-mode
- Fix --exception-level values: NONE/ALL (was undocumented)
Confidence: high
Scope-risk: narrow
* docs: fix --exception-level valid values to NONE/DEBUG
The CLI help text says ALL but the schema (GatewayExceptionLevelSchema)
defines the valid values as NONE and DEBUG. Aligns commands.md with
gateway.md and the Zod schema.
* docs: fix stale fields and add flags from upstream v0.5–v0.7
- Remove stale "type": "AgentCoreMemory" from memory streaming example
- Add memory streaming flags: --delivery-type, --data-stream-arn,
--stream-content-level, --stream-delivery-resources
- Add --exec to dev command flag table (Container agents)
- Add --skip-install to create command flag table
- Add --identity-name to fetch access flag table
@aidandaly24aidandaly24 mentioned this pull request Jun 25, 2026
Draft
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@notgitikanotgitikanotgitika approved these changes

Assignees

No one assigned

Labels

size/mPR size: M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jesseturner21@notgitika
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
refactor(schema): remove type fields from resource schemas and rename credential discriminator - #709
Merged
jesseturner21 merged 1 commit into
mainfrom 
refactor/remove-type-fields-rename-credential-discriminator
Mar 27, 2026
Merged
refactor(schema): remove type fields from resource schemas and rename credential discriminator#709
jesseturner21 merged 1 commit into
mainfrom 
refactor/remove-type-fields-rename-credential-discriminator
Conversation
@jesseturner21
@jesseturner21jesseturner21
commented
Mar 27, 2026

Copy link


Copy Markdown

Contributor
Description
Remove redundant type fields from all resource schemas and rename the credential discriminator from type to authorizerType.
Changes:
  • Remove type field from agent (AgentEnvSpecSchema), memory, evaluator, and online-eval-config schemas
  • Rename credential discriminated union key from type to authorizerType (values ApiKeyCredentialProvider and OAuthCredentialProvider unchanged)
  • Remove modelProvider from agent env schema (AgentEnvSpecSchema)
  • Update all consuming source files, primitives, operations, TUI components, and CLI commands
  • Regenerate agentcore.schema.v1.json
  • Update LLM-compacted schema documentation
Companion PR: aws/agentcore-l3-cdk-constructs (same branch name)
Related Issue
N/A — schema cleanup task
Type of Change
  •  Bug fix
  •  New feature
  •  Breaking change
  •  Documentation update
  •  Other (please describe):
Testing
TypeScript compilation: Both packages compile clean (tsc --noEmit passes)
Unit tests (CLI): 217/218 test files pass, 3112/3114 tests pass
  • 2 pre-existing PTY test failures (unrelated to this change)
Unit tests (CDK): 11/11 test files pass, 132/132 tests pass
JSON schema regeneration:node scripts/generate-schema.mjs succeeds, output committed
Specific test evidence:
  • Schema validation tests updated and passing for all resource types
  • Credential discriminated union tests verify authorizerType as discriminator
  • OnlineEvalConfigSchema tests pass without type field
  • AgentEnvSpecSchema tests pass without type and modelProvider
  • MemorySchema tests pass without type field
  • All credential operation tests (credential-ops, resolve-credential-strategy, pre-deploy-identity, fetch-gateway-token) pass with authorizerType
  • ResourceGraph component tests pass with updated credential rendering
  • Import/merge tests pass with updated schemas
  • Status command tests pass with authorizerType references
  •  I ran npm run test:unit and npm run test:integ
  •  I ran npm run typecheck
  •  I ran npm run lint
  •  If I modified src/assets/, I ran npm run test:update-snapshots and committed the updated snapshots
Checklist
  •  I have read the CONTRIBUTING document
  •  I have added any necessary tests that prove my fix is effective or my feature works
  •  I have updated the documentation accordingly
  •  I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  •  My changes generate no new warnings
  •  Any dependent changes have been merged and published
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the

terms of your choice.
@jesseturner21@claude
refactor(schema): remove type fields from resource schemas and rename…
52b1239
… credential discriminator
- Remove `type` field from agent, memory, evaluator, online-eval-config schemas
- Rename credential discriminator from `type` to `authorizerType`
- Remove `modelProvider` from agent env schema
- Update all source files, tests, and generated JSON schema
- Regenerate agentcore.schema.v1.json
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jesseturner21
jesseturner21
requested a review
from a teamMarch 27, 2026 20:35
@github-actionsgithub-actionsBot
added
the 
size/m
PR size: M
label
Mar 27, 2026
@github-actions
github-actionsBot
commented
Mar 27, 2026

Copy link


Copy Markdown

Contributor
Package Tarball
aws-agentcore-0.3.0-preview.9.0.tgz
How to install
npm install https://github.com/aws/agentcore-cli/releases/download/pr-709-tarball/aws-agentcore-0.3.0-preview.9.0.tgz
@github-actions
github-actionsBot
commented
Mar 27, 2026

Copy link


Copy Markdown

Contributor
Coverage Report
StatusCategoryPercentageCovered / Total
🔵Lines46.06%6568 / 14258
🔵Statements45.63%6980 / 15296
🔵Functions44.8%1182 / 2638
🔵Branches46.15%4341 / 9405
Generated in workflow #1464 for commit 52b1239 by the Vitest Coverage Report Action
@jesseturner21
jesseturner21
commented
Mar 27, 2026

Copy link


Copy Markdown

ContributorAuthor
E2E Test Evidence
Successfully tested end-to-end with the modified CLI and CDK packages:
1. Project creation
agentcore create --name TestRmType --framework Strands --defaults --skip-git --skip-python-setup

✅ Project created with no type fields in agentcore.json
2. Validation
agentcore validate

✅ Config validates successfully
3. Add credential (authorizerType flow)
agentcore add credential --name TestApiKey --type api-key --api-key fake-key-12345 --json

✅ Credential saved with authorizerType: "ApiKeyCredentialProvider" (not type)
4. Deploy
agentcore deploy --yes --json

✅ Deployed successfully to us-west-2:
  • Stack: AgentCore-TestRmType-default
  • Runtime ARN: arn:aws:bedrock-agentcore:us-west-2:325335451438:runtime/TestRmType_TestRmType-rthjn281qL
5. Invoke
agentcore invoke --agent TestRmType --prompt "Say hello" --json

✅ Agent responded: "Hello! 👋 How can I help you today?"
6. Status
agentcore status --json

✅ Agent shows deploymentState: "deployed", detail: "READY"
Unit test summary
  • CLI: 217/218 files pass, 3112/3114 tests pass (2 pre-existing PTY failures)
  • CDK: 11/11 files pass, 132/132 tests pass
  • TypeScript: Both packages compile clean
@jesseturner21jesseturner21
changed the title
refactor(schema): remove type fields and rename credential discriminatorrefactor(schema): remove type fields from resource schemas and rename credential discriminatorMar 27, 2026
jesseturner21
jesseturner21
commented
Mar 27, 2026
View reviewed changes
Comment threadschemas/agentcore.schema.v1.json
notgitika
notgitika
approved these changes
Mar 27, 2026
View reviewed changes
@notgitikanotgitika
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some redundant tests + dead code but we can fix those in a followup.

There is just a question around why the regex pattern was changed here and if this would break something otherwise LGTM
Comment threadschemas/agentcore.schema.v1.json
@jesseturner21
jesseturner21
merged commit 48dadfd
into
mainMar 27, 2026

22 of 25 checks passed

@jesseturner21
jesseturner21
deleted the

refactor/remove-type-fields-rename-credential-discriminator

branch
March 27, 2026 21:55
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 27, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
17c34ed
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
@jesseturner21jesseturner21
mentioned this pull request
Mar 27, 2026
 Merged

15 tasks
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 27, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
bd319cf
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 27, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
abac34e
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
@aidandaly24aidandaly24
mentioned this pull request
Mar 28, 2026
 Merged

15 tasks
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 28, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
ff51ae2
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 28, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
c39f516
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 28, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
0c88152
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Apr 8, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
89ac395
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
aidandaly24 added a commit
that referenced
this pull request
Apr 9, 2026
@aidandaly24
docs: fix 30 documentation inaccuracies found by source code audit (#697
767fd4c
)
* docs: fix 30 documentation inaccuracies found by source code audit
- configuration.md: fix networkMode PRIVATE→VPC, remove stale mcp.json
section, add 7 missing AgentEnvSpec fields, add Node.js runtimes,
fix gateway name max 63→100, list all 6 targetType values, fix memory
strategies wording, fix deployed-state.json path, add missing project
fields, fix CUSTOM_JWT field requirements, add customClaims field
- README.md: add CrewAI framework, update all 4 default model IDs,
add missing command sections
- frameworks.md: add CrewAI with model providers, add protocol
compatibility matrix (HTTP/MCP/A2A)
- commands.md: fix agent name max 64→48 chars, add fetch access section,
add policy-engine/policy to status --type, remove ghost
--tool-filter-description flag, fix model ID date
- gateway.md: add enableSemanticSearch/exceptionLevel config options,
fix mcp.json→agentcore.json, remove api-key from MCP Server auth
- transaction_search.md: fix traces command syntax
- container-builds.md: remove nonexistent --progress flag
- evals.md: fix model date 20250929→20250514
- local-development.md: fix mcp.json→agentcore.json
- AGENTS.md: remove AutoGen, remove stale mcp.json reference
- src/assets/README.md: add CrewAI to template list
- src/assets/agents/AGENTS.md: remove AutoGen
Constraint: All fixes verified against Zod schemas and CLI runtime
Constraint: CLI --help text bugs left for separate agent
Confidence: high
Scope-risk: narrow
* style: run prettier on documentation files
* test: update asset snapshots for edited README.md and AGENTS.md
* ci: trigger build workflow
* docs: update docs for upstream schema refactor and naming unification
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in #709)
- Remove `modelProvider` from agent spec (removed in #709)
- Rename credential `type` to `authorizerType` (renamed in #709)
- Rename `add identity` to `add credential` everywhere (#705)
- Replace `--force` with `-y/--yes` on remove commands (#705)
- Replace `--plan` with `--dry-run` on deploy command (#705)
- Update snapshot for src/assets/README.md change
* docs: fix stale agents reference in gateway example
Update `"agents": [...]` to `"runtimes": [...]` in the gateway
configuration example to match the schema rename in #706.
* docs: rename --agent flags to --runtime and remove stale type fields
Update all documentation to reflect upstream renames:
- --agent → --runtime, -a → -r across all commands
- --agent-arn → --runtime-arn, --agent-runtime-id → --runtime-id
- Remove stale "type" fields from JSON examples in evals.md,
memory.md, and container-builds.md
Constraint: --agent-id, --agent-alias-id, --agent-client-id,
--agent-client-secret are unchanged (different semantics)
Constraint: --type agent filter value in status/fetch stays as-is
Confidence: high
Scope-risk: narrow
* docs: add missing flags and fix --lines → --limit
- Add -H, --header flag to dev and invoke commands
- Add --bearer-token flag to invoke command
- Fix --lines → --limit in evals.md logs evals section
Confidence: high
Scope-risk: narrow
* docs: fix stale gateway flags and add missing CLI flags
- Rename --agent-client-id → --client-id, --agent-client-secret →
--client-secret in gateway docs (naming unification #705)
- Add missing flags to add agent: --authorizer-type, --discovery-url,
--allowed-audience, --allowed-clients, --allowed-scopes,
--custom-claims, --client-id, --client-secret, --idle-timeout,
--max-lifetime
- Add missing flags to create: --idle-timeout, --max-lifetime
- Add missing flags to add gateway: --runtimes, --custom-claims,
--policy-engine, --policy-engine-mode
- Fix --exception-level values: NONE/ALL (was undocumented)
Confidence: high
Scope-risk: narrow
* docs: fix --exception-level valid values to NONE/DEBUG
The CLI help text says ALL but the schema (GatewayExceptionLevelSchema)
defines the valid values as NONE and DEBUG. Aligns commands.md with
gateway.md and the Zod schema.
* docs: fix stale fields and add flags from upstream v0.5–v0.7
- Remove stale "type": "AgentCoreMemory" from memory streaming example
- Add memory streaming flags: --delivery-type, --data-stream-arn,
--stream-content-level, --stream-delivery-resources
- Add --exec to dev command flag table (Container agents)
- Add --skip-install to create command flag table
- Add --identity-name to fetch access flag table
@aidandaly24aidandaly24
mentioned this pull request
Jun 25, 2026
 Draft

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@notgitikanotgitikanotgitika approved these changes

Assignees


No one assigned


Labels

size/mPR size: M

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@jesseturner21@notgitika

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
refactor(schema): remove type fields from resource schemas and rename credential discriminator - #709
Merged
jesseturner21 merged 1 commit into
mainfrom 
refactor/remove-type-fields-rename-credential-discriminator
Mar 27, 2026
Merged
refactor(schema): remove type fields from resource schemas and rename credential discriminator#709
jesseturner21 merged 1 commit into
mainfrom 
refactor/remove-type-fields-rename-credential-discriminator
Conversation
@jesseturner21
@jesseturner21jesseturner21
commented
Mar 27, 2026

Copy link


Copy Markdown

Contributor
Description
Remove redundant type fields from all resource schemas and rename the credential discriminator from type to authorizerType.
Changes:
  • Remove type field from agent (AgentEnvSpecSchema), memory, evaluator, and online-eval-config schemas
  • Rename credential discriminated union key from type to authorizerType (values ApiKeyCredentialProvider and OAuthCredentialProvider unchanged)
  • Remove modelProvider from agent env schema (AgentEnvSpecSchema)
  • Update all consuming source files, primitives, operations, TUI components, and CLI commands
  • Regenerate agentcore.schema.v1.json
  • Update LLM-compacted schema documentation
Companion PR: aws/agentcore-l3-cdk-constructs (same branch name)
Related Issue
N/A — schema cleanup task
Type of Change
  •  Bug fix
  •  New feature
  •  Breaking change
  •  Documentation update
  •  Other (please describe):
Testing
TypeScript compilation: Both packages compile clean (tsc --noEmit passes)
Unit tests (CLI): 217/218 test files pass, 3112/3114 tests pass
  • 2 pre-existing PTY test failures (unrelated to this change)
Unit tests (CDK): 11/11 test files pass, 132/132 tests pass
JSON schema regeneration:node scripts/generate-schema.mjs succeeds, output committed
Specific test evidence:
  • Schema validation tests updated and passing for all resource types
  • Credential discriminated union tests verify authorizerType as discriminator
  • OnlineEvalConfigSchema tests pass without type field
  • AgentEnvSpecSchema tests pass without type and modelProvider
  • MemorySchema tests pass without type field
  • All credential operation tests (credential-ops, resolve-credential-strategy, pre-deploy-identity, fetch-gateway-token) pass with authorizerType
  • ResourceGraph component tests pass with updated credential rendering
  • Import/merge tests pass with updated schemas
  • Status command tests pass with authorizerType references
  •  I ran npm run test:unit and npm run test:integ
  •  I ran npm run typecheck
  •  I ran npm run lint
  •  If I modified src/assets/, I ran npm run test:update-snapshots and committed the updated snapshots
Checklist
  •  I have read the CONTRIBUTING document
  •  I have added any necessary tests that prove my fix is effective or my feature works
  •  I have updated the documentation accordingly
  •  I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  •  My changes generate no new warnings
  •  Any dependent changes have been merged and published
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the

terms of your choice.
@jesseturner21@claude
refactor(schema): remove type fields from resource schemas and rename…
52b1239
… credential discriminator
- Remove `type` field from agent, memory, evaluator, online-eval-config schemas
- Rename credential discriminator from `type` to `authorizerType`
- Remove `modelProvider` from agent env schema
- Update all source files, tests, and generated JSON schema
- Regenerate agentcore.schema.v1.json
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jesseturner21
jesseturner21
requested a review
from a teamMarch 27, 2026 20:35
@github-actionsgithub-actionsBot
added
the 
size/m
PR size: M
label
Mar 27, 2026
@github-actions
github-actionsBot
commented
Mar 27, 2026

Copy link


Copy Markdown

Contributor
Package Tarball
aws-agentcore-0.3.0-preview.9.0.tgz
How to install
npm install https://github.com/aws/agentcore-cli/releases/download/pr-709-tarball/aws-agentcore-0.3.0-preview.9.0.tgz
@github-actions
github-actionsBot
commented
Mar 27, 2026

Copy link


Copy Markdown

Contributor
Coverage Report
StatusCategoryPercentageCovered / Total
🔵Lines46.06%6568 / 14258
🔵Statements45.63%6980 / 15296
🔵Functions44.8%1182 / 2638
🔵Branches46.15%4341 / 9405
Generated in workflow #1464 for commit 52b1239 by the Vitest Coverage Report Action
@jesseturner21
jesseturner21
commented
Mar 27, 2026

Copy link


Copy Markdown

ContributorAuthor
E2E Test Evidence
Successfully tested end-to-end with the modified CLI and CDK packages:
1. Project creation
agentcore create --name TestRmType --framework Strands --defaults --skip-git --skip-python-setup

✅ Project created with no type fields in agentcore.json
2. Validation
agentcore validate

✅ Config validates successfully
3. Add credential (authorizerType flow)
agentcore add credential --name TestApiKey --type api-key --api-key fake-key-12345 --json

✅ Credential saved with authorizerType: "ApiKeyCredentialProvider" (not type)
4. Deploy
agentcore deploy --yes --json

✅ Deployed successfully to us-west-2:
  • Stack: AgentCore-TestRmType-default
  • Runtime ARN: arn:aws:bedrock-agentcore:us-west-2:325335451438:runtime/TestRmType_TestRmType-rthjn281qL
5. Invoke
agentcore invoke --agent TestRmType --prompt "Say hello" --json

✅ Agent responded: "Hello! 👋 How can I help you today?"
6. Status
agentcore status --json

✅ Agent shows deploymentState: "deployed", detail: "READY"
Unit test summary
  • CLI: 217/218 files pass, 3112/3114 tests pass (2 pre-existing PTY failures)
  • CDK: 11/11 files pass, 132/132 tests pass
  • TypeScript: Both packages compile clean
@jesseturner21jesseturner21
changed the title
refactor(schema): remove type fields and rename credential discriminatorrefactor(schema): remove type fields from resource schemas and rename credential discriminatorMar 27, 2026
jesseturner21
jesseturner21
commented
Mar 27, 2026
View reviewed changes
Comment threadschemas/agentcore.schema.v1.json
notgitika
notgitika
approved these changes
Mar 27, 2026
View reviewed changes
@notgitikanotgitika
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some redundant tests + dead code but we can fix those in a followup.

There is just a question around why the regex pattern was changed here and if this would break something otherwise LGTM
Comment threadschemas/agentcore.schema.v1.json
@jesseturner21
jesseturner21
merged commit 48dadfd
into
mainMar 27, 2026

22 of 25 checks passed

@jesseturner21
jesseturner21
deleted the

refactor/remove-type-fields-rename-credential-discriminator

branch
March 27, 2026 21:55
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 27, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
17c34ed
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
@jesseturner21jesseturner21
mentioned this pull request
Mar 27, 2026
 Merged

15 tasks
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 27, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
bd319cf
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 27, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
abac34e
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
@aidandaly24aidandaly24
mentioned this pull request
Mar 28, 2026
 Merged

15 tasks
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 28, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
ff51ae2
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 28, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
c39f516
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 28, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
0c88152
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Apr 8, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
89ac395
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
aidandaly24 added a commit
that referenced
this pull request
Apr 9, 2026
@aidandaly24
docs: fix 30 documentation inaccuracies found by source code audit (#697
767fd4c
)
* docs: fix 30 documentation inaccuracies found by source code audit
- configuration.md: fix networkMode PRIVATE→VPC, remove stale mcp.json
section, add 7 missing AgentEnvSpec fields, add Node.js runtimes,
fix gateway name max 63→100, list all 6 targetType values, fix memory
strategies wording, fix deployed-state.json path, add missing project
fields, fix CUSTOM_JWT field requirements, add customClaims field
- README.md: add CrewAI framework, update all 4 default model IDs,
add missing command sections
- frameworks.md: add CrewAI with model providers, add protocol
compatibility matrix (HTTP/MCP/A2A)
- commands.md: fix agent name max 64→48 chars, add fetch access section,
add policy-engine/policy to status --type, remove ghost
--tool-filter-description flag, fix model ID date
- gateway.md: add enableSemanticSearch/exceptionLevel config options,
fix mcp.json→agentcore.json, remove api-key from MCP Server auth
- transaction_search.md: fix traces command syntax
- container-builds.md: remove nonexistent --progress flag
- evals.md: fix model date 20250929→20250514
- local-development.md: fix mcp.json→agentcore.json
- AGENTS.md: remove AutoGen, remove stale mcp.json reference
- src/assets/README.md: add CrewAI to template list
- src/assets/agents/AGENTS.md: remove AutoGen
Constraint: All fixes verified against Zod schemas and CLI runtime
Constraint: CLI --help text bugs left for separate agent
Confidence: high
Scope-risk: narrow
* style: run prettier on documentation files
* test: update asset snapshots for edited README.md and AGENTS.md
* ci: trigger build workflow
* docs: update docs for upstream schema refactor and naming unification
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in #709)
- Remove `modelProvider` from agent spec (removed in #709)
- Rename credential `type` to `authorizerType` (renamed in #709)
- Rename `add identity` to `add credential` everywhere (#705)
- Replace `--force` with `-y/--yes` on remove commands (#705)
- Replace `--plan` with `--dry-run` on deploy command (#705)
- Update snapshot for src/assets/README.md change
* docs: fix stale agents reference in gateway example
Update `"agents": [...]` to `"runtimes": [...]` in the gateway
configuration example to match the schema rename in #706.
* docs: rename --agent flags to --runtime and remove stale type fields
Update all documentation to reflect upstream renames:
- --agent → --runtime, -a → -r across all commands
- --agent-arn → --runtime-arn, --agent-runtime-id → --runtime-id
- Remove stale "type" fields from JSON examples in evals.md,
memory.md, and container-builds.md
Constraint: --agent-id, --agent-alias-id, --agent-client-id,
--agent-client-secret are unchanged (different semantics)
Constraint: --type agent filter value in status/fetch stays as-is
Confidence: high
Scope-risk: narrow
* docs: add missing flags and fix --lines → --limit
- Add -H, --header flag to dev and invoke commands
- Add --bearer-token flag to invoke command
- Fix --lines → --limit in evals.md logs evals section
Confidence: high
Scope-risk: narrow
* docs: fix stale gateway flags and add missing CLI flags
- Rename --agent-client-id → --client-id, --agent-client-secret →
--client-secret in gateway docs (naming unification #705)
- Add missing flags to add agent: --authorizer-type, --discovery-url,
--allowed-audience, --allowed-clients, --allowed-scopes,
--custom-claims, --client-id, --client-secret, --idle-timeout,
--max-lifetime
- Add missing flags to create: --idle-timeout, --max-lifetime
- Add missing flags to add gateway: --runtimes, --custom-claims,
--policy-engine, --policy-engine-mode
- Fix --exception-level values: NONE/ALL (was undocumented)
Confidence: high
Scope-risk: narrow
* docs: fix --exception-level valid values to NONE/DEBUG
The CLI help text says ALL but the schema (GatewayExceptionLevelSchema)
defines the valid values as NONE and DEBUG. Aligns commands.md with
gateway.md and the Zod schema.
* docs: fix stale fields and add flags from upstream v0.5–v0.7
- Remove stale "type": "AgentCoreMemory" from memory streaming example
- Add memory streaming flags: --delivery-type, --data-stream-arn,
--stream-content-level, --stream-delivery-resources
- Add --exec to dev command flag table (Container agents)
- Add --skip-install to create command flag table
- Add --identity-name to fetch access flag table
@aidandaly24aidandaly24
mentioned this pull request
Jun 25, 2026
 Draft

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@notgitikanotgitikanotgitika approved these changes

Assignees


No one assigned


Labels

size/mPR size: M

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@jesseturner21@notgitika

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
refactor(schema): remove type fields from resource schemas and rename credential discriminator - #709
Merged
jesseturner21 merged 1 commit into
mainfrom 
refactor/remove-type-fields-rename-credential-discriminator
Mar 27, 2026
Merged
refactor(schema): remove type fields from resource schemas and rename credential discriminator#709
jesseturner21 merged 1 commit into
mainfrom 
refactor/remove-type-fields-rename-credential-discriminator
Conversation
@jesseturner21
@jesseturner21jesseturner21
commented
Mar 27, 2026

Copy link


Copy Markdown

Contributor
Description
Remove redundant type fields from all resource schemas and rename the credential discriminator from type to authorizerType.
Changes:
  • Remove type field from agent (AgentEnvSpecSchema), memory, evaluator, and online-eval-config schemas
  • Rename credential discriminated union key from type to authorizerType (values ApiKeyCredentialProvider and OAuthCredentialProvider unchanged)
  • Remove modelProvider from agent env schema (AgentEnvSpecSchema)
  • Update all consuming source files, primitives, operations, TUI components, and CLI commands
  • Regenerate agentcore.schema.v1.json
  • Update LLM-compacted schema documentation
Companion PR: aws/agentcore-l3-cdk-constructs (same branch name)
Related Issue
N/A — schema cleanup task
Type of Change
  •  Bug fix
  •  New feature
  •  Breaking change
  •  Documentation update
  •  Other (please describe):
Testing
TypeScript compilation: Both packages compile clean (tsc --noEmit passes)
Unit tests (CLI): 217/218 test files pass, 3112/3114 tests pass
  • 2 pre-existing PTY test failures (unrelated to this change)
Unit tests (CDK): 11/11 test files pass, 132/132 tests pass
JSON schema regeneration:node scripts/generate-schema.mjs succeeds, output committed
Specific test evidence:
  • Schema validation tests updated and passing for all resource types
  • Credential discriminated union tests verify authorizerType as discriminator
  • OnlineEvalConfigSchema tests pass without type field
  • AgentEnvSpecSchema tests pass without type and modelProvider
  • MemorySchema tests pass without type field
  • All credential operation tests (credential-ops, resolve-credential-strategy, pre-deploy-identity, fetch-gateway-token) pass with authorizerType
  • ResourceGraph component tests pass with updated credential rendering
  • Import/merge tests pass with updated schemas
  • Status command tests pass with authorizerType references
  •  I ran npm run test:unit and npm run test:integ
  •  I ran npm run typecheck
  •  I ran npm run lint
  •  If I modified src/assets/, I ran npm run test:update-snapshots and committed the updated snapshots
Checklist
  •  I have read the CONTRIBUTING document
  •  I have added any necessary tests that prove my fix is effective or my feature works
  •  I have updated the documentation accordingly
  •  I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  •  My changes generate no new warnings
  •  Any dependent changes have been merged and published
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the

terms of your choice.
@jesseturner21@claude
refactor(schema): remove type fields from resource schemas and rename…
52b1239
… credential discriminator
- Remove `type` field from agent, memory, evaluator, online-eval-config schemas
- Rename credential discriminator from `type` to `authorizerType`
- Remove `modelProvider` from agent env schema
- Update all source files, tests, and generated JSON schema
- Regenerate agentcore.schema.v1.json
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jesseturner21
jesseturner21
requested a review
from a teamMarch 27, 2026 20:35
@github-actionsgithub-actionsBot
added
the 
size/m
PR size: M
label
Mar 27, 2026
@github-actions
github-actionsBot
commented
Mar 27, 2026

Copy link


Copy Markdown

Contributor
Package Tarball
aws-agentcore-0.3.0-preview.9.0.tgz
How to install
npm install https://github.com/aws/agentcore-cli/releases/download/pr-709-tarball/aws-agentcore-0.3.0-preview.9.0.tgz
@github-actions
github-actionsBot
commented
Mar 27, 2026

Copy link


Copy Markdown

Contributor
Coverage Report
StatusCategoryPercentageCovered / Total
🔵Lines46.06%6568 / 14258
🔵Statements45.63%6980 / 15296
🔵Functions44.8%1182 / 2638
🔵Branches46.15%4341 / 9405
Generated in workflow #1464 for commit 52b1239 by the Vitest Coverage Report Action
@jesseturner21
jesseturner21
commented
Mar 27, 2026

Copy link


Copy Markdown

ContributorAuthor
E2E Test Evidence
Successfully tested end-to-end with the modified CLI and CDK packages:
1. Project creation
agentcore create --name TestRmType --framework Strands --defaults --skip-git --skip-python-setup

✅ Project created with no type fields in agentcore.json
2. Validation
agentcore validate

✅ Config validates successfully
3. Add credential (authorizerType flow)
agentcore add credential --name TestApiKey --type api-key --api-key fake-key-12345 --json

✅ Credential saved with authorizerType: "ApiKeyCredentialProvider" (not type)
4. Deploy
agentcore deploy --yes --json

✅ Deployed successfully to us-west-2:
  • Stack: AgentCore-TestRmType-default
  • Runtime ARN: arn:aws:bedrock-agentcore:us-west-2:325335451438:runtime/TestRmType_TestRmType-rthjn281qL
5. Invoke
agentcore invoke --agent TestRmType --prompt "Say hello" --json

✅ Agent responded: "Hello! 👋 How can I help you today?"
6. Status
agentcore status --json

✅ Agent shows deploymentState: "deployed", detail: "READY"
Unit test summary
  • CLI: 217/218 files pass, 3112/3114 tests pass (2 pre-existing PTY failures)
  • CDK: 11/11 files pass, 132/132 tests pass
  • TypeScript: Both packages compile clean
@jesseturner21jesseturner21
changed the title
refactor(schema): remove type fields and rename credential discriminatorrefactor(schema): remove type fields from resource schemas and rename credential discriminatorMar 27, 2026
jesseturner21
jesseturner21
commented
Mar 27, 2026
View reviewed changes
Comment threadschemas/agentcore.schema.v1.json
notgitika
notgitika
approved these changes
Mar 27, 2026
View reviewed changes
@notgitikanotgitika
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some redundant tests + dead code but we can fix those in a followup.

There is just a question around why the regex pattern was changed here and if this would break something otherwise LGTM
Comment threadschemas/agentcore.schema.v1.json
@jesseturner21
jesseturner21
merged commit 48dadfd
into
mainMar 27, 2026

22 of 25 checks passed

@jesseturner21
jesseturner21
deleted the

refactor/remove-type-fields-rename-credential-discriminator

branch
March 27, 2026 21:55
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 27, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
17c34ed
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
@jesseturner21jesseturner21
mentioned this pull request
Mar 27, 2026
 Merged

15 tasks
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 27, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
bd319cf
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 27, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
abac34e
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
@aidandaly24aidandaly24
mentioned this pull request
Mar 28, 2026
 Merged

15 tasks
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 28, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
ff51ae2
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 28, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
c39f516
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 28, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
0c88152
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Apr 8, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
89ac395
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
aidandaly24 added a commit
that referenced
this pull request
Apr 9, 2026
@aidandaly24
docs: fix 30 documentation inaccuracies found by source code audit (#697
767fd4c
)
* docs: fix 30 documentation inaccuracies found by source code audit
- configuration.md: fix networkMode PRIVATE→VPC, remove stale mcp.json
section, add 7 missing AgentEnvSpec fields, add Node.js runtimes,
fix gateway name max 63→100, list all 6 targetType values, fix memory
strategies wording, fix deployed-state.json path, add missing project
fields, fix CUSTOM_JWT field requirements, add customClaims field
- README.md: add CrewAI framework, update all 4 default model IDs,
add missing command sections
- frameworks.md: add CrewAI with model providers, add protocol
compatibility matrix (HTTP/MCP/A2A)
- commands.md: fix agent name max 64→48 chars, add fetch access section,
add policy-engine/policy to status --type, remove ghost
--tool-filter-description flag, fix model ID date
- gateway.md: add enableSemanticSearch/exceptionLevel config options,
fix mcp.json→agentcore.json, remove api-key from MCP Server auth
- transaction_search.md: fix traces command syntax
- container-builds.md: remove nonexistent --progress flag
- evals.md: fix model date 20250929→20250514
- local-development.md: fix mcp.json→agentcore.json
- AGENTS.md: remove AutoGen, remove stale mcp.json reference
- src/assets/README.md: add CrewAI to template list
- src/assets/agents/AGENTS.md: remove AutoGen
Constraint: All fixes verified against Zod schemas and CLI runtime
Constraint: CLI --help text bugs left for separate agent
Confidence: high
Scope-risk: narrow
* style: run prettier on documentation files
* test: update asset snapshots for edited README.md and AGENTS.md
* ci: trigger build workflow
* docs: update docs for upstream schema refactor and naming unification
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in #709)
- Remove `modelProvider` from agent spec (removed in #709)
- Rename credential `type` to `authorizerType` (renamed in #709)
- Rename `add identity` to `add credential` everywhere (#705)
- Replace `--force` with `-y/--yes` on remove commands (#705)
- Replace `--plan` with `--dry-run` on deploy command (#705)
- Update snapshot for src/assets/README.md change
* docs: fix stale agents reference in gateway example
Update `"agents": [...]` to `"runtimes": [...]` in the gateway
configuration example to match the schema rename in #706.
* docs: rename --agent flags to --runtime and remove stale type fields
Update all documentation to reflect upstream renames:
- --agent → --runtime, -a → -r across all commands
- --agent-arn → --runtime-arn, --agent-runtime-id → --runtime-id
- Remove stale "type" fields from JSON examples in evals.md,
memory.md, and container-builds.md
Constraint: --agent-id, --agent-alias-id, --agent-client-id,
--agent-client-secret are unchanged (different semantics)
Constraint: --type agent filter value in status/fetch stays as-is
Confidence: high
Scope-risk: narrow
* docs: add missing flags and fix --lines → --limit
- Add -H, --header flag to dev and invoke commands
- Add --bearer-token flag to invoke command
- Fix --lines → --limit in evals.md logs evals section
Confidence: high
Scope-risk: narrow
* docs: fix stale gateway flags and add missing CLI flags
- Rename --agent-client-id → --client-id, --agent-client-secret →
--client-secret in gateway docs (naming unification #705)
- Add missing flags to add agent: --authorizer-type, --discovery-url,
--allowed-audience, --allowed-clients, --allowed-scopes,
--custom-claims, --client-id, --client-secret, --idle-timeout,
--max-lifetime
- Add missing flags to create: --idle-timeout, --max-lifetime
- Add missing flags to add gateway: --runtimes, --custom-claims,
--policy-engine, --policy-engine-mode
- Fix --exception-level values: NONE/ALL (was undocumented)
Confidence: high
Scope-risk: narrow
* docs: fix --exception-level valid values to NONE/DEBUG
The CLI help text says ALL but the schema (GatewayExceptionLevelSchema)
defines the valid values as NONE and DEBUG. Aligns commands.md with
gateway.md and the Zod schema.
* docs: fix stale fields and add flags from upstream v0.5–v0.7
- Remove stale "type": "AgentCoreMemory" from memory streaming example
- Add memory streaming flags: --delivery-type, --data-stream-arn,
--stream-content-level, --stream-delivery-resources
- Add --exec to dev command flag table (Container agents)
- Add --skip-install to create command flag table
- Add --identity-name to fetch access flag table
@aidandaly24aidandaly24
mentioned this pull request
Jun 25, 2026
 Draft

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@notgitikanotgitikanotgitika approved these changes

Assignees


No one assigned


Labels

size/mPR size: M

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@jesseturner21@notgitika

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
refactor(schema): remove type fields from resource schemas and rename credential discriminator - #709
Merged
jesseturner21 merged 1 commit into
mainfrom 
refactor/remove-type-fields-rename-credential-discriminator
Mar 27, 2026
Merged
refactor(schema): remove type fields from resource schemas and rename credential discriminator#709
jesseturner21 merged 1 commit into
mainfrom 
refactor/remove-type-fields-rename-credential-discriminator
Conversation
@jesseturner21
@jesseturner21jesseturner21
commented
Mar 27, 2026

Copy link


Copy Markdown

Contributor
Description
Remove redundant type fields from all resource schemas and rename the credential discriminator from type to authorizerType.
Changes:
  • Remove type field from agent (AgentEnvSpecSchema), memory, evaluator, and online-eval-config schemas
  • Rename credential discriminated union key from type to authorizerType (values ApiKeyCredentialProvider and OAuthCredentialProvider unchanged)
  • Remove modelProvider from agent env schema (AgentEnvSpecSchema)
  • Update all consuming source files, primitives, operations, TUI components, and CLI commands
  • Regenerate agentcore.schema.v1.json
  • Update LLM-compacted schema documentation
Companion PR: aws/agentcore-l3-cdk-constructs (same branch name)
Related Issue
N/A — schema cleanup task
Type of Change
  •  Bug fix
  •  New feature
  •  Breaking change
  •  Documentation update
  •  Other (please describe):
Testing
TypeScript compilation: Both packages compile clean (tsc --noEmit passes)
Unit tests (CLI): 217/218 test files pass, 3112/3114 tests pass
  • 2 pre-existing PTY test failures (unrelated to this change)
Unit tests (CDK): 11/11 test files pass, 132/132 tests pass
JSON schema regeneration:node scripts/generate-schema.mjs succeeds, output committed
Specific test evidence:
  • Schema validation tests updated and passing for all resource types
  • Credential discriminated union tests verify authorizerType as discriminator
  • OnlineEvalConfigSchema tests pass without type field
  • AgentEnvSpecSchema tests pass without type and modelProvider
  • MemorySchema tests pass without type field
  • All credential operation tests (credential-ops, resolve-credential-strategy, pre-deploy-identity, fetch-gateway-token) pass with authorizerType
  • ResourceGraph component tests pass with updated credential rendering
  • Import/merge tests pass with updated schemas
  • Status command tests pass with authorizerType references
  •  I ran npm run test:unit and npm run test:integ
  •  I ran npm run typecheck
  •  I ran npm run lint
  •  If I modified src/assets/, I ran npm run test:update-snapshots and committed the updated snapshots
Checklist
  •  I have read the CONTRIBUTING document
  •  I have added any necessary tests that prove my fix is effective or my feature works
  •  I have updated the documentation accordingly
  •  I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  •  My changes generate no new warnings
  •  Any dependent changes have been merged and published
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the

terms of your choice.
@jesseturner21@claude
refactor(schema): remove type fields from resource schemas and rename…
52b1239
… credential discriminator
- Remove `type` field from agent, memory, evaluator, online-eval-config schemas
- Rename credential discriminator from `type` to `authorizerType`
- Remove `modelProvider` from agent env schema
- Update all source files, tests, and generated JSON schema
- Regenerate agentcore.schema.v1.json
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jesseturner21
jesseturner21
requested a review
from a teamMarch 27, 2026 20:35
@github-actionsgithub-actionsBot
added
the 
size/m
PR size: M
label
Mar 27, 2026
@github-actions
github-actionsBot
commented
Mar 27, 2026

Copy link


Copy Markdown

Contributor
Package Tarball
aws-agentcore-0.3.0-preview.9.0.tgz
How to install
npm install https://github.com/aws/agentcore-cli/releases/download/pr-709-tarball/aws-agentcore-0.3.0-preview.9.0.tgz
@github-actions
github-actionsBot
commented
Mar 27, 2026

Copy link


Copy Markdown

Contributor
Coverage Report
StatusCategoryPercentageCovered / Total
🔵Lines46.06%6568 / 14258
🔵Statements45.63%6980 / 15296
🔵Functions44.8%1182 / 2638
🔵Branches46.15%4341 / 9405
Generated in workflow #1464 for commit 52b1239 by the Vitest Coverage Report Action
@jesseturner21
jesseturner21
commented
Mar 27, 2026

Copy link


Copy Markdown

ContributorAuthor
E2E Test Evidence
Successfully tested end-to-end with the modified CLI and CDK packages:
1. Project creation
agentcore create --name TestRmType --framework Strands --defaults --skip-git --skip-python-setup

✅ Project created with no type fields in agentcore.json
2. Validation
agentcore validate

✅ Config validates successfully
3. Add credential (authorizerType flow)
agentcore add credential --name TestApiKey --type api-key --api-key fake-key-12345 --json

✅ Credential saved with authorizerType: "ApiKeyCredentialProvider" (not type)
4. Deploy
agentcore deploy --yes --json

✅ Deployed successfully to us-west-2:
  • Stack: AgentCore-TestRmType-default
  • Runtime ARN: arn:aws:bedrock-agentcore:us-west-2:325335451438:runtime/TestRmType_TestRmType-rthjn281qL
5. Invoke
agentcore invoke --agent TestRmType --prompt "Say hello" --json

✅ Agent responded: "Hello! 👋 How can I help you today?"
6. Status
agentcore status --json

✅ Agent shows deploymentState: "deployed", detail: "READY"
Unit test summary
  • CLI: 217/218 files pass, 3112/3114 tests pass (2 pre-existing PTY failures)
  • CDK: 11/11 files pass, 132/132 tests pass
  • TypeScript: Both packages compile clean
@jesseturner21jesseturner21
changed the title
refactor(schema): remove type fields and rename credential discriminatorrefactor(schema): remove type fields from resource schemas and rename credential discriminatorMar 27, 2026
jesseturner21
jesseturner21
commented
Mar 27, 2026
View reviewed changes
Comment threadschemas/agentcore.schema.v1.json
notgitika
notgitika
approved these changes
Mar 27, 2026
View reviewed changes
@notgitikanotgitika
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some redundant tests + dead code but we can fix those in a followup.

There is just a question around why the regex pattern was changed here and if this would break something otherwise LGTM
Comment threadschemas/agentcore.schema.v1.json
@jesseturner21
jesseturner21
merged commit 48dadfd
into
mainMar 27, 2026

22 of 25 checks passed

@jesseturner21
jesseturner21
deleted the

refactor/remove-type-fields-rename-credential-discriminator

branch
March 27, 2026 21:55
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 27, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
17c34ed
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
@jesseturner21jesseturner21
mentioned this pull request
Mar 27, 2026
 Merged

15 tasks
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 27, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
bd319cf
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 27, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
abac34e
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
@aidandaly24aidandaly24
mentioned this pull request
Mar 28, 2026
 Merged

15 tasks
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 28, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
ff51ae2
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 28, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
c39f516
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 28, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
0c88152
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Apr 8, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
89ac395
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
aidandaly24 added a commit
that referenced
this pull request
Apr 9, 2026
@aidandaly24
docs: fix 30 documentation inaccuracies found by source code audit (#697
767fd4c
)
* docs: fix 30 documentation inaccuracies found by source code audit
- configuration.md: fix networkMode PRIVATE→VPC, remove stale mcp.json
section, add 7 missing AgentEnvSpec fields, add Node.js runtimes,
fix gateway name max 63→100, list all 6 targetType values, fix memory
strategies wording, fix deployed-state.json path, add missing project
fields, fix CUSTOM_JWT field requirements, add customClaims field
- README.md: add CrewAI framework, update all 4 default model IDs,
add missing command sections
- frameworks.md: add CrewAI with model providers, add protocol
compatibility matrix (HTTP/MCP/A2A)
- commands.md: fix agent name max 64→48 chars, add fetch access section,
add policy-engine/policy to status --type, remove ghost
--tool-filter-description flag, fix model ID date
- gateway.md: add enableSemanticSearch/exceptionLevel config options,
fix mcp.json→agentcore.json, remove api-key from MCP Server auth
- transaction_search.md: fix traces command syntax
- container-builds.md: remove nonexistent --progress flag
- evals.md: fix model date 20250929→20250514
- local-development.md: fix mcp.json→agentcore.json
- AGENTS.md: remove AutoGen, remove stale mcp.json reference
- src/assets/README.md: add CrewAI to template list
- src/assets/agents/AGENTS.md: remove AutoGen
Constraint: All fixes verified against Zod schemas and CLI runtime
Constraint: CLI --help text bugs left for separate agent
Confidence: high
Scope-risk: narrow
* style: run prettier on documentation files
* test: update asset snapshots for edited README.md and AGENTS.md
* ci: trigger build workflow
* docs: update docs for upstream schema refactor and naming unification
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in #709)
- Remove `modelProvider` from agent spec (removed in #709)
- Rename credential `type` to `authorizerType` (renamed in #709)
- Rename `add identity` to `add credential` everywhere (#705)
- Replace `--force` with `-y/--yes` on remove commands (#705)
- Replace `--plan` with `--dry-run` on deploy command (#705)
- Update snapshot for src/assets/README.md change
* docs: fix stale agents reference in gateway example
Update `"agents": [...]` to `"runtimes": [...]` in the gateway
configuration example to match the schema rename in #706.
* docs: rename --agent flags to --runtime and remove stale type fields
Update all documentation to reflect upstream renames:
- --agent → --runtime, -a → -r across all commands
- --agent-arn → --runtime-arn, --agent-runtime-id → --runtime-id
- Remove stale "type" fields from JSON examples in evals.md,
memory.md, and container-builds.md
Constraint: --agent-id, --agent-alias-id, --agent-client-id,
--agent-client-secret are unchanged (different semantics)
Constraint: --type agent filter value in status/fetch stays as-is
Confidence: high
Scope-risk: narrow
* docs: add missing flags and fix --lines → --limit
- Add -H, --header flag to dev and invoke commands
- Add --bearer-token flag to invoke command
- Fix --lines → --limit in evals.md logs evals section
Confidence: high
Scope-risk: narrow
* docs: fix stale gateway flags and add missing CLI flags
- Rename --agent-client-id → --client-id, --agent-client-secret →
--client-secret in gateway docs (naming unification #705)
- Add missing flags to add agent: --authorizer-type, --discovery-url,
--allowed-audience, --allowed-clients, --allowed-scopes,
--custom-claims, --client-id, --client-secret, --idle-timeout,
--max-lifetime
- Add missing flags to create: --idle-timeout, --max-lifetime
- Add missing flags to add gateway: --runtimes, --custom-claims,
--policy-engine, --policy-engine-mode
- Fix --exception-level values: NONE/ALL (was undocumented)
Confidence: high
Scope-risk: narrow
* docs: fix --exception-level valid values to NONE/DEBUG
The CLI help text says ALL but the schema (GatewayExceptionLevelSchema)
defines the valid values as NONE and DEBUG. Aligns commands.md with
gateway.md and the Zod schema.
* docs: fix stale fields and add flags from upstream v0.5–v0.7
- Remove stale "type": "AgentCoreMemory" from memory streaming example
- Add memory streaming flags: --delivery-type, --data-stream-arn,
--stream-content-level, --stream-delivery-resources
- Add --exec to dev command flag table (Container agents)
- Add --skip-install to create command flag table
- Add --identity-name to fetch access flag table
@aidandaly24aidandaly24
mentioned this pull request
Jun 25, 2026
 Draft

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@notgitikanotgitikanotgitika approved these changes

Assignees


No one assigned


Labels

size/mPR size: M

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@jesseturner21@notgitika

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
refactor(schema): remove type fields from resource schemas and rename credential discriminator - #709
Merged
jesseturner21 merged 1 commit into
mainfrom 
refactor/remove-type-fields-rename-credential-discriminator
Mar 27, 2026
Merged
refactor(schema): remove type fields from resource schemas and rename credential discriminator#709
jesseturner21 merged 1 commit into
mainfrom 
refactor/remove-type-fields-rename-credential-discriminator
Conversation
@jesseturner21
@jesseturner21jesseturner21
commented
Mar 27, 2026

Copy link


Copy Markdown

Contributor
Description
Remove redundant type fields from all resource schemas and rename the credential discriminator from type to authorizerType.
Changes:
  • Remove type field from agent (AgentEnvSpecSchema), memory, evaluator, and online-eval-config schemas
  • Rename credential discriminated union key from type to authorizerType (values ApiKeyCredentialProvider and OAuthCredentialProvider unchanged)
  • Remove modelProvider from agent env schema (AgentEnvSpecSchema)
  • Update all consuming source files, primitives, operations, TUI components, and CLI commands
  • Regenerate agentcore.schema.v1.json
  • Update LLM-compacted schema documentation
Companion PR: aws/agentcore-l3-cdk-constructs (same branch name)
Related Issue
N/A — schema cleanup task
Type of Change
  •  Bug fix
  •  New feature
  •  Breaking change
  •  Documentation update
  •  Other (please describe):
Testing
TypeScript compilation: Both packages compile clean (tsc --noEmit passes)
Unit tests (CLI): 217/218 test files pass, 3112/3114 tests pass
  • 2 pre-existing PTY test failures (unrelated to this change)
Unit tests (CDK): 11/11 test files pass, 132/132 tests pass
JSON schema regeneration:node scripts/generate-schema.mjs succeeds, output committed
Specific test evidence:
  • Schema validation tests updated and passing for all resource types
  • Credential discriminated union tests verify authorizerType as discriminator
  • OnlineEvalConfigSchema tests pass without type field
  • AgentEnvSpecSchema tests pass without type and modelProvider
  • MemorySchema tests pass without type field
  • All credential operation tests (credential-ops, resolve-credential-strategy, pre-deploy-identity, fetch-gateway-token) pass with authorizerType
  • ResourceGraph component tests pass with updated credential rendering
  • Import/merge tests pass with updated schemas
  • Status command tests pass with authorizerType references
  •  I ran npm run test:unit and npm run test:integ
  •  I ran npm run typecheck
  •  I ran npm run lint
  •  If I modified src/assets/, I ran npm run test:update-snapshots and committed the updated snapshots
Checklist
  •  I have read the CONTRIBUTING document
  •  I have added any necessary tests that prove my fix is effective or my feature works
  •  I have updated the documentation accordingly
  •  I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  •  My changes generate no new warnings
  •  Any dependent changes have been merged and published
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the

terms of your choice.
@jesseturner21@claude
refactor(schema): remove type fields from resource schemas and rename…
52b1239
… credential discriminator
- Remove `type` field from agent, memory, evaluator, online-eval-config schemas
- Rename credential discriminator from `type` to `authorizerType`
- Remove `modelProvider` from agent env schema
- Update all source files, tests, and generated JSON schema
- Regenerate agentcore.schema.v1.json
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jesseturner21
jesseturner21
requested a review
from a teamMarch 27, 2026 20:35
@github-actionsgithub-actionsBot
added
the 
size/m
PR size: M
label
Mar 27, 2026
@github-actions
github-actionsBot
commented
Mar 27, 2026

Copy link


Copy Markdown

Contributor
Package Tarball
aws-agentcore-0.3.0-preview.9.0.tgz
How to install
npm install https://github.com/aws/agentcore-cli/releases/download/pr-709-tarball/aws-agentcore-0.3.0-preview.9.0.tgz
@github-actions
github-actionsBot
commented
Mar 27, 2026

Copy link


Copy Markdown

Contributor
Coverage Report
StatusCategoryPercentageCovered / Total
🔵Lines46.06%6568 / 14258
🔵Statements45.63%6980 / 15296
🔵Functions44.8%1182 / 2638
🔵Branches46.15%4341 / 9405
Generated in workflow #1464 for commit 52b1239 by the Vitest Coverage Report Action
@jesseturner21
jesseturner21
commented
Mar 27, 2026

Copy link


Copy Markdown

ContributorAuthor
E2E Test Evidence
Successfully tested end-to-end with the modified CLI and CDK packages:
1. Project creation
agentcore create --name TestRmType --framework Strands --defaults --skip-git --skip-python-setup

✅ Project created with no type fields in agentcore.json
2. Validation
agentcore validate

✅ Config validates successfully
3. Add credential (authorizerType flow)
agentcore add credential --name TestApiKey --type api-key --api-key fake-key-12345 --json

✅ Credential saved with authorizerType: "ApiKeyCredentialProvider" (not type)
4. Deploy
agentcore deploy --yes --json

✅ Deployed successfully to us-west-2:
  • Stack: AgentCore-TestRmType-default
  • Runtime ARN: arn:aws:bedrock-agentcore:us-west-2:325335451438:runtime/TestRmType_TestRmType-rthjn281qL
5. Invoke
agentcore invoke --agent TestRmType --prompt "Say hello" --json

✅ Agent responded: "Hello! 👋 How can I help you today?"
6. Status
agentcore status --json

✅ Agent shows deploymentState: "deployed", detail: "READY"
Unit test summary
  • CLI: 217/218 files pass, 3112/3114 tests pass (2 pre-existing PTY failures)
  • CDK: 11/11 files pass, 132/132 tests pass
  • TypeScript: Both packages compile clean
@jesseturner21jesseturner21
changed the title
refactor(schema): remove type fields and rename credential discriminatorrefactor(schema): remove type fields from resource schemas and rename credential discriminatorMar 27, 2026
jesseturner21
jesseturner21
commented
Mar 27, 2026
View reviewed changes
Comment threadschemas/agentcore.schema.v1.json
notgitika
notgitika
approved these changes
Mar 27, 2026
View reviewed changes
@notgitikanotgitika
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some redundant tests + dead code but we can fix those in a followup.

There is just a question around why the regex pattern was changed here and if this would break something otherwise LGTM
Comment threadschemas/agentcore.schema.v1.json
@jesseturner21
jesseturner21
merged commit 48dadfd
into
mainMar 27, 2026

22 of 25 checks passed

@jesseturner21
jesseturner21
deleted the

refactor/remove-type-fields-rename-credential-discriminator

branch
March 27, 2026 21:55
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 27, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
17c34ed
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
@jesseturner21jesseturner21
mentioned this pull request
Mar 27, 2026
 Merged

15 tasks
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 27, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
bd319cf
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 27, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
abac34e
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
@aidandaly24aidandaly24
mentioned this pull request
Mar 28, 2026
 Merged

15 tasks
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 28, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
ff51ae2
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 28, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
c39f516
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 28, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
0c88152
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Apr 8, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
89ac395
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
aidandaly24 added a commit
that referenced
this pull request
Apr 9, 2026
@aidandaly24
docs: fix 30 documentation inaccuracies found by source code audit (#697
767fd4c
)
* docs: fix 30 documentation inaccuracies found by source code audit
- configuration.md: fix networkMode PRIVATE→VPC, remove stale mcp.json
section, add 7 missing AgentEnvSpec fields, add Node.js runtimes,
fix gateway name max 63→100, list all 6 targetType values, fix memory
strategies wording, fix deployed-state.json path, add missing project
fields, fix CUSTOM_JWT field requirements, add customClaims field
- README.md: add CrewAI framework, update all 4 default model IDs,
add missing command sections
- frameworks.md: add CrewAI with model providers, add protocol
compatibility matrix (HTTP/MCP/A2A)
- commands.md: fix agent name max 64→48 chars, add fetch access section,
add policy-engine/policy to status --type, remove ghost
--tool-filter-description flag, fix model ID date
- gateway.md: add enableSemanticSearch/exceptionLevel config options,
fix mcp.json→agentcore.json, remove api-key from MCP Server auth
- transaction_search.md: fix traces command syntax
- container-builds.md: remove nonexistent --progress flag
- evals.md: fix model date 20250929→20250514
- local-development.md: fix mcp.json→agentcore.json
- AGENTS.md: remove AutoGen, remove stale mcp.json reference
- src/assets/README.md: add CrewAI to template list
- src/assets/agents/AGENTS.md: remove AutoGen
Constraint: All fixes verified against Zod schemas and CLI runtime
Constraint: CLI --help text bugs left for separate agent
Confidence: high
Scope-risk: narrow
* style: run prettier on documentation files
* test: update asset snapshots for edited README.md and AGENTS.md
* ci: trigger build workflow
* docs: update docs for upstream schema refactor and naming unification
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in #709)
- Remove `modelProvider` from agent spec (removed in #709)
- Rename credential `type` to `authorizerType` (renamed in #709)
- Rename `add identity` to `add credential` everywhere (#705)
- Replace `--force` with `-y/--yes` on remove commands (#705)
- Replace `--plan` with `--dry-run` on deploy command (#705)
- Update snapshot for src/assets/README.md change
* docs: fix stale agents reference in gateway example
Update `"agents": [...]` to `"runtimes": [...]` in the gateway
configuration example to match the schema rename in #706.
* docs: rename --agent flags to --runtime and remove stale type fields
Update all documentation to reflect upstream renames:
- --agent → --runtime, -a → -r across all commands
- --agent-arn → --runtime-arn, --agent-runtime-id → --runtime-id
- Remove stale "type" fields from JSON examples in evals.md,
memory.md, and container-builds.md
Constraint: --agent-id, --agent-alias-id, --agent-client-id,
--agent-client-secret are unchanged (different semantics)
Constraint: --type agent filter value in status/fetch stays as-is
Confidence: high
Scope-risk: narrow
* docs: add missing flags and fix --lines → --limit
- Add -H, --header flag to dev and invoke commands
- Add --bearer-token flag to invoke command
- Fix --lines → --limit in evals.md logs evals section
Confidence: high
Scope-risk: narrow
* docs: fix stale gateway flags and add missing CLI flags
- Rename --agent-client-id → --client-id, --agent-client-secret →
--client-secret in gateway docs (naming unification #705)
- Add missing flags to add agent: --authorizer-type, --discovery-url,
--allowed-audience, --allowed-clients, --allowed-scopes,
--custom-claims, --client-id, --client-secret, --idle-timeout,
--max-lifetime
- Add missing flags to create: --idle-timeout, --max-lifetime
- Add missing flags to add gateway: --runtimes, --custom-claims,
--policy-engine, --policy-engine-mode
- Fix --exception-level values: NONE/ALL (was undocumented)
Confidence: high
Scope-risk: narrow
* docs: fix --exception-level valid values to NONE/DEBUG
The CLI help text says ALL but the schema (GatewayExceptionLevelSchema)
defines the valid values as NONE and DEBUG. Aligns commands.md with
gateway.md and the Zod schema.
* docs: fix stale fields and add flags from upstream v0.5–v0.7
- Remove stale "type": "AgentCoreMemory" from memory streaming example
- Add memory streaming flags: --delivery-type, --data-stream-arn,
--stream-content-level, --stream-delivery-resources
- Add --exec to dev command flag table (Container agents)
- Add --skip-install to create command flag table
- Add --identity-name to fetch access flag table
@aidandaly24aidandaly24
mentioned this pull request
Jun 25, 2026
 Draft

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@notgitikanotgitikanotgitika approved these changes

Assignees


No one assigned


Labels

size/mPR size: M

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@jesseturner21@notgitika

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
refactor(schema): remove type fields from resource schemas and rename credential discriminator - #709
Merged
jesseturner21 merged 1 commit into
mainfrom 
refactor/remove-type-fields-rename-credential-discriminator
Mar 27, 2026
Merged
refactor(schema): remove type fields from resource schemas and rename credential discriminator#709
jesseturner21 merged 1 commit into
mainfrom 
refactor/remove-type-fields-rename-credential-discriminator
Conversation
@jesseturner21
@jesseturner21jesseturner21
commented
Mar 27, 2026

Copy link


Copy Markdown

Contributor
Description
Remove redundant type fields from all resource schemas and rename the credential discriminator from type to authorizerType.
Changes:
  • Remove type field from agent (AgentEnvSpecSchema), memory, evaluator, and online-eval-config schemas
  • Rename credential discriminated union key from type to authorizerType (values ApiKeyCredentialProvider and OAuthCredentialProvider unchanged)
  • Remove modelProvider from agent env schema (AgentEnvSpecSchema)
  • Update all consuming source files, primitives, operations, TUI components, and CLI commands
  • Regenerate agentcore.schema.v1.json
  • Update LLM-compacted schema documentation
Companion PR: aws/agentcore-l3-cdk-constructs (same branch name)
Related Issue
N/A — schema cleanup task
Type of Change
  •  Bug fix
  •  New feature
  •  Breaking change
  •  Documentation update
  •  Other (please describe):
Testing
TypeScript compilation: Both packages compile clean (tsc --noEmit passes)
Unit tests (CLI): 217/218 test files pass, 3112/3114 tests pass
  • 2 pre-existing PTY test failures (unrelated to this change)
Unit tests (CDK): 11/11 test files pass, 132/132 tests pass
JSON schema regeneration:node scripts/generate-schema.mjs succeeds, output committed
Specific test evidence:
  • Schema validation tests updated and passing for all resource types
  • Credential discriminated union tests verify authorizerType as discriminator
  • OnlineEvalConfigSchema tests pass without type field
  • AgentEnvSpecSchema tests pass without type and modelProvider
  • MemorySchema tests pass without type field
  • All credential operation tests (credential-ops, resolve-credential-strategy, pre-deploy-identity, fetch-gateway-token) pass with authorizerType
  • ResourceGraph component tests pass with updated credential rendering
  • Import/merge tests pass with updated schemas
  • Status command tests pass with authorizerType references
  •  I ran npm run test:unit and npm run test:integ
  •  I ran npm run typecheck
  •  I ran npm run lint
  •  If I modified src/assets/, I ran npm run test:update-snapshots and committed the updated snapshots
Checklist
  •  I have read the CONTRIBUTING document
  •  I have added any necessary tests that prove my fix is effective or my feature works
  •  I have updated the documentation accordingly
  •  I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  •  My changes generate no new warnings
  •  Any dependent changes have been merged and published
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the

terms of your choice.
@jesseturner21@claude
refactor(schema): remove type fields from resource schemas and rename…
52b1239
… credential discriminator
- Remove `type` field from agent, memory, evaluator, online-eval-config schemas
- Rename credential discriminator from `type` to `authorizerType`
- Remove `modelProvider` from agent env schema
- Update all source files, tests, and generated JSON schema
- Regenerate agentcore.schema.v1.json
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jesseturner21
jesseturner21
requested a review
from a teamMarch 27, 2026 20:35
@github-actionsgithub-actionsBot
added
the 
size/m
PR size: M
label
Mar 27, 2026
@github-actions
github-actionsBot
commented
Mar 27, 2026

Copy link


Copy Markdown

Contributor
Package Tarball
aws-agentcore-0.3.0-preview.9.0.tgz
How to install
npm install https://github.com/aws/agentcore-cli/releases/download/pr-709-tarball/aws-agentcore-0.3.0-preview.9.0.tgz
@github-actions
github-actionsBot
commented
Mar 27, 2026

Copy link


Copy Markdown

Contributor
Coverage Report
StatusCategoryPercentageCovered / Total
🔵Lines46.06%6568 / 14258
🔵Statements45.63%6980 / 15296
🔵Functions44.8%1182 / 2638
🔵Branches46.15%4341 / 9405
Generated in workflow #1464 for commit 52b1239 by the Vitest Coverage Report Action
@jesseturner21
jesseturner21
commented
Mar 27, 2026

Copy link


Copy Markdown

ContributorAuthor
E2E Test Evidence
Successfully tested end-to-end with the modified CLI and CDK packages:
1. Project creation
agentcore create --name TestRmType --framework Strands --defaults --skip-git --skip-python-setup

✅ Project created with no type fields in agentcore.json
2. Validation
agentcore validate

✅ Config validates successfully
3. Add credential (authorizerType flow)
agentcore add credential --name TestApiKey --type api-key --api-key fake-key-12345 --json

✅ Credential saved with authorizerType: "ApiKeyCredentialProvider" (not type)
4. Deploy
agentcore deploy --yes --json

✅ Deployed successfully to us-west-2:
  • Stack: AgentCore-TestRmType-default
  • Runtime ARN: arn:aws:bedrock-agentcore:us-west-2:325335451438:runtime/TestRmType_TestRmType-rthjn281qL
5. Invoke
agentcore invoke --agent TestRmType --prompt "Say hello" --json

✅ Agent responded: "Hello! 👋 How can I help you today?"
6. Status
agentcore status --json

✅ Agent shows deploymentState: "deployed", detail: "READY"
Unit test summary
  • CLI: 217/218 files pass, 3112/3114 tests pass (2 pre-existing PTY failures)
  • CDK: 11/11 files pass, 132/132 tests pass
  • TypeScript: Both packages compile clean
@jesseturner21jesseturner21
changed the title
refactor(schema): remove type fields and rename credential discriminatorrefactor(schema): remove type fields from resource schemas and rename credential discriminatorMar 27, 2026
jesseturner21
jesseturner21
commented
Mar 27, 2026
View reviewed changes
Comment threadschemas/agentcore.schema.v1.json
notgitika
notgitika
approved these changes
Mar 27, 2026
View reviewed changes
@notgitikanotgitika
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some redundant tests + dead code but we can fix those in a followup.

There is just a question around why the regex pattern was changed here and if this would break something otherwise LGTM
Comment threadschemas/agentcore.schema.v1.json
@jesseturner21
jesseturner21
merged commit 48dadfd
into
mainMar 27, 2026

22 of 25 checks passed

@jesseturner21
jesseturner21
deleted the

refactor/remove-type-fields-rename-credential-discriminator

branch
March 27, 2026 21:55
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 27, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
17c34ed
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
@jesseturner21jesseturner21
mentioned this pull request
Mar 27, 2026
 Merged

15 tasks
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 27, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
bd319cf
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 27, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
abac34e
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
@aidandaly24aidandaly24
mentioned this pull request
Mar 28, 2026
 Merged

15 tasks
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 28, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
ff51ae2
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 28, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
c39f516
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 28, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
0c88152
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Apr 8, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
89ac395
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
aidandaly24 added a commit
that referenced
this pull request
Apr 9, 2026
@aidandaly24
docs: fix 30 documentation inaccuracies found by source code audit (#697
767fd4c
)
* docs: fix 30 documentation inaccuracies found by source code audit
- configuration.md: fix networkMode PRIVATE→VPC, remove stale mcp.json
section, add 7 missing AgentEnvSpec fields, add Node.js runtimes,
fix gateway name max 63→100, list all 6 targetType values, fix memory
strategies wording, fix deployed-state.json path, add missing project
fields, fix CUSTOM_JWT field requirements, add customClaims field
- README.md: add CrewAI framework, update all 4 default model IDs,
add missing command sections
- frameworks.md: add CrewAI with model providers, add protocol
compatibility matrix (HTTP/MCP/A2A)
- commands.md: fix agent name max 64→48 chars, add fetch access section,
add policy-engine/policy to status --type, remove ghost
--tool-filter-description flag, fix model ID date
- gateway.md: add enableSemanticSearch/exceptionLevel config options,
fix mcp.json→agentcore.json, remove api-key from MCP Server auth
- transaction_search.md: fix traces command syntax
- container-builds.md: remove nonexistent --progress flag
- evals.md: fix model date 20250929→20250514
- local-development.md: fix mcp.json→agentcore.json
- AGENTS.md: remove AutoGen, remove stale mcp.json reference
- src/assets/README.md: add CrewAI to template list
- src/assets/agents/AGENTS.md: remove AutoGen
Constraint: All fixes verified against Zod schemas and CLI runtime
Constraint: CLI --help text bugs left for separate agent
Confidence: high
Scope-risk: narrow
* style: run prettier on documentation files
* test: update asset snapshots for edited README.md and AGENTS.md
* ci: trigger build workflow
* docs: update docs for upstream schema refactor and naming unification
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in #709)
- Remove `modelProvider` from agent spec (removed in #709)
- Rename credential `type` to `authorizerType` (renamed in #709)
- Rename `add identity` to `add credential` everywhere (#705)
- Replace `--force` with `-y/--yes` on remove commands (#705)
- Replace `--plan` with `--dry-run` on deploy command (#705)
- Update snapshot for src/assets/README.md change
* docs: fix stale agents reference in gateway example
Update `"agents": [...]` to `"runtimes": [...]` in the gateway
configuration example to match the schema rename in #706.
* docs: rename --agent flags to --runtime and remove stale type fields
Update all documentation to reflect upstream renames:
- --agent → --runtime, -a → -r across all commands
- --agent-arn → --runtime-arn, --agent-runtime-id → --runtime-id
- Remove stale "type" fields from JSON examples in evals.md,
memory.md, and container-builds.md
Constraint: --agent-id, --agent-alias-id, --agent-client-id,
--agent-client-secret are unchanged (different semantics)
Constraint: --type agent filter value in status/fetch stays as-is
Confidence: high
Scope-risk: narrow
* docs: add missing flags and fix --lines → --limit
- Add -H, --header flag to dev and invoke commands
- Add --bearer-token flag to invoke command
- Fix --lines → --limit in evals.md logs evals section
Confidence: high
Scope-risk: narrow
* docs: fix stale gateway flags and add missing CLI flags
- Rename --agent-client-id → --client-id, --agent-client-secret →
--client-secret in gateway docs (naming unification #705)
- Add missing flags to add agent: --authorizer-type, --discovery-url,
--allowed-audience, --allowed-clients, --allowed-scopes,
--custom-claims, --client-id, --client-secret, --idle-timeout,
--max-lifetime
- Add missing flags to create: --idle-timeout, --max-lifetime
- Add missing flags to add gateway: --runtimes, --custom-claims,
--policy-engine, --policy-engine-mode
- Fix --exception-level values: NONE/ALL (was undocumented)
Confidence: high
Scope-risk: narrow
* docs: fix --exception-level valid values to NONE/DEBUG
The CLI help text says ALL but the schema (GatewayExceptionLevelSchema)
defines the valid values as NONE and DEBUG. Aligns commands.md with
gateway.md and the Zod schema.
* docs: fix stale fields and add flags from upstream v0.5–v0.7
- Remove stale "type": "AgentCoreMemory" from memory streaming example
- Add memory streaming flags: --delivery-type, --data-stream-arn,
--stream-content-level, --stream-delivery-resources
- Add --exec to dev command flag table (Container agents)
- Add --skip-install to create command flag table
- Add --identity-name to fetch access flag table
@aidandaly24aidandaly24
mentioned this pull request
Jun 25, 2026
 Draft

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@notgitikanotgitikanotgitika approved these changes

Assignees


No one assigned


Labels

size/mPR size: M

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@jesseturner21@notgitika

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
refactor(schema): remove type fields from resource schemas and rename credential discriminator - #709
Merged
jesseturner21 merged 1 commit into
mainfrom 
refactor/remove-type-fields-rename-credential-discriminator
Mar 27, 2026
Merged
refactor(schema): remove type fields from resource schemas and rename credential discriminator#709
jesseturner21 merged 1 commit into
mainfrom 
refactor/remove-type-fields-rename-credential-discriminator
Conversation
@jesseturner21
@jesseturner21jesseturner21
commented
Mar 27, 2026

Copy link


Copy Markdown

Contributor
Description
Remove redundant type fields from all resource schemas and rename the credential discriminator from type to authorizerType.
Changes:
  • Remove type field from agent (AgentEnvSpecSchema), memory, evaluator, and online-eval-config schemas
  • Rename credential discriminated union key from type to authorizerType (values ApiKeyCredentialProvider and OAuthCredentialProvider unchanged)
  • Remove modelProvider from agent env schema (AgentEnvSpecSchema)
  • Update all consuming source files, primitives, operations, TUI components, and CLI commands
  • Regenerate agentcore.schema.v1.json
  • Update LLM-compacted schema documentation
Companion PR: aws/agentcore-l3-cdk-constructs (same branch name)
Related Issue
N/A — schema cleanup task
Type of Change
  •  Bug fix
  •  New feature
  •  Breaking change
  •  Documentation update
  •  Other (please describe):
Testing
TypeScript compilation: Both packages compile clean (tsc --noEmit passes)
Unit tests (CLI): 217/218 test files pass, 3112/3114 tests pass
  • 2 pre-existing PTY test failures (unrelated to this change)
Unit tests (CDK): 11/11 test files pass, 132/132 tests pass
JSON schema regeneration:node scripts/generate-schema.mjs succeeds, output committed
Specific test evidence:
  • Schema validation tests updated and passing for all resource types
  • Credential discriminated union tests verify authorizerType as discriminator
  • OnlineEvalConfigSchema tests pass without type field
  • AgentEnvSpecSchema tests pass without type and modelProvider
  • MemorySchema tests pass without type field
  • All credential operation tests (credential-ops, resolve-credential-strategy, pre-deploy-identity, fetch-gateway-token) pass with authorizerType
  • ResourceGraph component tests pass with updated credential rendering
  • Import/merge tests pass with updated schemas
  • Status command tests pass with authorizerType references
  •  I ran npm run test:unit and npm run test:integ
  •  I ran npm run typecheck
  •  I ran npm run lint
  •  If I modified src/assets/, I ran npm run test:update-snapshots and committed the updated snapshots
Checklist
  •  I have read the CONTRIBUTING document
  •  I have added any necessary tests that prove my fix is effective or my feature works
  •  I have updated the documentation accordingly
  •  I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  •  My changes generate no new warnings
  •  Any dependent changes have been merged and published
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the

terms of your choice.
@jesseturner21@claude
refactor(schema): remove type fields from resource schemas and rename…
52b1239
… credential discriminator
- Remove `type` field from agent, memory, evaluator, online-eval-config schemas
- Rename credential discriminator from `type` to `authorizerType`
- Remove `modelProvider` from agent env schema
- Update all source files, tests, and generated JSON schema
- Regenerate agentcore.schema.v1.json
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jesseturner21
jesseturner21
requested a review
from a teamMarch 27, 2026 20:35
@github-actionsgithub-actionsBot
added
the 
size/m
PR size: M
label
Mar 27, 2026
@github-actions
github-actionsBot
commented
Mar 27, 2026

Copy link


Copy Markdown

Contributor
Package Tarball
aws-agentcore-0.3.0-preview.9.0.tgz
How to install
npm install https://github.com/aws/agentcore-cli/releases/download/pr-709-tarball/aws-agentcore-0.3.0-preview.9.0.tgz
@github-actions
github-actionsBot
commented
Mar 27, 2026

Copy link


Copy Markdown

Contributor
Coverage Report
StatusCategoryPercentageCovered / Total
🔵Lines46.06%6568 / 14258
🔵Statements45.63%6980 / 15296
🔵Functions44.8%1182 / 2638
🔵Branches46.15%4341 / 9405
Generated in workflow #1464 for commit 52b1239 by the Vitest Coverage Report Action
@jesseturner21
jesseturner21
commented
Mar 27, 2026

Copy link


Copy Markdown

ContributorAuthor
E2E Test Evidence
Successfully tested end-to-end with the modified CLI and CDK packages:
1. Project creation
agentcore create --name TestRmType --framework Strands --defaults --skip-git --skip-python-setup

✅ Project created with no type fields in agentcore.json
2. Validation
agentcore validate

✅ Config validates successfully
3. Add credential (authorizerType flow)
agentcore add credential --name TestApiKey --type api-key --api-key fake-key-12345 --json

✅ Credential saved with authorizerType: "ApiKeyCredentialProvider" (not type)
4. Deploy
agentcore deploy --yes --json

✅ Deployed successfully to us-west-2:
  • Stack: AgentCore-TestRmType-default
  • Runtime ARN: arn:aws:bedrock-agentcore:us-west-2:325335451438:runtime/TestRmType_TestRmType-rthjn281qL
5. Invoke
agentcore invoke --agent TestRmType --prompt "Say hello" --json

✅ Agent responded: "Hello! 👋 How can I help you today?"
6. Status
agentcore status --json

✅ Agent shows deploymentState: "deployed", detail: "READY"
Unit test summary
  • CLI: 217/218 files pass, 3112/3114 tests pass (2 pre-existing PTY failures)
  • CDK: 11/11 files pass, 132/132 tests pass
  • TypeScript: Both packages compile clean
@jesseturner21jesseturner21
changed the title
refactor(schema): remove type fields and rename credential discriminatorrefactor(schema): remove type fields from resource schemas and rename credential discriminatorMar 27, 2026
jesseturner21
jesseturner21
commented
Mar 27, 2026
View reviewed changes
Comment threadschemas/agentcore.schema.v1.json
notgitika
notgitika
approved these changes
Mar 27, 2026
View reviewed changes
@notgitikanotgitika
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some redundant tests + dead code but we can fix those in a followup.

There is just a question around why the regex pattern was changed here and if this would break something otherwise LGTM
Comment threadschemas/agentcore.schema.v1.json
@jesseturner21
jesseturner21
merged commit 48dadfd
into
mainMar 27, 2026

22 of 25 checks passed

@jesseturner21
jesseturner21
deleted the

refactor/remove-type-fields-rename-credential-discriminator

branch
March 27, 2026 21:55
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 27, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
17c34ed
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
@jesseturner21jesseturner21
mentioned this pull request
Mar 27, 2026
 Merged

15 tasks
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 27, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
bd319cf
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 27, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
abac34e
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
@aidandaly24aidandaly24
mentioned this pull request
Mar 28, 2026
 Merged

15 tasks
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 28, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
ff51ae2
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 28, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
c39f516
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Mar 28, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
0c88152
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
aidandaly24 added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Apr 8, 2026
@aidandaly24
docs: update docs for upstream schema refactor and naming unification
89ac395
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in aws#709)
- Remove `modelProvider` from agent spec (removed in aws#709)
- Rename credential `type` to `authorizerType` (renamed in aws#709)
- Rename `add identity` to `add credential` everywhere (aws#705)
- Replace `--force` with `-y/--yes` on remove commands (aws#705)
- Replace `--plan` with `--dry-run` on deploy command (aws#705)
- Update snapshot for src/assets/README.md change
aidandaly24 added a commit
that referenced
this pull request
Apr 9, 2026
@aidandaly24
docs: fix 30 documentation inaccuracies found by source code audit (#697
767fd4c
)
* docs: fix 30 documentation inaccuracies found by source code audit
- configuration.md: fix networkMode PRIVATE→VPC, remove stale mcp.json
section, add 7 missing AgentEnvSpec fields, add Node.js runtimes,
fix gateway name max 63→100, list all 6 targetType values, fix memory
strategies wording, fix deployed-state.json path, add missing project
fields, fix CUSTOM_JWT field requirements, add customClaims field
- README.md: add CrewAI framework, update all 4 default model IDs,
add missing command sections
- frameworks.md: add CrewAI with model providers, add protocol
compatibility matrix (HTTP/MCP/A2A)
- commands.md: fix agent name max 64→48 chars, add fetch access section,
add policy-engine/policy to status --type, remove ghost
--tool-filter-description flag, fix model ID date
- gateway.md: add enableSemanticSearch/exceptionLevel config options,
fix mcp.json→agentcore.json, remove api-key from MCP Server auth
- transaction_search.md: fix traces command syntax
- container-builds.md: remove nonexistent --progress flag
- evals.md: fix model date 20250929→20250514
- local-development.md: fix mcp.json→agentcore.json
- AGENTS.md: remove AutoGen, remove stale mcp.json reference
- src/assets/README.md: add CrewAI to template list
- src/assets/agents/AGENTS.md: remove AutoGen
Constraint: All fixes verified against Zod schemas and CLI runtime
Constraint: CLI --help text bugs left for separate agent
Confidence: high
Scope-risk: narrow
* style: run prettier on documentation files
* test: update asset snapshots for edited README.md and AGENTS.md
* ci: trigger build workflow
* docs: update docs for upstream schema refactor and naming unification
- Remove `type` fields from agent, memory, evaluator, online-eval-config
examples and field tables (removed in #709)
- Remove `modelProvider` from agent spec (removed in #709)
- Rename credential `type` to `authorizerType` (renamed in #709)
- Rename `add identity` to `add credential` everywhere (#705)
- Replace `--force` with `-y/--yes` on remove commands (#705)
- Replace `--plan` with `--dry-run` on deploy command (#705)
- Update snapshot for src/assets/README.md change
* docs: fix stale agents reference in gateway example
Update `"agents": [...]` to `"runtimes": [...]` in the gateway
configuration example to match the schema rename in #706.
* docs: rename --agent flags to --runtime and remove stale type fields
Update all documentation to reflect upstream renames:
- --agent → --runtime, -a → -r across all commands
- --agent-arn → --runtime-arn, --agent-runtime-id → --runtime-id
- Remove stale "type" fields from JSON examples in evals.md,
memory.md, and container-builds.md
Constraint: --agent-id, --agent-alias-id, --agent-client-id,
--agent-client-secret are unchanged (different semantics)
Constraint: --type agent filter value in status/fetch stays as-is
Confidence: high
Scope-risk: narrow
* docs: add missing flags and fix --lines → --limit
- Add -H, --header flag to dev and invoke commands
- Add --bearer-token flag to invoke command
- Fix --lines → --limit in evals.md logs evals section
Confidence: high
Scope-risk: narrow
* docs: fix stale gateway flags and add missing CLI flags
- Rename --agent-client-id → --client-id, --agent-client-secret →
--client-secret in gateway docs (naming unification #705)
- Add missing flags to add agent: --authorizer-type, --discovery-url,
--allowed-audience, --allowed-clients, --allowed-scopes,
--custom-claims, --client-id, --client-secret, --idle-timeout,
--max-lifetime
- Add missing flags to create: --idle-timeout, --max-lifetime
- Add missing flags to add gateway: --runtimes, --custom-claims,
--policy-engine, --policy-engine-mode
- Fix --exception-level values: NONE/ALL (was undocumented)
Confidence: high
Scope-risk: narrow
* docs: fix --exception-level valid values to NONE/DEBUG
The CLI help text says ALL but the schema (GatewayExceptionLevelSchema)
defines the valid values as NONE and DEBUG. Aligns commands.md with
gateway.md and the Zod schema.
* docs: fix stale fields and add flags from upstream v0.5–v0.7
- Remove stale "type": "AgentCoreMemory" from memory streaming example
- Add memory streaming flags: --delivery-type, --data-stream-arn,
--stream-content-level, --stream-delivery-resources
- Add --exec to dev command flag table (Container agents)
- Add --skip-install to create command flag table
- Add --identity-name to fetch access flag table
@aidandaly24aidandaly24
mentioned this pull request
Jun 25, 2026
 Draft

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@notgitikanotgitikanotgitika approved these changes

Assignees


No one assigned


Labels

size/mPR size: M

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@jesseturner21@notgitika