Uh oh!
There was an error while loading. Please reload this page.
feat(webkit): [ENG-47606] add DocProse, the documentation typography contract - #906
Merged
gabriel-lisboa-azion merged 0 commit intoAug 25, 2026
Conversation
This was referenced Aug 22, 2026
isaque-bock-azion
changed the base branch from
feat/ENG-47561-docs-measure-and-mono-body
to
feat/webkit-documentationAugust 24, 2026 13:04
robson-junior-azion
approved these changes
Aug 25, 2026
isaque-bock-azionforce-pushed
the
feat/ENG-47606-doc-prose
branch
from
August 25, 2026 22:42
3f69b5e to
de9875aCompareUh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DocProseunder the newdocumentationcategory — the typography contract a documentation page wraps its body in. It styles descendants rather than itself, so it works over any markdown/MDX pipeline's output, hand-written markup, or CMS HTML. The design system ships no renderer; the consumer brings their own.:not([data-doc-chrome],[data-doc-chrome]_*), so the contract stops at a documentation component's edge instead of restyling the webkit internals it wraps (a Message body, a CodeBlock's lines, an Accordion trigger's heading)..layout-column-docs.How to test
pnpm storybook:dev→ Components / Documentation / DocProse. TheDocProsestory shows the full ladder; Chrome boundary shows adata-doc-chromesubtree keeping its own styling while the prose around it does not.xl) / h3 24 / h4 16 / prose 16 / block 24, and that it reads the same at 390px and 1440px. The ladder is pinned by descending responsive pairs, so a rung that moves with width is a bug.cd packages/webkit && npx vitest run src/components/documentation/doc-prose/doc-prose.test.ts— 8/8 pass in Chromium.node packages/webkit/scripts/check-size.mjs—doc-prose1.02 KB against a 1.5 KB budget.node packages/webkit/scripts/check-authoring.mjsandnode .claude/hooks/validate-story-source.mjs --all— both clean.Notes
documentationcategory). Merge chore: [ENG-47606] add the documentation component category #904 → feat(theme): [ENG-47561] add the docs measure and the prose + mono body registers #905 → this; each retargets automatically.pandlitake the newtext-body-prose-mdregister rather thantext-body-mdplus aleading-*override.check-authoring'sleading-rawcheck deliberately rejects that override even in token form, and line-height belongs in the token — the same calltext-body-code-smalready makes.h1..h6to weight 400 via an unlayered!importantinpreview.css, so h4's rung — which it earns onfont-medium, not on space — is not verifiable in Storybook. Check that one in a real page.Delivery
The Documentation family is delivered on the feature branch
feat/docs-components-bundle, not piecemeal tomain— somaintakes the whole family as one merge, while review stays per-component.Merge order, bottom-up — each PR's base is the one before it, and each retargets automatically as its parent lands:
#904→#905→#906→#907→#908→#909→#910→#911→#912→#913→#914→#915→#916→#917→#918→feat/docs-components-bundle→main#904documentationcategory (standards only)#905#906–#918