Uh oh!
There was an error while loading. Please reload this page.
feat(webkit): [ENG-47607] add DocCallout, the documentation admonition - #907
Closed
gabriel-lisboa-azion wants to merge 0 commit into
Closed
feat(webkit): [ENG-47607] add DocCallout, the documentation admonition#907gabriel-lisboa-azion wants to merge 0 commit into
gabriel-lisboa-azion wants to merge 0 commit into
Conversation
isaque-bock-azion
changed the base branch from
feat/ENG-47606-doc-prose
to
feat/webkit-documentationAugust 24, 2026 13:04
gabriel-lisboa-azionforce-pushed
the
feat/ENG-47607-doc-callout
branch
from
August 25, 2026 12:44
a7a4292 to
3eb370dCompareisaque-bock-azionforce-pushed
the
feat/ENG-47607-doc-callout
branch
from
August 25, 2026 22:42
3eb370d to
de9875aCompare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DocCallout— the admonition a documentation page interrupts itself with (Note, Info, Tip, Check, Warning, Danger), rendered on the webkitMessagesurface so the severity colour, border, icon and radius come from the design system rather than from this layer.titleprop: the name repeated what the glyph and the tint already say, cost a line on every aside, and pushed the sentence the reader came for down the box.tiptakes the page's own surface and rule and spends its whole emphasis on the glyph, in--primary. That stops a friendly shortcut being painted the same green as a confirmed success.How to test
pnpm storybook:dev→ Components / Documentation / DocCallout. The Kinds story puts all six side by side; check in both themes that each fill, border and glyph actually paints, and thattipreads as neutral rather than as a severity.cd packages/webkit && npx vitest run src/components/documentation/doc-callout/doc-callout.test.ts— 14/14 in Chromium, covering every kind's severity + glyph mapping, the neutral flag, the unknown-kind fallback, and the testid override.node packages/webkit/scripts/check-size.mjs—doc-callout5.68 KB against a 6.5 KB budget.node packages/webkit/scripts/check-authoring.mjs— 0 new violations.Notes
doc-callout-${kind}, an interpolated literal a consumer could not override. It is now the deriveddocumentation-doc-calloutwithinheritAttrs: false+$attrson the root, and the kind stays readable ondata-kindso a test can still target one flavour.<Highlight>/<Tip>as tags, and used<severity>as a placeholder. They are now prose.Messageas props and land as real attributes; the paint is verified in the browser and by the visual gate.Delivery
The Documentation family is delivered on the feature branch
feat/docs-components-bundle, not piecemeal tomain— somaintakes the whole family as one merge, while review stays per-component.Merge order, bottom-up — each PR's base is the one before it, and each retargets automatically as its parent lands:
#904→#905→#906→#907→#908→#909→#910→#911→#912→#913→#914→#915→#916→#917→#918→feat/docs-components-bundle→main#904documentationcategory (standards only)#905#906–#918