Uh oh!
There was an error while loading. Please reload this page.
feat: upgrade to protobuf 27.0 and remove py_proto_library (#1933) - #1951
Closed
aignas wants to merge 1 commit into
Closed
feat: upgrade to protobuf 27.0 and remove py_proto_library (#1933)#1951aignas wants to merge 1 commit into
aignas wants to merge 1 commit into
Conversation
aignas
commented
Jun 12, 2024
CollaboratorAuthor
Should wait before #1953 is merged. |
comius
commented
Jun 13, 2024
Contributor
My main motivation for this was #1956. There might be other solutions to it, and this PR could wait. |
aignas
commented
Jun 17, 2024
CollaboratorAuthor
Closing since #1957 got merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reintroduce the changes in #1933, which got reverted in
commit 8b0eaed (#1948).