Uh oh!
There was an error while loading. Please reload this page.
fix(rules): drop the unused argument - #1953
Merged
Merged
Conversation
aignas
commented
Jun 12, 2024
CollaboratorAuthor
FYI @fmeum |
aignas
commented
Jun 12, 2024
CollaboratorAuthor
Once this is merged, we will need to cherry-pick and release a 0.33.1, IMHO. |
This was referenced Jun 12, 2024
CollaboratorAuthor
@rickeylev, feel free to take over the PR and finish it. Since I have started it, if you stamp after making any extra changes, you should be able to merge it. :) EDIT: I took a stab at implementing the tests myself, let me know what you think. I amended the CHANGELOG to assume that we are releasing 0.33.1 straight after and I checked locally with: $ bazel run --build_python_zip //tools/publish:twineWARNING: Build option --build_python_zip has changed, discarding analysis cache (this can be expensive, see https://bazel.build/advanced/performance/iteration-speed).INFO: Analyzed target //tools/publish:twine (61 packages loaded, 6988 targets configured).INFO: Found 1 target...Target //tools/publish:twine up-to-date: bazel-bin/tools/publish/_twine.zip bazel-bin/tools/publish/rules_python_entry_point_twine.py bazel-bin/tools/publish/_twineINFO: Elapsed time: 22.087s, Critical Path: 10.20sINFO: 22 processes: 17 internal, 5 linux-sandbox.INFO: Build completed successfully, 22 total actionsINFO: Running command line: bazel-bin/tools/publish/twineusage: twine [-h] [--version] [--no-color] {check,upload,register}twine: error: the following arguments are required: command, argsSo it does indeed seem to be an extra argument. |
It seems that there is an extra argument that is there but I am not sure about the reason, it is most likely a leftover. As part of this change we add an analysis test for non-windows zip building. I could reproduce the failure and now the newly added test passes. Fixes#1954
rickeylev
approved these changes
Jun 12, 2024
rickeylev
left a comment
Collaborator
There was a problem hiding this comment.
Oops, thanks. Yeah, I missed that arg and there weren't tests covering it. Fix LGTM.
rickeylev pushed a commit
to rickeylev/rules_python
that referenced
this pull request
Jun 13, 2024
It seems that there is an extra argument that is there but I am not sure about the reason, it is most likely a leftover. As part of this change we add an analysis test for non-windows zip building. I could reproduce the failure and now the newly added test passes. Fixesbazel-contrib#1954
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that there is an extra argument that is there but I am not sure about
the reason, it is most likely a leftover. As part of this change we add an
analysis test for non-windows zip building. I could reproduce the failure and
now the newly added test passes.
Fixes#1954