Skip to content

Add missing windows CI - #344

Closed
alexeagle wants to merge 2 commits into
bazel-contrib:mainfrom
alexeagle:windows
Closed

Add missing windows CI#344
alexeagle wants to merge 2 commits into
bazel-contrib:mainfrom
alexeagle:windows

Conversation

@alexeagle

@alexeaglealexeagle commented Jul 19, 2020

Copy link
Copy Markdown
Contributor

Fixes#2 (if we can get it green)

@thundergolfer

Copy link
Copy Markdown

Failing due to google/subpar#39 (comment)

@thundergolfer

Copy link
Copy Markdown

There's a whole lot of Windows specific logic in https://github.com/bazelbuild/bazel/blob/1a0852199d05bef95fcceaa1ef244c36d393bfb0/src/main/java/com/google/devtools/build/lib/bazel/rules/python/BazelPythonSemantics.java that ends up creating the <target_name>.exe that is in this case compiler.exe.

Somewhere in there a non-UTF-8 char is being introduced, or the whole file is actually just binary and not a text-based bash file like in Unix.

I'd say I'd be better to address this issue be replacing the .par files, like we did in rules_python_external.

@alexeagle

Copy link
Copy Markdown
ContributorAuthor

Agreed that the best path forward here is to upstream rules_python_external approach.

@github-actions

Copy link
Copy Markdown
Contributor

This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days.
Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_python!

@github-actionsgithub-actionsBot added the Can Close? Will close in 30 days if there is no new activity label Apr 14, 2021
@thundergolferthundergolfer self-assigned this Apr 19, 2021
@thundergolferthundergolfer removed the Can Close? Will close in 30 days if there is no new activity label Apr 19, 2021
@UebelAndreUebelAndre mentioned this pull request Dec 30, 2021
12 tasks
@UebelAndre

Copy link
Copy Markdown
Contributor

@alexeagle this could probably be closed now that #585 has been merged

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows support

4 participants

@alexeagle@thundergolfer@UebelAndre@googlebot