Skip to content

Enabled CI for Windows - #585

Merged
alexeagle merged 2 commits into
bazel-contrib:mainfrom
UebelAndre:windows
Jan 3, 2022
Merged

Enabled CI for Windows#585
alexeagle merged 2 commits into
bazel-contrib:mainfrom
UebelAndre:windows

Conversation

@UebelAndre

@UebelAndreUebelAndre commented Dec 28, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?
This change includes all the necessary fixes and updates to support enabling CI for windows platforms.

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #2
I don't know if this closes#2 but seems related

What is the new behavior?

Updated rules and tests to support windows platforms.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

closes#572

@UebelAndre
UebelAndre marked this pull request as ready for review December 29, 2021 00:36
@UebelAndre

UebelAndre commented Dec 29, 2021

Copy link
Copy Markdown
ContributorAuthor

@alexeagle you may want to take a look at the changes to the integration test runner. I could be mistaken but I think you have the most context on that bit of code 😅

alexeagle
alexeagle reviewed Dec 29, 2021
View reviewed changes
Comment threaddocs/BUILD Outdated
Comment threadpython/pip_install/extract_wheels/lib/BUILD Outdated
Comment threadpython/pip_install/extract_wheels/lib/BUILD Outdated
Comment threadpython/pip_install/extract_wheels/lib/whl_filegroup_test.py Outdated
@UebelAndre

UebelAndre commented Dec 29, 2021

Copy link
Copy Markdown
ContributorAuthor

@alexeagle all comments addressed and ready for another review 😄

@alexeagle

alexeagle commented Dec 29, 2021

Copy link
Copy Markdown
Contributor

Does this fix #2 ? if not, do you know what's left?

alexeagle
alexeagle reviewed Dec 29, 2021
View reviewed changes
Comment threadtools/bazel_integration_test/test_runner.py Outdated
Comment threadpython/pip_install/extract_wheels/lib/whl_filegroup_test.py
@UebelAndre

UebelAndre commented Dec 29, 2021

Copy link
Copy Markdown
ContributorAuthor

Does this fix #2 ? if not, do you know what's left?

I'm not entirely sure. I just recalled seeing a "Add windows support" style issue and thought it'd be relevant to this.

@UebelAndre

UebelAndre commented Dec 30, 2021

Copy link
Copy Markdown
ContributorAuthor

This PR would also close out #344

alexeagle
alexeagle approved these changes Jan 3, 2022
View reviewed changes

@alexeaglealexeagle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks!

@alexeagle
alexeagle merged commit 628d40f into bazel-contrib:mainJan 3, 2022
@UebelAndre
UebelAndre deleted the windows branch January 3, 2022 05:55
@UebelAndreUebelAndre mentioned this pull request Jan 5, 2022
Merged
12 tasks
@jheaff1jheaff1 mentioned this pull request Jan 6, 2022
Closed
12 tasks
@UebelAndreUebelAndre mentioned this pull request Jan 17, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexeaglealexeaglealexeagle approved these changes
@andyscottandyscottAwaiting requested review from andyscott
@brandjonbrandjonAwaiting requested review from brandjon
@lberkilberkiAwaiting requested review from lberki
@thundergolferthundergolferAwaiting requested review from thundergolfer

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Windows support

2 participants

@UebelAndre@alexeagle