moved changes from flow-devel - #23
Conversation
cathywu
left a comment
There was a problem hiding this comment.
Did we want to get rid of docs/source/tutorial.rst as outdated?
Anyway, LGTM but probably @eugenevinitsky should take a pass as well.
| rl_actions: list or numpy ndarray, optional | ||
| actions to be performed by rl vehicles in the network (if there | ||
| are any) | ||
| rl_actions: method, optional |
| # The maximum number of workers nodes to launch in addition to the head | ||
| # node. This takes precedence over min_workers. | ||
| max_workers: 2 | ||
| max_workers: 0 |
There was a problem hiding this comment.
This prevents it from auto-scaling; I think having extra nodes suddenly pop up and raise your costs would be undesired behavior.
| "/tmp/foo2": "/Users/eugenevinitsky/.ssh/ray-autoscaler_1_us-west-1.pem", | ||
| #"/tmp/path": "<PATH TO LEARNING TRAFFIC>/.git/refs/heads/<BRANCH NAME>", | ||
| #"/tmp/ray_autoscaler_key": "<PATH TO RAY_AUTOSCALER_KEY>", | ||
| "/tmp/path": "/Users/eugenevinitsky/Desktop/Research/Bayen/Code/rllab-multiagent/learning-traffic/.git/refs/heads/ars_runner", |
There was a problem hiding this comment.
These paths probably shouldn't be committed, but this can be cleaned up in a separate PR. @eugenevinitsky
There was a problem hiding this comment.
A commit is coming. Noted.
| - cd flow-devel && GIT_SSH_COMMAND="ssh -i ~/ray_autoscaler_key.pem" git fetch && GIT_SSH_COMMAND="ssh -i ~/ray_autoscaler_key.pem" git checkout `cat /tmp/foo` | ||
| - cd /tmp && cp ray_autoscaler_key ~/ray_autoscaler_key.pem | ||
| - cd flow-devel && GIT_SSH_COMMAND="ssh -i ~/ray_autoscaler_key.pem" git fetch && GIT_SSH_COMMAND="ssh -i ~/ray_autoscaler_key.pem" git checkout `cat /tmp/path` | ||
| - cd ray && git fetch eugene_upstream && git checkout add_ars && git pull |
| - [Documentation](https://berkeleyflow.readthedocs.org/en/latest/) | ||
| - [Installation instructions](http://berkeleyflow.readthedocs.io/en/latest/flow_setup.html) | ||
| - [Tutorial](http://berkeleyflow.readthedocs.io/en/latest/tutorial.html) | ||
| - [Tutorials](https://github.com/berkeleyflow/flow/tree/master/tutorials) |
There was a problem hiding this comment.
What's happening here?
There was a problem hiding this comment.
we're linking to the tutorials page on github instead of the old tutorial which is outdated and has been deleted
eugenevinitsky
left a comment
There was a problem hiding this comment.
LGTM. Really nice work on the test environments
eugene has commented on cathy's concerns
fixing name concatenation bug
No description provided.