Skip to content

Examples fix - #25

Merged
eugenevinitsky merged 6 commits into
masterfrom
examples_fix
Aug 16, 2018
Merged

Examples fix#25
eugenevinitsky merged 6 commits into
masterfrom
examples_fix

Conversation

@AboudyKreidieh

Copy link
Copy Markdown
Collaborator

prerequisite: #23

  • cleaned up examples and ensured they are all running
  • renamed two_loops_merge_straight -> loop_merge for simplicity
  • renamed TwoLoopMergeEnv -> TwoLoopMergePOEnv for consistency among examples that use the environment

changes originally approved in flow-devel

@AboudyKreidiehAboudyKreidieh mentioned this pull request Aug 10, 2018
Comment threadflow/envs/loop/loop_merges.py Outdated

class TwoLoopsMergeEnv(Env):
class TwoLoopsMergePOEnv(Env):
"""Environment for training cooperative merging behavior in a closed loop

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modify description to indicate that it is partially observed?

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@eugenevinitskyeugenevinitsky left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eugenevinitsky
eugenevinitsky merged commit 442fe1c into masterAug 16, 2018
@eugenevinitsky
eugenevinitsky deleted the examples_fix branch August 16, 2018 16:37
kjang96 pushed a commit to kjang96/flow that referenced this pull request Aug 17, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@AboudyKreidieh@eugenevinitsky