chore(rustsec): update rustls-webpki 0.103.10

[vadim-anfv]

Fixes#276
Fixes#277
Fixes#280

---

Description

Update transitive dependency rustls-webpki from 0.103.10 to 0.103.13 via:

cargo update -p rustls-webpki@0.103.10 --precise 0.103.13

Notes to the reviewers

This does not fix rustls-webpki 0.101.7, pulled in via minreq:

-> % cargo audit
...
Dependency tree:
rustls-webpki 0.101.7
├── rustls 0.21.12
│ └── minreq 2.14.1
│ ├── jsonrpc 0.18.0
│ │ └── bitcoincore-rpc 0.19.0
│ │ └── bdk_bitcoind_rpc 0.21.0
│ │ └── bdk-cli 3.0.0
│ └── esplora-client 0.12.1
│ └── bdk_esplora 0.22.1
│ └── bdk-cli 3.0.0
└── minreq 2.14.1
...

Checklists

All Submissions:

• I've signed all my commits
• I followed the contribution guidelines
• I ran cargo fmt and cargo clippy before committing

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 10.96%. Comparing base (7c33b33) to head (aec0c8a).
⚠️ Report is 113 commits behind head on master.

Additional details and impacted files

@@ Coverage Diff @@## master #281 +/- ##
=======================================
Coverage 10.96% 10.96% =======================================
Files 8 8 Lines 2526 2526 =======================================
Hits 277 277 Misses 2249 2249 

Flag	Coverage Δ
rust	10.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[tvpeter]

ACK aec0c8a

[notmandatory]

Can this be fixed more permanently by updating to (future) releases of esplora-client and a corepc based rpc client that uses bitreq instead of minreq?

bitcoindevkit/rust-esplora-client#136
rust-bitcoin/corepc#399

[vadim-anfv]

Can this be fixed more permanently by updating to (future) releases of esplora-client and a corepc based rpc client that uses bitreq instead of minreq?

I looked into it, current status:

• esplora-client (via bdk_esplora): as you mentioned, esplora-clientalready uses bitreq on master, so we will get the rustls-webpki fix with the next bdk_esplora release.

• bitcoincore-rpc (via bdk_bitcoind_rpc): bdk_bitcoind_rpc 0.21.0usesbitcoincore-rpc, which depends on minreq. rust-bitcoincore-rpc is now archived and points users to corepc-client, so the fix is migrating bdk_bitcoind_rpc to corepc-client.

I'll check whether there's already an issue on bdk for migrating bdk_bitcoind_rpc to corepc-client and open one if not.

[vadim-anfv]

I'll check whether there's already an issue on bdk for migrating bdk_bitcoind_rpc to corepc-client and open one if not.

Status update:

• esplora-client: we will get the rustls-webpki fix with the next bdk_esplora release with esplora-client 0.13.0.
• bdk_bitcoind_rpc: fix lands here once Refactor: update bdk-bitcoind-rpc to use bdk-bitcoind-client bdk#2119 ships in a release.

Both fixes are upstream, no local patching needed.

[vadim-anfv]

The change from this PR is already in master, landed via #242. Rebasing leaves an empty diff.

It only fixed half of the problem though. The 0.103.10 occurrence the issues in the description reported is gone from the lockfile, but cargo audit is still red: the same three advisories are now reported against rustls-webpki 0.101.7, which we pull in through minreq 2.14.1:

$ cargo tree --all-features -i rustls-webpki@0.101.7
rustls-webpki v0.101.7
├── minreq v2.14.1
│ ├── esplora-client v0.12.3
│ │ └── bdk_esplora v0.22.2
│ │ └── bdk-cli v4.0.0 (/home/v/src/bitcoindevkit/bdk-cli)
│ └── jsonrpc v0.18.0
│ └── bitcoincore-rpc v0.19.0
│ ├── bdk_bitcoind_rpc v0.22.0
│ │ └── bdk-cli v4.0.0 (/home/v/src/bitcoindevkit/bdk-cli)
│ └── bitcoind v0.36.1
│ └── electrsd v0.28.0
│ └── bdk_testenv v0.13.1
│ [dev-dependencies]
│ └── bdk-cli v4.0.0 (/home/v/src/bitcoindevkit/bdk-cli)
├── minreq v2.14.1
│ [build-dependencies]
│ ├── bitcoind v0.36.1 (*)
│ └── electrsd v0.28.0 (*)
└── rustls v0.21.12
├── minreq v2.14.1 (*)
└── minreq v2.14.1 (*)

esplora-clientdroppedminreq for bitreq in v0.13.0, but bdk_esplora has not picked up that release yet (bitcoindevkit/bdk#2189).

Closing as superseded by #242, I will open a tracking issue for the bdk_esplora bump.

[vadim-anfv]

Fixes#276
Fixes#277
Fixes#280

---

Description

Update transitive dependency rustls-webpki from 0.103.10 to 0.103.13 via:

cargo update -p rustls-webpki@0.103.10 --precise 0.103.13

Notes to the reviewers

This does not fix rustls-webpki 0.101.7, pulled in via minreq:

-> % cargo audit
...
Dependency tree:
rustls-webpki 0.101.7
├── rustls 0.21.12
│ └── minreq 2.14.1
│ ├── jsonrpc 0.18.0
│ │ └── bitcoincore-rpc 0.19.0
│ │ └── bdk_bitcoind_rpc 0.21.0
│ │ └── bdk-cli 3.0.0
│ └── esplora-client 0.12.1
│ └── bdk_esplora 0.22.1
│ └── bdk-cli 3.0.0
└── minreq 2.14.1
...

Checklists

All Submissions:

• I've signed all my commits
• I followed the contribution guidelines
• I ran cargo fmt and cargo clippy before committing

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 10.96%. Comparing base (7c33b33) to head (aec0c8a).
⚠️ Report is 113 commits behind head on master.

Additional details and impacted files

@@ Coverage Diff @@## master #281 +/- ##
=======================================
Coverage 10.96% 10.96% =======================================
Files 8 8 Lines 2526 2526 =======================================
Hits 277 277 Misses 2249 2249 

Flag	Coverage Δ
rust	10.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[tvpeter]

ACK aec0c8a

[notmandatory]

Can this be fixed more permanently by updating to (future) releases of esplora-client and a corepc based rpc client that uses bitreq instead of minreq?

bitcoindevkit/rust-esplora-client#136
rust-bitcoin/corepc#399

[vadim-anfv]

Can this be fixed more permanently by updating to (future) releases of esplora-client and a corepc based rpc client that uses bitreq instead of minreq?

I looked into it, current status:

• esplora-client (via bdk_esplora): as you mentioned, esplora-clientalready uses bitreq on master, so we will get the rustls-webpki fix with the next bdk_esplora release.

• bitcoincore-rpc (via bdk_bitcoind_rpc): bdk_bitcoind_rpc 0.21.0usesbitcoincore-rpc, which depends on minreq. rust-bitcoincore-rpc is now archived and points users to corepc-client, so the fix is migrating bdk_bitcoind_rpc to corepc-client.

I'll check whether there's already an issue on bdk for migrating bdk_bitcoind_rpc to corepc-client and open one if not.

[vadim-anfv]

I'll check whether there's already an issue on bdk for migrating bdk_bitcoind_rpc to corepc-client and open one if not.

Status update:

• esplora-client: we will get the rustls-webpki fix with the next bdk_esplora release with esplora-client 0.13.0.
• bdk_bitcoind_rpc: fix lands here once Refactor: update bdk-bitcoind-rpc to use bdk-bitcoind-client bdk#2119 ships in a release.

Both fixes are upstream, no local patching needed.

[vadim-anfv]

The change from this PR is already in master, landed via #242. Rebasing leaves an empty diff.

It only fixed half of the problem though. The 0.103.10 occurrence the issues in the description reported is gone from the lockfile, but cargo audit is still red: the same three advisories are now reported against rustls-webpki 0.101.7, which we pull in through minreq 2.14.1:

$ cargo tree --all-features -i rustls-webpki@0.101.7
rustls-webpki v0.101.7
├── minreq v2.14.1
│ ├── esplora-client v0.12.3
│ │ └── bdk_esplora v0.22.2
│ │ └── bdk-cli v4.0.0 (/home/v/src/bitcoindevkit/bdk-cli)
│ └── jsonrpc v0.18.0
│ └── bitcoincore-rpc v0.19.0
│ ├── bdk_bitcoind_rpc v0.22.0
│ │ └── bdk-cli v4.0.0 (/home/v/src/bitcoindevkit/bdk-cli)
│ └── bitcoind v0.36.1
│ └── electrsd v0.28.0
│ └── bdk_testenv v0.13.1
│ [dev-dependencies]
│ └── bdk-cli v4.0.0 (/home/v/src/bitcoindevkit/bdk-cli)
├── minreq v2.14.1
│ [build-dependencies]
│ ├── bitcoind v0.36.1 (*)
│ └── electrsd v0.28.0 (*)
└── rustls v0.21.12
├── minreq v2.14.1 (*)
└── minreq v2.14.1 (*)

esplora-clientdroppedminreq for bitreq in v0.13.0, but bdk_esplora has not picked up that release yet (bitcoindevkit/bdk#2189).

Closing as superseded by #242, I will open a tracking issue for the bdk_esplora bump.

[vadim-anfv]

Fixes#276
Fixes#277
Fixes#280

---

Description

Update transitive dependency rustls-webpki from 0.103.10 to 0.103.13 via:

cargo update -p rustls-webpki@0.103.10 --precise 0.103.13

Notes to the reviewers

This does not fix rustls-webpki 0.101.7, pulled in via minreq:

-> % cargo audit
...
Dependency tree:
rustls-webpki 0.101.7
├── rustls 0.21.12
│ └── minreq 2.14.1
│ ├── jsonrpc 0.18.0
│ │ └── bitcoincore-rpc 0.19.0
│ │ └── bdk_bitcoind_rpc 0.21.0
│ │ └── bdk-cli 3.0.0
│ └── esplora-client 0.12.1
│ └── bdk_esplora 0.22.1
│ └── bdk-cli 3.0.0
└── minreq 2.14.1
...

Checklists

All Submissions:

• I've signed all my commits
• I followed the contribution guidelines
• I ran cargo fmt and cargo clippy before committing

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 10.96%. Comparing base (7c33b33) to head (aec0c8a).
⚠️ Report is 113 commits behind head on master.

Additional details and impacted files

@@ Coverage Diff @@## master #281 +/- ##
=======================================
Coverage 10.96% 10.96% =======================================
Files 8 8 Lines 2526 2526 =======================================
Hits 277 277 Misses 2249 2249 

Flag	Coverage Δ
rust	10.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[tvpeter]

ACK aec0c8a

[notmandatory]

Can this be fixed more permanently by updating to (future) releases of esplora-client and a corepc based rpc client that uses bitreq instead of minreq?

bitcoindevkit/rust-esplora-client#136
rust-bitcoin/corepc#399

[vadim-anfv]

Can this be fixed more permanently by updating to (future) releases of esplora-client and a corepc based rpc client that uses bitreq instead of minreq?

I looked into it, current status:

• esplora-client (via bdk_esplora): as you mentioned, esplora-clientalready uses bitreq on master, so we will get the rustls-webpki fix with the next bdk_esplora release.

• bitcoincore-rpc (via bdk_bitcoind_rpc): bdk_bitcoind_rpc 0.21.0usesbitcoincore-rpc, which depends on minreq. rust-bitcoincore-rpc is now archived and points users to corepc-client, so the fix is migrating bdk_bitcoind_rpc to corepc-client.

I'll check whether there's already an issue on bdk for migrating bdk_bitcoind_rpc to corepc-client and open one if not.

[vadim-anfv]

I'll check whether there's already an issue on bdk for migrating bdk_bitcoind_rpc to corepc-client and open one if not.

Status update:

• esplora-client: we will get the rustls-webpki fix with the next bdk_esplora release with esplora-client 0.13.0.
• bdk_bitcoind_rpc: fix lands here once Refactor: update bdk-bitcoind-rpc to use bdk-bitcoind-client bdk#2119 ships in a release.

Both fixes are upstream, no local patching needed.

[vadim-anfv]

The change from this PR is already in master, landed via #242. Rebasing leaves an empty diff.

It only fixed half of the problem though. The 0.103.10 occurrence the issues in the description reported is gone from the lockfile, but cargo audit is still red: the same three advisories are now reported against rustls-webpki 0.101.7, which we pull in through minreq 2.14.1:

$ cargo tree --all-features -i rustls-webpki@0.101.7
rustls-webpki v0.101.7
├── minreq v2.14.1
│ ├── esplora-client v0.12.3
│ │ └── bdk_esplora v0.22.2
│ │ └── bdk-cli v4.0.0 (/home/v/src/bitcoindevkit/bdk-cli)
│ └── jsonrpc v0.18.0
│ └── bitcoincore-rpc v0.19.0
│ ├── bdk_bitcoind_rpc v0.22.0
│ │ └── bdk-cli v4.0.0 (/home/v/src/bitcoindevkit/bdk-cli)
│ └── bitcoind v0.36.1
│ └── electrsd v0.28.0
│ └── bdk_testenv v0.13.1
│ [dev-dependencies]
│ └── bdk-cli v4.0.0 (/home/v/src/bitcoindevkit/bdk-cli)
├── minreq v2.14.1
│ [build-dependencies]
│ ├── bitcoind v0.36.1 (*)
│ └── electrsd v0.28.0 (*)
└── rustls v0.21.12
├── minreq v2.14.1 (*)
└── minreq v2.14.1 (*)

esplora-clientdroppedminreq for bitreq in v0.13.0, but bdk_esplora has not picked up that release yet (bitcoindevkit/bdk#2189).

Closing as superseded by #242, I will open a tracking issue for the bdk_esplora bump.

[vadim-anfv]

Fixes#276
Fixes#277
Fixes#280

---

Description

Update transitive dependency rustls-webpki from 0.103.10 to 0.103.13 via:

cargo update -p rustls-webpki@0.103.10 --precise 0.103.13

Notes to the reviewers

This does not fix rustls-webpki 0.101.7, pulled in via minreq:

-> % cargo audit
...
Dependency tree:
rustls-webpki 0.101.7
├── rustls 0.21.12
│ └── minreq 2.14.1
│ ├── jsonrpc 0.18.0
│ │ └── bitcoincore-rpc 0.19.0
│ │ └── bdk_bitcoind_rpc 0.21.0
│ │ └── bdk-cli 3.0.0
│ └── esplora-client 0.12.1
│ └── bdk_esplora 0.22.1
│ └── bdk-cli 3.0.0
└── minreq 2.14.1
...

Checklists

All Submissions:

• I've signed all my commits
• I followed the contribution guidelines
• I ran cargo fmt and cargo clippy before committing

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 10.96%. Comparing base (7c33b33) to head (aec0c8a).
⚠️ Report is 113 commits behind head on master.

Additional details and impacted files

@@ Coverage Diff @@## master #281 +/- ##
=======================================
Coverage 10.96% 10.96% =======================================
Files 8 8 Lines 2526 2526 =======================================
Hits 277 277 Misses 2249 2249 

Flag	Coverage Δ
rust	10.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[tvpeter]

ACK aec0c8a

[notmandatory]

Can this be fixed more permanently by updating to (future) releases of esplora-client and a corepc based rpc client that uses bitreq instead of minreq?

bitcoindevkit/rust-esplora-client#136
rust-bitcoin/corepc#399

[vadim-anfv]

Can this be fixed more permanently by updating to (future) releases of esplora-client and a corepc based rpc client that uses bitreq instead of minreq?

I looked into it, current status:

• esplora-client (via bdk_esplora): as you mentioned, esplora-clientalready uses bitreq on master, so we will get the rustls-webpki fix with the next bdk_esplora release.

• bitcoincore-rpc (via bdk_bitcoind_rpc): bdk_bitcoind_rpc 0.21.0usesbitcoincore-rpc, which depends on minreq. rust-bitcoincore-rpc is now archived and points users to corepc-client, so the fix is migrating bdk_bitcoind_rpc to corepc-client.

I'll check whether there's already an issue on bdk for migrating bdk_bitcoind_rpc to corepc-client and open one if not.

[vadim-anfv]

I'll check whether there's already an issue on bdk for migrating bdk_bitcoind_rpc to corepc-client and open one if not.

Status update:

• esplora-client: we will get the rustls-webpki fix with the next bdk_esplora release with esplora-client 0.13.0.
• bdk_bitcoind_rpc: fix lands here once Refactor: update bdk-bitcoind-rpc to use bdk-bitcoind-client bdk#2119 ships in a release.

Both fixes are upstream, no local patching needed.

[vadim-anfv]

The change from this PR is already in master, landed via #242. Rebasing leaves an empty diff.

It only fixed half of the problem though. The 0.103.10 occurrence the issues in the description reported is gone from the lockfile, but cargo audit is still red: the same three advisories are now reported against rustls-webpki 0.101.7, which we pull in through minreq 2.14.1:

$ cargo tree --all-features -i rustls-webpki@0.101.7
rustls-webpki v0.101.7
├── minreq v2.14.1
│ ├── esplora-client v0.12.3
│ │ └── bdk_esplora v0.22.2
│ │ └── bdk-cli v4.0.0 (/home/v/src/bitcoindevkit/bdk-cli)
│ └── jsonrpc v0.18.0
│ └── bitcoincore-rpc v0.19.0
│ ├── bdk_bitcoind_rpc v0.22.0
│ │ └── bdk-cli v4.0.0 (/home/v/src/bitcoindevkit/bdk-cli)
│ └── bitcoind v0.36.1
│ └── electrsd v0.28.0
│ └── bdk_testenv v0.13.1
│ [dev-dependencies]
│ └── bdk-cli v4.0.0 (/home/v/src/bitcoindevkit/bdk-cli)
├── minreq v2.14.1
│ [build-dependencies]
│ ├── bitcoind v0.36.1 (*)
│ └── electrsd v0.28.0 (*)
└── rustls v0.21.12
├── minreq v2.14.1 (*)
└── minreq v2.14.1 (*)

esplora-clientdroppedminreq for bitreq in v0.13.0, but bdk_esplora has not picked up that release yet (bitcoindevkit/bdk#2189).

Closing as superseded by #242, I will open a tracking issue for the bdk_esplora bump.

[vadim-anfv]

Fixes#276
Fixes#277
Fixes#280

---

Description

Update transitive dependency rustls-webpki from 0.103.10 to 0.103.13 via:

cargo update -p rustls-webpki@0.103.10 --precise 0.103.13

Notes to the reviewers

This does not fix rustls-webpki 0.101.7, pulled in via minreq:

-> % cargo audit
...
Dependency tree:
rustls-webpki 0.101.7
├── rustls 0.21.12
│ └── minreq 2.14.1
│ ├── jsonrpc 0.18.0
│ │ └── bitcoincore-rpc 0.19.0
│ │ └── bdk_bitcoind_rpc 0.21.0
│ │ └── bdk-cli 3.0.0
│ └── esplora-client 0.12.1
│ └── bdk_esplora 0.22.1
│ └── bdk-cli 3.0.0
└── minreq 2.14.1
...

Checklists

All Submissions:

• I've signed all my commits
• I followed the contribution guidelines
• I ran cargo fmt and cargo clippy before committing

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 10.96%. Comparing base (7c33b33) to head (aec0c8a).
⚠️ Report is 113 commits behind head on master.

Additional details and impacted files

@@ Coverage Diff @@## master #281 +/- ##
=======================================
Coverage 10.96% 10.96% =======================================
Files 8 8 Lines 2526 2526 =======================================
Hits 277 277 Misses 2249 2249 

Flag	Coverage Δ
rust	10.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[tvpeter]

ACK aec0c8a

[notmandatory]

Can this be fixed more permanently by updating to (future) releases of esplora-client and a corepc based rpc client that uses bitreq instead of minreq?

bitcoindevkit/rust-esplora-client#136
rust-bitcoin/corepc#399

[vadim-anfv]

Can this be fixed more permanently by updating to (future) releases of esplora-client and a corepc based rpc client that uses bitreq instead of minreq?

I looked into it, current status:

• esplora-client (via bdk_esplora): as you mentioned, esplora-clientalready uses bitreq on master, so we will get the rustls-webpki fix with the next bdk_esplora release.

• bitcoincore-rpc (via bdk_bitcoind_rpc): bdk_bitcoind_rpc 0.21.0usesbitcoincore-rpc, which depends on minreq. rust-bitcoincore-rpc is now archived and points users to corepc-client, so the fix is migrating bdk_bitcoind_rpc to corepc-client.

I'll check whether there's already an issue on bdk for migrating bdk_bitcoind_rpc to corepc-client and open one if not.

[vadim-anfv]

I'll check whether there's already an issue on bdk for migrating bdk_bitcoind_rpc to corepc-client and open one if not.

Status update:

• esplora-client: we will get the rustls-webpki fix with the next bdk_esplora release with esplora-client 0.13.0.
• bdk_bitcoind_rpc: fix lands here once Refactor: update bdk-bitcoind-rpc to use bdk-bitcoind-client bdk#2119 ships in a release.

Both fixes are upstream, no local patching needed.

[vadim-anfv]

The change from this PR is already in master, landed via #242. Rebasing leaves an empty diff.

It only fixed half of the problem though. The 0.103.10 occurrence the issues in the description reported is gone from the lockfile, but cargo audit is still red: the same three advisories are now reported against rustls-webpki 0.101.7, which we pull in through minreq 2.14.1:

$ cargo tree --all-features -i rustls-webpki@0.101.7
rustls-webpki v0.101.7
├── minreq v2.14.1
│ ├── esplora-client v0.12.3
│ │ └── bdk_esplora v0.22.2
│ │ └── bdk-cli v4.0.0 (/home/v/src/bitcoindevkit/bdk-cli)
│ └── jsonrpc v0.18.0
│ └── bitcoincore-rpc v0.19.0
│ ├── bdk_bitcoind_rpc v0.22.0
│ │ └── bdk-cli v4.0.0 (/home/v/src/bitcoindevkit/bdk-cli)
│ └── bitcoind v0.36.1
│ └── electrsd v0.28.0
│ └── bdk_testenv v0.13.1
│ [dev-dependencies]
│ └── bdk-cli v4.0.0 (/home/v/src/bitcoindevkit/bdk-cli)
├── minreq v2.14.1
│ [build-dependencies]
│ ├── bitcoind v0.36.1 (*)
│ └── electrsd v0.28.0 (*)
└── rustls v0.21.12
├── minreq v2.14.1 (*)
└── minreq v2.14.1 (*)

esplora-clientdroppedminreq for bitreq in v0.13.0, but bdk_esplora has not picked up that release yet (bitcoindevkit/bdk#2189).

Closing as superseded by #242, I will open a tracking issue for the bdk_esplora bump.

[vadim-anfv]

Fixes#276
Fixes#277
Fixes#280

---

Description

Update transitive dependency rustls-webpki from 0.103.10 to 0.103.13 via:

cargo update -p rustls-webpki@0.103.10 --precise 0.103.13

Notes to the reviewers

This does not fix rustls-webpki 0.101.7, pulled in via minreq:

-> % cargo audit
...
Dependency tree:
rustls-webpki 0.101.7
├── rustls 0.21.12
│ └── minreq 2.14.1
│ ├── jsonrpc 0.18.0
│ │ └── bitcoincore-rpc 0.19.0
│ │ └── bdk_bitcoind_rpc 0.21.0
│ │ └── bdk-cli 3.0.0
│ └── esplora-client 0.12.1
│ └── bdk_esplora 0.22.1
│ └── bdk-cli 3.0.0
└── minreq 2.14.1
...

Checklists

All Submissions:

• I've signed all my commits
• I followed the contribution guidelines
• I ran cargo fmt and cargo clippy before committing

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 10.96%. Comparing base (7c33b33) to head (aec0c8a).
⚠️ Report is 113 commits behind head on master.

Additional details and impacted files

@@ Coverage Diff @@## master #281 +/- ##
=======================================
Coverage 10.96% 10.96% =======================================
Files 8 8 Lines 2526 2526 =======================================
Hits 277 277 Misses 2249 2249 

Flag	Coverage Δ
rust	10.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[tvpeter]

ACK aec0c8a

[notmandatory]

Can this be fixed more permanently by updating to (future) releases of esplora-client and a corepc based rpc client that uses bitreq instead of minreq?

bitcoindevkit/rust-esplora-client#136
rust-bitcoin/corepc#399

[vadim-anfv]

Can this be fixed more permanently by updating to (future) releases of esplora-client and a corepc based rpc client that uses bitreq instead of minreq?

I looked into it, current status:

• esplora-client (via bdk_esplora): as you mentioned, esplora-clientalready uses bitreq on master, so we will get the rustls-webpki fix with the next bdk_esplora release.

• bitcoincore-rpc (via bdk_bitcoind_rpc): bdk_bitcoind_rpc 0.21.0usesbitcoincore-rpc, which depends on minreq. rust-bitcoincore-rpc is now archived and points users to corepc-client, so the fix is migrating bdk_bitcoind_rpc to corepc-client.

I'll check whether there's already an issue on bdk for migrating bdk_bitcoind_rpc to corepc-client and open one if not.

[vadim-anfv]

I'll check whether there's already an issue on bdk for migrating bdk_bitcoind_rpc to corepc-client and open one if not.

Status update:

• esplora-client: we will get the rustls-webpki fix with the next bdk_esplora release with esplora-client 0.13.0.
• bdk_bitcoind_rpc: fix lands here once Refactor: update bdk-bitcoind-rpc to use bdk-bitcoind-client bdk#2119 ships in a release.

Both fixes are upstream, no local patching needed.

[vadim-anfv]

The change from this PR is already in master, landed via #242. Rebasing leaves an empty diff.

It only fixed half of the problem though. The 0.103.10 occurrence the issues in the description reported is gone from the lockfile, but cargo audit is still red: the same three advisories are now reported against rustls-webpki 0.101.7, which we pull in through minreq 2.14.1:

$ cargo tree --all-features -i rustls-webpki@0.101.7
rustls-webpki v0.101.7
├── minreq v2.14.1
│ ├── esplora-client v0.12.3
│ │ └── bdk_esplora v0.22.2
│ │ └── bdk-cli v4.0.0 (/home/v/src/bitcoindevkit/bdk-cli)
│ └── jsonrpc v0.18.0
│ └── bitcoincore-rpc v0.19.0
│ ├── bdk_bitcoind_rpc v0.22.0
│ │ └── bdk-cli v4.0.0 (/home/v/src/bitcoindevkit/bdk-cli)
│ └── bitcoind v0.36.1
│ └── electrsd v0.28.0
│ └── bdk_testenv v0.13.1
│ [dev-dependencies]
│ └── bdk-cli v4.0.0 (/home/v/src/bitcoindevkit/bdk-cli)
├── minreq v2.14.1
│ [build-dependencies]
│ ├── bitcoind v0.36.1 (*)
│ └── electrsd v0.28.0 (*)
└── rustls v0.21.12
├── minreq v2.14.1 (*)
└── minreq v2.14.1 (*)

esplora-clientdroppedminreq for bitreq in v0.13.0, but bdk_esplora has not picked up that release yet (bitcoindevkit/bdk#2189).

Closing as superseded by #242, I will open a tracking issue for the bdk_esplora bump.

[vadim-anfv]

Fixes#276
Fixes#277
Fixes#280

---

Description

Update transitive dependency rustls-webpki from 0.103.10 to 0.103.13 via:

cargo update -p rustls-webpki@0.103.10 --precise 0.103.13

Notes to the reviewers

This does not fix rustls-webpki 0.101.7, pulled in via minreq:

-> % cargo audit
...
Dependency tree:
rustls-webpki 0.101.7
├── rustls 0.21.12
│ └── minreq 2.14.1
│ ├── jsonrpc 0.18.0
│ │ └── bitcoincore-rpc 0.19.0
│ │ └── bdk_bitcoind_rpc 0.21.0
│ │ └── bdk-cli 3.0.0
│ └── esplora-client 0.12.1
│ └── bdk_esplora 0.22.1
│ └── bdk-cli 3.0.0
└── minreq 2.14.1
...

Checklists

All Submissions:

• I've signed all my commits
• I followed the contribution guidelines
• I ran cargo fmt and cargo clippy before committing

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 10.96%. Comparing base (7c33b33) to head (aec0c8a).
⚠️ Report is 113 commits behind head on master.

Additional details and impacted files

@@ Coverage Diff @@## master #281 +/- ##
=======================================
Coverage 10.96% 10.96% =======================================
Files 8 8 Lines 2526 2526 =======================================
Hits 277 277 Misses 2249 2249 

Flag	Coverage Δ
rust	10.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[tvpeter]

ACK aec0c8a

[notmandatory]

Can this be fixed more permanently by updating to (future) releases of esplora-client and a corepc based rpc client that uses bitreq instead of minreq?

bitcoindevkit/rust-esplora-client#136
rust-bitcoin/corepc#399

[vadim-anfv]

Can this be fixed more permanently by updating to (future) releases of esplora-client and a corepc based rpc client that uses bitreq instead of minreq?

I looked into it, current status:

• esplora-client (via bdk_esplora): as you mentioned, esplora-clientalready uses bitreq on master, so we will get the rustls-webpki fix with the next bdk_esplora release.

• bitcoincore-rpc (via bdk_bitcoind_rpc): bdk_bitcoind_rpc 0.21.0usesbitcoincore-rpc, which depends on minreq. rust-bitcoincore-rpc is now archived and points users to corepc-client, so the fix is migrating bdk_bitcoind_rpc to corepc-client.

I'll check whether there's already an issue on bdk for migrating bdk_bitcoind_rpc to corepc-client and open one if not.

[vadim-anfv]

I'll check whether there's already an issue on bdk for migrating bdk_bitcoind_rpc to corepc-client and open one if not.

Status update:

• esplora-client: we will get the rustls-webpki fix with the next bdk_esplora release with esplora-client 0.13.0.
• bdk_bitcoind_rpc: fix lands here once Refactor: update bdk-bitcoind-rpc to use bdk-bitcoind-client bdk#2119 ships in a release.

Both fixes are upstream, no local patching needed.

[vadim-anfv]

The change from this PR is already in master, landed via #242. Rebasing leaves an empty diff.

It only fixed half of the problem though. The 0.103.10 occurrence the issues in the description reported is gone from the lockfile, but cargo audit is still red: the same three advisories are now reported against rustls-webpki 0.101.7, which we pull in through minreq 2.14.1:

$ cargo tree --all-features -i rustls-webpki@0.101.7
rustls-webpki v0.101.7
├── minreq v2.14.1
│ ├── esplora-client v0.12.3
│ │ └── bdk_esplora v0.22.2
│ │ └── bdk-cli v4.0.0 (/home/v/src/bitcoindevkit/bdk-cli)
│ └── jsonrpc v0.18.0
│ └── bitcoincore-rpc v0.19.0
│ ├── bdk_bitcoind_rpc v0.22.0
│ │ └── bdk-cli v4.0.0 (/home/v/src/bitcoindevkit/bdk-cli)
│ └── bitcoind v0.36.1
│ └── electrsd v0.28.0
│ └── bdk_testenv v0.13.1
│ [dev-dependencies]
│ └── bdk-cli v4.0.0 (/home/v/src/bitcoindevkit/bdk-cli)
├── minreq v2.14.1
│ [build-dependencies]
│ ├── bitcoind v0.36.1 (*)
│ └── electrsd v0.28.0 (*)
└── rustls v0.21.12
├── minreq v2.14.1 (*)
└── minreq v2.14.1 (*)

esplora-clientdroppedminreq for bitreq in v0.13.0, but bdk_esplora has not picked up that release yet (bitcoindevkit/bdk#2189).

Closing as superseded by #242, I will open a tracking issue for the bdk_esplora bump.

[vadim-anfv]

Fixes#276
Fixes#277
Fixes#280

---

Description

Update transitive dependency rustls-webpki from 0.103.10 to 0.103.13 via:

cargo update -p rustls-webpki@0.103.10 --precise 0.103.13

Notes to the reviewers

This does not fix rustls-webpki 0.101.7, pulled in via minreq:

-> % cargo audit
...
Dependency tree:
rustls-webpki 0.101.7
├── rustls 0.21.12
│ └── minreq 2.14.1
│ ├── jsonrpc 0.18.0
│ │ └── bitcoincore-rpc 0.19.0
│ │ └── bdk_bitcoind_rpc 0.21.0
│ │ └── bdk-cli 3.0.0
│ └── esplora-client 0.12.1
│ └── bdk_esplora 0.22.1
│ └── bdk-cli 3.0.0
└── minreq 2.14.1
...

Checklists

All Submissions:

• I've signed all my commits
• I followed the contribution guidelines
• I ran cargo fmt and cargo clippy before committing

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 10.96%. Comparing base (7c33b33) to head (aec0c8a).
⚠️ Report is 113 commits behind head on master.

Additional details and impacted files

@@ Coverage Diff @@## master #281 +/- ##
=======================================
Coverage 10.96% 10.96% =======================================
Files 8 8 Lines 2526 2526 =======================================
Hits 277 277 Misses 2249 2249 

Flag	Coverage Δ
rust	10.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[tvpeter]

ACK aec0c8a

[notmandatory]

Can this be fixed more permanently by updating to (future) releases of esplora-client and a corepc based rpc client that uses bitreq instead of minreq?

bitcoindevkit/rust-esplora-client#136
rust-bitcoin/corepc#399

[vadim-anfv]

Can this be fixed more permanently by updating to (future) releases of esplora-client and a corepc based rpc client that uses bitreq instead of minreq?

I looked into it, current status:

• esplora-client (via bdk_esplora): as you mentioned, esplora-clientalready uses bitreq on master, so we will get the rustls-webpki fix with the next bdk_esplora release.

• bitcoincore-rpc (via bdk_bitcoind_rpc): bdk_bitcoind_rpc 0.21.0usesbitcoincore-rpc, which depends on minreq. rust-bitcoincore-rpc is now archived and points users to corepc-client, so the fix is migrating bdk_bitcoind_rpc to corepc-client.

I'll check whether there's already an issue on bdk for migrating bdk_bitcoind_rpc to corepc-client and open one if not.

[vadim-anfv]

I'll check whether there's already an issue on bdk for migrating bdk_bitcoind_rpc to corepc-client and open one if not.

Status update:

• esplora-client: we will get the rustls-webpki fix with the next bdk_esplora release with esplora-client 0.13.0.
• bdk_bitcoind_rpc: fix lands here once Refactor: update bdk-bitcoind-rpc to use bdk-bitcoind-client bdk#2119 ships in a release.

Both fixes are upstream, no local patching needed.

[vadim-anfv]

The change from this PR is already in master, landed via #242. Rebasing leaves an empty diff.

It only fixed half of the problem though. The 0.103.10 occurrence the issues in the description reported is gone from the lockfile, but cargo audit is still red: the same three advisories are now reported against rustls-webpki 0.101.7, which we pull in through minreq 2.14.1:

$ cargo tree --all-features -i rustls-webpki@0.101.7
rustls-webpki v0.101.7
├── minreq v2.14.1
│ ├── esplora-client v0.12.3
│ │ └── bdk_esplora v0.22.2
│ │ └── bdk-cli v4.0.0 (/home/v/src/bitcoindevkit/bdk-cli)
│ └── jsonrpc v0.18.0
│ └── bitcoincore-rpc v0.19.0
│ ├── bdk_bitcoind_rpc v0.22.0
│ │ └── bdk-cli v4.0.0 (/home/v/src/bitcoindevkit/bdk-cli)
│ └── bitcoind v0.36.1
│ └── electrsd v0.28.0
│ └── bdk_testenv v0.13.1
│ [dev-dependencies]
│ └── bdk-cli v4.0.0 (/home/v/src/bitcoindevkit/bdk-cli)
├── minreq v2.14.1
│ [build-dependencies]
│ ├── bitcoind v0.36.1 (*)
│ └── electrsd v0.28.0 (*)
└── rustls v0.21.12
├── minreq v2.14.1 (*)
└── minreq v2.14.1 (*)

esplora-clientdroppedminreq for bitreq in v0.13.0, but bdk_esplora has not picked up that release yet (bitcoindevkit/bdk#2189).

Closing as superseded by #242, I will open a tracking issue for the bdk_esplora bump.