Skip to content

test(browser): settle startup catch-up before request baselines - #43

Merged
wesbillman merged 1 commit into
mainfrom
carl/ci-startup-races
Sep 13, 2026
Merged

wesbillman merged 1 commit into
mainfrom
carl/ci-startup-races

Conversation

@wesbillman

Copy link
Copy Markdown
Collaborator

Summary

  • Make sidebar unread request accounting wait for the forced-late Alpha catch-up before measuring cue-triggered traffic.
  • Make channel-opening warm-cache measurements wait for an exact signed missed message to reach each channel’s mounted UI before capturing the no-new-head baseline.
  • Preserve strict request-count, focus/read-state, and <100ms warm-paint assertions. Only two tests change; no production code, fixture machinery, retries or relaxed thresholds.

Validation

At base 834433c580d8e36a8ae9cd9da5695d1166604b94 plus the two-test patch, on Apple Silicon macOS:

  • Controlled old ordering fails the intended assertion in both Chromium and WebKit for each race.
  • Sidebar entire test file: 30/30 pass across three repetitions in both engines.
  • Channel-opening entire test file: 6/6 pass across three repetitions in both engines.
  • Full browser diagnostic sweep: 288 passed, 2 failed (26.4 minutes). Both modified files passed. Chromium failures in unchanged typeahead.spec.mjs: rejected replacement yielded an empty draft at line 353; retry option absent at line 741. Causes unresolved, not dismissed as flakes. No retries used.
  • Independent source review of the exact patch found no material defects.
  • Whole-repository scan and hosted checks not established yet. Channel-opening WebKit remains documented local-only coverage; Chromium retains CI coverage.
  • Published head: e212e00eb915bac57001387361c53e84cfff00ad. The normal pre-commit hook made formatting-only line-wrap/trailing-comma changes to channel-opening after the browser runs; those runs cover the pre-format manifest, not the final bytes. Pre-commit passed; pre-push passed its selector and reported no JS unit-test inputs changed. No hook bypass.
  • Carl authorship and Signed-off-by verified for the single PR commit. Main advanced to d587700 after local validation; the patch remains based on 834433c, so merge-result validation is deferred to hosted checks.

Separate findings, not fixed here

The historical presence-publication 503 belongs to PR #39’s implementation, absent from this base. Historical terminal fixture loading also showed Vite 504 Outdated Optimize Dep; the terminal cases passed this diagnostic run, which does not disprove that failure. Neither issue is hidden with a console-error allow-list or claimed repaired by this patch.

Signed-off-by: Carl <32a2e2c9d428ee08902cab75d956da2c1d235a22d4766b0dd4138bf6e2e5db1d@buzz.block.builderlab.xyz>
@wesbillman
wesbillman marked this pull request as ready for review September 13, 2026 14:37
@wesbillman
wesbillman merged commit 61274d4 into main Sep 13, 2026
11 checks passed
@wesbillman
wesbillman deleted the carl/ci-startup-races branch September 13, 2026 14:45
delkc added a commit that referenced this pull request Sep 14, 2026
* origin/main:
  fix(messages): prevent native WebKit prepend blanking (#49)
  feat: add shared browser and standard desktop notifications (#38)
  Prevent whole-window scroll bounce (#41)
  test: replace timing races with explicit lifecycle barriers (#45)
  test(browser): isolate fixture optimizer caches (#46)
  test(browser): settle startup catch-up before request baselines (#43)
  feat(messages): show message-carried blurhash before decoded originals (#40)
  Add a shared full-page surface (#29)
  fix(messages): prevent image-driven timeline scroll snap-back (#31)
  Restore grouped channel membership activity (#30)
  feat: add broker-backed Agent Activity panel (#36)

Signed-off-by: Clay Delk <clay.delk@gmail.com>

# Conflicts:
#	src/bundled/channels/ChannelsPage.tsx
#	src/features/messages/ChannelTimeline.tsx
#	src/features/messages/MessageRow.tsx
#	src/features/relay/contracts.ts
#	src/features/relay/fold.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant