Skip to content

test(browser): isolate fixture optimizer caches - #46

Merged
wesbillman merged 2 commits into
mainfrom
brain/fixture-cache-isolation
Sep 13, 2026
Merged

wesbillman merged 2 commits into
mainfrom
brain/fixture-cache-isolation

Conversation

@wesbillman

Copy link
Copy Markdown
Collaborator

Summary

Small prerequisite split from #39; no production changes.

  • Give nine existing Vite fixture consumers an individually owned temporary optimizer cache.
  • Preserve cleanup through listen/page setup and earlier teardown failures.
  • Keep browser assertions, timing budgets and zero retries unchanged.
  • Make the existing contributor scope-growth checkpoint explicit.

Why

PR39's failed WebKit job
left the terminal fixture blank after three module imports returned 504 Outdated Optimize Dep.
These fixture servers shared Vite's default optimizer directory. This fixes cache ownership;
it does not add retries or suppress module errors. It is independent of presence implementation.

Validation

At 4ec53255a41498caa7e8bec705e252a7a219b929, all 64 Chromium/WebKit journeys
in the nine changed fixture files pass with two workers and no retries.
Checks/type checks and the three Node cache-ownership tests passed on the exact extracted patch.
Independent review verified extraction against the reviewed combined patch.

On an isolated copy of that combined patch, twelve mutations were caught: shared-cache reuse,
lost cleanup, and bypassing the helper in each of ten consumers (the extra consumer is
presence.spec.mjs, which stays in #39). This proves ownership regression detection, not that
we deterministically reproduced which CI server invalidated which optimized import.

Hosted CI and required approval remain separate gates. No native/runtime production change.

Origin: presence-sensing channel 2128346d-ae35-4e44-98f7-5f278fe7b60d.

Brain and others added 2 commits September 13, 2026 09:48
Give concurrent fixture servers separate temporary caches and preserve close ownership through setup/cleanup failure. Keep assertions, timing budgets and zero retries unchanged. Record the scope-growth checkpoint before extending shared systems.

Signed-off-by: Brain <1a02c72794dcd0f07058a353bc3a81f4028b8c77c92c87fce6d5c8b85970a20b@buzz.block.builderlab.xyz>
Signed-off-by: Pinky <5f5ab050ec58ae208332edd544ebf705221e24c1b86d82a6ca07038a7a8f6ac9@buzz.block.builderlab.xyz>
(cherry picked from commit 597cd93)
Signed-off-by: Brain <1a02c72794dcd0f07058a353bc3a81f4028b8c77c92c87fce6d5c8b85970a20b@buzz.block.builderlab.xyz>

@wesbillman wesbillman left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Carl, an automated reviewer, commenting via Wes’s GitHub account.

No material code findings at abc257755f27ee944c4de2fa7de449dc20d150d7, against 61274d40e0171cae4ef519021370345e18b884d3.

  • Reviewed the cache helper, all nine consumer migrations, setup/teardown ownership, test discovery and the observer-test clock freeze. Unique cache ownership is enforced at creation; cleanup follows Vite shutdown and survives earlier teardown failures. Browser assertions, timing budgets, retries and production behavior are unchanged.
  • Exact-head hosted checks are green, including both browser engines and Node/Vitest coverage. Independent source-review lanes found no material regressions. No local suites were rerun. The reported 64-journey local run belongs to the cache commit 4ec53255; the later head adds only the test clock freeze.
  • Validation boundary: this is not an attestation of a full local just scan. The PR body reports focused local validation, not that full gate; the three documented local-only WebKit cases remain outside hosted CI. Keep the repository's remaining local-gate requirement or explicit owner exception separate from this code verdict. Required human approval is also separate; this comment is not an approval.

@wesbillman
wesbillman merged commit a67102a into main Sep 13, 2026
11 checks passed
@wesbillman
wesbillman deleted the brain/fixture-cache-isolation branch September 13, 2026 16:23
delkc added a commit that referenced this pull request Sep 14, 2026
* origin/main:
  fix(messages): prevent native WebKit prepend blanking (#49)
  feat: add shared browser and standard desktop notifications (#38)
  Prevent whole-window scroll bounce (#41)
  test: replace timing races with explicit lifecycle barriers (#45)
  test(browser): isolate fixture optimizer caches (#46)
  test(browser): settle startup catch-up before request baselines (#43)
  feat(messages): show message-carried blurhash before decoded originals (#40)
  Add a shared full-page surface (#29)
  fix(messages): prevent image-driven timeline scroll snap-back (#31)
  Restore grouped channel membership activity (#30)
  feat: add broker-backed Agent Activity panel (#36)

Signed-off-by: Clay Delk <clay.delk@gmail.com>

# Conflicts:
#	src/bundled/channels/ChannelsPage.tsx
#	src/features/messages/ChannelTimeline.tsx
#	src/features/messages/MessageRow.tsx
#	src/features/relay/contracts.ts
#	src/features/relay/fold.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant