Skip to content

Avoid session sidecars for in-memory storage - #8

Closed
bmehta001 wants to merge 1 commit into
mainfrom
bhamehta/avoid-in-memory-session-sidecar
Closed

bmehta001 wants to merge 1 commit into
mainfrom
bhamehta/avoid-in-memory-session-sidecar

Conversation

@bmehta001

@bmehta001 bmehta001 commented Sep 14, 2026

Copy link
Copy Markdown
Owner

Summary

  • treat SQLite's :memory: cache path as non-file-backed for session data
  • prevent creation or deletion attempts for a physical :memory:.ses sidecar
  • add regression coverage for create, reset, and delete

Borrowed from the fix in microsoft/onnxruntime#32538, where ONNX Runtime currently carries this as a dependency patch.

Validation

  • WSL/Ubuntu 24.04: LogSessionDataFuncTests.* (5/5 passed)
  • Windows/Visual Studio 2026: changed production and test translation units compile; the existing functional-test target then fails to link on unresolved AITelemetrySystem because Azure Monitor headers are auto-detected while its implementation is not linked
  • git diff --check
  • clang-format 20.1.8 on changed line ranges

Treat SQLite's :memory: cache path as non-file-backed so telemetry fallback does not leave a physical .ses file in the working directory.

Files changed:
- lib/offline/LogSessionDataProvider.cpp
- tests/functests/LogSessionDataFuncTests.cpp

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: f2382f49-919c-48fe-b04f-5c2b9b2c744c
@bmehta001

Copy link
Copy Markdown
Owner Author

Superseded by microsoft#1535.

@bmehta001 bmehta001 closed this Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant