Conversation
Treat SQLite's :memory: cache path as non-file-backed so telemetry fallback does not leave a physical .ses file in the working directory. Files changed: - lib/offline/LogSessionDataProvider.cpp - tests/functests/LogSessionDataFuncTests.cpp Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f2382f49-919c-48fe-b04f-5c2b9b2c744c
Generate ephemeral session metadata when SQLite uses :memory: so session events remain valid without creating a sidecar file. Files changed: - lib/offline/LogSessionDataProvider.cpp - tests/functests/LogSessionDataFuncTests.cpp Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f2382f49-919c-48fe-b04f-5c2b9b2c744c
Contributor
Author
|
Fixed the cross-platform LoggerTests.LogSession_CanEventPropertiesBeSentReturnsTrue_CallsSubmit failure in 89ebcc5. The :memory: path now generates ephemeral session timestamp/UID values while still suppressing the .ses sidecar. The exact failing unit test and the strengthened in-memory sidecar functional test pass on both Visual Studio 2026 and WSL. |
Reference the cache path directly after removing the local inMemory variable, restoring compilation across all native targets. Files changed: - lib/offline/LogSessionDataProvider.cpp Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f2382f49-919c-48fe-b04f-5c2b9b2c744c
…y-session-sidecar
Adapt legacy SQLite targets produced by older CMake FindSQLite3 modules and stop Android setup from requesting the removed tools package. Files changed: - .github/workflows/build-android.yml - .github/workflows/codeql-analysis.yml - cmake/MSTelemetryConfig.cmake.in - cmake/MatsdkDependencyTargets.cmake Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f2382f49-919c-48fe-b04f-5c2b9b2c744c
Contributor
Author
|
Merged #1532 and fixed the two deterministic CI regressions from its new main state in 6bc46bf: older CMake FindSQLite3 modules are adapted from SQLite::SQLite3 to SQLite3::SQLite3, and Android setup no longer requests the removed SDK ools package. Local validation: installed system-package consumer 10/10 on CMake 3.28; focused session tests pass on Visual Studio 2026. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:memory:cache path as non-file-backed for session data:memory:.sessidecarBorrowed from the fix in microsoft/onnxruntime#32538, where ONNX Runtime currently carries this as a dependency patch. This upstreams the behavior so consumers can receive it without maintaining a local patch.
Validation
LogSessionDataFuncTests.*(5/5 passed)AITelemetrySystembecause Azure Monitor headers are auto-detected while its implementation is not linkedgit diff --check