Skip to content

improve code coverage, found and fixed a few bugs - #53

Merged
jeking3 merged 1 commit into
boostorg:developfrom
jeking3:coverage
Nov 1, 2017
Merged

improve code coverage, found and fixed a few bugs#53
jeking3 merged 1 commit into
boostorg:developfrom
jeking3:coverage

Conversation

@jeking3

@jeking3jeking3 commented Nov 1, 2017

Copy link
Copy Markdown
Collaborator

Got parser up to 99.7% code coverage, a significant improvement. Found three issues along the way:

  1. Using %1$T in "don't throw" mode would throw an unhandled exception.
  2. The parser allowed for a number to follow an asterisk, for example %1$*4.*5d.
  3. The examples were not actually executed to verify they are successful.

Apologies for the whitespace cleanup applied by my editor (geany).

@jeking3jeking3 added the bug label Nov 1, 2017
@jeking3jeking3 added this to the v1.66.0 milestone Nov 1, 2017
@jeking3jeking3 self-assigned this Nov 1, 2017
@codecov

codecovBot commented Nov 1, 2017

Copy link
Copy Markdown

Codecov Report

Merging #53 into develop will increase coverage by 8.21%.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@## develop #53 +/- ##
===========================================
+ Coverage 79.59% 87.81% +8.21% 
===========================================
Files 10 10 Lines 799 886 +87 ===========================================
+ Hits 636 778 +142 + Misses 163 108 -55
Impacted FilesCoverage Δ
include/boost/format/parsing.hpp97.3% <100%> (+14.52%)⬆️
include/boost/format/format_class.hpp100% <0%> (ø)⬆️
include/boost/format/group.hpp100% <0%> (ø)⬆️
include/boost/format/alt_sstream.hpp100% <0%> (ø)⬆️
include/boost/format/alt_sstream_impl.hpp42.64% <0%> (+0.71%)⬆️
include/boost/format/feed_args.hpp96.74% <0%> (+0.81%)⬆️
include/boost/format/format_implementation.hpp92.41% <0%> (+1.67%)⬆️
include/boost/format/internals.hpp89.47% <0%> (+5.75%)⬆️
include/boost/format/free_funcs.hpp94.11% <0%> (+17.64%)⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ed06cf...50ba112. Read the comment docs.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@jeking3