Skip to content

Add appveyor and travis CI configuration files for future pull requests - #30

Closed
jeking3 wants to merge 1 commit into
boostorg:developfrom
jeking3:ci
Closed

Add appveyor and travis CI configuration files for future pull requests#30
jeking3 wants to merge 1 commit into
boostorg:developfrom
jeking3:ci

Conversation

@jeking3

@jeking3jeking3 commented Oct 8, 2017

Copy link
Copy Markdown
Contributor

Results

Appveyor: https://ci.appveyor.com/project/jeking3/random/build/1.0.18-develop
Travis: https://travis-ci.org/jeking3/random/builds/286190652

Known Issues

The following builds are commented out because of issues in this or other modules:

ticketmoduleissue
trac-13248randomtest_hyperexponential_distribution fails in debug builds on travis CI osx any xcode level
trac-13249testcygwin build on appveyor fails attempting to use linux calls (still an issue in 1.66.0 with cygwin on appveyor)
trac-13255testmingw build on appveyor uses undefined vsnprintf
github-270buildcannot use mingw or gcc toolset to build mingw on windows

These should be investigated, fixed, and tests re-enabled.

Maintainer Follow-Up

To activate these changes, the maintainer of Boost.Random would need to request admin access on github, travis, and appveyor so that they can enable automatic builds on pull requests to the official repository.

I would also recommend a README.md should also be added similar to Boost.Uuid that allows for inspection of the current build status of master and develop branches.

@jeking3
jeking3force-pushed the ci branch 5 times, most recently from b71a0a9 to b6e5115CompareOctober 10, 2017 19:24
@jeking3

Copy link
Copy Markdown
ContributorAuthor

@swatanabe this is ready to merge, and following that if you need any assistance getting the builds running for PRs in the boostorg account, let me know. I may put a document together on it.

@jeking3

Copy link
Copy Markdown
ContributorAuthor

@swatanabe anything else you need me to do in order to get this merged?

@jeking3

Copy link
Copy Markdown
ContributorAuthor

This can evolve to codecov.io support, check out the cool integration they have:

boostorg/format#53

@jeking3jeking3 mentioned this pull request Nov 3, 2017
@jeking3

Copy link
Copy Markdown
ContributorAuthor

@swatanabe anything else you need me to do in order to get this merged?

@swatanabe

swatanabe commented Dec 6, 2017 via email

Copy link
Copy Markdown
Collaborator

@jeking3

Copy link
Copy Markdown
ContributorAuthor

I'm confused - you don't want to enable folks submitting pull requests into Boost.Random to be able to self-verify their changes are somewhat decent before a code review? These changes are not just for you, but also to help folks submit higher quality code on their own.

@jeking3
jeking3force-pushed the ci branch 2 times, most recently from 4359256 to 702d280CompareDecember 7, 2017 16:07
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jeking3@swatanabe