Uh oh!
There was an error while loading. Please reload this page.
feat: added apply_rasterizer() free function - #695
Conversation
Codecov Report
@@ Coverage Diff @@## develop #695 +/- ##
===========================================
+ Coverage 80.69% 80.75% +0.05%
===========================================
Files 116 116 Lines 5072 5086 +14 ===========================================
+ Hits 4093 4107 +14
Misses 979 979 |
mloskot
commented
Jun 27, 2022
The rasterizers have not been released yet, so we are not breaking anything, IMO. |
* develop: docs!: Announce plan to require C++17 after Boost 1.80 (#694) feat: Added apply_rasterizer() free function (#695) refactor: Ellipse rasterizer according to the comment at (#692) refactor: Deprecate apply_operation in favor of variant2::visit for any_image (#656) refactor: Replace deprecated libtiff v4.3 typedefs with C99 fixed-size integers (#685) fix: Automatic detection of <filesystem> header (#684) test: Add tiled TIFF test case to simple_all_formats test: Add tests for RGB to HSL (#691) refactor: Move RGB to HSL tests to color_convert_rgb.cpp refactor: Make with_tolerance reusable across other tests chore: Correct include guard fix: Add missing #include <array> fix: Wrong RGB -> HSL convertion (#505)
| draw_curve(view, pixel, center, obtain_trajectory(semi_axes)); | ||
| draw_curve(view, obtain_trajectory()); |
There was a problem hiding this comment.
@marco-langer AFAICT, this draw_curve(view, obtain_trajectory()); invocation is not correct as the draw_curve still takes 3 arguments: view, pixel and trajectory_points.
The CI jobs for this PR were green though. It looks like this part is not covered by tests.
It will fail during compilation of example/rasterizer_ellipse.cpp though.
There was a problem hiding this comment.
I will fix it and also add test cases
Description
This PR implements the
gil::apply_rasterizer()free function mentioned in #680.However, I had to change the API of all three rasterizers quite considerably in order to squeeze them through this common interface. I am not sure if all those API changes are still debatable if we consider the deadline for Boost 1.80 in three days on 29th of June.
If you look at the updated examples, the usability is improved considerable (in my opinion) and it is still worth it (in my opinion) to discuss the PR, but I also understand that it might be too late for these kind of major API changes.
References
#680
Tasklist