Skip to content

fix: broken build for midpoint_ellipse_rasterizer::draw_curve - #705

Merged
mloskot merged 2 commits into
boostorg:developfrom
marco-langer:fix-apply-rasterizer
Jul 4, 2022
Merged

fix: broken build for midpoint_ellipse_rasterizer::draw_curve#705
mloskot merged 2 commits into
boostorg:developfrom
marco-langer:fix-apply-rasterizer

Conversation

@marco-langer

@marco-langermarco-langer commented Jul 2, 2022•
edited by mloskot
Loading

Copy link
Copy Markdown
Contributor

Description

This PR fixes a bug in midpoint_ellipse_rasterizer::draw_curve(), which I have introduced in my other PR while working on the apply_rasterizer function. I have also added missing test cases to cover these invocations.

Tasklist

  • Add test case(s)
  • Ensure all CI builds pass
  • Review and approve

@codecov

codecovBot commented Jul 2, 2022•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #705 (ce61114) into develop (233dc53) will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## develop #705 +/- ##
===========================================
+ Coverage 80.97% 81.10% +0.13% 
===========================================
Files 116 117 +1 Lines 5130 5171 +41 ===========================================
+ Hits 4154 4194 +40 - Misses 976 977 +1

@mloskotmloskot added this to the Boost 1.80 milestone Jul 2, 2022
@mloskotmloskot added the ext/rasterization boost/gil/extension/rasterization label Jul 2, 2022
mloskot
mloskot reviewed Jul 2, 2022
View reviewed changes
Comment threadtest/extension/rasterization/line.cpp Outdated
@marco-langer
marco-langerforce-pushed the fix-apply-rasterizer branch from daa1fa1 to ce61114CompareJuly 2, 2022 15:40
@mloskot
mloskot merged commit 573ba13 into boostorg:developJul 4, 2022
mloskot added a commit that referenced this pull request Jul 4, 2022
@mloskot
Merge branch 'develop'
4306a66
* develop:
fix: broken build for midpoint_ellipse_rasterizer::draw_curve (#705)
docs: fixed gradient tutorial (#703)
fix: Unused variable warning (#704)
@mloskotmloskot mentioned this pull request Jul 5, 2022
Closed
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mloskotmloskotmloskot approved these changes

Assignees

No one assigned

Labels

ext/rasterizationboost/gil/extension/rasterization

Projects

None yet

Milestone

Boost 1.80

Development

Successfully merging this pull request may close these issues.

2 participants

@marco-langer@mloskot