Skip to content

Add config push (backup to repo) task - #244

Merged
bubacoder merged 1 commit into
mainfrom
feature/backup
Dec 8, 2025
Merged

Add config push (backup to repo) task#244
bubacoder merged 1 commit into
mainfrom
feature/backup

Conversation

@bubacoder

@bubacoder bubacoder commented Dec 8, 2025

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • New Features

    • Enhanced backup workflow to include automatic synchronization and pushing of configuration repository changes.
  • Refactor

    • Reorganized backup-related operations with improved naming conventions for clarity.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitai Bot commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

The changes rename three Obsidian repository management tasks for improved naming clarity and introduce a new push-config-repo task. The backup workflow is restructured to execute the new task followed by the renamed vault backup task, replacing the previous repo-backup invocation.

Changes

Cohort / File(s) Summary
Task workflow restructuring
Taskfile.yaml
Added new push-config-repo task that commits and pushes config repository changes with conditional git operations. Modified backup task to replace obsidian:repo-backup with sequential execution of push-config-repo and obsidian:backup-vault-repo.
Task renaming and reference updates
docker/tools/Taskfile.obsidian.yaml
Renamed three tasks: repo-syncsync-vault-repo, repo-commitpush-vault-repo, repo-backupbackup-vault-repo. Updated internal task references within backup-vault-repo to use new task names. Minor formatting: added single quotes around REPO_PATH in error messages.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • Verify the conditional logic in the new push-config-repo task (git add, commit only if changes exist, push only if origin is configured)
  • Confirm all task name references are updated consistently across both files
  • Validate the new backup workflow sequence produces the intended behavior

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: adding a new push-config-repo task that commits and pushes config repository changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/backup

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ac77003 and a1150e0.

📒 Files selected for processing (2)
  • Taskfile.yaml (2 hunks)
  • docker/tools/Taskfile.obsidian.yaml (3 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{yaml,yml}

📄 CodeRabbit inference engine (AGENTS.md)

YAML files must pass YAML linting and validation

Files:

  • docker/tools/Taskfile.obsidian.yaml
  • Taskfile.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: check
🔇 Additional comments (3)
Taskfile.yaml (2)

167-178: Confirm the backup workflow sequence is intentional.

The backup task now executes push-config-repo before obsidian:backup-vault-repo, changing the sequence from the previous vault-focused flow. This decouples the config git operations from the vault operations, which provides clearer separation of concerns. Verify this ordering aligns with your backup strategy—particularly whether pushing config changes should precede vault synchronization.


141-164: Taskfile.yaml passes YAML linting and the push-config-repo task logic is sound.

The push-config-repo task implements proper error handling: validates the config directory and .git folder existence, conditionally commits only if changes exist, and conditionally pushes only if an origin remote is configured. The implementation is consistent with similar patterns in Taskfile.obsidian.yaml.

docker/tools/Taskfile.obsidian.yaml (1)

1-52: YAML linting passes and task name migration is complete.

The file passes YAML validation. All references to old task names (repo-sync, repo-commit, repo-backup) have been fully updated throughout the codebase—no orphaned references remain. The task renames (repo-sync → sync-vault-repo, repo-commit → push-vault-repo, repo-backup → backup-vault-repo) are consistently applied within the file, and the error-handling patterns match those in Taskfile.yaml. The backup-vault-repo task cleanly delegates to sync-vault-repo and push-vault-repo, which is a good architectural improvement.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bubacoder
bubacoder merged commit 39cd34f into main Dec 8, 2025
4 checks passed
@bubacoder
bubacoder deleted the feature/backup branch December 8, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant