Move obsidian:push-vault-repo task content to the vault repo, config sync - #344
Conversation
Walkthrough
ChangesTaskfile Push Task Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docker/Taskfile.obsidian.yaml`:
- Line 4: The OBSIDIAN_VAULT_NAME variable is set to ".." which resolves to the
parent directory instead of the actual vault repository location. Given that
STORAGE_OBSIDIAN points to the obsidian directory, the current relative path
causes VAULT_PATH to resolve outside the intended Obsidian directory structure.
Change the OBSIDIAN_VAULT_NAME value from ".." to the correct relative path that
properly targets the vault repository itself (likely "." or another appropriate
path depending on your vault structure). Apply this same fix at line 24 where
the same issue exists.
- Around line 16-17: Replace the bash-specific `source` command with the
POSIX-compatible `.` operator in the environment file sourcing statements.
Change both occurrences in lines 16 and 17 where `source config/docker/.env`
should become `. config/docker/.env` and `source config/docker/localhost/.env`
should become `. config/docker/localhost/.env`. This ensures the Task file
remains compatible across different shell interpreters that may not support the
Bash-specific `source` syntax.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: de66cea2-aded-4c86-8fc6-71831c4b9cfb
📒 Files selected for processing (2)
Taskfile.yamldocker/Taskfile.obsidian.yaml
Summary by CodeRabbit