fix(desktop): exclude opposite-arch Darwin node-pty prebuild from mac packages by buluma · Pull Request #53 · buluma/helmcode

buluma · 2026-09-02T23:17:30Z

node-pty ships prebuilt pty.node/spawn-helper binaries for both darwin-x64 and darwin-arm64 in the same package. A single-architecture mac build only ever loads its own arch's prebuild, but electron-builder's static files list had no way to know that, so the opposite-arch prebuild rode along and macOS flagged the arm64 app as containing Intel-only nested binaries.

Adds resolveMacFileExclusions(arch) and threads arch into createBuildConfig, scoped to platform === "mac" — universal builds (and any caller that omits arch) keep both prebuilds, unchanged from before.

Ported from pingdotgg/t3code#9240.

Windows ships the same opposite-arch bloat (win32-x64/win32-arm64) but that's out of scope for this PR.

Testing

vp test run scripts/build-desktop-artifact.test.ts — 32/32 pass, including two new tests covering the resolver and the wired-through createBuildConfig output
tsc --noEmit on scripts, vp lint — both clean

Summary by CodeRabbit

Bug Fixes
- Improved macOS desktop builds by excluding incompatible node-pty binaries for the selected architecture.
- Added support for correct exclusions in universal macOS builds.
- Increased verification of architecture-specific file lists and signed macOS build configurations.

… packages node-pty ships prebuilt pty.node/spawn-helper binaries for both darwin-x64 and darwin-arm64 in the same package. A single-architecture mac build only loads its own arch's prebuild, but electron-builder's static files list had no way to know that, so the opposite-arch prebuild rode along and macOS flagged the arm64 app as containing Intel-only nested binaries. Add resolveMacFileExclusions(arch), thread arch into createBuildConfig, and scope the exclusion to platform === "mac" so universal builds (and any caller that omits arch) keep both prebuilds unchanged. Windows ships the same opposite-arch bloat but is out of scope here. Ported from pingdotgg/t3code#9240.

coderabbitai · 2026-09-02T23:19:57Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: f9c666d6-2160-43b3-b33c-4b22afef4e63

📥 Commits

Reviewing files that changed from the base of the PR and between 3c9cf9c and 214d89c.

📒 Files selected for processing (2)

scripts/build-desktop-artifact.test.ts
scripts/build-desktop-artifact.ts

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.

📝 Walkthrough

Walkthrough

The desktop build configuration now accepts an architecture and excludes opposite-architecture macOS node-pty prebuilds. Tests cover arm64, x64, universal macOS builds, and existing signed, Linux, and Windows configurations.

Changes

Desktop artifact architecture handling

Layer / File(s)	Summary
Architecture-specific exclusion resolution `scripts/build-desktop-artifact.ts`	`createBuildConfig` now receives the target architecture and appends the matching macOS `node-pty` exclusion. Staged builds pass `options.arch`.
Configuration and integration tests `scripts/build-desktop-artifact.test.ts`	Tests verify opposite-architecture exclusions for arm64 and x64 builds, no architecture-specific exclusions for universal builds, and explicit architectures for other build configurations.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk:⚪ Minimal · up to 214d8

The change narrowly excludes opposite-architecture Darwin binaries from single-architecture macOS packages while preserving universal-build behavior; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the primary change: excluding opposite-architecture Darwin node-pty prebuilds from macOS packages.
Description check	✅ Passed	The description clearly explains what changed, why it changed, the scope limits, and the test results. It omits the template headings and checklist, but it provides the required information and remain…
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description clearly explains what changed, why it changed, the scope limits, and the test results. It omits the template headings and checklist, but it provides the required information and remains focused.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/desktop-mac-node-pty-arch-exclusion

_{Comment @coderabbitai help to get the list of available commands.}

buluma · 2026-09-02T23:17:30Z

node-pty ships prebuilt pty.node/spawn-helper binaries for both darwin-x64 and darwin-arm64 in the same package. A single-architecture mac build only ever loads its own arch's prebuild, but electron-builder's static files list had no way to know that, so the opposite-arch prebuild rode along and macOS flagged the arm64 app as containing Intel-only nested binaries.

Adds resolveMacFileExclusions(arch) and threads arch into createBuildConfig, scoped to platform === "mac" — universal builds (and any caller that omits arch) keep both prebuilds, unchanged from before.

Ported from pingdotgg/t3code#9240.

Windows ships the same opposite-arch bloat (win32-x64/win32-arm64) but that's out of scope for this PR.

Testing

vp test run scripts/build-desktop-artifact.test.ts — 32/32 pass, including two new tests covering the resolver and the wired-through createBuildConfig output
tsc --noEmit on scripts, vp lint — both clean

Summary by CodeRabbit

Bug Fixes
- Improved macOS desktop builds by excluding incompatible node-pty binaries for the selected architecture.
- Added support for correct exclusions in universal macOS builds.
- Increased verification of architecture-specific file lists and signed macOS build configurations.

… packages node-pty ships prebuilt pty.node/spawn-helper binaries for both darwin-x64 and darwin-arm64 in the same package. A single-architecture mac build only loads its own arch's prebuild, but electron-builder's static files list had no way to know that, so the opposite-arch prebuild rode along and macOS flagged the arm64 app as containing Intel-only nested binaries. Add resolveMacFileExclusions(arch), thread arch into createBuildConfig, and scope the exclusion to platform === "mac" so universal builds (and any caller that omits arch) keep both prebuilds unchanged. Windows ships the same opposite-arch bloat but is out of scope here. Ported from pingdotgg/t3code#9240.

coderabbitai · 2026-09-02T23:19:57Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: f9c666d6-2160-43b3-b33c-4b22afef4e63

📥 Commits

Reviewing files that changed from the base of the PR and between 3c9cf9c and 214d89c.

📒 Files selected for processing (2)

scripts/build-desktop-artifact.test.ts
scripts/build-desktop-artifact.ts

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.

📝 Walkthrough

Walkthrough

The desktop build configuration now accepts an architecture and excludes opposite-architecture macOS node-pty prebuilds. Tests cover arm64, x64, universal macOS builds, and existing signed, Linux, and Windows configurations.

Changes

Desktop artifact architecture handling

Layer / File(s)	Summary
Architecture-specific exclusion resolution `scripts/build-desktop-artifact.ts`	`createBuildConfig` now receives the target architecture and appends the matching macOS `node-pty` exclusion. Staged builds pass `options.arch`.
Configuration and integration tests `scripts/build-desktop-artifact.test.ts`	Tests verify opposite-architecture exclusions for arm64 and x64 builds, no architecture-specific exclusions for universal builds, and explicit architectures for other build configurations.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk:⚪ Minimal · up to 214d8

The change narrowly excludes opposite-architecture Darwin binaries from single-architecture macOS packages while preserving universal-build behavior; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the primary change: excluding opposite-architecture Darwin node-pty prebuilds from macOS packages.
Description check	✅ Passed	The description clearly explains what changed, why it changed, the scope limits, and the test results. It omits the template headings and checklist, but it provides the required information and remain…
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description clearly explains what changed, why it changed, the scope limits, and the test results. It omits the template headings and checklist, but it provides the required information and remains focused.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/desktop-mac-node-pty-arch-exclusion

_{Comment @coderabbitai help to get the list of available commands.}

buluma · 2026-09-02T23:17:30Z

node-pty ships prebuilt pty.node/spawn-helper binaries for both darwin-x64 and darwin-arm64 in the same package. A single-architecture mac build only ever loads its own arch's prebuild, but electron-builder's static files list had no way to know that, so the opposite-arch prebuild rode along and macOS flagged the arm64 app as containing Intel-only nested binaries.

Adds resolveMacFileExclusions(arch) and threads arch into createBuildConfig, scoped to platform === "mac" — universal builds (and any caller that omits arch) keep both prebuilds, unchanged from before.

Ported from pingdotgg/t3code#9240.

Windows ships the same opposite-arch bloat (win32-x64/win32-arm64) but that's out of scope for this PR.

Testing

vp test run scripts/build-desktop-artifact.test.ts — 32/32 pass, including two new tests covering the resolver and the wired-through createBuildConfig output
tsc --noEmit on scripts, vp lint — both clean

Summary by CodeRabbit

Bug Fixes
- Improved macOS desktop builds by excluding incompatible node-pty binaries for the selected architecture.
- Added support for correct exclusions in universal macOS builds.
- Increased verification of architecture-specific file lists and signed macOS build configurations.

… packages node-pty ships prebuilt pty.node/spawn-helper binaries for both darwin-x64 and darwin-arm64 in the same package. A single-architecture mac build only loads its own arch's prebuild, but electron-builder's static files list had no way to know that, so the opposite-arch prebuild rode along and macOS flagged the arm64 app as containing Intel-only nested binaries. Add resolveMacFileExclusions(arch), thread arch into createBuildConfig, and scope the exclusion to platform === "mac" so universal builds (and any caller that omits arch) keep both prebuilds unchanged. Windows ships the same opposite-arch bloat but is out of scope here. Ported from pingdotgg/t3code#9240.

coderabbitai · 2026-09-02T23:19:57Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: f9c666d6-2160-43b3-b33c-4b22afef4e63

📥 Commits

Reviewing files that changed from the base of the PR and between 3c9cf9c and 214d89c.

📒 Files selected for processing (2)

scripts/build-desktop-artifact.test.ts
scripts/build-desktop-artifact.ts

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.

📝 Walkthrough

Walkthrough

The desktop build configuration now accepts an architecture and excludes opposite-architecture macOS node-pty prebuilds. Tests cover arm64, x64, universal macOS builds, and existing signed, Linux, and Windows configurations.

Changes

Desktop artifact architecture handling

Layer / File(s)	Summary
Architecture-specific exclusion resolution `scripts/build-desktop-artifact.ts`	`createBuildConfig` now receives the target architecture and appends the matching macOS `node-pty` exclusion. Staged builds pass `options.arch`.
Configuration and integration tests `scripts/build-desktop-artifact.test.ts`	Tests verify opposite-architecture exclusions for arm64 and x64 builds, no architecture-specific exclusions for universal builds, and explicit architectures for other build configurations.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk:⚪ Minimal · up to 214d8

The change narrowly excludes opposite-architecture Darwin binaries from single-architecture macOS packages while preserving universal-build behavior; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the primary change: excluding opposite-architecture Darwin node-pty prebuilds from macOS packages.
Description check	✅ Passed	The description clearly explains what changed, why it changed, the scope limits, and the test results. It omits the template headings and checklist, but it provides the required information and remain…
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description clearly explains what changed, why it changed, the scope limits, and the test results. It omits the template headings and checklist, but it provides the required information and remains focused.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/desktop-mac-node-pty-arch-exclusion

_{Comment @coderabbitai help to get the list of available commands.}

buluma · 2026-09-02T23:17:30Z

node-pty ships prebuilt pty.node/spawn-helper binaries for both darwin-x64 and darwin-arm64 in the same package. A single-architecture mac build only ever loads its own arch's prebuild, but electron-builder's static files list had no way to know that, so the opposite-arch prebuild rode along and macOS flagged the arm64 app as containing Intel-only nested binaries.

Adds resolveMacFileExclusions(arch) and threads arch into createBuildConfig, scoped to platform === "mac" — universal builds (and any caller that omits arch) keep both prebuilds, unchanged from before.

Ported from pingdotgg/t3code#9240.

Windows ships the same opposite-arch bloat (win32-x64/win32-arm64) but that's out of scope for this PR.

Testing

vp test run scripts/build-desktop-artifact.test.ts — 32/32 pass, including two new tests covering the resolver and the wired-through createBuildConfig output
tsc --noEmit on scripts, vp lint — both clean

Summary by CodeRabbit

Bug Fixes
- Improved macOS desktop builds by excluding incompatible node-pty binaries for the selected architecture.
- Added support for correct exclusions in universal macOS builds.
- Increased verification of architecture-specific file lists and signed macOS build configurations.

… packages node-pty ships prebuilt pty.node/spawn-helper binaries for both darwin-x64 and darwin-arm64 in the same package. A single-architecture mac build only loads its own arch's prebuild, but electron-builder's static files list had no way to know that, so the opposite-arch prebuild rode along and macOS flagged the arm64 app as containing Intel-only nested binaries. Add resolveMacFileExclusions(arch), thread arch into createBuildConfig, and scope the exclusion to platform === "mac" so universal builds (and any caller that omits arch) keep both prebuilds unchanged. Windows ships the same opposite-arch bloat but is out of scope here. Ported from pingdotgg/t3code#9240.

coderabbitai · 2026-09-02T23:19:57Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: f9c666d6-2160-43b3-b33c-4b22afef4e63

📥 Commits

Reviewing files that changed from the base of the PR and between 3c9cf9c and 214d89c.

📒 Files selected for processing (2)

scripts/build-desktop-artifact.test.ts
scripts/build-desktop-artifact.ts

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.

📝 Walkthrough

Walkthrough

The desktop build configuration now accepts an architecture and excludes opposite-architecture macOS node-pty prebuilds. Tests cover arm64, x64, universal macOS builds, and existing signed, Linux, and Windows configurations.

Changes

Desktop artifact architecture handling

Layer / File(s)	Summary
Architecture-specific exclusion resolution `scripts/build-desktop-artifact.ts`	`createBuildConfig` now receives the target architecture and appends the matching macOS `node-pty` exclusion. Staged builds pass `options.arch`.
Configuration and integration tests `scripts/build-desktop-artifact.test.ts`	Tests verify opposite-architecture exclusions for arm64 and x64 builds, no architecture-specific exclusions for universal builds, and explicit architectures for other build configurations.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk:⚪ Minimal · up to 214d8

The change narrowly excludes opposite-architecture Darwin binaries from single-architecture macOS packages while preserving universal-build behavior; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the primary change: excluding opposite-architecture Darwin node-pty prebuilds from macOS packages.
Description check	✅ Passed	The description clearly explains what changed, why it changed, the scope limits, and the test results. It omits the template headings and checklist, but it provides the required information and remain…
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description clearly explains what changed, why it changed, the scope limits, and the test results. It omits the template headings and checklist, but it provides the required information and remains focused.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/desktop-mac-node-pty-arch-exclusion

_{Comment @coderabbitai help to get the list of available commands.}

buluma · 2026-09-02T23:17:30Z

node-pty ships prebuilt pty.node/spawn-helper binaries for both darwin-x64 and darwin-arm64 in the same package. A single-architecture mac build only ever loads its own arch's prebuild, but electron-builder's static files list had no way to know that, so the opposite-arch prebuild rode along and macOS flagged the arm64 app as containing Intel-only nested binaries.

Adds resolveMacFileExclusions(arch) and threads arch into createBuildConfig, scoped to platform === "mac" — universal builds (and any caller that omits arch) keep both prebuilds, unchanged from before.

Ported from pingdotgg/t3code#9240.

Windows ships the same opposite-arch bloat (win32-x64/win32-arm64) but that's out of scope for this PR.

Testing

vp test run scripts/build-desktop-artifact.test.ts — 32/32 pass, including two new tests covering the resolver and the wired-through createBuildConfig output
tsc --noEmit on scripts, vp lint — both clean

Summary by CodeRabbit

Bug Fixes
- Improved macOS desktop builds by excluding incompatible node-pty binaries for the selected architecture.
- Added support for correct exclusions in universal macOS builds.
- Increased verification of architecture-specific file lists and signed macOS build configurations.

… packages node-pty ships prebuilt pty.node/spawn-helper binaries for both darwin-x64 and darwin-arm64 in the same package. A single-architecture mac build only loads its own arch's prebuild, but electron-builder's static files list had no way to know that, so the opposite-arch prebuild rode along and macOS flagged the arm64 app as containing Intel-only nested binaries. Add resolveMacFileExclusions(arch), thread arch into createBuildConfig, and scope the exclusion to platform === "mac" so universal builds (and any caller that omits arch) keep both prebuilds unchanged. Windows ships the same opposite-arch bloat but is out of scope here. Ported from pingdotgg/t3code#9240.

coderabbitai · 2026-09-02T23:19:57Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: f9c666d6-2160-43b3-b33c-4b22afef4e63

📥 Commits

Reviewing files that changed from the base of the PR and between 3c9cf9c and 214d89c.

📒 Files selected for processing (2)

scripts/build-desktop-artifact.test.ts
scripts/build-desktop-artifact.ts

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.

📝 Walkthrough

Walkthrough

The desktop build configuration now accepts an architecture and excludes opposite-architecture macOS node-pty prebuilds. Tests cover arm64, x64, universal macOS builds, and existing signed, Linux, and Windows configurations.

Changes

Desktop artifact architecture handling

Layer / File(s)	Summary
Architecture-specific exclusion resolution `scripts/build-desktop-artifact.ts`	`createBuildConfig` now receives the target architecture and appends the matching macOS `node-pty` exclusion. Staged builds pass `options.arch`.
Configuration and integration tests `scripts/build-desktop-artifact.test.ts`	Tests verify opposite-architecture exclusions for arm64 and x64 builds, no architecture-specific exclusions for universal builds, and explicit architectures for other build configurations.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk:⚪ Minimal · up to 214d8

The change narrowly excludes opposite-architecture Darwin binaries from single-architecture macOS packages while preserving universal-build behavior; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the primary change: excluding opposite-architecture Darwin node-pty prebuilds from macOS packages.
Description check	✅ Passed	The description clearly explains what changed, why it changed, the scope limits, and the test results. It omits the template headings and checklist, but it provides the required information and remain…
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description clearly explains what changed, why it changed, the scope limits, and the test results. It omits the template headings and checklist, but it provides the required information and remains focused.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/desktop-mac-node-pty-arch-exclusion

_{Comment @coderabbitai help to get the list of available commands.}

buluma · 2026-09-02T23:17:30Z

node-pty ships prebuilt pty.node/spawn-helper binaries for both darwin-x64 and darwin-arm64 in the same package. A single-architecture mac build only ever loads its own arch's prebuild, but electron-builder's static files list had no way to know that, so the opposite-arch prebuild rode along and macOS flagged the arm64 app as containing Intel-only nested binaries.

Adds resolveMacFileExclusions(arch) and threads arch into createBuildConfig, scoped to platform === "mac" — universal builds (and any caller that omits arch) keep both prebuilds, unchanged from before.

Ported from pingdotgg/t3code#9240.

Windows ships the same opposite-arch bloat (win32-x64/win32-arm64) but that's out of scope for this PR.

Testing

vp test run scripts/build-desktop-artifact.test.ts — 32/32 pass, including two new tests covering the resolver and the wired-through createBuildConfig output
tsc --noEmit on scripts, vp lint — both clean

Summary by CodeRabbit

Bug Fixes
- Improved macOS desktop builds by excluding incompatible node-pty binaries for the selected architecture.
- Added support for correct exclusions in universal macOS builds.
- Increased verification of architecture-specific file lists and signed macOS build configurations.

… packages node-pty ships prebuilt pty.node/spawn-helper binaries for both darwin-x64 and darwin-arm64 in the same package. A single-architecture mac build only loads its own arch's prebuild, but electron-builder's static files list had no way to know that, so the opposite-arch prebuild rode along and macOS flagged the arm64 app as containing Intel-only nested binaries. Add resolveMacFileExclusions(arch), thread arch into createBuildConfig, and scope the exclusion to platform === "mac" so universal builds (and any caller that omits arch) keep both prebuilds unchanged. Windows ships the same opposite-arch bloat but is out of scope here. Ported from pingdotgg/t3code#9240.

coderabbitai · 2026-09-02T23:19:57Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: f9c666d6-2160-43b3-b33c-4b22afef4e63

📥 Commits

Reviewing files that changed from the base of the PR and between 3c9cf9c and 214d89c.

📒 Files selected for processing (2)

scripts/build-desktop-artifact.test.ts
scripts/build-desktop-artifact.ts

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.

📝 Walkthrough

Walkthrough

The desktop build configuration now accepts an architecture and excludes opposite-architecture macOS node-pty prebuilds. Tests cover arm64, x64, universal macOS builds, and existing signed, Linux, and Windows configurations.

Changes

Desktop artifact architecture handling

Layer / File(s)	Summary
Architecture-specific exclusion resolution `scripts/build-desktop-artifact.ts`	`createBuildConfig` now receives the target architecture and appends the matching macOS `node-pty` exclusion. Staged builds pass `options.arch`.
Configuration and integration tests `scripts/build-desktop-artifact.test.ts`	Tests verify opposite-architecture exclusions for arm64 and x64 builds, no architecture-specific exclusions for universal builds, and explicit architectures for other build configurations.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk:⚪ Minimal · up to 214d8

The change narrowly excludes opposite-architecture Darwin binaries from single-architecture macOS packages while preserving universal-build behavior; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the primary change: excluding opposite-architecture Darwin node-pty prebuilds from macOS packages.
Description check	✅ Passed	The description clearly explains what changed, why it changed, the scope limits, and the test results. It omits the template headings and checklist, but it provides the required information and remain…
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description clearly explains what changed, why it changed, the scope limits, and the test results. It omits the template headings and checklist, but it provides the required information and remains focused.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/desktop-mac-node-pty-arch-exclusion

_{Comment @coderabbitai help to get the list of available commands.}

buluma · 2026-09-02T23:17:30Z

node-pty ships prebuilt pty.node/spawn-helper binaries for both darwin-x64 and darwin-arm64 in the same package. A single-architecture mac build only ever loads its own arch's prebuild, but electron-builder's static files list had no way to know that, so the opposite-arch prebuild rode along and macOS flagged the arm64 app as containing Intel-only nested binaries.

Adds resolveMacFileExclusions(arch) and threads arch into createBuildConfig, scoped to platform === "mac" — universal builds (and any caller that omits arch) keep both prebuilds, unchanged from before.

Ported from pingdotgg/t3code#9240.

Windows ships the same opposite-arch bloat (win32-x64/win32-arm64) but that's out of scope for this PR.

Testing

vp test run scripts/build-desktop-artifact.test.ts — 32/32 pass, including two new tests covering the resolver and the wired-through createBuildConfig output
tsc --noEmit on scripts, vp lint — both clean

Summary by CodeRabbit

Bug Fixes
- Improved macOS desktop builds by excluding incompatible node-pty binaries for the selected architecture.
- Added support for correct exclusions in universal macOS builds.
- Increased verification of architecture-specific file lists and signed macOS build configurations.

… packages node-pty ships prebuilt pty.node/spawn-helper binaries for both darwin-x64 and darwin-arm64 in the same package. A single-architecture mac build only loads its own arch's prebuild, but electron-builder's static files list had no way to know that, so the opposite-arch prebuild rode along and macOS flagged the arm64 app as containing Intel-only nested binaries. Add resolveMacFileExclusions(arch), thread arch into createBuildConfig, and scope the exclusion to platform === "mac" so universal builds (and any caller that omits arch) keep both prebuilds unchanged. Windows ships the same opposite-arch bloat but is out of scope here. Ported from pingdotgg/t3code#9240.

coderabbitai · 2026-09-02T23:19:57Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: f9c666d6-2160-43b3-b33c-4b22afef4e63

📥 Commits

Reviewing files that changed from the base of the PR and between 3c9cf9c and 214d89c.

📒 Files selected for processing (2)

scripts/build-desktop-artifact.test.ts
scripts/build-desktop-artifact.ts

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.

📝 Walkthrough

Walkthrough

The desktop build configuration now accepts an architecture and excludes opposite-architecture macOS node-pty prebuilds. Tests cover arm64, x64, universal macOS builds, and existing signed, Linux, and Windows configurations.

Changes

Desktop artifact architecture handling

Layer / File(s)	Summary
Architecture-specific exclusion resolution `scripts/build-desktop-artifact.ts`	`createBuildConfig` now receives the target architecture and appends the matching macOS `node-pty` exclusion. Staged builds pass `options.arch`.
Configuration and integration tests `scripts/build-desktop-artifact.test.ts`	Tests verify opposite-architecture exclusions for arm64 and x64 builds, no architecture-specific exclusions for universal builds, and explicit architectures for other build configurations.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk:⚪ Minimal · up to 214d8

The change narrowly excludes opposite-architecture Darwin binaries from single-architecture macOS packages while preserving universal-build behavior; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the primary change: excluding opposite-architecture Darwin node-pty prebuilds from macOS packages.
Description check	✅ Passed	The description clearly explains what changed, why it changed, the scope limits, and the test results. It omits the template headings and checklist, but it provides the required information and remain…
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description clearly explains what changed, why it changed, the scope limits, and the test results. It omits the template headings and checklist, but it provides the required information and remains focused.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/desktop-mac-node-pty-arch-exclusion

_{Comment @coderabbitai help to get the list of available commands.}

buluma · 2026-09-02T23:17:30Z

node-pty ships prebuilt pty.node/spawn-helper binaries for both darwin-x64 and darwin-arm64 in the same package. A single-architecture mac build only ever loads its own arch's prebuild, but electron-builder's static files list had no way to know that, so the opposite-arch prebuild rode along and macOS flagged the arm64 app as containing Intel-only nested binaries.

Adds resolveMacFileExclusions(arch) and threads arch into createBuildConfig, scoped to platform === "mac" — universal builds (and any caller that omits arch) keep both prebuilds, unchanged from before.

Ported from pingdotgg/t3code#9240.

Windows ships the same opposite-arch bloat (win32-x64/win32-arm64) but that's out of scope for this PR.

Testing

vp test run scripts/build-desktop-artifact.test.ts — 32/32 pass, including two new tests covering the resolver and the wired-through createBuildConfig output
tsc --noEmit on scripts, vp lint — both clean

Summary by CodeRabbit

Bug Fixes
- Improved macOS desktop builds by excluding incompatible node-pty binaries for the selected architecture.
- Added support for correct exclusions in universal macOS builds.
- Increased verification of architecture-specific file lists and signed macOS build configurations.

… packages node-pty ships prebuilt pty.node/spawn-helper binaries for both darwin-x64 and darwin-arm64 in the same package. A single-architecture mac build only loads its own arch's prebuild, but electron-builder's static files list had no way to know that, so the opposite-arch prebuild rode along and macOS flagged the arm64 app as containing Intel-only nested binaries. Add resolveMacFileExclusions(arch), thread arch into createBuildConfig, and scope the exclusion to platform === "mac" so universal builds (and any caller that omits arch) keep both prebuilds unchanged. Windows ships the same opposite-arch bloat but is out of scope here. Ported from pingdotgg/t3code#9240.

coderabbitai · 2026-09-02T23:19:57Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: f9c666d6-2160-43b3-b33c-4b22afef4e63

📥 Commits

Reviewing files that changed from the base of the PR and between 3c9cf9c and 214d89c.

📒 Files selected for processing (2)

scripts/build-desktop-artifact.test.ts
scripts/build-desktop-artifact.ts

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.

📝 Walkthrough

Walkthrough

The desktop build configuration now accepts an architecture and excludes opposite-architecture macOS node-pty prebuilds. Tests cover arm64, x64, universal macOS builds, and existing signed, Linux, and Windows configurations.

Changes

Desktop artifact architecture handling

Layer / File(s)	Summary
Architecture-specific exclusion resolution `scripts/build-desktop-artifact.ts`	`createBuildConfig` now receives the target architecture and appends the matching macOS `node-pty` exclusion. Staged builds pass `options.arch`.
Configuration and integration tests `scripts/build-desktop-artifact.test.ts`	Tests verify opposite-architecture exclusions for arm64 and x64 builds, no architecture-specific exclusions for universal builds, and explicit architectures for other build configurations.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk:⚪ Minimal · up to 214d8

The change narrowly excludes opposite-architecture Darwin binaries from single-architecture macOS packages while preserving universal-build behavior; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the primary change: excluding opposite-architecture Darwin node-pty prebuilds from macOS packages.
Description check	✅ Passed	The description clearly explains what changed, why it changed, the scope limits, and the test results. It omits the template headings and checklist, but it provides the required information and remain…
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description clearly explains what changed, why it changed, the scope limits, and the test results. It omits the template headings and checklist, but it provides the required information and remains focused.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/desktop-mac-node-pty-arch-exclusion

_{Comment @coderabbitai help to get the list of available commands.}

github-actionsBot added the size:S label Sep 2, 2026