fix(desktop): exclude opposite macOS pty prebuilds

[extoci]

Problem:
The arm64 macOS artifact includes node-pty darwin-x64 pty.node and spawn-helper files, causing macOS to detect Intel-only nested components.

Fix:
Pass the target architecture into the desktop packaging config and exclude only the opposite Darwin node-pty prebuilds for single-architecture packages. Universal builds retain both architectures, and Intel macOS support remains unchanged.

Tests:

• vp test run scripts/build-desktop-artifact.test.ts — 66 passed
• Targeted formatting and type-aware lint passed
• Exact GitHub arm64 release artifact was independently audited; filtered node-pty tree loaded and spawned /bin/sh successfully on Apple silicon

Bundle impact:
The audited arm64 app loses 101,072 uncompressed bytes (~98.7 KiB). The two entries occupied 31,045 compressed bytes (~30.3 KiB) in the ZIP, plus archive metadata.

Model/harness: GPT-5.6 / Codex harness.

---

Note

Low Risk
Packaging-only change scoped to macOS file exclusions in the desktop artifact script; runtime app logic is unchanged, though misconfigured callers that omit arch would still bundle both prebuilds.

Overview
Single-architecture macOS desktop packages were still shipping both Darwin node-pty prebuilds, which led macOS to treat Intel-only nested binaries as present in arm64 builds.

This PR adds resolveMacFileExclusions, which keeps the existing Windows-related exclusions and, for arm64 or x64 targets, adds an electron-builder exclusion for the non-targetdarwin-* prebuild tree. Universal builds (or callers that omit arch) keep both Darwin prebuilds, matching prior behavior.

The target arch is passed into createBuildConfig from buildDesktopArtifact so staged package.jsonbuild.files uses the resolved list instead of the static MAC_FILE_EXCLUSIONS alone.

^{Reviewed by Cursor Bugbot for commit 2d9596e. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Exclude unused Darwin node-pty prebuilds from single-architecture macOS desktop builds

• Adds resolveMacFileExclusions in build-desktop-artifact.ts which drops the opposite-architecture Darwin node-pty prebuild for single-arch macOS packages and keeps both prebuilds for universal or unspecified builds
• Threads an architecture parameter through createBuildConfig and passes options.arch from buildDesktopArtifact so the exclusion resolver receives the requested target
• Behavioral Change: single-architecture macOS artifacts now ship only the matching Darwin node-pty prebuild instead of both; universal and arch-unspecified builds are unchanged

^{Macroscope summarized 2d9596e.}

[macroscopeapp]

Approvability

Verdict: Approved at 2d9596e

Macroscope's review found this PR approvable — This is a focused macOS packaging fix that removes unused opposite-architecture node-pty binaries from single-architecture artifacts while preserving universal builds and application runtime logic. The change is small, localized, and has no product-default, security, schema, or infrastructure implications.

^{You can add or adjust custom eligibility rules. Learn more.}

Dismissing prior approval to re-evaluate 1ccaa2e

[extoci]

Release Smoke is the only failing required check. It fails before any desktop packaging step while regenerating the temporary lockfile in scripts/release-smoke.ts: ERR_PNPM_UNUSED_PATCH for expo-sharing@57.0.16. The same command reproduces locally from this clean branch, and the PR diff contains no mobile, patch, or lockfile changes; the current registry also resolves expo-sharing 57.0.17, which does not match the existing 57.0.16 patch. I left this PR scoped to the macOS packaging fix. Coded on behalf of me — GPT-5.6 / Codex harness.

[extoci]

Update: I verified the required Release Smoke failure was caused by the existing expo-sharing patch being version-specific while its dependency range allowed 57.0.17. The final PR now includes only a two-line specifier/lockfile alignment to keep the already-patched 57.0.16 behavior; the full smoke script passes locally. Coded on behalf of me — GPT-5.6 / Codex harness.

Dismissing prior approval to re-evaluate 817f596

Dismissing prior approval to re-evaluate 2d9596e

[extoci]

Correction after rebasing onto current main: the Expo Sharing patch/version fix is already present upstream and is no longer part of this PR. The rebased branch now contains only the macOS desktop packaging change (+19/-1); the earlier CI note referred to the pre-rebase state. Coded on behalf of me — GPT-5.6 / Codex harness.

[mackinleysmith]

hey @maria-rcks, do you think we could rebase or cherry pick this into the t3code/rebuild-mobile-app-swift branch so i can get the tests passing on #9071 please? thank you kindly!

[extoci]

Problem:
The arm64 macOS artifact includes node-pty darwin-x64 pty.node and spawn-helper files, causing macOS to detect Intel-only nested components.

Fix:
Pass the target architecture into the desktop packaging config and exclude only the opposite Darwin node-pty prebuilds for single-architecture packages. Universal builds retain both architectures, and Intel macOS support remains unchanged.

Tests:

• vp test run scripts/build-desktop-artifact.test.ts — 66 passed
• Targeted formatting and type-aware lint passed
• Exact GitHub arm64 release artifact was independently audited; filtered node-pty tree loaded and spawned /bin/sh successfully on Apple silicon

Bundle impact:
The audited arm64 app loses 101,072 uncompressed bytes (~98.7 KiB). The two entries occupied 31,045 compressed bytes (~30.3 KiB) in the ZIP, plus archive metadata.

Model/harness: GPT-5.6 / Codex harness.

---

Note

Low Risk
Packaging-only change scoped to macOS file exclusions in the desktop artifact script; runtime app logic is unchanged, though misconfigured callers that omit arch would still bundle both prebuilds.

Overview
Single-architecture macOS desktop packages were still shipping both Darwin node-pty prebuilds, which led macOS to treat Intel-only nested binaries as present in arm64 builds.

This PR adds resolveMacFileExclusions, which keeps the existing Windows-related exclusions and, for arm64 or x64 targets, adds an electron-builder exclusion for the non-targetdarwin-* prebuild tree. Universal builds (or callers that omit arch) keep both Darwin prebuilds, matching prior behavior.

The target arch is passed into createBuildConfig from buildDesktopArtifact so staged package.jsonbuild.files uses the resolved list instead of the static MAC_FILE_EXCLUSIONS alone.

^{Reviewed by Cursor Bugbot for commit 2d9596e. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Exclude unused Darwin node-pty prebuilds from single-architecture macOS desktop builds

• Adds resolveMacFileExclusions in build-desktop-artifact.ts which drops the opposite-architecture Darwin node-pty prebuild for single-arch macOS packages and keeps both prebuilds for universal or unspecified builds
• Threads an architecture parameter through createBuildConfig and passes options.arch from buildDesktopArtifact so the exclusion resolver receives the requested target
• Behavioral Change: single-architecture macOS artifacts now ship only the matching Darwin node-pty prebuild instead of both; universal and arch-unspecified builds are unchanged

^{Macroscope summarized 2d9596e.}

[macroscopeapp]

Approvability

Verdict: Approved at 2d9596e

Macroscope's review found this PR approvable — This is a focused macOS packaging fix that removes unused opposite-architecture node-pty binaries from single-architecture artifacts while preserving universal builds and application runtime logic. The change is small, localized, and has no product-default, security, schema, or infrastructure implications.

^{You can add or adjust custom eligibility rules. Learn more.}

Dismissing prior approval to re-evaluate 1ccaa2e

[extoci]

Release Smoke is the only failing required check. It fails before any desktop packaging step while regenerating the temporary lockfile in scripts/release-smoke.ts: ERR_PNPM_UNUSED_PATCH for expo-sharing@57.0.16. The same command reproduces locally from this clean branch, and the PR diff contains no mobile, patch, or lockfile changes; the current registry also resolves expo-sharing 57.0.17, which does not match the existing 57.0.16 patch. I left this PR scoped to the macOS packaging fix. Coded on behalf of me — GPT-5.6 / Codex harness.

[extoci]

Update: I verified the required Release Smoke failure was caused by the existing expo-sharing patch being version-specific while its dependency range allowed 57.0.17. The final PR now includes only a two-line specifier/lockfile alignment to keep the already-patched 57.0.16 behavior; the full smoke script passes locally. Coded on behalf of me — GPT-5.6 / Codex harness.

Dismissing prior approval to re-evaluate 817f596

Dismissing prior approval to re-evaluate 2d9596e

[extoci]

Correction after rebasing onto current main: the Expo Sharing patch/version fix is already present upstream and is no longer part of this PR. The rebased branch now contains only the macOS desktop packaging change (+19/-1); the earlier CI note referred to the pre-rebase state. Coded on behalf of me — GPT-5.6 / Codex harness.

[mackinleysmith]

hey @maria-rcks, do you think we could rebase or cherry pick this into the t3code/rebuild-mobile-app-swift branch so i can get the tests passing on #9071 please? thank you kindly!

[extoci]

Problem:
The arm64 macOS artifact includes node-pty darwin-x64 pty.node and spawn-helper files, causing macOS to detect Intel-only nested components.

Fix:
Pass the target architecture into the desktop packaging config and exclude only the opposite Darwin node-pty prebuilds for single-architecture packages. Universal builds retain both architectures, and Intel macOS support remains unchanged.

Tests:

• vp test run scripts/build-desktop-artifact.test.ts — 66 passed
• Targeted formatting and type-aware lint passed
• Exact GitHub arm64 release artifact was independently audited; filtered node-pty tree loaded and spawned /bin/sh successfully on Apple silicon

Bundle impact:
The audited arm64 app loses 101,072 uncompressed bytes (~98.7 KiB). The two entries occupied 31,045 compressed bytes (~30.3 KiB) in the ZIP, plus archive metadata.

Model/harness: GPT-5.6 / Codex harness.

---

Note

Low Risk
Packaging-only change scoped to macOS file exclusions in the desktop artifact script; runtime app logic is unchanged, though misconfigured callers that omit arch would still bundle both prebuilds.

Overview
Single-architecture macOS desktop packages were still shipping both Darwin node-pty prebuilds, which led macOS to treat Intel-only nested binaries as present in arm64 builds.

This PR adds resolveMacFileExclusions, which keeps the existing Windows-related exclusions and, for arm64 or x64 targets, adds an electron-builder exclusion for the non-targetdarwin-* prebuild tree. Universal builds (or callers that omit arch) keep both Darwin prebuilds, matching prior behavior.

The target arch is passed into createBuildConfig from buildDesktopArtifact so staged package.jsonbuild.files uses the resolved list instead of the static MAC_FILE_EXCLUSIONS alone.

^{Reviewed by Cursor Bugbot for commit 2d9596e. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Exclude unused Darwin node-pty prebuilds from single-architecture macOS desktop builds

• Adds resolveMacFileExclusions in build-desktop-artifact.ts which drops the opposite-architecture Darwin node-pty prebuild for single-arch macOS packages and keeps both prebuilds for universal or unspecified builds
• Threads an architecture parameter through createBuildConfig and passes options.arch from buildDesktopArtifact so the exclusion resolver receives the requested target
• Behavioral Change: single-architecture macOS artifacts now ship only the matching Darwin node-pty prebuild instead of both; universal and arch-unspecified builds are unchanged

^{Macroscope summarized 2d9596e.}

[macroscopeapp]

Approvability

Verdict: Approved at 2d9596e

Macroscope's review found this PR approvable — This is a focused macOS packaging fix that removes unused opposite-architecture node-pty binaries from single-architecture artifacts while preserving universal builds and application runtime logic. The change is small, localized, and has no product-default, security, schema, or infrastructure implications.

^{You can add or adjust custom eligibility rules. Learn more.}

Dismissing prior approval to re-evaluate 1ccaa2e

[extoci]

Release Smoke is the only failing required check. It fails before any desktop packaging step while regenerating the temporary lockfile in scripts/release-smoke.ts: ERR_PNPM_UNUSED_PATCH for expo-sharing@57.0.16. The same command reproduces locally from this clean branch, and the PR diff contains no mobile, patch, or lockfile changes; the current registry also resolves expo-sharing 57.0.17, which does not match the existing 57.0.16 patch. I left this PR scoped to the macOS packaging fix. Coded on behalf of me — GPT-5.6 / Codex harness.

[extoci]

Update: I verified the required Release Smoke failure was caused by the existing expo-sharing patch being version-specific while its dependency range allowed 57.0.17. The final PR now includes only a two-line specifier/lockfile alignment to keep the already-patched 57.0.16 behavior; the full smoke script passes locally. Coded on behalf of me — GPT-5.6 / Codex harness.

Dismissing prior approval to re-evaluate 817f596

Dismissing prior approval to re-evaluate 2d9596e

[extoci]

Correction after rebasing onto current main: the Expo Sharing patch/version fix is already present upstream and is no longer part of this PR. The rebased branch now contains only the macOS desktop packaging change (+19/-1); the earlier CI note referred to the pre-rebase state. Coded on behalf of me — GPT-5.6 / Codex harness.

[mackinleysmith]

hey @maria-rcks, do you think we could rebase or cherry pick this into the t3code/rebuild-mobile-app-swift branch so i can get the tests passing on #9071 please? thank you kindly!

[extoci]

Problem:
The arm64 macOS artifact includes node-pty darwin-x64 pty.node and spawn-helper files, causing macOS to detect Intel-only nested components.

Fix:
Pass the target architecture into the desktop packaging config and exclude only the opposite Darwin node-pty prebuilds for single-architecture packages. Universal builds retain both architectures, and Intel macOS support remains unchanged.

Tests:

• vp test run scripts/build-desktop-artifact.test.ts — 66 passed
• Targeted formatting and type-aware lint passed
• Exact GitHub arm64 release artifact was independently audited; filtered node-pty tree loaded and spawned /bin/sh successfully on Apple silicon

Bundle impact:
The audited arm64 app loses 101,072 uncompressed bytes (~98.7 KiB). The two entries occupied 31,045 compressed bytes (~30.3 KiB) in the ZIP, plus archive metadata.

Model/harness: GPT-5.6 / Codex harness.

---

Note

Low Risk
Packaging-only change scoped to macOS file exclusions in the desktop artifact script; runtime app logic is unchanged, though misconfigured callers that omit arch would still bundle both prebuilds.

Overview
Single-architecture macOS desktop packages were still shipping both Darwin node-pty prebuilds, which led macOS to treat Intel-only nested binaries as present in arm64 builds.

This PR adds resolveMacFileExclusions, which keeps the existing Windows-related exclusions and, for arm64 or x64 targets, adds an electron-builder exclusion for the non-targetdarwin-* prebuild tree. Universal builds (or callers that omit arch) keep both Darwin prebuilds, matching prior behavior.

The target arch is passed into createBuildConfig from buildDesktopArtifact so staged package.jsonbuild.files uses the resolved list instead of the static MAC_FILE_EXCLUSIONS alone.

^{Reviewed by Cursor Bugbot for commit 2d9596e. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Exclude unused Darwin node-pty prebuilds from single-architecture macOS desktop builds

• Adds resolveMacFileExclusions in build-desktop-artifact.ts which drops the opposite-architecture Darwin node-pty prebuild for single-arch macOS packages and keeps both prebuilds for universal or unspecified builds
• Threads an architecture parameter through createBuildConfig and passes options.arch from buildDesktopArtifact so the exclusion resolver receives the requested target
• Behavioral Change: single-architecture macOS artifacts now ship only the matching Darwin node-pty prebuild instead of both; universal and arch-unspecified builds are unchanged

^{Macroscope summarized 2d9596e.}

[macroscopeapp]

Approvability

Verdict: Approved at 2d9596e

Macroscope's review found this PR approvable — This is a focused macOS packaging fix that removes unused opposite-architecture node-pty binaries from single-architecture artifacts while preserving universal builds and application runtime logic. The change is small, localized, and has no product-default, security, schema, or infrastructure implications.

^{You can add or adjust custom eligibility rules. Learn more.}

Dismissing prior approval to re-evaluate 1ccaa2e

[extoci]

Release Smoke is the only failing required check. It fails before any desktop packaging step while regenerating the temporary lockfile in scripts/release-smoke.ts: ERR_PNPM_UNUSED_PATCH for expo-sharing@57.0.16. The same command reproduces locally from this clean branch, and the PR diff contains no mobile, patch, or lockfile changes; the current registry also resolves expo-sharing 57.0.17, which does not match the existing 57.0.16 patch. I left this PR scoped to the macOS packaging fix. Coded on behalf of me — GPT-5.6 / Codex harness.

[extoci]

Update: I verified the required Release Smoke failure was caused by the existing expo-sharing patch being version-specific while its dependency range allowed 57.0.17. The final PR now includes only a two-line specifier/lockfile alignment to keep the already-patched 57.0.16 behavior; the full smoke script passes locally. Coded on behalf of me — GPT-5.6 / Codex harness.

Dismissing prior approval to re-evaluate 817f596

Dismissing prior approval to re-evaluate 2d9596e

[extoci]

Correction after rebasing onto current main: the Expo Sharing patch/version fix is already present upstream and is no longer part of this PR. The rebased branch now contains only the macOS desktop packaging change (+19/-1); the earlier CI note referred to the pre-rebase state. Coded on behalf of me — GPT-5.6 / Codex harness.

[mackinleysmith]

hey @maria-rcks, do you think we could rebase or cherry pick this into the t3code/rebuild-mobile-app-swift branch so i can get the tests passing on #9071 please? thank you kindly!

[extoci]

Problem:
The arm64 macOS artifact includes node-pty darwin-x64 pty.node and spawn-helper files, causing macOS to detect Intel-only nested components.

Fix:
Pass the target architecture into the desktop packaging config and exclude only the opposite Darwin node-pty prebuilds for single-architecture packages. Universal builds retain both architectures, and Intel macOS support remains unchanged.

Tests:

• vp test run scripts/build-desktop-artifact.test.ts — 66 passed
• Targeted formatting and type-aware lint passed
• Exact GitHub arm64 release artifact was independently audited; filtered node-pty tree loaded and spawned /bin/sh successfully on Apple silicon

Bundle impact:
The audited arm64 app loses 101,072 uncompressed bytes (~98.7 KiB). The two entries occupied 31,045 compressed bytes (~30.3 KiB) in the ZIP, plus archive metadata.

Model/harness: GPT-5.6 / Codex harness.

---

Note

Low Risk
Packaging-only change scoped to macOS file exclusions in the desktop artifact script; runtime app logic is unchanged, though misconfigured callers that omit arch would still bundle both prebuilds.

Overview
Single-architecture macOS desktop packages were still shipping both Darwin node-pty prebuilds, which led macOS to treat Intel-only nested binaries as present in arm64 builds.

This PR adds resolveMacFileExclusions, which keeps the existing Windows-related exclusions and, for arm64 or x64 targets, adds an electron-builder exclusion for the non-targetdarwin-* prebuild tree. Universal builds (or callers that omit arch) keep both Darwin prebuilds, matching prior behavior.

The target arch is passed into createBuildConfig from buildDesktopArtifact so staged package.jsonbuild.files uses the resolved list instead of the static MAC_FILE_EXCLUSIONS alone.

^{Reviewed by Cursor Bugbot for commit 2d9596e. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Exclude unused Darwin node-pty prebuilds from single-architecture macOS desktop builds

• Adds resolveMacFileExclusions in build-desktop-artifact.ts which drops the opposite-architecture Darwin node-pty prebuild for single-arch macOS packages and keeps both prebuilds for universal or unspecified builds
• Threads an architecture parameter through createBuildConfig and passes options.arch from buildDesktopArtifact so the exclusion resolver receives the requested target
• Behavioral Change: single-architecture macOS artifacts now ship only the matching Darwin node-pty prebuild instead of both; universal and arch-unspecified builds are unchanged

^{Macroscope summarized 2d9596e.}

[macroscopeapp]

Approvability

Verdict: Approved at 2d9596e

Macroscope's review found this PR approvable — This is a focused macOS packaging fix that removes unused opposite-architecture node-pty binaries from single-architecture artifacts while preserving universal builds and application runtime logic. The change is small, localized, and has no product-default, security, schema, or infrastructure implications.

^{You can add or adjust custom eligibility rules. Learn more.}

Dismissing prior approval to re-evaluate 1ccaa2e

[extoci]

Release Smoke is the only failing required check. It fails before any desktop packaging step while regenerating the temporary lockfile in scripts/release-smoke.ts: ERR_PNPM_UNUSED_PATCH for expo-sharing@57.0.16. The same command reproduces locally from this clean branch, and the PR diff contains no mobile, patch, or lockfile changes; the current registry also resolves expo-sharing 57.0.17, which does not match the existing 57.0.16 patch. I left this PR scoped to the macOS packaging fix. Coded on behalf of me — GPT-5.6 / Codex harness.

[extoci]

Update: I verified the required Release Smoke failure was caused by the existing expo-sharing patch being version-specific while its dependency range allowed 57.0.17. The final PR now includes only a two-line specifier/lockfile alignment to keep the already-patched 57.0.16 behavior; the full smoke script passes locally. Coded on behalf of me — GPT-5.6 / Codex harness.

Dismissing prior approval to re-evaluate 817f596

Dismissing prior approval to re-evaluate 2d9596e

[extoci]

Correction after rebasing onto current main: the Expo Sharing patch/version fix is already present upstream and is no longer part of this PR. The rebased branch now contains only the macOS desktop packaging change (+19/-1); the earlier CI note referred to the pre-rebase state. Coded on behalf of me — GPT-5.6 / Codex harness.

[mackinleysmith]

hey @maria-rcks, do you think we could rebase or cherry pick this into the t3code/rebuild-mobile-app-swift branch so i can get the tests passing on #9071 please? thank you kindly!

[extoci]

Problem:
The arm64 macOS artifact includes node-pty darwin-x64 pty.node and spawn-helper files, causing macOS to detect Intel-only nested components.

Fix:
Pass the target architecture into the desktop packaging config and exclude only the opposite Darwin node-pty prebuilds for single-architecture packages. Universal builds retain both architectures, and Intel macOS support remains unchanged.

Tests:

• vp test run scripts/build-desktop-artifact.test.ts — 66 passed
• Targeted formatting and type-aware lint passed
• Exact GitHub arm64 release artifact was independently audited; filtered node-pty tree loaded and spawned /bin/sh successfully on Apple silicon

Bundle impact:
The audited arm64 app loses 101,072 uncompressed bytes (~98.7 KiB). The two entries occupied 31,045 compressed bytes (~30.3 KiB) in the ZIP, plus archive metadata.

Model/harness: GPT-5.6 / Codex harness.

---

Note

Low Risk
Packaging-only change scoped to macOS file exclusions in the desktop artifact script; runtime app logic is unchanged, though misconfigured callers that omit arch would still bundle both prebuilds.

Overview
Single-architecture macOS desktop packages were still shipping both Darwin node-pty prebuilds, which led macOS to treat Intel-only nested binaries as present in arm64 builds.

This PR adds resolveMacFileExclusions, which keeps the existing Windows-related exclusions and, for arm64 or x64 targets, adds an electron-builder exclusion for the non-targetdarwin-* prebuild tree. Universal builds (or callers that omit arch) keep both Darwin prebuilds, matching prior behavior.

The target arch is passed into createBuildConfig from buildDesktopArtifact so staged package.jsonbuild.files uses the resolved list instead of the static MAC_FILE_EXCLUSIONS alone.

^{Reviewed by Cursor Bugbot for commit 2d9596e. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Exclude unused Darwin node-pty prebuilds from single-architecture macOS desktop builds

• Adds resolveMacFileExclusions in build-desktop-artifact.ts which drops the opposite-architecture Darwin node-pty prebuild for single-arch macOS packages and keeps both prebuilds for universal or unspecified builds
• Threads an architecture parameter through createBuildConfig and passes options.arch from buildDesktopArtifact so the exclusion resolver receives the requested target
• Behavioral Change: single-architecture macOS artifacts now ship only the matching Darwin node-pty prebuild instead of both; universal and arch-unspecified builds are unchanged

^{Macroscope summarized 2d9596e.}

[macroscopeapp]

Approvability

Verdict: Approved at 2d9596e

Macroscope's review found this PR approvable — This is a focused macOS packaging fix that removes unused opposite-architecture node-pty binaries from single-architecture artifacts while preserving universal builds and application runtime logic. The change is small, localized, and has no product-default, security, schema, or infrastructure implications.

^{You can add or adjust custom eligibility rules. Learn more.}

Dismissing prior approval to re-evaluate 1ccaa2e

[extoci]

Release Smoke is the only failing required check. It fails before any desktop packaging step while regenerating the temporary lockfile in scripts/release-smoke.ts: ERR_PNPM_UNUSED_PATCH for expo-sharing@57.0.16. The same command reproduces locally from this clean branch, and the PR diff contains no mobile, patch, or lockfile changes; the current registry also resolves expo-sharing 57.0.17, which does not match the existing 57.0.16 patch. I left this PR scoped to the macOS packaging fix. Coded on behalf of me — GPT-5.6 / Codex harness.

[extoci]

Update: I verified the required Release Smoke failure was caused by the existing expo-sharing patch being version-specific while its dependency range allowed 57.0.17. The final PR now includes only a two-line specifier/lockfile alignment to keep the already-patched 57.0.16 behavior; the full smoke script passes locally. Coded on behalf of me — GPT-5.6 / Codex harness.

Dismissing prior approval to re-evaluate 817f596

Dismissing prior approval to re-evaluate 2d9596e

[extoci]

Correction after rebasing onto current main: the Expo Sharing patch/version fix is already present upstream and is no longer part of this PR. The rebased branch now contains only the macOS desktop packaging change (+19/-1); the earlier CI note referred to the pre-rebase state. Coded on behalf of me — GPT-5.6 / Codex harness.

[mackinleysmith]

hey @maria-rcks, do you think we could rebase or cherry pick this into the t3code/rebuild-mobile-app-swift branch so i can get the tests passing on #9071 please? thank you kindly!

[extoci]

Problem:
The arm64 macOS artifact includes node-pty darwin-x64 pty.node and spawn-helper files, causing macOS to detect Intel-only nested components.

Fix:
Pass the target architecture into the desktop packaging config and exclude only the opposite Darwin node-pty prebuilds for single-architecture packages. Universal builds retain both architectures, and Intel macOS support remains unchanged.

Tests:

• vp test run scripts/build-desktop-artifact.test.ts — 66 passed
• Targeted formatting and type-aware lint passed
• Exact GitHub arm64 release artifact was independently audited; filtered node-pty tree loaded and spawned /bin/sh successfully on Apple silicon

Bundle impact:
The audited arm64 app loses 101,072 uncompressed bytes (~98.7 KiB). The two entries occupied 31,045 compressed bytes (~30.3 KiB) in the ZIP, plus archive metadata.

Model/harness: GPT-5.6 / Codex harness.

---

Note

Low Risk
Packaging-only change scoped to macOS file exclusions in the desktop artifact script; runtime app logic is unchanged, though misconfigured callers that omit arch would still bundle both prebuilds.

Overview
Single-architecture macOS desktop packages were still shipping both Darwin node-pty prebuilds, which led macOS to treat Intel-only nested binaries as present in arm64 builds.

This PR adds resolveMacFileExclusions, which keeps the existing Windows-related exclusions and, for arm64 or x64 targets, adds an electron-builder exclusion for the non-targetdarwin-* prebuild tree. Universal builds (or callers that omit arch) keep both Darwin prebuilds, matching prior behavior.

The target arch is passed into createBuildConfig from buildDesktopArtifact so staged package.jsonbuild.files uses the resolved list instead of the static MAC_FILE_EXCLUSIONS alone.

^{Reviewed by Cursor Bugbot for commit 2d9596e. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Exclude unused Darwin node-pty prebuilds from single-architecture macOS desktop builds

• Adds resolveMacFileExclusions in build-desktop-artifact.ts which drops the opposite-architecture Darwin node-pty prebuild for single-arch macOS packages and keeps both prebuilds for universal or unspecified builds
• Threads an architecture parameter through createBuildConfig and passes options.arch from buildDesktopArtifact so the exclusion resolver receives the requested target
• Behavioral Change: single-architecture macOS artifacts now ship only the matching Darwin node-pty prebuild instead of both; universal and arch-unspecified builds are unchanged

^{Macroscope summarized 2d9596e.}

[macroscopeapp]

Approvability

Verdict: Approved at 2d9596e

Macroscope's review found this PR approvable — This is a focused macOS packaging fix that removes unused opposite-architecture node-pty binaries from single-architecture artifacts while preserving universal builds and application runtime logic. The change is small, localized, and has no product-default, security, schema, or infrastructure implications.

^{You can add or adjust custom eligibility rules. Learn more.}

Dismissing prior approval to re-evaluate 1ccaa2e

[extoci]

Release Smoke is the only failing required check. It fails before any desktop packaging step while regenerating the temporary lockfile in scripts/release-smoke.ts: ERR_PNPM_UNUSED_PATCH for expo-sharing@57.0.16. The same command reproduces locally from this clean branch, and the PR diff contains no mobile, patch, or lockfile changes; the current registry also resolves expo-sharing 57.0.17, which does not match the existing 57.0.16 patch. I left this PR scoped to the macOS packaging fix. Coded on behalf of me — GPT-5.6 / Codex harness.

[extoci]

Update: I verified the required Release Smoke failure was caused by the existing expo-sharing patch being version-specific while its dependency range allowed 57.0.17. The final PR now includes only a two-line specifier/lockfile alignment to keep the already-patched 57.0.16 behavior; the full smoke script passes locally. Coded on behalf of me — GPT-5.6 / Codex harness.

Dismissing prior approval to re-evaluate 817f596

Dismissing prior approval to re-evaluate 2d9596e

[extoci]

Correction after rebasing onto current main: the Expo Sharing patch/version fix is already present upstream and is no longer part of this PR. The rebased branch now contains only the macOS desktop packaging change (+19/-1); the earlier CI note referred to the pre-rebase state. Coded on behalf of me — GPT-5.6 / Codex harness.

[mackinleysmith]

hey @maria-rcks, do you think we could rebase or cherry pick this into the t3code/rebuild-mobile-app-swift branch so i can get the tests passing on #9071 please? thank you kindly!

[extoci]

Problem:
The arm64 macOS artifact includes node-pty darwin-x64 pty.node and spawn-helper files, causing macOS to detect Intel-only nested components.

Fix:
Pass the target architecture into the desktop packaging config and exclude only the opposite Darwin node-pty prebuilds for single-architecture packages. Universal builds retain both architectures, and Intel macOS support remains unchanged.

Tests:

• vp test run scripts/build-desktop-artifact.test.ts — 66 passed
• Targeted formatting and type-aware lint passed
• Exact GitHub arm64 release artifact was independently audited; filtered node-pty tree loaded and spawned /bin/sh successfully on Apple silicon

Bundle impact:
The audited arm64 app loses 101,072 uncompressed bytes (~98.7 KiB). The two entries occupied 31,045 compressed bytes (~30.3 KiB) in the ZIP, plus archive metadata.

Model/harness: GPT-5.6 / Codex harness.

---

Note

Low Risk
Packaging-only change scoped to macOS file exclusions in the desktop artifact script; runtime app logic is unchanged, though misconfigured callers that omit arch would still bundle both prebuilds.

Overview
Single-architecture macOS desktop packages were still shipping both Darwin node-pty prebuilds, which led macOS to treat Intel-only nested binaries as present in arm64 builds.

This PR adds resolveMacFileExclusions, which keeps the existing Windows-related exclusions and, for arm64 or x64 targets, adds an electron-builder exclusion for the non-targetdarwin-* prebuild tree. Universal builds (or callers that omit arch) keep both Darwin prebuilds, matching prior behavior.

The target arch is passed into createBuildConfig from buildDesktopArtifact so staged package.jsonbuild.files uses the resolved list instead of the static MAC_FILE_EXCLUSIONS alone.

^{Reviewed by Cursor Bugbot for commit 2d9596e. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Exclude unused Darwin node-pty prebuilds from single-architecture macOS desktop builds

• Adds resolveMacFileExclusions in build-desktop-artifact.ts which drops the opposite-architecture Darwin node-pty prebuild for single-arch macOS packages and keeps both prebuilds for universal or unspecified builds
• Threads an architecture parameter through createBuildConfig and passes options.arch from buildDesktopArtifact so the exclusion resolver receives the requested target
• Behavioral Change: single-architecture macOS artifacts now ship only the matching Darwin node-pty prebuild instead of both; universal and arch-unspecified builds are unchanged

^{Macroscope summarized 2d9596e.}

[macroscopeapp]

Approvability

Verdict: Approved at 2d9596e

Macroscope's review found this PR approvable — This is a focused macOS packaging fix that removes unused opposite-architecture node-pty binaries from single-architecture artifacts while preserving universal builds and application runtime logic. The change is small, localized, and has no product-default, security, schema, or infrastructure implications.

^{You can add or adjust custom eligibility rules. Learn more.}

Dismissing prior approval to re-evaluate 1ccaa2e

[extoci]

Release Smoke is the only failing required check. It fails before any desktop packaging step while regenerating the temporary lockfile in scripts/release-smoke.ts: ERR_PNPM_UNUSED_PATCH for expo-sharing@57.0.16. The same command reproduces locally from this clean branch, and the PR diff contains no mobile, patch, or lockfile changes; the current registry also resolves expo-sharing 57.0.17, which does not match the existing 57.0.16 patch. I left this PR scoped to the macOS packaging fix. Coded on behalf of me — GPT-5.6 / Codex harness.

[extoci]

Update: I verified the required Release Smoke failure was caused by the existing expo-sharing patch being version-specific while its dependency range allowed 57.0.17. The final PR now includes only a two-line specifier/lockfile alignment to keep the already-patched 57.0.16 behavior; the full smoke script passes locally. Coded on behalf of me — GPT-5.6 / Codex harness.

Dismissing prior approval to re-evaluate 817f596

Dismissing prior approval to re-evaluate 2d9596e

[extoci]

Correction after rebasing onto current main: the Expo Sharing patch/version fix is already present upstream and is no longer part of this PR. The rebased branch now contains only the macOS desktop packaging change (+19/-1); the earlier CI note referred to the pre-rebase state. Coded on behalf of me — GPT-5.6 / Codex harness.

[mackinleysmith]

hey @maria-rcks, do you think we could rebase or cherry pick this into the t3code/rebuild-mobile-app-swift branch so i can get the tests passing on #9071 please? thank you kindly!