Add fabric on iOS by okwasniewski · Pull Request #400 · callstack/react-native-slider

okwasniewski · 2022-07-19T11:28:45Z

Summary:

Setup codegen spec in flow
Move requireNativeComponent to separate file
Update podspec file
Add codegenConfig in package.json
Ensure backwards compatibility
iOS Implementation

Test Plan:

iOS: Install pods using RCT_NEW_ARCH_ENABLED=1 pod install

BartoszKlonowski · 2022-07-19T21:26:12Z

This PR is part of #380 - linking this to the issue.

BartoszKlonowski

note: I've allowed myself to rebase your branch, as I saw there's a leftover in package lockfile with old npm version (your PR updates it correctly, but the updated version should be on main branch). I updated it on main and rebased your branch to avoid potential conflicts - sorry for inconvenience.

BartoszKlonowski

Looks like a decent base for further implementation 👍
I left some minor comments and we are missing some important props: trackImage, thumbImage and tapToSeek.

BartoszKlonowski

Just a couple of minor comments, a question and idea to bring back Pods caching.

BartoszKlonowski · 2022-07-28T15:59:26Z

+ device=$(xcrun simctl list devices "${device_name}" available | grep "${device_name} (")
+ re='\(([-0-9A-Fa-f]+)\)'
+ [[ $device =~ $re ]] || exit 1
+ xcodebuild -workspace example.xcworkspace -scheme example -destination "platform=iOS Simulator,id=${BASH_REMATCH[1]}" CODE_SIGNING_ALLOWED=NO COMPILER_INDEX_STORE_ENABLE=NO build


Just wondering: Don't we have COMPILER_INDEX_STORE_ENABLED set to NO by default?

It defaults to YES, and it gives us major speed improvements. Check this out:
https://twitter.com/steipete/status/1100404024224804871
https://stackoverflow.com/questions/71109718/what-is-the-compiler-index-store-enable-xcode-build-settings-default-value

* Bring back Pods to cache * Use new-arch string in key for new arch cache * Try to reinstall pods instead of creating new * Separate deps installation between two caches * Rename Pods reinstall step

BartoszKlonowski

Huge amount of hard work, looks good 👍
Thank you!

This check is no longer needed.

* Add fabric on iOS (#400) * Update podspec file for fabric * Define codegen spec & move import to separate file * Add codegenConfig in package.json * Update podspec to detect .mm files * Change spec types to floats * Implement fabric component with props updating * Re-order functions, add accessibilityIncrements prop * Clean up imports, remove comment * Sort out props updating, remove unused functions * Add event handling * Add tapToSeek implementation * Fix tapToSeek * Handle images using bridge * Add missing typedef * Verify the build for new arch with GH Actions * Save new-arch Pods under new-arch cache key * Use Podfile.lock with old arch and regenerate for new one * Correct path for new arch Podfile.lock creation * Disable flipper in Podfile * Install pods with new arch flag * Fix tapToSeek on iOS * Allow value property to be controlled * Generate project.pbxproj for new arch * Separate npm & pods step in CI * Change step names, fix cache keys * Remove pods cache * Run npm install if cache was not found * Run build using xcodebuild * Fix: Pods-related error after using Pods from cache (#407) * Bring back Pods to cache * Use new-arch string in key for new arch cache * Try to reinstall pods instead of creating new * Separate deps installation between two caches * Rename Pods reinstall step * Remove explicit folly version, default to old arch * Add clean scripts in example for codegen cleanup * Change CI step names * Remove isFabricEnabled This check is no longer needed. Co-authored-by: BartoszKlonowski <Bartosz.Klonowski@callstack.com> * Add fabric on Android (#402) * Configure build.gradle * Update libraryName on android * Create ReactSlider shared implementation * Split implementations into oldarch and newarch * Dispatch events * Cleanup eventDispatcher * Make oldarch implementation use shared code * Add defaults to js spec * Clean up newarch ReactSliderManager * Reorder props to fix disabled state * Handle TestID setter * Move ReactSliderShadowNode to shared implementation * Share getExportedCustomDirectEventTypeConstants * Remove comments, add empty line

okwasniewski requested a review from BartoszKlonowski July 19, 2022 12:06

BartoszKlonowski force-pushed the chore/fabric-setup branch from 0db2976 to 3e5fde1Compare July 19, 2022 21:29

BartoszKlonowski reviewed Jul 19, 2022
View reviewed changes

BartoszKlonowski reviewed Jul 20, 2022
View reviewed changes

okwasniewski changed the title ~~Setup fabric on iOS~~Add fabric on iOSJul 22, 2022

okwasniewski added 14 commits July 25, 2022 23:56

Update podspec file for fabric
1ed4402

Define codegen spec & move import to separate file
51ca37e

Add codegenConfig in package.json
b86cf6c

Update podspec to detect .mm files
4f8671d

Change spec types to floats
00d9a79

Implement fabric component with props updating
1c40598

Re-order functions, add accessibilityIncrements prop
c7a4e23

Clean up imports, remove comment
8dfb795

Sort out props updating, remove unused functions
8946e51

Add event handling
5e6f348

Add tapToSeek implementation
c93b119

Fix tapToSeek
1ae3f1d

Handle images using bridge
3ab0013

Add missing typedef
8195867

BartoszKlonowski force-pushed the chore/fabric-setup branch from c030233 to 8195867Compare July 25, 2022 21:58

BartoszKlonowskiand others added 9 commits July 26, 2022 00:51

Verify the build for new arch with GH Actions
e647c95

Save new-arch Pods under new-arch cache key
bc90c77

Use Podfile.lock with old arch and regenerate for new one
e8b2a6c

Correct path for new arch Podfile.lock creation
c5c2b80

Disable flipper in Podfile
d258a90

Install pods with new arch flag
dc0988a

Fix tapToSeek on iOS
8574ae6

Allow value property to be controlled
62e5e46

Generate project.pbxproj for new arch
9a35cb8

okwasniewski added 5 commits July 28, 2022 13:40

Separate npm & pods step in CI
ad2f640

Change step names, fix cache keys
e6531fc

Remove pods cache
190454a

Run npm install if cache was not found
22aa190

Run build using xcodebuild
e2d87ec

BartoszKlonowski reviewed Jul 28, 2022
View reviewed changes

satya164 reviewed Jul 28, 2022
View reviewed changes

Comment threadpackage/react-native-slider.podspec Outdated

Fix: Pods-related error after using Pods from cache (#407)
9bfb6eb
* Bring back Pods to cache * Use new-arch string in key for new arch cache * Try to reinstall pods instead of creating new * Separate deps installation between two caches * Rename Pods reinstall step

BartoszKlonowski approved these changes Jul 28, 2022
View reviewed changes

okwasniewski added 3 commits July 29, 2022 09:27

Remove explicit folly version, default to old arch
4193daf

Add clean scripts in example for codegen cleanup
9af9061

Change CI step names
1ae1cda

okwasniewski requested a review from BartoszKlonowski July 29, 2022 07:35

thymikee mentioned this pull request Jul 29, 2022
Proposal to remove Slider and other deprecated components react-native-community/discussions-and-proposals#451
Open

Remove isFabricEnabled
629d526
This check is no longer needed.

BartoszKlonowski approved these changes Aug 2, 2022
View reviewed changes

okwasniewski merged commit 533db3c into chore/fabric-migrationAug 2, 2022

okwasniewski mentioned this pull request Aug 4, 2022
Add Fabric support #410
Merged

WoLewicki mentioned this pull request Aug 10, 2022
feat: change ios CI software-mansion/react-native-svg#1831
Merged

Uh oh!

Conversation

okwasniewski commented Jul 19, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary:

Test Plan:

Uh oh!

BartoszKlonowski commented Jul 19, 2022

Uh oh!

BartoszKlonowski left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BartoszKlonowski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BartoszKlonowski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BartoszKlonowskiJul 28, 2022

Choose a reason for hiding this comment

Uh oh!

okwasniewskiJul 29, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

BartoszKlonowski left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

okwasniewski commented Jul 19, 2022•
edited
Loading

BartoszKlonowski left a comment •
edited
Loading