Uh oh!
There was an error while loading. Please reload this page.
Add fabric on iOS#400
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -60,7 +60,7 @@ jobs: | ||
| verify: | ||
| name: Verify example app sources | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| @@ -75,7 +75,7 @@ jobs: | ||
| build-android-app: | ||
| name: Build example app Android | ||
| runs-on: ubuntu-latest | ||
| needs: [verify] | ||
| @@ -95,7 +95,7 @@ jobs: | ||
| build-iOS-app: | ||
| name: Build example app iOS | ||
| runs-on: macos-latest | ||
| needs: [verify] | ||
| steps: | ||
| @@ -105,33 +105,101 @@ jobs: | ||
| id: cache-npm | ||
| uses: actions/cache@v3 | ||
| env: | ||
| cache-name: cached-ios-npm-deps | ||
| with: | ||
| path: example/node_modules | ||
| key: ${{ hashFiles('./example/package-lock.json') }}-${{ hashFiles('./package/package-lock.json') }} | ||
| - name: Install required dependencies on cache miss (npm) | ||
| if: steps.cache-npm.outputs.cache-hit != 'true' | ||
| run: | | ||
| npm install | ||
| - name: Cache Pods | ||
| id: cache-pods | ||
| uses: actions/cache@v3 | ||
| env: | ||
| cache-name: cached-ios-pods-deps | ||
| with: | ||
| path: example/ios/Pods | ||
| key: ${{ hashFiles('./example/ios/Podfile.lock') }} | ||
| - name: Install required dependencies on cache miss (Pods) | ||
| if: steps.cache-pods.outputs.cache-hit != 'true' | ||
| run: | | ||
| cd example/ios && pod install | ||
| - name: Reinstall Pods only if using cached ones | ||
| if: steps.cache-pods.outputs.cache-hit == 'true' | ||
| run: cd example/ios && pod install | ||
| - name: Use the current package sources in build | ||
| run: cd example && npm run refresh-package | ||
| - name: Build iOS | ||
| run: | | ||
| device_name='iPhone 13' | ||
| device=$(xcrun simctl list devices "${device_name}" available | grep "${device_name} (") | ||
BartoszKlonowski marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| re='\(([-0-9A-Fa-f]+)\)' | ||
| [[ $device =~ $re ]] || exit 1 | ||
| xcodebuild -workspace example.xcworkspace -scheme example -destination "platform=iOS Simulator,id=${BASH_REMATCH[1]}" CODE_SIGNING_ALLOWED=NO COMPILER_INDEX_STORE_ENABLE=NO build | ||
There was a problem hiding this comment. Just wondering: Don't we have ContributorAuthor There was a problem hiding this comment. It defaults to YES, and it gives us major speed improvements. Check this out: | ||
| working-directory: example/ios | ||
| build-iOS-new-arch-app: | ||
| name: Build example app iOS (Fabric) | ||
| runs-on: macos-latest | ||
| needs: [build-iOS-app] | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - name: Cache node modules | ||
| id: cache-npm | ||
| uses: actions/cache@v3 | ||
| env: | ||
| cache-name: cached-ios-npm-deps | ||
| with: | ||
| path: example/node_modules | ||
| key: new-arch-${{ hashFiles('./example/package-lock.json') }}-${{ hashFiles('./package/package-lock.json') }} | ||
| - name: Install required dependencies on cache miss (npm) | ||
| if: steps.cache-npm.outputs.cache-hit != 'true' | ||
| run: | | ||
| npm install | ||
| - name: Cache Pods | ||
| id: cache-pods | ||
| uses: actions/cache@v3 | ||
| env: | ||
| cache-name: cached-ios-pods-deps | ||
| with: | ||
| path: example/ios/Pods | ||
| key: new-arch-${{ hashFiles('./example/ios/Podfile.lock') }} | ||
| - name: Install required dependencies on cache miss (Pods) | ||
| if: steps.cache-pods.outputs.cache-hit != 'true' | ||
| run: | | ||
| cd example/ios && RCT_NEW_ARCH_ENABLED=1 pod install | ||
| - name: Reinstall Pods only if using cached ones | ||
| if: steps.cache-pods.outputs.cache-hit == 'true' | ||
| run: cd example/ios && RCT_NEW_ARCH_ENABLED=1 pod install | ||
| - name: Use the current package sources in build | ||
| run: cd example && npm run refresh-package | ||
| - name: Build iOS - Fabric | ||
| run: | | ||
| device_name='iPhone 13' | ||
| device=$(xcrun simctl list devices "${device_name}" available | grep "${device_name} (") | ||
| re='\(([-0-9A-Fa-f]+)\)' | ||
| [[ $device =~ $re ]] || exit 1 | ||
| xcodebuild -workspace example.xcworkspace -scheme example -destination "platform=iOS Simulator,id=${BASH_REMATCH[1]}" CODE_SIGNING_ALLOWED=NO COMPILER_INDEX_STORE_ENABLE=NO build | ||
| working-directory: example/ios | ||
| build-Windows-app: | ||
| name: Build example app Windows | ||
| runs-on: windows-latest | ||
| needs: [verify] | ||
| steps: | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.