Skip to content

chore: add warning when using InputAccessoryView - #24

Merged
okwasniewski merged 6 commits into
callstack:mainfrom
TMisiukiewicz:input-accessory-view-warning
Nov 3, 2023
Merged

chore: add warning when using InputAccessoryView#24
okwasniewski merged 6 commits into
callstack:mainfrom
TMisiukiewicz:input-accessory-view-warning

Conversation

@TMisiukiewicz

@TMisiukiewiczTMisiukiewicz commented Oct 27, 2023•
edited
Loading

Copy link
Copy Markdown

Summary:

Closing #8
Since InputAccessoryView is not supported on VisionOS, this change adds a warning message about the component being unavailable on the platform.

Changelog:

[VISIONOS] [ADDED] - warning about unavailable InputAccessoryView

Test Plan:

  1. Open InputAccessoryView in RNTester
  2. Verify warn is displayed in the app and in the Metro logs
imageScreenshot 2023-10-28 at 11 38 48

okwasniewski
okwasniewski reviewed Oct 28, 2023
View reviewed changes
Comment threadpackages/react-native/Libraries/Components/TextInput/InputAccessoryView.js Outdated

@okwasniewskiokwasniewskiOct 28, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the name to 'visionOS'? As it's the official naming Apple uses

@TMisiukiewiczTMisiukiewiczOct 30, 2023

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done ✅

matthargett
matthargett approved these changes Oct 31, 2023
View reviewed changes

@matthargettmatthargett left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes requested

Comment threadpackages/react-native/Libraries/Components/TextInput/InputAccessoryView.js Outdated
Comment threadpackages/react-native/Libraries/Components/TextInput/InputAccessoryView.js Outdated
@TMisiukiewicz

TMisiukiewicz commented Nov 3, 2023

Copy link
Copy Markdown
Author

@matthargett thanks for your comments, everything is fixed now. Also rebased branch with the current main

@okwasniewski
okwasniewski merged commit f6fff4a into callstack:mainNov 3, 2023
@okwasniewskiokwasniewski mentioned this pull request Nov 5, 2023
Merged
thiagobrez
thiagobrez reviewed Nov 5, 2023
View reviewed changes
Comment threadpackages/react-native/Libraries/Components/TextInput/InputAccessoryView.js
componentDidMount() {
if (Platform.isVisionOS) {
warnOnce(
'component-unavailable',

@thiagobrezthiagobrezNov 5, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TMisiukiewicz@okwasniewski Shouldn't the key here be something more identifiable, like InputAccessoryView-unavailable?

component-unavailable seems a bit generic, and if it is used in other files, I believe one warning might override the other, causing some to be missed?

@okwasniewskiokwasniewskiNov 6, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's valid point I think we should rename it

@TMisiukiewiczTMisiukiewiczNov 6, 2023•
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no problem, i'll take care of it in a new PR

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@thiagobrezthiagobrezthiagobrez left review comments
@okwasniewskiokwasniewskiokwasniewski approved these changes
@matthargettmatthargettmatthargett approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TMisiukiewicz@matthargett@thiagobrez@okwasniewski