Skip to content

chore: add warning when using InputAccessoryView#24

Merged
okwasniewski merged 6 commits into from
Nov 3, 2023
Merged

chore: add warning when using InputAccessoryView#24

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dcc5c52
feat: add visionos support
okwasniewski Nov 3, 2023
a990983
chore: sync Podfile.lock
okwasniewski Nov 3, 2023
2562a6c
add warning when using InputAccessoryView
TMisiukiewicz Nov 3, 2023
fb34c41
do not render component if visionos
TMisiukiewicz Nov 3, 2023
d25028f
update platform naming
TMisiukiewicz Nov 3, 2023
ca99100
use warnOnce and add mark comments as TODOs
TMisiukiewicz Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions packages/react-native/Libraries/Components/TextInput/InputAccessoryView.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,6 +13,7 @@ import StyleSheet, {
type ViewStyleProp,
} from '../../StyleSheet/StyleSheet';
import Platform from '../../Utilities/Platform';
import warnOnce from '../../Utilities/warnOnce';
import RCTInputAccessoryViewNativeComponent from './RCTInputAccessoryViewNativeComponent';
import * as React from 'react';

Expand DownExpand Up@@ -86,7 +87,22 @@ type Props = $ReadOnly<{|
|}>;

class InputAccessoryView extends React.Component<Props> {
// TODO: once the 'visionos' is implemented as a platform, we can remove this
componentDidMount() {
if (Platform.isVisionOS) {
warnOnce(
'component-unavailable',

@thiagobrezthiagobrezNov 5, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TMisiukiewicz@okwasniewski Shouldn't the key here be something more identifiable, like InputAccessoryView-unavailable?

component-unavailable seems a bit generic, and if it is used in other files, I believe one warning might override the other, causing some to be missed?

@okwasniewskiokwasniewskiNov 6, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's valid point I think we should rename it

@TMisiukiewiczTMisiukiewiczNov 6, 2023•
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no problem, i'll take care of it in a new PR

'InputAccessoryView is not available on visionOS platform.',
);
}
}

render(): React.Node {
// TODO: once the 'visionos' is implemented as a platform, we can remove this
if (Platform.isVisionOS) {
return null;
}

if (Platform.OS === 'ios') {
if (React.Children.count(this.props.children) === 0) {
return null;
Expand Down