Skip to content

Feature/auth - #14

Merged
fakhri007 merged 35 commits into
mainfrom
feature/auth
Dec 8, 2020
Merged

Feature/auth#14
fakhri007 merged 35 commits into
mainfrom
feature/auth

Conversation

@fakhri007

@fakhri007fakhri007 commented Dec 1, 2020

Copy link
Copy Markdown
Contributor

No description provided.

jacky-htg
jacky-htg reviewed Dec 1, 2020
View reviewed changes
Comment threaddoc/auth.md Outdated
jacky-htg
jacky-htg reviewed Dec 1, 2020
View reviewed changes
Comment threaddoc/auth.md Outdated
jacky-htg
jacky-htg reviewed Dec 1, 2020
View reviewed changes
Comment threaddoc/auth.md Outdated
jacky-htg
jacky-htg reviewed Dec 1, 2020
View reviewed changes
Comment threaddoc/auth.md Outdated
jacky-htg
jacky-htg reviewed Dec 1, 2020
View reviewed changes
Comment threaddoc/auth.md Outdated
jacky-htg
jacky-htg reviewed Dec 1, 2020
View reviewed changes
Comment threaddoc/auth.md Outdated
jacky-htg
jacky-htg reviewed Dec 1, 2020
View reviewed changes
Comment threaddoc/auth.md Outdated
jacky-htg
jacky-htg reviewed Dec 1, 2020
View reviewed changes
Comment threaddoc/auth.md
jacky-htg
jacky-htg reviewed Dec 1, 2020
View reviewed changes
Comment threaddoc/auth.md
jacky-htg
jacky-htg reviewed Dec 1, 2020
View reviewed changes
Comment threaddoc/auth.md Outdated
jacky-htg
jacky-htg reviewed Dec 1, 2020
View reviewed changes
Comment threaddoc/auth.md Outdated
jacky-htg
jacky-htg reviewed Dec 1, 2020
View reviewed changes
Comment threaddoc/auth.md Outdated
jacky-htg
jacky-htg reviewed Dec 1, 2020
View reviewed changes
Comment threaddoc/auth.md
jacky-htg
jacky-htg reviewed Dec 1, 2020
View reviewed changes
Comment threaddoc/auth.md
jacky-htg
jacky-htg reviewed Dec 1, 2020
View reviewed changes
Comment threaddoc/auth.md
jacky-htg
jacky-htg reviewed Dec 1, 2020
View reviewed changes
Comment threaddoc/auth.md Outdated
jacky-htg
jacky-htg reviewed Dec 1, 2020
View reviewed changes
Comment threaddoc/auth.md
jacky-htg
jacky-htg requested changes Dec 1, 2020
View reviewed changes

@jacky-htgjacky-htg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

POST /forgot-password

  1. need 1 input only : email
  2. add sql script for create forgot_passwords table
  3. add logic step by step
  4. add negative case for scenario not found in database. the email input is valid, but no record in the database.

Comment threaddoc/auth.md Outdated
jacky-htg
jacky-htg requested changes Dec 1, 2020
View reviewed changes

@jacky-htgjacky-htg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many my feedback has been resolved. You need to resolve two point below:

  1. add sql script create forgot_password tables.
  2. add step by step logic

jacky-htg
jacky-htg requested changes Dec 3, 2020
View reviewed changes

@jacky-htgjacky-htg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve my comments below. thanks.

Comment threaddoc/auth.md
Comment threaddoc/auth.md Outdated
Comment threaddoc/auth.md Outdated
Comment threaddoc/auth.md Outdated
Comment threaddoc/auth.md Outdated
Comment threaddoc/auth.md Outdated
Comment threaddoc/auth.md Outdated
Comment threaddoc/auth.md Outdated
Comment threaddoc/auth.md Outdated
Comment threaddoc/auth.md Outdated
jacky-htg
jacky-htg reviewed Dec 4, 2020
View reviewed changes
Comment threaddoc/auth.md Outdated
--- | ---
Content-Type | application/json
Accept | application/json
Email | application/json

@jacky-htgjacky-htgDec 4, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example value of Email is rijal.asep.nugroho@gmail.com, not application/json

msyuniarto
msyuniarto requested changes Dec 5, 2020
View reviewed changes
Comment threaddoc/auth.md Outdated
Comment threaddoc/auth.md Outdated
Comment threaddoc/auth.md Outdated
Comment threaddoc/auth.md Outdated
Comment threaddoc/auth.md Outdated
msyuniartoand others added 6 commits December 7, 2020 09:40
@msyuniarto@fakhri007
[#3] Update Regions Documentation and add a figure of regions table (#16
19db1e6
)
* [#3] Update Regions Documentation and add a figure of regions table
* [#3] Update Region Documentation based on review
* [#3] Update Region Documentation based on 2nd review
* [#3] add region code must be unique and remove the last line that does not need comma
* [#3] Update region-layer
* [#3] Rename regions.png to region-layer.png
* [#3] Remove company_code and kunci from regions table
@fakhri007
[#9] resolve conflict
f7ae7f3
@fakhri007
[#9] resolve conflict
709bca0
@rasepnugroho@fakhri007
add validation logic on login
089abbe
@fakhri007
[#9] resolve conflict
4049748
@fakhri007
[#9] update doc
90e210e
msyuniarto
msyuniarto requested changes Dec 7, 2020
View reviewed changes
Comment threaddoc/auth.md Outdated
@fakhri007
fakhri007 merged commit 60835ba into mainDec 8, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacky-htgjacky-htgjacky-htg approved these changes
@msyuniartomsyuniartomsyuniarto approved these changes
@vdennisvdennisAwaiting requested review from vdennis
@wahabliewahablieAwaiting requested review from wahablie
@AhmadGozali19AhmadGozali19Awaiting requested review from AhmadGozali19
@Jonsen-92Jonsen-92Awaiting requested review from Jonsen-92
@dzakitajudindzakitajudinAwaiting requested review from dzakitajudin
@juniarthaimjuniarthaimAwaiting requested review from juniarthaim
@lukman134lukman134Awaiting requested review from lukman134
+1 more reviewer
@ferrystiawanferrystiawanferrystiawan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fakhri007@jacky-htg@ferrystiawan@msyuniarto@rasepnugroho