[#3] Update Regions Documentation and add a figure of regions table by msyuniarto · Pull Request #16 · cdcgi/user-service

msyuniarto · 2020-12-02T04:40:59Z

No description provided.

wahablie

untuk kolom id gunakan char(36), auto generate

jacky-htg

Please resolve my comment below. Thanks.

vdennis

kurang coma bos

…s not need comma

jacky-htg

remove company_code from regions table. You should have one foreign key to companies table.
field of kunci. can you explain what it is for?

) * [#3] Update Regions Documentation and add a figure of regions table * [#3] Update Region Documentation based on review * [#3] Update Region Documentation based on 2nd review * [#3] add region code must be unique and remove the last line that does not need comma * [#3] Update region-layer * [#3] Rename regions.png to region-layer.png * [#3] Remove company_code and kunci from regions table

* [#2] Update documentation Employee * [#2] Update Employee - Add Database Employee * [#3] Update Regions Documentation and add a figure of regions table (#16) * [#3] Update Regions Documentation and add a figure of regions table * [#3] Update Region Documentation based on review * [#3] Update Region Documentation based on 2nd review * [#3] add region code must be unique and remove the last line that does not need comma * [#3] Update region-layer * [#3] Rename regions.png to region-layer.png * [#3] Remove company_code and kunci from regions table * [#2] Update documentation Employee * [#2] Update Employee - Add Database Employee * [#2] Revise documentation Employee * [#2] Update email Documentation * [#2] Update email Documentation * [#2] Completing documentation Co-authored-by: Muhammad Sofi Yuniarto <58578584+msyuniarto@users.noreply.github.com>

* add validation logic on login * [#9] add documentation * [#9] add documentation forgot password * [#9] revise add documentation forgot password * [#9] revise add document forgot password(2) * [#9] add forgot password layer image * [#9] revise forgot password layer and add documentation change password * [#9] add documentation reset password * add validation logic on login * [#9] revise documentation change password and reset password * [#9] resolve conflict * [#9] resolve conflict * [#9] resolve conflict * [#9] resolve conflict * [#9] update change password and reset password documentation * add validation logic on login * add validation logic on login * [#9] resolve conflict * [#9] resolve conflict * [#9] resolve conflict * [#9] resolve conflict * add validation logic on login * [#9] re-update change password, forgot password, and reset password * [#9] resolve conflict * [#9] resolve conflict * [#9] revise documentation change password * [#3] Update Regions Documentation and add a figure of regions table (#16) * [#3] Update Regions Documentation and add a figure of regions table * [#3] Update Region Documentation based on review * [#3] Update Region Documentation based on 2nd review * [#3] add region code must be unique and remove the last line that does not need comma * [#3] Update region-layer * [#3] Rename regions.png to region-layer.png * [#3] Remove company_code and kunci from regions table * [#9] resolve conflict * [#9] resolve conflict * add validation logic on login * [#9] resolve conflict * [#9] update doc * [#9] update doc 2 Co-authored-by: Rijal Asepnugroho <rasepnugroho@waresix.com> Co-authored-by: Muhammad Sofi Yuniarto <58578584+msyuniarto@users.noreply.github.com>

* [#2] Update documentation Employee * [#2] Update Employee - Add Database Employee * [#3] Update Regions Documentation and add a figure of regions table (#16) * [#3] Update Regions Documentation and add a figure of regions table * [#3] Update Region Documentation based on review * [#3] Update Region Documentation based on 2nd review * [#3] add region code must be unique and remove the last line that does not need comma * [#3] Update region-layer * [#3] Rename regions.png to region-layer.png * [#3] Remove company_code and kunci from regions table * [#2] Update documentation Employee * [#2] Update Employee - Add Database Employee * [#2] Revise documentation Employee * [#2] Update email Documentation * [#2] Update email Documentation * [#2] Completing documentation Co-authored-by: Muhammad Sofi Yuniarto <58578584+msyuniarto@users.noreply.github.com>

* add validation logic on login * [#9] add documentation * [#9] add documentation forgot password * [#9] revise add documentation forgot password * [#9] revise add document forgot password(2) * [#9] add forgot password layer image * [#9] revise forgot password layer and add documentation change password * [#9] add documentation reset password * add validation logic on login * [#9] revise documentation change password and reset password * [#9] resolve conflict * [#9] resolve conflict * [#9] resolve conflict * [#9] resolve conflict * [#9] update change password and reset password documentation * add validation logic on login * add validation logic on login * [#9] resolve conflict * [#9] resolve conflict * [#9] resolve conflict * [#9] resolve conflict * add validation logic on login * [#9] re-update change password, forgot password, and reset password * [#9] resolve conflict * [#9] resolve conflict * [#9] revise documentation change password * [#3] Update Regions Documentation and add a figure of regions table (#16) * [#3] Update Regions Documentation and add a figure of regions table * [#3] Update Region Documentation based on review * [#3] Update Region Documentation based on 2nd review * [#3] add region code must be unique and remove the last line that does not need comma * [#3] Update region-layer * [#3] Rename regions.png to region-layer.png * [#3] Remove company_code and kunci from regions table * [#9] resolve conflict * [#9] resolve conflict * add validation logic on login * [#9] resolve conflict * [#9] update doc * [#9] update doc 2 * [#2] Update documentation Employee (#15) * [#2] Update documentation Employee * [#2] Update Employee - Add Database Employee * [#3] Update Regions Documentation and add a figure of regions table (#16) * [#3] Update Regions Documentation and add a figure of regions table * [#3] Update Region Documentation based on review * [#3] Update Region Documentation based on 2nd review * [#3] add region code must be unique and remove the last line that does not need comma * [#3] Update region-layer * [#3] Rename regions.png to region-layer.png * [#3] Remove company_code and kunci from regions table * [#2] Update documentation Employee * [#2] Update Employee - Add Database Employee * [#2] Revise documentation Employee * [#2] Update email Documentation * [#2] Update email Documentation * [#2] Completing documentation Co-authored-by: Muhammad Sofi Yuniarto <58578584+msyuniarto@users.noreply.github.com> * [#9] add documentation * [#9] resolve conflict * [#9] resolve conflict * [#9] resolve conflict * [#9] resolve conflict * [#9] bring back acl-layer Co-authored-by: Rijal Asepnugroho <rasepnugroho@waresix.com> Co-authored-by: Muhammad Sofi Yuniarto <58578584+msyuniarto@users.noreply.github.com> Co-authored-by: ferrystiawan <56244036+ferrystiawan@users.noreply.github.com>

* [#4] update branches api documentation * [#3] Update Regions Documentation and add a figure of regions table (#16) * [#3] Update Regions Documentation and add a figure of regions table * [#3] Update Region Documentation based on review * [#3] Update Region Documentation based on 2nd review * [#3] add region code must be unique and remove the last line that does not need comma * [#3] Update region-layer * [#3] Rename regions.png to region-layer.png * [#3] Remove company_code and kunci from regions table * [#4] update branches api documentation * [#4] update endpoint and field branches api * [#4] update branches api documentation * [#4] update param query and positive case * [#4] add query param description with table Co-authored-by: Muhammad Sofi Yuniarto <58578584+msyuniarto@users.noreply.github.com>

* [#8] Create User Documentation and add a figure of users table * [#8] Update User Documentation based on review * [#3] Update Regions Documentation and add a figure of regions table (#16) * [#3] Update Regions Documentation and add a figure of regions table * [#3] Update Region Documentation based on review * [#3] Update Region Documentation based on 2nd review * [#3] add region code must be unique and remove the last line that does not need comma * [#3] Update region-layer * [#3] Rename regions.png to region-layer.png * [#3] Remove company_code and kunci from regions table * [#8] Create User Documentation and add a figure of users table * [#8] Update User Documentation based on review * [#8] Update User Add Documentation * [#8] Update User Add Documentation * [#8] Update User Edit Documentation * [#8] Update type akses and add positive case edit password * [#8] Update status code when not found 400 to 404 * [#8] Update view and delete user documentation * [#8] Update User documentation, view all user, and database image * [#8] update user documentation on edit Co-authored-by: Muhammad Sofi Yuniarto <58578584+msyuniarto@users.noreply.github.com>

[#3] Update Regions Documentation and add a figure of regions table
c825dc8

msyuniarto requested review from jacky-htg, lukman134, vdennis and wahablie December 2, 2020 04:40

wahablie approved these changes Dec 2, 2020
View reviewed changes

jacky-htg requested changes Dec 3, 2020
View reviewed changes

vdennis requested changes Dec 4, 2020
View reviewed changes

Comment threaddoc/regions.md

[#3] Update Region Documentation based on review
359fdf2

msyuniarto requested review from jacky-htg, vdennis and wahablie December 4, 2020 08:50

jacky-htg requested changes Dec 4, 2020
View reviewed changes

Comment threaddoc/regions.md
Comment threaddoc/regions.md Outdated
Comment threaddoc/regions.md Outdated
Comment threaddoc/regions.md
Comment threaddoc/regions.md Outdated
Comment threaddoc/regions.md Outdated

[#3] Update Region Documentation based on 2nd review
0a0fa74

msyuniarto requested a review from jacky-htg December 4, 2020 14:00

jacky-htg reviewed Dec 4, 2020
View reviewed changes

[#3] add region code must be unique and remove the last line that doe…
62c7c16
…s not need comma

msyuniarto requested a review from jacky-htg December 4, 2020 16:31

jacky-htg approved these changes Dec 4, 2020
View reviewed changes

vdennis approved these changes Dec 5, 2020
View reviewed changes

msyuniarto added 2 commits December 5, 2020 16:41

[#3] Update region-layer
ddca13b

[#3] Rename regions.png to region-layer.png
80c270d

msyuniarto requested a review from jacky-htg December 5, 2020 09:53

jacky-htg requested changes Dec 6, 2020
View reviewed changes

[#3] Remove company_code and kunci from regions table
aeb02be

msyuniarto requested a review from jacky-htg December 6, 2020 05:23

jacky-htg approved these changes Dec 6, 2020
View reviewed changes

jacky-htg merged commit 57a5f55 into mainDec 6, 2020

Uh oh!

Conversation

msyuniarto commented Dec 2, 2020

Uh oh!

wahablie left a comment

Choose a reason for hiding this comment

Uh oh!

jacky-htg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vdennis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jacky-htg left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants