[#2] Update documentation Employee by ferrystiawan · Pull Request #15 · cdcgi/user-service

ferrystiawan · 2020-12-01T08:00:00Z

No description provided.

jacky-htg

Add endpoint for read employee
Please finalise the complete documentation of one endpoint first, ex: endpoint of POST / employees.

jacky-htg

Please discuss how to get user login information and confirm to Pak @wahablie

) * [#3] Update Regions Documentation and add a figure of regions table * [#3] Update Region Documentation based on review * [#3] Update Region Documentation based on 2nd review * [#3] add region code must be unique and remove the last line that does not need comma * [#3] Update region-layer * [#3] Rename regions.png to region-layer.png * [#3] Remove company_code and kunci from regions table

msyuniarto · 2020-12-07T03:51:11Z

+ "stall_code": "Heavy Repair",
+


baris terakhir gak butuh tanda koma, hapus baris kosong

msyuniarto · 2020-12-07T04:25:21Z

 "employee_nama": "ferry",
- "stall_code": "Heavy Repair",
+ "stall_code": "Heavy Repair"



ini dihapus aja fer baris kosongnya, biar rapi

baik mas @msyuniarto sudah diganti mohon di review kembali

jacky-htg · 2020-12-07T05:38:49Z

@@ -1 +1,605 @@
 # Employees Module
+Module | Description 


wrong table format.
Module Method Description

* [#2] Update documentation Employee * [#2] Update Employee - Add Database Employee * [#3] Update Regions Documentation and add a figure of regions table (#16) * [#3] Update Regions Documentation and add a figure of regions table * [#3] Update Region Documentation based on review * [#3] Update Region Documentation based on 2nd review * [#3] add region code must be unique and remove the last line that does not need comma * [#3] Update region-layer * [#3] Rename regions.png to region-layer.png * [#3] Remove company_code and kunci from regions table * [#2] Update documentation Employee * [#2] Update Employee - Add Database Employee * [#2] Revise documentation Employee * [#2] Update email Documentation * [#2] Update email Documentation * [#2] Completing documentation Co-authored-by: Muhammad Sofi Yuniarto <58578584+msyuniarto@users.noreply.github.com>

* add validation logic on login * [#9] add documentation * [#9] add documentation forgot password * [#9] revise add documentation forgot password * [#9] revise add document forgot password(2) * [#9] add forgot password layer image * [#9] revise forgot password layer and add documentation change password * [#9] add documentation reset password * add validation logic on login * [#9] revise documentation change password and reset password * [#9] resolve conflict * [#9] resolve conflict * [#9] resolve conflict * [#9] resolve conflict * [#9] update change password and reset password documentation * add validation logic on login * add validation logic on login * [#9] resolve conflict * [#9] resolve conflict * [#9] resolve conflict * [#9] resolve conflict * add validation logic on login * [#9] re-update change password, forgot password, and reset password * [#9] resolve conflict * [#9] resolve conflict * [#9] revise documentation change password * [#3] Update Regions Documentation and add a figure of regions table (#16) * [#3] Update Regions Documentation and add a figure of regions table * [#3] Update Region Documentation based on review * [#3] Update Region Documentation based on 2nd review * [#3] add region code must be unique and remove the last line that does not need comma * [#3] Update region-layer * [#3] Rename regions.png to region-layer.png * [#3] Remove company_code and kunci from regions table * [#9] resolve conflict * [#9] resolve conflict * add validation logic on login * [#9] resolve conflict * [#9] update doc * [#9] update doc 2 * [#2] Update documentation Employee (#15) * [#2] Update documentation Employee * [#2] Update Employee - Add Database Employee * [#3] Update Regions Documentation and add a figure of regions table (#16) * [#3] Update Regions Documentation and add a figure of regions table * [#3] Update Region Documentation based on review * [#3] Update Region Documentation based on 2nd review * [#3] add region code must be unique and remove the last line that does not need comma * [#3] Update region-layer * [#3] Rename regions.png to region-layer.png * [#3] Remove company_code and kunci from regions table * [#2] Update documentation Employee * [#2] Update Employee - Add Database Employee * [#2] Revise documentation Employee * [#2] Update email Documentation * [#2] Update email Documentation * [#2] Completing documentation Co-authored-by: Muhammad Sofi Yuniarto <58578584+msyuniarto@users.noreply.github.com> * [#9] add documentation * [#9] resolve conflict * [#9] resolve conflict * [#9] resolve conflict * [#9] resolve conflict * [#9] bring back acl-layer Co-authored-by: Rijal Asepnugroho <rasepnugroho@waresix.com> Co-authored-by: Muhammad Sofi Yuniarto <58578584+msyuniarto@users.noreply.github.com> Co-authored-by: ferrystiawan <56244036+ferrystiawan@users.noreply.github.com>

[#2] Update documentation Employee
0ec9d83

ferrystiawan requested review from jacky-htg, vdennis and wahablie December 1, 2020 08:00

jacky-htg requested changes Dec 1, 2020
View reviewed changes

Comment threaddoc/employees.md

[#2] Update Employee - Add Database Employee
1da41c4

ferrystiawan requested a review from jacky-htg December 3, 2020 04:12

jacky-htg requested changes Dec 3, 2020
View reviewed changes

Comment threaddoc/employees.md

msyuniartoand others added 5 commits December 6, 2020 13:58

[#2] Update documentation Employee
2420c71

[#2] Update Employee - Add Database Employee
cf6cbfa

[#2] Revise documentation Employee
fb72d59

[#2] Revise documentation Employee
dfbb8c6

ferrystiawan requested review from AhmadGozali19, Jonsen-92, dzakitajudin, fakhri007, jacky-htg, juniarthaim, lukman134 and msyuniarto December 7, 2020 03:20

msyuniarto requested changes Dec 7, 2020
View reviewed changes

[#2] Update email Documentation
eefc8bc

ferrystiawan requested a review from msyuniarto December 7, 2020 04:11

msyuniarto approved these changes Dec 7, 2020
View reviewed changes

[#2] Update email Documentation
b908a5f

ferrystiawan requested a review from msyuniarto December 7, 2020 04:30

jacky-htg requested changes Dec 7, 2020
View reviewed changes

[#2] Completing documentation
aaa3970

ferrystiawan requested a review from jacky-htg December 7, 2020 08:04

jacky-htg approved these changes Dec 8, 2020
View reviewed changes

fakhri007 approved these changes Dec 8, 2020
View reviewed changes

ferrystiawan merged commit 070bb03 into mainDec 8, 2020

Uh oh!

Conversation

ferrystiawan commented Dec 1, 2020

Uh oh!

jacky-htg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jacky-htg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

msyuniartoDec 7, 2020

Choose a reason for hiding this comment

Uh oh!

msyuniartoDec 7, 2020

Choose a reason for hiding this comment

Uh oh!

ferrystiawanDec 7, 2020

Choose a reason for hiding this comment

Uh oh!

jacky-htgDec 7, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants