Skip to content

[#4] update branches api documentation - #20

Merged
dzakitajudin merged 8 commits into
mainfrom
feature/branches
Dec 11, 2020
Merged

[#4] update branches api documentation#20
dzakitajudin merged 8 commits into
mainfrom
feature/branches

Conversation

@dzakitajudin

@dzakitajudindzakitajudin commented Dec 4, 2020

Copy link
Copy Markdown
Contributor

No description provided.

jacky-htg
jacky-htg requested changes Dec 4, 2020
View reviewed changes

@jacky-htgjacky-htg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve my comments below. thanks.

Comment threaddoc/branches.md Outdated
Comment threaddoc/branches.md Outdated
Comment threaddoc/branches.md Outdated
Comment threaddoc/branches.md Outdated
Comment threaddoc/branches.md Outdated
Comment threaddoc/branches.md Outdated
Comment threaddoc/branches.md Outdated
Comment threaddoc/branches.md
Comment threaddoc/branches.md Outdated
msyuniartoand others added 4 commits December 6, 2020 13:58
@msyuniarto
[#3] Update Regions Documentation and add a figure of regions table (#16
57a5f55
)
* [#3] Update Regions Documentation and add a figure of regions table
* [#3] Update Region Documentation based on review
* [#3] Update Region Documentation based on 2nd review
* [#3] add region code must be unique and remove the last line that does not need comma
* [#3] Update region-layer
* [#3] Rename regions.png to region-layer.png
* [#3] Remove company_code and kunci from regions table
@dzakitajudin
[#4] update branches api documentation
6d8eaa2
@dzakitajudin
[#4] update endpoint and field branches api
c0be0ab
@dzakitajudin
[#4] update endpoint and field branches api
69a311d
jacky-htg
jacky-htg requested changes Dec 7, 2020
View reviewed changes
Comment threaddoc/branches.md
Comment threaddoc/branches.md Outdated
Comment threaddoc/branches.md Outdated
Comment threaddoc/branches.md Outdated
Comment threaddoc/branches.md Outdated
Comment threaddoc/branches.md Outdated
Comment threaddoc/branches.md Outdated
Comment threaddoc/branches.md Outdated
Comment threaddoc/branches.md Outdated
Comment threaddoc/branches.md Outdated
jacky-htg
jacky-htg requested changes Dec 8, 2020
View reviewed changes
Comment threaddoc/branches.md Outdated
Comment threaddoc/branches.md Outdated
Comment threaddoc/branches.md Outdated
Comment threaddoc/branches.md Outdated
Comment threaddoc/branches.md

### Request Payloads
No Request Payloads

@jacky-htgjacky-htgDec 8, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is your param query?

Comment threaddoc/branches.md Outdated
Comment threaddoc/branches.md Outdated
Comment threaddoc/branches.md
Comment threaddoc/branches.md Outdated
Comment threaddoc/branches.md Outdated
jacky-htg
jacky-htg requested changes Dec 10, 2020
View reviewed changes
Comment threaddoc/branches.md

### Request Payloads
No Request Payloads

@jacky-htgjacky-htgDec 10, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what might be considered for adding a warehouse filter?

Comment threaddoc/branches.md
Comment threaddoc/branches.md Outdated
@dzakitajudin
dzakitajudin merged commit 20d2079 into mainDec 11, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacky-htgjacky-htgjacky-htg approved these changes
@msyuniartomsyuniartomsyuniarto approved these changes
@vdennisvdennisAwaiting requested review from vdennis
@fakhri007fakhri007Awaiting requested review from fakhri007
@wahabliewahablieAwaiting requested review from wahablie
@Jonsen-92Jonsen-92Awaiting requested review from Jonsen-92
@lukman134lukman134Awaiting requested review from lukman134
@juniarthaimjuniarthaimAwaiting requested review from juniarthaim
@AhmadGozali19AhmadGozali19Awaiting requested review from AhmadGozali19
+1 more reviewer
@ferrystiawanferrystiawanferrystiawan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dzakitajudin@jacky-htg@ferrystiawan@msyuniarto