Uh oh!
There was an error while loading. Please reload this page.
SP-1173: extend CUI marking to every --json command - #407
Open
Dennis Woditsch (dwoditsch) wants to merge 4 commits into
Open
SP-1173: extend CUI marking to every --json command#407Dennis Woditsch (dwoditsch) wants to merge 4 commits into
Dennis Woditsch (dwoditsch) wants to merge 4 commits into
Conversation
Dennis Woditsch (dwoditsch)force-pushed
the
feat/SP-1173-cui-marking-json-commands
branch
from
August 10, 2026 09:28
12e7d86 to
aa47776Compare
This was referenced Aug 10, 2026
Sixteen write sites whose enclosing method is already async and awaited to the Commander action, so this is call-site substitution only: no signature changes. Each now logs the returned filename, since marking renames the file to "CUI - <name>.zip". Includes-AI-Code: true Co-authored-by: Cursor <cursoragent@cursor.com>
Ten private write helpers were synchronous, so they could not await the CUI cover probe. Each becomes async and every caller awaits it. list-assignments used a blanket axios mock that shadowed the shared cover-endpoint default and left the probe without a status; it now goes through mockAxiosGet like the other specs. Includes-AI-Code: true Co-authored-by: Cursor <cursoragent@cursor.com>
Both were private static, so they could not reach an instance field to get at the CuiFileService. Nine call sites move from the static form to await this.writeJson(...). Includes-AI-Code: true Co-authored-by: Cursor <cursoragent@cursor.com>
One classified-outcome test per family, asserting the command produces "CUI - <name>.zip" with the cover sheet inside and logs that name. The marking logic itself stays covered by the CuiFileService unit tests. Includes-AI-Code: true Co-authored-by: Cursor <cursoragent@cursor.com>
Dennis Woditsch (dwoditsch)force-pushed
the
feat/SP-1173-cui-marking-json-commands
branch
from
August 10, 2026 12:14
aa47776 to
e80318dCompare
This was referenced Aug 10, 2026
Nikolai Fischer (nikolai-celonis)
approved these changes
Aug 10, 2026
Dennis Woditsch (dwoditsch)
marked this pull request as ready for review
August 11, 2026 05:26
Dennis Woditsch (dwoditsch)
requested review from
a team, Dusan Radosavljevic (Dusan-r), Ekta Dubey (EktaCelonis), Ivan Gandacov (IvanGandacov) and Oleg Goras (gorasoCelonis)
as code ownersAugust 11, 2026 05:26
3 tasks
| fileService.writeToFileWithGivenName(JSON.stringify(packageVersionTransport, null, 2), filename); | ||
| logger.info(FileService.fileDownloadedMessage + filename); | ||
| const writtenFilename = await this.cuiFileService.writeToFileWithGivenName(JSON.stringify(packageVersionTransport, null, 2), filename); | ||
| logger.info(FileService.fileDownloadedMessage + writtenFilename); |
Contributor
There was a problem hiding this comment.
Would it make sense to extract fileDownloadedMessage? CuiFileService is used now as a replacement but for logging we still rely on FileService, which does basically nothing. This question also applies for the other parts.
Another possibility: duplicate fileDownloadedMessage and use it in CuiFileService
Nikolai Fischer (nikolai-celonis)
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stacked on #405, which added the marking mechanism and the first two commands. This PR finishes the
--jsonrow: every remaining--jsonlisting and report is now marked.Scope: how the write is triggered
--jsonlistings and reportslist spaces,list packages--jsonlistings and reportslist assets/assignments/data-pools,config *,t2tc package list/diff,deployment *,asset-registry *-o, --outputToJsonFilereportsanalyze/import action-flows,export data-pool,import data-pools,t2tc package importreportconfig package export --zip,config branch export --zip,t2tc package export,export action-flows,pull packagepull asset/skill/data-pool/view-bookmarks/bookmarks,export bookmarksconfig package export,config branch export,t2tc package export --unzip--gitBranchvariantsconfig package export,config branch export,t2tc package exportBoth open questions from #405 are unaffected: how to mark an artifact that is already a zip, and what to do for directory output.
Relevant links
Checklist
Note
Medium Risk
Wide but mechanical refactor across many commands; behavior change when CUI applies (JSON becomes a classified zip) could surprise automation that expected
.jsonfilenames, though unclassified/no-cover paths stay the same.Overview
Completes CUI marking for every CLI path that writes
--jsonlistings and reports (building on the earlier marking mechanism).fileService.writeToFileWithGivenNameis replaced withCuiFileService.writeToFileWithGivenNameacross config management, deployment, asset-registry, studio assets, t2tc, and data-pool list/export flows so classified tenants get a cover sheet and aCUI - …zipartifact instead of a bare.json.Each affected service now constructs
CuiFileServicefrom context,awaits the async write helpers, and logs the actual filename returned (which may differ when marking applies). Console-only output is unchanged.Tests: new
cui-marking-json-commands.spec.tsexercises representative commands end-to-end (classified zip prefix, PDF cover, JSON payload inside the archive).list-assignments.spec.tsswitches to sharedmockAxiosGethelpers.Out of scope here:
-o/--outputToJsonFilereports, zip/directory exports, and data-pool batch import/export file writes still use plainfileService(follow-up PRs).Reviewed by Cursor Bugbot for commit e80318d. Bugbot is set up for automated code reviews on this repo. Configure here.