Uh oh!
There was an error while loading. Please reload this page.
SP-1173: extend CUI marking to single-file exports - #412
Draft
Dennis Woditsch (dwoditsch) wants to merge 3 commits into
Draft
Conversation
Route BaseManager.pull through CuiFileService so the five pull commands that emit one .yml or .json file get the same marking as the archive exports, and do the same for the standalone export bookmarks path. Includes-AI-Code: true Co-authored-by: Cursor <cursoragent@cursor.com>
One case per call site, asserting the classified name and that the archive carries the cover sheet plus the original payload. The asset case reads its entry back as YAML. Includes-AI-Code: true Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Aug 10, 2026
BaseManager.update had no test. Cover both branches through update data-pool, its only caller, which also needed a PUT error helper in the shared axios mock. Includes-AI-Code: true Co-authored-by: Cursor <cursoragent@cursor.com>
|
Nikolai Fischer (nikolai-celonis)
approved these changes
Aug 10, 2026
| @@ -18,24 +15,14 @@ export abstract class BaseManager { | |||
| } | |||
| public async pull(): Promise<any> { | |||
There was a problem hiding this comment.
Suggested change
| publicasyncpull(): Promise<any>{ | |
| publicasyncpull(): Promise<void>{ |
I don't work that much with Promises, but I think if you return nothing, it has to Promise
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stacked on #411, which finished the archive row. This PR takes the row below it: the six exports whose artifact is one
.ymlor.jsonfile. Nothing new mechanically, they go through the same path the--jsonreports use, so a classified file becomesCUI - <name>.zip.export bookmarkshas a--fileoption, so a user-chosen name is marked too.After this PR
CuiFileServiceis the only module in the CLI that writes a file a user receives. The directory tree is the single path left.Scope: how the write is triggered
--jsonlistings and reportslist spaces,list packages--jsonlistings and reportslist assets/assignments/data-pools,config *,t2tc package list/diff,deployment *,asset-registry *-o, --outputToJsonFilereportsanalyze/import action-flows,export data-pool,import data-pools,t2tc package importreportconfig package export --zip,config branch export --zip,t2tc package export,export action-flows,pull packagepull asset/skill/data-pool/view-bookmarks/bookmarks,export bookmarksconfig package export,config branch export,t2tc package export --unzip--gitBranchvariantsconfig package export,config branch export,t2tc package exportRelevant links
Checklist
Made with Cursor