Skip to content

This fixes #2589 - #2590

Merged
etimberg merged 1 commit into
chartjs:masterfrom
haschu:fix/2589
May 19, 2016
Merged

etimberg merged 1 commit into
chartjs:masterfrom
haschu:fix/2589

Conversation

@haschu

@haschu haschu commented May 18, 2016

Copy link
Copy Markdown
Contributor

Seems to be fixed.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 75.597% when pulling 577c140 on haschu:fix/2589 into 725ee1c on chartjs:master.

@etimberg

Copy link
Copy Markdown
Member

@haschu can you post before and after photos?

@haschu

haschu commented May 19, 2016

Copy link
Copy Markdown
Contributor Author

@etimberg here you go. Taken with #2584 fixed version.

Before:
bildschirmfoto 2016-05-19 um 10 27 24

After:
bildschirmfoto 2016-05-19 um 10 28 06

@etimberg
etimberg merged commit ecb7ce1 into chartjs:master May 19, 2016
@haschu

haschu commented May 19, 2016

Copy link
Copy Markdown
Contributor Author

@etimberg The same problem still exists for time scales, because there is a separat handling for showing the last tick. Going to fix this later today.
Should I open a new issue for that, or do you want to reopen the "old" one?

@haschu
haschu deleted the fix/2589 branch May 19, 2016 12:08
@haschu

haschu commented May 19, 2016

Copy link
Copy Markdown
Contributor Author

New Issue: #2599
New PR: #2600

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants