Skip to content

pagestore: exercise image layer publication crashes - #232

Merged
hurricane1026 merged 4 commits into
pagestorefrom
feat/pagestore-h1-layer-crash
Sep 8, 2026
Merged

pagestore: exercise image layer publication crashes#232
hurricane1026 merged 4 commits into
pagestorefrom
feat/pagestore-h1-layer-crash

Conversation

@hurricane1026

Copy link
Copy Markdown

Summary

  • add authenticated process-abort probes for POSIX image-layer create, write, seal, and manifest ADD stages
  • add a deterministic IPC sentinel workload and four declarative recovery scenarios
  • assert pre-recovery physical state, recovered manifest state, page/LSN integrity, and clean-restart convergence
  • wire the scenarios into Meson and standalone CI and update the MVP roadmap

Validation

  • ninja -C build-h1
  • python3 -m unittest discover -s contrib/pagestore/harness/tests (182 passed)
  • meson test -C build-h1 --suite pagestore --print-errorlogs (42 passed)
  • four new H1 scenarios repeated three times (12 passed)
  • workflow-equivalent standalone compilation

Scope

This covers POSIX process-abort recovery only. The write-before-seal stage does not claim power-loss durability. Physical crash-orphan cleanup remains out of scope until the store has cross-process ownership fencing.

@hurricane1026

Copy link
Copy Markdown
Author

@codex, review

@chatgpt-codex-connector

chatgpt-codex-connectorBot commented Sep 8, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

ReviewStatusCommitReview trigger
📝 Code ReviewCompleted2026-09-08T07:39:06.016280Z52ad06aDraft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit:6885c52f7a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@hurricane1026

Copy link
Copy Markdown
Author

@codex, review

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:ef95d56d9b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadcontrib/pagestore/harness/pagestore_harness.py Outdated
Comment threadcontrib/pagestore/harness/pagestore_harness.py
Comment threadcontrib/pagestore/harness/pagestore_harness.py Outdated
@hurricane1026

Copy link
Copy Markdown
Author

@codex, review

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:3c30fff954

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadcontrib/pagestore/harness/pagestore_harness.py Outdated
@hurricane1026

Copy link
Copy Markdown
Author

@codex, review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit:52ad06af7b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@hurricane1026
hurricane1026 marked this pull request as ready for review September 8, 2026 07:31
@hurricane1026
hurricane1026 merged commit 5f09239 into pagestoreSep 8, 2026
3 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@hurricane1026