Uh oh!
There was an error while loading. Please reload this page.
pagestore: fence POSIX recovery and reclaim orphan layers - #233
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
hurricane1026
commented
Sep 8, 2026
@codex, review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:98884cfe4a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
hurricane1026
commented
Sep 8, 2026
@codex, review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:55848bab2e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Uh oh!
There was an error while loading. Please reload this page.
hurricane1026
commented
Sep 8, 2026
@codex, review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:27fd0f727f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
hurricane1026
commented
Sep 8, 2026
@codex, review |
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Uh oh!
There was an error while loading. Please reload this page.
Summary
Follow up #232 with local POSIX store ownership and safe crash-orphan layer recovery.
.pagestore.lockinode across storage, layer-store, and manifest recovery/teardown. Competing processes fail before provider mutations; inherited handles cannot release the parent's lease..pagestore-orphan-sweep-inhibited; later restarts stay inhibited. Reject malformed markers and nonregular/aliased manifests.Validation
cc -O2 -Wall -Wextra -Werror -fsyntax-onlypassed.git diff --checkpassed.Scope and limitations
This is cooperative, local POSIX ownership and process-crash recovery. Older binaries/external tools that do not acquire the lock must remain stopped; never remove the persistent lock inode while a store is live. An ambiguous manifest repair permanently inhibits automatic sweeping pending explicit repair. No object-tier orphan sweep, power-loss certification, or SPDK runtime testing is claimed. The SPDK build source list is updated only to retain linkage with the shared POSIX module.