Skip to content

pagestore: exercise portable bootstrap installation crashes - #234

Merged
hurricane1026 merged 1 commit into
pagestorefrom
feat/pagestore-bootstrap-install-crash
Sep 8, 2026
Merged

pagestore: exercise portable bootstrap installation crashes#234
hurricane1026 merged 1 commit into
pagestorefrom
feat/pagestore-bootstrap-install-crash

Conversation

@hurricane1026

Copy link
Copy Markdown

Summary

Follow up #233 with the H1 portable branch bootstrap/install process-crash acceptance slice.

  • Add four portable-only named abort boundaries: after durable maps/bootstrap, in the pg_xact remove/rename gap, before final manifest publication, and after durable manifest publication.
  • Extend the composed golden scenario with exact fault-report/PID/exit-88 checks, absent-manifest startup fencing, prepared/control immutability, exact map and SLRU restoration, and byte-idempotent retries.
  • Preserve the final real SQL fork-point visibility, parent/child isolation, and restart checks.
  • Add a standalone Python artifact oracle with negative tests, wire Meson and CI, and update MVP coverage documents.
  • Preserve full reinstall semantics and isolate fault-state cleanup from legacy/reader installation paths.

Validation

  • Meson pagestore suite: 45/45 passed; final oracle test rerun passed.
  • Python harness tests: 198 passed.
  • Four-phase composed golden scenario: passed twice, including the final helper correction.
  • Full PostgreSQL integration_test.sh: passed.
  • Full PostgreSQL build and temporary installation succeeded.
  • bash syntax and git diff checks passed.
  • Sol architecture gate and independent Luna review approved after addressing the oracle commit-ts ordering finding.

Boundaries

Local POSIX process-abort coverage for one installer and an offline same-build, default-tablespace target. No concurrent-installer, external service-manager, power-loss, or SPDK runtime certification. Existing manifest-based readiness and full reinstall behavior are retained. Manifest replacement and reclaim/GC crash matrices remain follow-up tasks.

@chatgpt-codex-connector

chatgpt-codex-connectorBot commented Sep 8, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

ReviewStatusCommitReview trigger
📝 Code ReviewCompleted2026-09-08T13:53:21.328053Z3b0f6eeManual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@hurricane1026

Copy link
Copy Markdown
Author

@codex, review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit:3b0f6ee53f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@hurricane1026
hurricane1026 merged commit 9298549 into pagestoreSep 8, 2026
3 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@hurricane1026