Fix terminal scroll jumps after redraws and task switches - #253
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Terminal redraws that clear scrollback and stream replacement output in separate chunks could move the viewport above the latest output, especially after switching tasks. Defer bottom restoration until xterm's viewport updates and native scroll events settle, and resync the scrollbar when revealing a hidden terminal.
Preserve deliberate scrolling while output arrives or the terminal resizes. User input cancels pending corrections, and switching tasks discards late snapshots and callbacks for disposed terminals.
Validation: reproduced the original jump in Electron; the fix passed 100 redraw repetitions. Added an invisible Electron regression runner covering split redraws, manual scrolling, resizing, task switches, hidden output, and teardown (
bun apps/desktop/scripts/test-terminal-scroll.ts). Desktop and fixture typechecks, targeted Biome checks, andgit diff --checkpassed.