proxy: Use one proxy instance per VM

[jodh-intel]

Re-vendor virtcontainers and update the runtime to move to using one
proxy instance for each VM (pod). Also incorporates requires runtime
changes to take account of virtcontainers API changes.

virtcontainers changes since last re-vendor:

01b012b vendor: Move the ciao vendoring to ciao-project
148b06a proxy: Launch one proxy instance per pod
619300a proxy: Use CC3 proxy path
d8f2a22 shim: Only show shim-count if there are any
c993e45 shim: Quote urls in error

Fixes#795.

Signed-off-by: James O. D. Hunt james.o.hunt@intel.com

[jodh-intel]

Here is the "proper" PR that replaces #833. This will unbreak the virtcontainers tests (which pull in the runtime code), but this PR is going to fail at the CI stage until we get a new clear-containers-image package on the CI systems that includes clearcontainers/agent#160.

@erick0z, @gorozco1 - we might need to create a new clear-containers-image package early including the latest agent code.

/cc @sboeuf, @chavafg, @sameo.

Adding dnm tag to flag that this will break the CI tests currently.

[clearcontainersbot]

kubernetes qa-passed 👍

[chavafg]

Took a look at the logs and see these failures from unit tests:

16:40:22 INFO: Running 'go test' as current user on packages '.' with flags '-v -race -timeout 10s'
16:40:28 # github.com/clearcontainers/runtime
16:40:28 ./cc-env_test.go:137: unknown field 'URL' in struct literal of type ProxyInfo
16:40:28 ./cc-env_test.go:746: unknown field 'URL' in struct literal of type ProxyInfo
16:40:28 ./config_test.go:143: unknown field 'URL' in struct literal of type virtcontainers.CCProxyConfig
16:40:28 ./config_test.go:510: unknown field 'URL' in struct literal of type virtcontainers.CCProxyConfig
16:40:28 ./config_test.go:789: p.url undefined (type proxy has no field or method url)
16:40:28 ./config_test.go:789: undefined: defaultProxyURL
16:40:28 ./config_test.go:792: p.URL undefined (type proxy has no field or method URL)
16:40:28 ./config_test.go:793: p.url undefined (type proxy has no field or method url)
16:40:28 FAIL	github.com/clearcontainers/runtime [build failed]
16:40:28 make: *** [Makefile:307: check-go-test] Error 2
16:40:28 Build step 'Execute shell' marked build as failure

[jodh-intel]

Ouch - fixing...

[jodh-intel]

Branch updated.

[gorozco1]

cc @jcvenegas

[clearcontainersbot]

kubernetes qa-passed 👍

[jcvenegas]

@jodh-intel the image with last agent changes is out, can review clearcontainers/tests#761 ?

[jodh-intel]

Hi @jcvenegas - thanks - I've re-pushed to trigger a re-test.

However, I was actually expecting the tests to fail before the agent was updated on clearcontainers/tests#761, so I don't think this should be part of todays release - we need to understand the results before it's merged.

[clearcontainersbot]

kubernetes qa-passed 👍

[jodh-intel]

I've re-tested this branch with 3.0.9 and it's all working fine.

Also confirmed that this PR fails when testing with image version 19030, but passes with 19070 and 19350 (which contain the required agent changes).

[jodh-intel]

@grahamwhaley, @sameo - could you review so we can unbreak the virtcontainers builds?

[sameo]

LGTM