refactor(scripts): consolidate releaser into scripts/lib by wyattjoh · Pull Request #134 · clerk/cli

wyattjoh · 2026-04-09T19:51:39Z

Reorganizes the scripts directory to reduce nesting and improve cohesion.

Move scripts/releaser/targets.ts to scripts/lib/targets.ts — already shared by build.ts and sign-macos.ts, now lives with other shared lib utilities
Add run() and publish() to scripts/lib/npm.ts alongside the existing isPublished() — all npm subprocess logic in one place
Flatten scripts/releaser/index.ts to scripts/releaser.ts — the subdirectory only held one file
Update import paths in build.ts, sign-macos.ts, and package.json

wyattjoh · 2026-04-09T19:51:46Z

Stack: npm-publishing-fixes

refactor(scripts): consolidate releaser into scripts/lib #134 👈 this PR
- chore(ci): remove NODE_AUTH_TOKEN once OIDC trusted publishing is enabled #135

Part of a stacked PR chain. Do not merge manually.

coderabbitai · 2026-04-09T21:05:35Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 350d2bf4-d74d-4ece-b8bb-bd35bd31e09e

📥 Commits

Reviewing files that changed from the base of the PR and between f031159 and 31f96b0.

📒 Files selected for processing (6)

package.json
scripts/build.ts
scripts/lib/npm.ts
scripts/lib/targets.ts
scripts/releaser.ts
scripts/sign-macos.ts

✅ Files skipped from review due to trivial changes (3)

scripts/build.ts
scripts/lib/targets.ts
package.json

🚧 Files skipped from review as they are similar to previous changes (2)

scripts/sign-macos.ts
scripts/lib/npm.ts

📝 Walkthrough

Walkthrough

NPM release scripts were changed to run scripts/releaser.ts (preserving --tag canary/snapshot). Common utilities and target definitions were moved/centralized under scripts/lib/: a new scripts/lib/npm.ts exports run and publish, and scripts/lib/targets.ts is now the source for targets. Import paths in scripts/releaser.ts, scripts/build.ts, and scripts/sign-macos.ts were updated to the new locations. scripts/releaser.ts had several local helper functions removed in favor of the imported helpers and its artifact/wrapper package path constants were adjusted upward one directory. Minor comment edits only.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 60.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely summarizes the main change: consolidating the releaser functionality into the scripts/lib directory to reduce nesting.
Description check	✅ Passed	The description is directly related to the changeset, providing clear details about the reorganization, file movements, and import path updates.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

- Move targets to scripts/lib/targets.ts (shared by build, sign-macos, and releaser) - Move run() and publish() helpers into scripts/lib/npm.ts alongside the existing isPublished() - Flatten scripts/releaser/index.ts to scripts/releaser.ts now that the directory only held one file - Update import paths in build.ts, sign-macos.ts, and package.json

wyattjoh · 2026-04-09T21:43:05Z

!snapshot

github-actions · 2026-04-09T21:47:36Z

Snapshot published

npm install -g clerk@0.0.2-snapshot.v20260409214324

Package	Version
`clerk`	`0.0.2-snapshot.v20260409214324`

Published from 31f96b0

PR #134 moved shared helpers to scripts/lib/ but the sparse checkout in sign-macos.yml was never updated, causing `Cannot find module './lib/targets.ts'`.

wyattjoh · 2026-04-09T19:51:39Z

Reorganizes the scripts directory to reduce nesting and improve cohesion.

Move scripts/releaser/targets.ts to scripts/lib/targets.ts — already shared by build.ts and sign-macos.ts, now lives with other shared lib utilities
Add run() and publish() to scripts/lib/npm.ts alongside the existing isPublished() — all npm subprocess logic in one place
Flatten scripts/releaser/index.ts to scripts/releaser.ts — the subdirectory only held one file
Update import paths in build.ts, sign-macos.ts, and package.json

wyattjoh · 2026-04-09T19:51:46Z

Stack: npm-publishing-fixes

refactor(scripts): consolidate releaser into scripts/lib #134 👈 this PR
- chore(ci): remove NODE_AUTH_TOKEN once OIDC trusted publishing is enabled #135

Part of a stacked PR chain. Do not merge manually.

coderabbitai · 2026-04-09T21:05:35Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 350d2bf4-d74d-4ece-b8bb-bd35bd31e09e

📥 Commits

Reviewing files that changed from the base of the PR and between f031159 and 31f96b0.

📒 Files selected for processing (6)

package.json
scripts/build.ts
scripts/lib/npm.ts
scripts/lib/targets.ts
scripts/releaser.ts
scripts/sign-macos.ts

✅ Files skipped from review due to trivial changes (3)

scripts/build.ts
scripts/lib/targets.ts
package.json

🚧 Files skipped from review as they are similar to previous changes (2)

scripts/sign-macos.ts
scripts/lib/npm.ts

📝 Walkthrough

Walkthrough

NPM release scripts were changed to run scripts/releaser.ts (preserving --tag canary/snapshot). Common utilities and target definitions were moved/centralized under scripts/lib/: a new scripts/lib/npm.ts exports run and publish, and scripts/lib/targets.ts is now the source for targets. Import paths in scripts/releaser.ts, scripts/build.ts, and scripts/sign-macos.ts were updated to the new locations. scripts/releaser.ts had several local helper functions removed in favor of the imported helpers and its artifact/wrapper package path constants were adjusted upward one directory. Minor comment edits only.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 60.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely summarizes the main change: consolidating the releaser functionality into the scripts/lib directory to reduce nesting.
Description check	✅ Passed	The description is directly related to the changeset, providing clear details about the reorganization, file movements, and import path updates.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

- Move targets to scripts/lib/targets.ts (shared by build, sign-macos, and releaser) - Move run() and publish() helpers into scripts/lib/npm.ts alongside the existing isPublished() - Flatten scripts/releaser/index.ts to scripts/releaser.ts now that the directory only held one file - Update import paths in build.ts, sign-macos.ts, and package.json

wyattjoh · 2026-04-09T21:43:05Z

!snapshot

github-actions · 2026-04-09T21:47:36Z

Snapshot published

npm install -g clerk@0.0.2-snapshot.v20260409214324

Package	Version
`clerk`	`0.0.2-snapshot.v20260409214324`

Published from 31f96b0

PR #134 moved shared helpers to scripts/lib/ but the sparse checkout in sign-macos.yml was never updated, causing `Cannot find module './lib/targets.ts'`.

wyattjoh · 2026-04-09T19:51:39Z

Reorganizes the scripts directory to reduce nesting and improve cohesion.

Move scripts/releaser/targets.ts to scripts/lib/targets.ts — already shared by build.ts and sign-macos.ts, now lives with other shared lib utilities
Add run() and publish() to scripts/lib/npm.ts alongside the existing isPublished() — all npm subprocess logic in one place
Flatten scripts/releaser/index.ts to scripts/releaser.ts — the subdirectory only held one file
Update import paths in build.ts, sign-macos.ts, and package.json

wyattjoh · 2026-04-09T19:51:46Z

Stack: npm-publishing-fixes

refactor(scripts): consolidate releaser into scripts/lib #134 👈 this PR
- chore(ci): remove NODE_AUTH_TOKEN once OIDC trusted publishing is enabled #135

Part of a stacked PR chain. Do not merge manually.

coderabbitai · 2026-04-09T21:05:35Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 350d2bf4-d74d-4ece-b8bb-bd35bd31e09e

📥 Commits

Reviewing files that changed from the base of the PR and between f031159 and 31f96b0.

📒 Files selected for processing (6)

package.json
scripts/build.ts
scripts/lib/npm.ts
scripts/lib/targets.ts
scripts/releaser.ts
scripts/sign-macos.ts

✅ Files skipped from review due to trivial changes (3)

scripts/build.ts
scripts/lib/targets.ts
package.json

🚧 Files skipped from review as they are similar to previous changes (2)

scripts/sign-macos.ts
scripts/lib/npm.ts

📝 Walkthrough

Walkthrough

NPM release scripts were changed to run scripts/releaser.ts (preserving --tag canary/snapshot). Common utilities and target definitions were moved/centralized under scripts/lib/: a new scripts/lib/npm.ts exports run and publish, and scripts/lib/targets.ts is now the source for targets. Import paths in scripts/releaser.ts, scripts/build.ts, and scripts/sign-macos.ts were updated to the new locations. scripts/releaser.ts had several local helper functions removed in favor of the imported helpers and its artifact/wrapper package path constants were adjusted upward one directory. Minor comment edits only.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 60.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely summarizes the main change: consolidating the releaser functionality into the scripts/lib directory to reduce nesting.
Description check	✅ Passed	The description is directly related to the changeset, providing clear details about the reorganization, file movements, and import path updates.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

- Move targets to scripts/lib/targets.ts (shared by build, sign-macos, and releaser) - Move run() and publish() helpers into scripts/lib/npm.ts alongside the existing isPublished() - Flatten scripts/releaser/index.ts to scripts/releaser.ts now that the directory only held one file - Update import paths in build.ts, sign-macos.ts, and package.json

wyattjoh · 2026-04-09T21:43:05Z

!snapshot

github-actions · 2026-04-09T21:47:36Z

Snapshot published

npm install -g clerk@0.0.2-snapshot.v20260409214324

Package	Version
`clerk`	`0.0.2-snapshot.v20260409214324`

Published from 31f96b0

PR #134 moved shared helpers to scripts/lib/ but the sparse checkout in sign-macos.yml was never updated, causing `Cannot find module './lib/targets.ts'`.

wyattjoh · 2026-04-09T19:51:39Z

Reorganizes the scripts directory to reduce nesting and improve cohesion.

Move scripts/releaser/targets.ts to scripts/lib/targets.ts — already shared by build.ts and sign-macos.ts, now lives with other shared lib utilities
Add run() and publish() to scripts/lib/npm.ts alongside the existing isPublished() — all npm subprocess logic in one place
Flatten scripts/releaser/index.ts to scripts/releaser.ts — the subdirectory only held one file
Update import paths in build.ts, sign-macos.ts, and package.json

wyattjoh · 2026-04-09T19:51:46Z

Stack: npm-publishing-fixes

refactor(scripts): consolidate releaser into scripts/lib #134 👈 this PR
- chore(ci): remove NODE_AUTH_TOKEN once OIDC trusted publishing is enabled #135

Part of a stacked PR chain. Do not merge manually.

coderabbitai · 2026-04-09T21:05:35Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 350d2bf4-d74d-4ece-b8bb-bd35bd31e09e

📥 Commits

Reviewing files that changed from the base of the PR and between f031159 and 31f96b0.

📒 Files selected for processing (6)

package.json
scripts/build.ts
scripts/lib/npm.ts
scripts/lib/targets.ts
scripts/releaser.ts
scripts/sign-macos.ts

✅ Files skipped from review due to trivial changes (3)

scripts/build.ts
scripts/lib/targets.ts
package.json

🚧 Files skipped from review as they are similar to previous changes (2)

scripts/sign-macos.ts
scripts/lib/npm.ts

📝 Walkthrough

Walkthrough

NPM release scripts were changed to run scripts/releaser.ts (preserving --tag canary/snapshot). Common utilities and target definitions were moved/centralized under scripts/lib/: a new scripts/lib/npm.ts exports run and publish, and scripts/lib/targets.ts is now the source for targets. Import paths in scripts/releaser.ts, scripts/build.ts, and scripts/sign-macos.ts were updated to the new locations. scripts/releaser.ts had several local helper functions removed in favor of the imported helpers and its artifact/wrapper package path constants were adjusted upward one directory. Minor comment edits only.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 60.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely summarizes the main change: consolidating the releaser functionality into the scripts/lib directory to reduce nesting.
Description check	✅ Passed	The description is directly related to the changeset, providing clear details about the reorganization, file movements, and import path updates.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

- Move targets to scripts/lib/targets.ts (shared by build, sign-macos, and releaser) - Move run() and publish() helpers into scripts/lib/npm.ts alongside the existing isPublished() - Flatten scripts/releaser/index.ts to scripts/releaser.ts now that the directory only held one file - Update import paths in build.ts, sign-macos.ts, and package.json

wyattjoh · 2026-04-09T21:43:05Z

!snapshot

github-actions · 2026-04-09T21:47:36Z

Snapshot published

npm install -g clerk@0.0.2-snapshot.v20260409214324

Package	Version
`clerk`	`0.0.2-snapshot.v20260409214324`

Published from 31f96b0

PR #134 moved shared helpers to scripts/lib/ but the sparse checkout in sign-macos.yml was never updated, causing `Cannot find module './lib/targets.ts'`.

wyattjoh · 2026-04-09T19:51:39Z

Reorganizes the scripts directory to reduce nesting and improve cohesion.

Move scripts/releaser/targets.ts to scripts/lib/targets.ts — already shared by build.ts and sign-macos.ts, now lives with other shared lib utilities
Add run() and publish() to scripts/lib/npm.ts alongside the existing isPublished() — all npm subprocess logic in one place
Flatten scripts/releaser/index.ts to scripts/releaser.ts — the subdirectory only held one file
Update import paths in build.ts, sign-macos.ts, and package.json

wyattjoh · 2026-04-09T19:51:46Z

Stack: npm-publishing-fixes

refactor(scripts): consolidate releaser into scripts/lib #134 👈 this PR
- chore(ci): remove NODE_AUTH_TOKEN once OIDC trusted publishing is enabled #135

Part of a stacked PR chain. Do not merge manually.

coderabbitai · 2026-04-09T21:05:35Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 350d2bf4-d74d-4ece-b8bb-bd35bd31e09e

📥 Commits

Reviewing files that changed from the base of the PR and between f031159 and 31f96b0.

📒 Files selected for processing (6)

package.json
scripts/build.ts
scripts/lib/npm.ts
scripts/lib/targets.ts
scripts/releaser.ts
scripts/sign-macos.ts

✅ Files skipped from review due to trivial changes (3)

scripts/build.ts
scripts/lib/targets.ts
package.json

🚧 Files skipped from review as they are similar to previous changes (2)

scripts/sign-macos.ts
scripts/lib/npm.ts

📝 Walkthrough

Walkthrough

NPM release scripts were changed to run scripts/releaser.ts (preserving --tag canary/snapshot). Common utilities and target definitions were moved/centralized under scripts/lib/: a new scripts/lib/npm.ts exports run and publish, and scripts/lib/targets.ts is now the source for targets. Import paths in scripts/releaser.ts, scripts/build.ts, and scripts/sign-macos.ts were updated to the new locations. scripts/releaser.ts had several local helper functions removed in favor of the imported helpers and its artifact/wrapper package path constants were adjusted upward one directory. Minor comment edits only.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 60.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely summarizes the main change: consolidating the releaser functionality into the scripts/lib directory to reduce nesting.
Description check	✅ Passed	The description is directly related to the changeset, providing clear details about the reorganization, file movements, and import path updates.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

- Move targets to scripts/lib/targets.ts (shared by build, sign-macos, and releaser) - Move run() and publish() helpers into scripts/lib/npm.ts alongside the existing isPublished() - Flatten scripts/releaser/index.ts to scripts/releaser.ts now that the directory only held one file - Update import paths in build.ts, sign-macos.ts, and package.json

wyattjoh · 2026-04-09T21:43:05Z

!snapshot

github-actions · 2026-04-09T21:47:36Z

Snapshot published

npm install -g clerk@0.0.2-snapshot.v20260409214324

Package	Version
`clerk`	`0.0.2-snapshot.v20260409214324`

Published from 31f96b0

PR #134 moved shared helpers to scripts/lib/ but the sparse checkout in sign-macos.yml was never updated, causing `Cannot find module './lib/targets.ts'`.

wyattjoh · 2026-04-09T19:51:39Z

Reorganizes the scripts directory to reduce nesting and improve cohesion.

Move scripts/releaser/targets.ts to scripts/lib/targets.ts — already shared by build.ts and sign-macos.ts, now lives with other shared lib utilities
Add run() and publish() to scripts/lib/npm.ts alongside the existing isPublished() — all npm subprocess logic in one place
Flatten scripts/releaser/index.ts to scripts/releaser.ts — the subdirectory only held one file
Update import paths in build.ts, sign-macos.ts, and package.json

wyattjoh · 2026-04-09T19:51:46Z

Stack: npm-publishing-fixes

refactor(scripts): consolidate releaser into scripts/lib #134 👈 this PR
- chore(ci): remove NODE_AUTH_TOKEN once OIDC trusted publishing is enabled #135

Part of a stacked PR chain. Do not merge manually.

coderabbitai · 2026-04-09T21:05:35Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 350d2bf4-d74d-4ece-b8bb-bd35bd31e09e

📥 Commits

Reviewing files that changed from the base of the PR and between f031159 and 31f96b0.

📒 Files selected for processing (6)

package.json
scripts/build.ts
scripts/lib/npm.ts
scripts/lib/targets.ts
scripts/releaser.ts
scripts/sign-macos.ts

✅ Files skipped from review due to trivial changes (3)

scripts/build.ts
scripts/lib/targets.ts
package.json

🚧 Files skipped from review as they are similar to previous changes (2)

scripts/sign-macos.ts
scripts/lib/npm.ts

📝 Walkthrough

Walkthrough

NPM release scripts were changed to run scripts/releaser.ts (preserving --tag canary/snapshot). Common utilities and target definitions were moved/centralized under scripts/lib/: a new scripts/lib/npm.ts exports run and publish, and scripts/lib/targets.ts is now the source for targets. Import paths in scripts/releaser.ts, scripts/build.ts, and scripts/sign-macos.ts were updated to the new locations. scripts/releaser.ts had several local helper functions removed in favor of the imported helpers and its artifact/wrapper package path constants were adjusted upward one directory. Minor comment edits only.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 60.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely summarizes the main change: consolidating the releaser functionality into the scripts/lib directory to reduce nesting.
Description check	✅ Passed	The description is directly related to the changeset, providing clear details about the reorganization, file movements, and import path updates.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

- Move targets to scripts/lib/targets.ts (shared by build, sign-macos, and releaser) - Move run() and publish() helpers into scripts/lib/npm.ts alongside the existing isPublished() - Flatten scripts/releaser/index.ts to scripts/releaser.ts now that the directory only held one file - Update import paths in build.ts, sign-macos.ts, and package.json

wyattjoh · 2026-04-09T21:43:05Z

!snapshot

github-actions · 2026-04-09T21:47:36Z

Snapshot published

npm install -g clerk@0.0.2-snapshot.v20260409214324

Package	Version
`clerk`	`0.0.2-snapshot.v20260409214324`

Published from 31f96b0

PR #134 moved shared helpers to scripts/lib/ but the sparse checkout in sign-macos.yml was never updated, causing `Cannot find module './lib/targets.ts'`.

wyattjoh · 2026-04-09T19:51:39Z

Reorganizes the scripts directory to reduce nesting and improve cohesion.

Move scripts/releaser/targets.ts to scripts/lib/targets.ts — already shared by build.ts and sign-macos.ts, now lives with other shared lib utilities
Add run() and publish() to scripts/lib/npm.ts alongside the existing isPublished() — all npm subprocess logic in one place
Flatten scripts/releaser/index.ts to scripts/releaser.ts — the subdirectory only held one file
Update import paths in build.ts, sign-macos.ts, and package.json

wyattjoh · 2026-04-09T19:51:46Z

Stack: npm-publishing-fixes

refactor(scripts): consolidate releaser into scripts/lib #134 👈 this PR
- chore(ci): remove NODE_AUTH_TOKEN once OIDC trusted publishing is enabled #135

Part of a stacked PR chain. Do not merge manually.

coderabbitai · 2026-04-09T21:05:35Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 350d2bf4-d74d-4ece-b8bb-bd35bd31e09e

📥 Commits

Reviewing files that changed from the base of the PR and between f031159 and 31f96b0.

📒 Files selected for processing (6)

package.json
scripts/build.ts
scripts/lib/npm.ts
scripts/lib/targets.ts
scripts/releaser.ts
scripts/sign-macos.ts

✅ Files skipped from review due to trivial changes (3)

scripts/build.ts
scripts/lib/targets.ts
package.json

🚧 Files skipped from review as they are similar to previous changes (2)

scripts/sign-macos.ts
scripts/lib/npm.ts

📝 Walkthrough

Walkthrough

NPM release scripts were changed to run scripts/releaser.ts (preserving --tag canary/snapshot). Common utilities and target definitions were moved/centralized under scripts/lib/: a new scripts/lib/npm.ts exports run and publish, and scripts/lib/targets.ts is now the source for targets. Import paths in scripts/releaser.ts, scripts/build.ts, and scripts/sign-macos.ts were updated to the new locations. scripts/releaser.ts had several local helper functions removed in favor of the imported helpers and its artifact/wrapper package path constants were adjusted upward one directory. Minor comment edits only.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 60.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely summarizes the main change: consolidating the releaser functionality into the scripts/lib directory to reduce nesting.
Description check	✅ Passed	The description is directly related to the changeset, providing clear details about the reorganization, file movements, and import path updates.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

- Move targets to scripts/lib/targets.ts (shared by build, sign-macos, and releaser) - Move run() and publish() helpers into scripts/lib/npm.ts alongside the existing isPublished() - Flatten scripts/releaser/index.ts to scripts/releaser.ts now that the directory only held one file - Update import paths in build.ts, sign-macos.ts, and package.json

wyattjoh · 2026-04-09T21:43:05Z

!snapshot

github-actions · 2026-04-09T21:47:36Z

Snapshot published

npm install -g clerk@0.0.2-snapshot.v20260409214324

Package	Version
`clerk`	`0.0.2-snapshot.v20260409214324`

Published from 31f96b0

PR #134 moved shared helpers to scripts/lib/ but the sparse checkout in sign-macos.yml was never updated, causing `Cannot find module './lib/targets.ts'`.

wyattjoh · 2026-04-09T19:51:39Z

Reorganizes the scripts directory to reduce nesting and improve cohesion.

Move scripts/releaser/targets.ts to scripts/lib/targets.ts — already shared by build.ts and sign-macos.ts, now lives with other shared lib utilities
Add run() and publish() to scripts/lib/npm.ts alongside the existing isPublished() — all npm subprocess logic in one place
Flatten scripts/releaser/index.ts to scripts/releaser.ts — the subdirectory only held one file
Update import paths in build.ts, sign-macos.ts, and package.json

wyattjoh · 2026-04-09T19:51:46Z

Stack: npm-publishing-fixes

refactor(scripts): consolidate releaser into scripts/lib #134 👈 this PR
- chore(ci): remove NODE_AUTH_TOKEN once OIDC trusted publishing is enabled #135

Part of a stacked PR chain. Do not merge manually.

coderabbitai · 2026-04-09T21:05:35Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 350d2bf4-d74d-4ece-b8bb-bd35bd31e09e

📥 Commits

Reviewing files that changed from the base of the PR and between f031159 and 31f96b0.

📒 Files selected for processing (6)

package.json
scripts/build.ts
scripts/lib/npm.ts
scripts/lib/targets.ts
scripts/releaser.ts
scripts/sign-macos.ts

✅ Files skipped from review due to trivial changes (3)

scripts/build.ts
scripts/lib/targets.ts
package.json

🚧 Files skipped from review as they are similar to previous changes (2)

scripts/sign-macos.ts
scripts/lib/npm.ts

📝 Walkthrough

Walkthrough

NPM release scripts were changed to run scripts/releaser.ts (preserving --tag canary/snapshot). Common utilities and target definitions were moved/centralized under scripts/lib/: a new scripts/lib/npm.ts exports run and publish, and scripts/lib/targets.ts is now the source for targets. Import paths in scripts/releaser.ts, scripts/build.ts, and scripts/sign-macos.ts were updated to the new locations. scripts/releaser.ts had several local helper functions removed in favor of the imported helpers and its artifact/wrapper package path constants were adjusted upward one directory. Minor comment edits only.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 60.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely summarizes the main change: consolidating the releaser functionality into the scripts/lib directory to reduce nesting.
Description check	✅ Passed	The description is directly related to the changeset, providing clear details about the reorganization, file movements, and import path updates.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

- Move targets to scripts/lib/targets.ts (shared by build, sign-macos, and releaser) - Move run() and publish() helpers into scripts/lib/npm.ts alongside the existing isPublished() - Flatten scripts/releaser/index.ts to scripts/releaser.ts now that the directory only held one file - Update import paths in build.ts, sign-macos.ts, and package.json

wyattjoh · 2026-04-09T21:43:05Z

!snapshot

github-actions · 2026-04-09T21:47:36Z

Snapshot published

npm install -g clerk@0.0.2-snapshot.v20260409214324

Package	Version
`clerk`	`0.0.2-snapshot.v20260409214324`

Published from 31f96b0

PR #134 moved shared helpers to scripts/lib/ but the sparse checkout in sign-macos.yml was never updated, causing `Cannot find module './lib/targets.ts'`.

wyattjoh mentioned this pull request Apr 9, 2026
fix(ci): add NODE_AUTH_TOKEN to npm publish steps #133
Merged

wyattjoh mentioned this pull request Apr 9, 2026
chore(ci): remove NODE_AUTH_TOKEN once OIDC trusted publishing is enabled #135
Merged

Base automatically changed from fix/npm-publish-auth to mainApril 9, 2026 20:20

wyattjoh changed the base branch from main to fix/ci-release-node-ltsApril 9, 2026 20:50

wyattjoh mentioned this pull request Apr 9, 2026
fix(ci): upgrade npm publish jobs to Node.js LTS #139
Merged

wyattjoh force-pushed the refactor/scripts-releaser branch 3 times, most recently from 26e0afd to 5ea4dbbCompare April 9, 2026 20:56

Base automatically changed from fix/ci-release-node-lts to mainApril 9, 2026 21:01

wyattjoh force-pushed the refactor/scripts-releaser branch from 5ea4dbb to 7d8511fCompare April 9, 2026 21:02

wyattjoh marked this pull request as ready for review April 9, 2026 21:02

wyattjoh force-pushed the refactor/scripts-releaser branch from 7d8511f to f031159Compare April 9, 2026 21:10

wyattjoh changed the base branch from main to fix/disable-npm-provenanceApril 9, 2026 21:10

wyattjoh marked this pull request as draft April 9, 2026 21:10

This was referenced Apr 9, 2026
fix(scripts): disable npm provenance for private repo #140
Closed
fix(scripts): disable npm provenance for private repo #141
Merged

Base automatically changed from fix/disable-npm-provenance to mainApril 9, 2026 21:14

wyattjoh force-pushed the refactor/scripts-releaser branch from f031159 to 31f96b0Compare April 9, 2026 21:38

wyattjoh marked this pull request as ready for review April 9, 2026 21:39

rafa-thayto approved these changes Apr 9, 2026
View reviewed changes

Railly approved these changes Apr 9, 2026
View reviewed changes

wyattjoh merged commit 5affe13 into mainApr 9, 2026
6 checks passed

wyattjoh deleted the refactor/scripts-releaser branch April 9, 2026 21:56

rafa-thayto added a commit that referenced this pull request Apr 10, 2026
fix(ci): add scripts/lib/ to sign-macos sparse checkout
eade9b4
PR #134 moved shared helpers to scripts/lib/ but the sparse checkout in sign-macos.yml was never updated, causing `Cannot find module './lib/targets.ts'`.

rafa-thayto added a commit that referenced this pull request Apr 10, 2026
fix(ci): add scripts/lib/ to sign-macos sparse checkout
8c6e477
PR #134 moved shared helpers to scripts/lib/ but the sparse checkout in sign-macos.yml was never updated, causing `Cannot find module './lib/targets.ts'`.

rafa-thayto mentioned this pull request Apr 10, 2026
fix(ci): add scripts/lib/ to sign-macos sparse checkout #143
Merged
1 task