chore(clerk-js): Deprecate FormControl by panteliselef · Pull Request #1912 · clerk/javascript

panteliselef · 2023-10-18T10:49:48Z

Description

This is PR starts the refactoring process for our forms. The main focus is refactoring how our fields are structure, starting the PlainInput which represents a simple input element.

In the immediate feature we want to completely drop Form.Control and offer these alternatives

Form.PasswordInput
Form.Checkbox
Form.RadioGroup
Form.InputGroup

Their API will remain simple and those will be opinionated about the UI they represent, the underlying implementation will allow for easy changes tho.

Replace Form.Control with Form.PlainInput (example usage)
Top level API remains simple, but the internally Form.PlainInput is very modular.
Renaming contexts and hooks with the field prefix in order to clearly indicate that the internal state reflects to a field not the entire form
- FormFieldContextProvider replaces FormControlContextProvider (both need to co-exist until the refactor is complete)
Force the usage of isDisabled, isRequired over the native html attributes

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

Packages affected

changeset-bot · 2023-10-18T10:49:52Z

🦋 Changeset detected

Latest commit: b59249e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@clerk/clerk-js	Patch
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

desiprisg · 2023-10-25T17:43:32Z

+ LabelRow: FieldLabelRow,
+ Input: InputElement,
+ Action: FieldAction,
+ AsOptional: FieldOptionalLabel,


Maybe rename this to OptionalLabel ?

anagstef

@panteliselef great stuff! just commit the changes we talked about and it's good to go.

anagstef

💯

dimkl

Let's add the deprecation of the FormControl in the main-v4 branch and open a clean-up PR from the main.

desiprisg · 2023-10-31T10:42:21Z

 * Stand-alone express middlewares bound to the pre-initialised clerkClient
 */
-export const ClerkExpressRequireAuth = (...args: any) => {
+export const ClerkExpressRequireAuth = (...args: Parameters<ReturnType<typeof createClerkExpressRequireAuth>>) => {


Is this meant to be in this PR?

no! Should be dropped from this PR

This is now dropped 🔥

panteliselef requested a review from a team as a code owner October 18, 2023 10:49

panteliselef self-assigned this Oct 18, 2023

clerk-cookie added the clerk-js label Oct 18, 2023

panteliselef force-pushed the elef/SDK-674-form-control-provider branch from fd3d8b7 to bddf7adCompare October 18, 2023 10:55

desiprisg reviewed Oct 25, 2023
View reviewed changes