Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 469
chore(clerk-js): Deprecate FormControl#1912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Uh oh!
There was an error while loading. Please reload this page.
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@clerk/clerk-js': patch | ||
| --- | ||
| Internal refactoring of form fields, deprecation of Form.Control and introduction of Form.PlainInput. |
4 changes: 2 additions & 2 deletions
4 packages/clerk-js/src/ui/components/OrganizationProfile/AddDomainPage.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 16 additions & 24 deletions
40 packages/clerk-js/src/ui/components/SignUp/SignUpForm.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4 packages/clerk-js/src/ui/components/UserProfile/UsernamePage.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,225 @@ | ||
| import type { FieldId } from '@clerk/types'; | ||
| import type { PropsWithChildren } from 'react'; | ||
| import React, { forwardRef } from 'react'; | ||
| import type { LocalizationKey } from '../customizables'; | ||
| import { | ||
| descriptors, | ||
| Flex, | ||
| FormControl as FormControlPrim, | ||
| FormLabel, | ||
| Icon as IconCustomizable, | ||
| Input, | ||
| Link, | ||
| localizationKeys, | ||
| Text, | ||
| useLocalizations, | ||
| } from '../customizables'; | ||
| import { FormFieldContextProvider, sanitizeInputProps, useFormField } from '../primitives/hooks'; | ||
| import type { PropsOfComponent } from '../styledSystem'; | ||
| import type { useFormControl as useFormControlUtil } from '../utils'; | ||
| import { useFormControlFeedback } from '../utils'; | ||
| import { useCardState } from './contexts'; | ||
| import type { FormFeedbackProps } from './FormControl'; | ||
| import { FormFeedback } from './FormControl'; | ||
| type FormControlProps = Omit<PropsOfComponent<typeof Input>, 'label' | 'placeholder' | 'disabled' | 'required'> & | ||
| ReturnType<typeof useFormControlUtil<FieldId>>['props']; | ||
| const Root = (props: PropsWithChildren<FormControlProps>) => { | ||
| const card = useCardState(); | ||
| const { | ||
| id, | ||
| isRequired, | ||
| sx, | ||
| setError, | ||
| setInfo, | ||
| setSuccess, | ||
| setWarning, | ||
| setHasPassedComplexity, | ||
| clearFeedback, | ||
| feedbackType, | ||
| feedback, | ||
| isFocused, | ||
| } = props; | ||
| const { debounced: debouncedState } = useFormControlFeedback({ feedback, feedbackType, isFocused }); | ||
| const isDisabled = props.isDisabled || card.isLoading; | ||
| return ( | ||
| <FormFieldContextProvider {...{ ...props, isDisabled }}> | ||
| {/*Most of our primitives still depend on this provider.*/} | ||
| {/*TODO: In follow-up PRs these will be removed*/} | ||
| <FormControlPrim | ||
| elementDescriptor={descriptors.formField} | ||
| elementId={descriptors.formField.setId(id)} | ||
| id={id} | ||
| hasError={debouncedState.feedbackType === 'error'} | ||
| isDisabled={isDisabled} | ||
| isRequired={isRequired} | ||
| setError={setError} | ||
| setSuccess={setSuccess} | ||
| setWarning={setWarning} | ||
| setInfo={setInfo} | ||
| setHasPassedComplexity={setHasPassedComplexity} | ||
| clearFeedback={clearFeedback} | ||
| sx={sx} | ||
| > | ||
| {props.children} | ||
| </FormControlPrim> | ||
| </FormFieldContextProvider> | ||
| ); | ||
| }; | ||
| const FieldAction = ( | ||
| props: PropsWithChildren<{ localizationKey?: LocalizationKey | string; onClick?: React.MouseEventHandler }>, | ||
| ) => { | ||
| const { fieldId, isDisabled } = useFormField(); | ||
| if (!props.localizationKey && !props.children) { | ||
| return null; | ||
| } | ||
| return ( | ||
| <Link | ||
| localizationKey={props.localizationKey} | ||
| elementDescriptor={descriptors.formFieldAction} | ||
| elementId={descriptors.formFieldLabel.setId(fieldId)} | ||
| isDisabled={isDisabled} | ||
| colorScheme='primary' | ||
| onClick={e => { | ||
| e.preventDefault(); | ||
| props.onClick?.(e); | ||
| }} | ||
| > | ||
| {props.children} | ||
| </Link> | ||
| ); | ||
| }; | ||
| const FieldOptionalLabel = () => { | ||
| const { fieldId, isDisabled } = useFormField(); | ||
| return ( | ||
| <Text | ||
| localizationKey={localizationKeys('formFieldHintText__optional')} | ||
| elementDescriptor={descriptors.formFieldHintText} | ||
| elementId={descriptors.formFieldHintText.setId(fieldId)} | ||
| as='span' | ||
| colorScheme='neutral' | ||
| variant='smallRegular' | ||
| isDisabled={isDisabled} | ||
| /> | ||
| ); | ||
| }; | ||
| const FieldLabelIcon = (props: { icon?: React.ComponentType }) => { | ||
| const { t } = useLocalizations(); | ||
| if (!props.icon) { | ||
| return null; | ||
| } | ||
| return ( | ||
| <Flex | ||
| as={'span'} | ||
| title={t(localizationKeys('formFieldHintText__slug'))} | ||
| sx={{ | ||
| marginRight: 'auto', | ||
| }} | ||
| > | ||
| <IconCustomizable | ||
| icon={props.icon} | ||
| sx={theme => ({ | ||
| marginLeft: theme.space.$0x5, | ||
| color: theme.colors.$blackAlpha400, | ||
| width: theme.sizes.$4, | ||
| height: theme.sizes.$4, | ||
| })} | ||
| /> | ||
| </Flex> | ||
| ); | ||
| }; | ||
| const FieldLabel = (props: PropsWithChildren<{ localizationKey?: LocalizationKey | string }>) => { | ||
| const { isRequired, id, label, isDisabled, hasError } = useFormField(); | ||
| if (!(props.localizationKey || label) && !props.children) { | ||
| return null; | ||
| } | ||
| return ( | ||
| <FormLabel | ||
| localizationKey={props.localizationKey || label} | ||
| elementDescriptor={descriptors.formFieldLabel} | ||
| elementId={descriptors.formFieldLabel.setId(id as FieldId)} | ||
| hasError={!!hasError} | ||
| isDisabled={isDisabled} | ||
| isRequired={isRequired} | ||
| sx={{ | ||
| display: 'flex', | ||
| alignItems: 'center', | ||
| }} | ||
| > | ||
| {props.children} | ||
| </FormLabel> | ||
| ); | ||
| }; | ||
| const FieldLabelRow = (props: PropsWithChildren) => { | ||
| const { fieldId } = useFormField(); | ||
| return ( | ||
| <Flex | ||
| justify={'between'} | ||
| align='center' | ||
| elementDescriptor={descriptors.formFieldLabelRow} | ||
| elementId={descriptors.formFieldLabelRow.setId(fieldId)} | ||
| sx={theme => ({ | ||
| marginBottom: theme.space.$1, | ||
| marginLeft: 0, | ||
| })} | ||
| > | ||
| {props.children} | ||
| </Flex> | ||
| ); | ||
| }; | ||
| const FieldFeedback = (props: Pick<FormFeedbackProps, 'elementDescriptors'>) => { | ||
| const { feedback, feedbackType, isFocused, fieldId } = useFormField(); | ||
| const { debounced } = useFormControlFeedback({ feedback, feedbackType, isFocused }); | ||
| return ( | ||
| <FormFeedback | ||
| {...{ | ||
| ...debounced, | ||
| elementDescriptors: props.elementDescriptors, | ||
| id: fieldId, | ||
| }} | ||
| /> | ||
| ); | ||
| }; | ||
| const InputElement = forwardRef<HTMLInputElement>((_, ref) => { | ||
| const { t } = useLocalizations(); | ||
| const formField = useFormField(); | ||
| const { placeholder, ...inputProps } = sanitizeInputProps(formField); | ||
| return ( | ||
| <Input | ||
| ref={ref} | ||
| elementDescriptor={descriptors.formFieldInput} | ||
| elementId={descriptors.formFieldInput.setId(formField.fieldId)} | ||
| {...inputProps} | ||
| placeholder={t(placeholder)} | ||
| /> | ||
| ); | ||
| }); | ||
| export const Field = { | ||
| Root: Root, | ||
| Label: FieldLabel, | ||
| LabelRow: FieldLabelRow, | ||
| Input: InputElement, | ||
| Action: FieldAction, | ||
| AsOptional: FieldOptionalLabel, | ||
| LabelIcon: FieldLabelIcon, | ||
| Feedback: FieldFeedback, | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe rename this to
OptionalLabel?