feat(backend): Also export token-related errors - #1980

Closed
flawnn wants to merge 2 commits into
clerk:mainfrom
flawnn:feat/tokenexport
Closed

feat(backend): Also export token-related errors#1980
flawnn wants to merge 2 commits into
clerk:mainfrom
flawnn:feat/tokenexport

Conversation

@flawnn

@flawnnflawnn commented Oct 30, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other: Developer Experience

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

@changeset-bot

changeset-botBot commented Oct 30, 2023•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 1cef899

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
NameType
@clerk/backendMinor
@clerk/fastifyPatch
gatsby-plugin-clerkPatch
@clerk/nextjsPatch
@clerk/remixPatch
@clerk/clerk-sdk-nodePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

tmilewski
tmilewski approved these changes Oct 30, 2023
View reviewed changes

@tmilewskitmilewski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flawnn Thanks for your PR! Looks good to me! Would you mind adding a changeset?

@flawnn

flawnn commented Oct 31, 2023

Copy link
Copy Markdown
ContributorAuthor

@tmilewski Done!

nikosdouvlis
nikosdouvlis requested changes Oct 31, 2023
View reviewed changes

@nikosdouvlisnikosdouvlis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @flawnn :)
This PR makes total sense to me, however, it also exposes a few internal errors that should probably remain internal for the time being.

Could you please share more details about your use case so we can better understand the changes we need to make?

@LekoArts

LekoArts commented Oct 31, 2023

Copy link
Copy Markdown
Contributor

Please also add a description to your PR. Thanks!

@flawnn

flawnn commented Nov 2, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Hello @flawnn :) This PR makes total sense to me, however, it also exposes a few internal errors that should probably remain internal for the time being.

Could you please share more details about your use case so we can better understand the changes we need to make?

Hey! The reason why I was suggesting this PR was that I wanted to be able to catch JWT Verification errors when working with verifyJwt. As an example here a code snippet:

try{letv=awaitverifyJwt(authHeader.split(" ")[1],{}asVerifyJwtOptions);next();}catch(e){if(einstanceofTokenVerificationError){// Logic here doesn't make sense as there are multiple reasons obviously but just for sake of testingreturnres.status(401).send("Token has expired");}returnres.status(401).send("Invalid token");}

Maybe as a reason why I even decided doing that, is that the Clerk Middleware for Express actually just throws an error and doesn't pass that error on to following middlewares when decoding the JWT Token (in some cases). One case was, when the JWT Token expired. The problem with not passing it on to following middlewares is obviously that it doesn't allow for custom error handling.

EDIT:

https://clerk.com/docs/backend-requests/handling/nodejs#express-error-handlers

The paragraph here basically isn't true. I am not able to handle all errors apparently.

@tmilewski
tmilewski changed the base branch from main to release/v4November 17, 2023 21:10
@tmilewski
tmilewski requested a review from a team as a code ownerNovember 17, 2023 21:10
@tmilewski
tmilewski changed the base branch from release/v4 to mainNovember 17, 2023 21:13
@tmilewski
tmilewski removed the request for review from a teamNovember 17, 2023 21:15
@tmilewski
tmilewski changed the base branch from main to release/v4November 17, 2023 21:40
@tmilewski
tmilewski changed the base branch from release/v4 to mainNovember 17, 2023 21:41
@tmilewskitmilewski mentioned this pull request Nov 22, 2023
Merged
24 tasks
@nikosdouvlis

nikosdouvlis commented Nov 23, 2023

Copy link
Copy Markdown
Member

@flawnn, many thanks for the contribution and inciting an internal discussion about this!
I'm going to close this PR as it targets main which is the development branch of our next major release (v5)
@tmilewski will be backporting the change into v4 (the current version of our packages) - you can track the progress here: #2189

Thank you :)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikosdouvlisnikosdouvlisnikosdouvlis requested changes
@tmilewskitmilewskitmilewski approved these changes

Assignees

No one assigned

Labels

backend

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@flawnn@LekoArts@nikosdouvlis@tmilewski@clerk-cookie
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
feat(backend): Also export token-related errors - #1980
Closed
flawnn wants to merge 2 commits into
clerk:mainfrom 
flawnn:feat/tokenexport
Closed
feat(backend): Also export token-related errors#1980
flawnn wants to merge 2 commits into
clerk:mainfrom 
flawnn:feat/tokenexport
Conversation
@flawnn
@flawnnflawnn
commented
Oct 30, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Checklist
  • npm test runs as expected.
  • npm run build runs as expected.
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other: Developer Experience
Packages affected
  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore
@changeset-bot
changeset-botBot
commented
Oct 30, 2023•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 1cef899
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 6 packages
NameType
@clerk/backendMinor
@clerk/fastifyPatch
gatsby-plugin-clerkPatch
@clerk/nextjsPatch
@clerk/remixPatch
@clerk/clerk-sdk-nodePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
tmilewski
tmilewski
approved these changes
Oct 30, 2023
View reviewed changes
@tmilewskitmilewski
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flawnn Thanks for your PR! Looks good to me! Would you mind adding a changeset?
@flawnn
flawnn
commented
Oct 31, 2023

Copy link


Copy Markdown

ContributorAuthor
@tmilewski Done!
nikosdouvlis
nikosdouvlis
requested changes
Oct 31, 2023
View reviewed changes
@nikosdouvlisnikosdouvlis
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @flawnn :)

This PR makes total sense to me, however, it also exposes a few internal errors that should probably remain internal for the time being.
Could you please share more details about your use case so we can better understand the changes we need to make?
@LekoArts
LekoArts
commented
Oct 31, 2023

Copy link


Copy Markdown

Contributor
Please also add a description to your PR. Thanks!
@flawnn
flawnn
commented
Nov 2, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Hello @flawnn :) This PR makes total sense to me, however, it also exposes a few internal errors that should probably remain internal for the time being.
Could you please share more details about your use case so we can better understand the changes we need to make?
Hey! The reason why I was suggesting this PR was that I wanted to be able to catch JWT Verification errors when working with verifyJwt. As an example here a code snippet:
try{letv=awaitverifyJwt(authHeader.split(" ")[1],{}asVerifyJwtOptions);next();}catch(e){if(einstanceofTokenVerificationError){// Logic here doesn't make sense as there are multiple reasons obviously but just for sake of testingreturnres.status(401).send("Token has expired");}returnres.status(401).send("Invalid token");}
Maybe as a reason why I even decided doing that, is that the Clerk Middleware for Express actually just throws an error and doesn't pass that error on to following middlewares when decoding the JWT Token (in some cases). One case was, when the JWT Token expired. The problem with not passing it on to following middlewares is obviously that it doesn't allow for custom error handling.
EDIT:
https://clerk.com/docs/backend-requests/handling/nodejs#express-error-handlers
The paragraph here basically isn't true. I am not able to handle all errors apparently.
@tmilewski
tmilewski
changed the base branch from
main
to
release/v4November 17, 2023 21:10
@tmilewski
tmilewski
requested a review
from a team
as a code ownerNovember 17, 2023 21:10
@tmilewski
tmilewski
changed the base branch from
release/v4
to
mainNovember 17, 2023 21:13
@tmilewski
tmilewski
removed the request for review
from a teamNovember 17, 2023 21:15
@tmilewski
tmilewski
changed the base branch from
main
to
release/v4November 17, 2023 21:40
@tmilewski
tmilewski
changed the base branch from
release/v4
to
mainNovember 17, 2023 21:41
@tmilewskitmilewski
mentioned this pull request
Nov 22, 2023
 Merged

24 tasks
@nikosdouvlis
nikosdouvlis
commented
Nov 23, 2023

Copy link


Copy Markdown

Member
@flawnn, many thanks for the contribution and inciting an internal discussion about this!

I'm going to close this PR as it targets main which is the development branch of our next major release (v5)
@tmilewski will be backporting the change into v4 (the current version of our packages) - you can track the progress here: #2189
Thank you :)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nikosdouvlisnikosdouvlisnikosdouvlis requested changes
@tmilewskitmilewskitmilewski approved these changes

Assignees


No one assigned


Labels

backend

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@flawnn@LekoArts@nikosdouvlis@tmilewski@clerk-cookie

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(backend): Also export token-related errors - #1980
Closed
flawnn wants to merge 2 commits into
clerk:mainfrom 
flawnn:feat/tokenexport
Closed
feat(backend): Also export token-related errors#1980
flawnn wants to merge 2 commits into
clerk:mainfrom 
flawnn:feat/tokenexport
Conversation
@flawnn
@flawnnflawnn
commented
Oct 30, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Checklist
  • npm test runs as expected.
  • npm run build runs as expected.
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other: Developer Experience
Packages affected
  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore
@changeset-bot
changeset-botBot
commented
Oct 30, 2023•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 1cef899
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 6 packages
NameType
@clerk/backendMinor
@clerk/fastifyPatch
gatsby-plugin-clerkPatch
@clerk/nextjsPatch
@clerk/remixPatch
@clerk/clerk-sdk-nodePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
tmilewski
tmilewski
approved these changes
Oct 30, 2023
View reviewed changes
@tmilewskitmilewski
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flawnn Thanks for your PR! Looks good to me! Would you mind adding a changeset?
@flawnn
flawnn
commented
Oct 31, 2023

Copy link


Copy Markdown

ContributorAuthor
@tmilewski Done!
nikosdouvlis
nikosdouvlis
requested changes
Oct 31, 2023
View reviewed changes
@nikosdouvlisnikosdouvlis
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @flawnn :)

This PR makes total sense to me, however, it also exposes a few internal errors that should probably remain internal for the time being.
Could you please share more details about your use case so we can better understand the changes we need to make?
@LekoArts
LekoArts
commented
Oct 31, 2023

Copy link


Copy Markdown

Contributor
Please also add a description to your PR. Thanks!
@flawnn
flawnn
commented
Nov 2, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Hello @flawnn :) This PR makes total sense to me, however, it also exposes a few internal errors that should probably remain internal for the time being.
Could you please share more details about your use case so we can better understand the changes we need to make?
Hey! The reason why I was suggesting this PR was that I wanted to be able to catch JWT Verification errors when working with verifyJwt. As an example here a code snippet:
try{letv=awaitverifyJwt(authHeader.split(" ")[1],{}asVerifyJwtOptions);next();}catch(e){if(einstanceofTokenVerificationError){// Logic here doesn't make sense as there are multiple reasons obviously but just for sake of testingreturnres.status(401).send("Token has expired");}returnres.status(401).send("Invalid token");}
Maybe as a reason why I even decided doing that, is that the Clerk Middleware for Express actually just throws an error and doesn't pass that error on to following middlewares when decoding the JWT Token (in some cases). One case was, when the JWT Token expired. The problem with not passing it on to following middlewares is obviously that it doesn't allow for custom error handling.
EDIT:
https://clerk.com/docs/backend-requests/handling/nodejs#express-error-handlers
The paragraph here basically isn't true. I am not able to handle all errors apparently.
@tmilewski
tmilewski
changed the base branch from
main
to
release/v4November 17, 2023 21:10
@tmilewski
tmilewski
requested a review
from a team
as a code ownerNovember 17, 2023 21:10
@tmilewski
tmilewski
changed the base branch from
release/v4
to
mainNovember 17, 2023 21:13
@tmilewski
tmilewski
removed the request for review
from a teamNovember 17, 2023 21:15
@tmilewski
tmilewski
changed the base branch from
main
to
release/v4November 17, 2023 21:40
@tmilewski
tmilewski
changed the base branch from
release/v4
to
mainNovember 17, 2023 21:41
@tmilewskitmilewski
mentioned this pull request
Nov 22, 2023
 Merged

24 tasks
@nikosdouvlis
nikosdouvlis
commented
Nov 23, 2023

Copy link


Copy Markdown

Member
@flawnn, many thanks for the contribution and inciting an internal discussion about this!

I'm going to close this PR as it targets main which is the development branch of our next major release (v5)
@tmilewski will be backporting the change into v4 (the current version of our packages) - you can track the progress here: #2189
Thank you :)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nikosdouvlisnikosdouvlisnikosdouvlis requested changes
@tmilewskitmilewskitmilewski approved these changes

Assignees


No one assigned


Labels

backend

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@flawnn@LekoArts@nikosdouvlis@tmilewski@clerk-cookie

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(backend): Also export token-related errors - #1980
Closed
flawnn wants to merge 2 commits into
clerk:mainfrom 
flawnn:feat/tokenexport
Closed
feat(backend): Also export token-related errors#1980
flawnn wants to merge 2 commits into
clerk:mainfrom 
flawnn:feat/tokenexport
Conversation
@flawnn
@flawnnflawnn
commented
Oct 30, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Checklist
  • npm test runs as expected.
  • npm run build runs as expected.
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other: Developer Experience
Packages affected
  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore
@changeset-bot
changeset-botBot
commented
Oct 30, 2023•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 1cef899
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 6 packages
NameType
@clerk/backendMinor
@clerk/fastifyPatch
gatsby-plugin-clerkPatch
@clerk/nextjsPatch
@clerk/remixPatch
@clerk/clerk-sdk-nodePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
tmilewski
tmilewski
approved these changes
Oct 30, 2023
View reviewed changes
@tmilewskitmilewski
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flawnn Thanks for your PR! Looks good to me! Would you mind adding a changeset?
@flawnn
flawnn
commented
Oct 31, 2023

Copy link


Copy Markdown

ContributorAuthor
@tmilewski Done!
nikosdouvlis
nikosdouvlis
requested changes
Oct 31, 2023
View reviewed changes
@nikosdouvlisnikosdouvlis
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @flawnn :)

This PR makes total sense to me, however, it also exposes a few internal errors that should probably remain internal for the time being.
Could you please share more details about your use case so we can better understand the changes we need to make?
@LekoArts
LekoArts
commented
Oct 31, 2023

Copy link


Copy Markdown

Contributor
Please also add a description to your PR. Thanks!
@flawnn
flawnn
commented
Nov 2, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Hello @flawnn :) This PR makes total sense to me, however, it also exposes a few internal errors that should probably remain internal for the time being.
Could you please share more details about your use case so we can better understand the changes we need to make?
Hey! The reason why I was suggesting this PR was that I wanted to be able to catch JWT Verification errors when working with verifyJwt. As an example here a code snippet:
try{letv=awaitverifyJwt(authHeader.split(" ")[1],{}asVerifyJwtOptions);next();}catch(e){if(einstanceofTokenVerificationError){// Logic here doesn't make sense as there are multiple reasons obviously but just for sake of testingreturnres.status(401).send("Token has expired");}returnres.status(401).send("Invalid token");}
Maybe as a reason why I even decided doing that, is that the Clerk Middleware for Express actually just throws an error and doesn't pass that error on to following middlewares when decoding the JWT Token (in some cases). One case was, when the JWT Token expired. The problem with not passing it on to following middlewares is obviously that it doesn't allow for custom error handling.
EDIT:
https://clerk.com/docs/backend-requests/handling/nodejs#express-error-handlers
The paragraph here basically isn't true. I am not able to handle all errors apparently.
@tmilewski
tmilewski
changed the base branch from
main
to
release/v4November 17, 2023 21:10
@tmilewski
tmilewski
requested a review
from a team
as a code ownerNovember 17, 2023 21:10
@tmilewski
tmilewski
changed the base branch from
release/v4
to
mainNovember 17, 2023 21:13
@tmilewski
tmilewski
removed the request for review
from a teamNovember 17, 2023 21:15
@tmilewski
tmilewski
changed the base branch from
main
to
release/v4November 17, 2023 21:40
@tmilewski
tmilewski
changed the base branch from
release/v4
to
mainNovember 17, 2023 21:41
@tmilewskitmilewski
mentioned this pull request
Nov 22, 2023
 Merged

24 tasks
@nikosdouvlis
nikosdouvlis
commented
Nov 23, 2023

Copy link


Copy Markdown

Member
@flawnn, many thanks for the contribution and inciting an internal discussion about this!

I'm going to close this PR as it targets main which is the development branch of our next major release (v5)
@tmilewski will be backporting the change into v4 (the current version of our packages) - you can track the progress here: #2189
Thank you :)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nikosdouvlisnikosdouvlisnikosdouvlis requested changes
@tmilewskitmilewskitmilewski approved these changes

Assignees


No one assigned


Labels

backend

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@flawnn@LekoArts@nikosdouvlis@tmilewski@clerk-cookie

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
feat(backend): Also export token-related errors - #1980
Closed
flawnn wants to merge 2 commits into
clerk:mainfrom 
flawnn:feat/tokenexport
Closed
feat(backend): Also export token-related errors#1980
flawnn wants to merge 2 commits into
clerk:mainfrom 
flawnn:feat/tokenexport
Conversation
@flawnn
@flawnnflawnn
commented
Oct 30, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Checklist
  • npm test runs as expected.
  • npm run build runs as expected.
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other: Developer Experience
Packages affected
  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore
@changeset-bot
changeset-botBot
commented
Oct 30, 2023•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 1cef899
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 6 packages
NameType
@clerk/backendMinor
@clerk/fastifyPatch
gatsby-plugin-clerkPatch
@clerk/nextjsPatch
@clerk/remixPatch
@clerk/clerk-sdk-nodePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
tmilewski
tmilewski
approved these changes
Oct 30, 2023
View reviewed changes
@tmilewskitmilewski
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flawnn Thanks for your PR! Looks good to me! Would you mind adding a changeset?
@flawnn
flawnn
commented
Oct 31, 2023

Copy link


Copy Markdown

ContributorAuthor
@tmilewski Done!
nikosdouvlis
nikosdouvlis
requested changes
Oct 31, 2023
View reviewed changes
@nikosdouvlisnikosdouvlis
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @flawnn :)

This PR makes total sense to me, however, it also exposes a few internal errors that should probably remain internal for the time being.
Could you please share more details about your use case so we can better understand the changes we need to make?
@LekoArts
LekoArts
commented
Oct 31, 2023

Copy link


Copy Markdown

Contributor
Please also add a description to your PR. Thanks!
@flawnn
flawnn
commented
Nov 2, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Hello @flawnn :) This PR makes total sense to me, however, it also exposes a few internal errors that should probably remain internal for the time being.
Could you please share more details about your use case so we can better understand the changes we need to make?
Hey! The reason why I was suggesting this PR was that I wanted to be able to catch JWT Verification errors when working with verifyJwt. As an example here a code snippet:
try{letv=awaitverifyJwt(authHeader.split(" ")[1],{}asVerifyJwtOptions);next();}catch(e){if(einstanceofTokenVerificationError){// Logic here doesn't make sense as there are multiple reasons obviously but just for sake of testingreturnres.status(401).send("Token has expired");}returnres.status(401).send("Invalid token");}
Maybe as a reason why I even decided doing that, is that the Clerk Middleware for Express actually just throws an error and doesn't pass that error on to following middlewares when decoding the JWT Token (in some cases). One case was, when the JWT Token expired. The problem with not passing it on to following middlewares is obviously that it doesn't allow for custom error handling.
EDIT:
https://clerk.com/docs/backend-requests/handling/nodejs#express-error-handlers
The paragraph here basically isn't true. I am not able to handle all errors apparently.
@tmilewski
tmilewski
changed the base branch from
main
to
release/v4November 17, 2023 21:10
@tmilewski
tmilewski
requested a review
from a team
as a code ownerNovember 17, 2023 21:10
@tmilewski
tmilewski
changed the base branch from
release/v4
to
mainNovember 17, 2023 21:13
@tmilewski
tmilewski
removed the request for review
from a teamNovember 17, 2023 21:15
@tmilewski
tmilewski
changed the base branch from
main
to
release/v4November 17, 2023 21:40
@tmilewski
tmilewski
changed the base branch from
release/v4
to
mainNovember 17, 2023 21:41
@tmilewskitmilewski
mentioned this pull request
Nov 22, 2023
 Merged

24 tasks
@nikosdouvlis
nikosdouvlis
commented
Nov 23, 2023

Copy link


Copy Markdown

Member
@flawnn, many thanks for the contribution and inciting an internal discussion about this!

I'm going to close this PR as it targets main which is the development branch of our next major release (v5)
@tmilewski will be backporting the change into v4 (the current version of our packages) - you can track the progress here: #2189
Thank you :)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nikosdouvlisnikosdouvlisnikosdouvlis requested changes
@tmilewskitmilewskitmilewski approved these changes

Assignees


No one assigned


Labels

backend

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@flawnn@LekoArts@nikosdouvlis@tmilewski@clerk-cookie

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(backend): Also export token-related errors - #1980
Closed
flawnn wants to merge 2 commits into
clerk:mainfrom 
flawnn:feat/tokenexport
Closed
feat(backend): Also export token-related errors#1980
flawnn wants to merge 2 commits into
clerk:mainfrom 
flawnn:feat/tokenexport
Conversation
@flawnn
@flawnnflawnn
commented
Oct 30, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Checklist
  • npm test runs as expected.
  • npm run build runs as expected.
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other: Developer Experience
Packages affected
  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore
@changeset-bot
changeset-botBot
commented
Oct 30, 2023•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 1cef899
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 6 packages
NameType
@clerk/backendMinor
@clerk/fastifyPatch
gatsby-plugin-clerkPatch
@clerk/nextjsPatch
@clerk/remixPatch
@clerk/clerk-sdk-nodePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
tmilewski
tmilewski
approved these changes
Oct 30, 2023
View reviewed changes
@tmilewskitmilewski
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flawnn Thanks for your PR! Looks good to me! Would you mind adding a changeset?
@flawnn
flawnn
commented
Oct 31, 2023

Copy link


Copy Markdown

ContributorAuthor
@tmilewski Done!
nikosdouvlis
nikosdouvlis
requested changes
Oct 31, 2023
View reviewed changes
@nikosdouvlisnikosdouvlis
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @flawnn :)

This PR makes total sense to me, however, it also exposes a few internal errors that should probably remain internal for the time being.
Could you please share more details about your use case so we can better understand the changes we need to make?
@LekoArts
LekoArts
commented
Oct 31, 2023

Copy link


Copy Markdown

Contributor
Please also add a description to your PR. Thanks!
@flawnn
flawnn
commented
Nov 2, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Hello @flawnn :) This PR makes total sense to me, however, it also exposes a few internal errors that should probably remain internal for the time being.
Could you please share more details about your use case so we can better understand the changes we need to make?
Hey! The reason why I was suggesting this PR was that I wanted to be able to catch JWT Verification errors when working with verifyJwt. As an example here a code snippet:
try{letv=awaitverifyJwt(authHeader.split(" ")[1],{}asVerifyJwtOptions);next();}catch(e){if(einstanceofTokenVerificationError){// Logic here doesn't make sense as there are multiple reasons obviously but just for sake of testingreturnres.status(401).send("Token has expired");}returnres.status(401).send("Invalid token");}
Maybe as a reason why I even decided doing that, is that the Clerk Middleware for Express actually just throws an error and doesn't pass that error on to following middlewares when decoding the JWT Token (in some cases). One case was, when the JWT Token expired. The problem with not passing it on to following middlewares is obviously that it doesn't allow for custom error handling.
EDIT:
https://clerk.com/docs/backend-requests/handling/nodejs#express-error-handlers
The paragraph here basically isn't true. I am not able to handle all errors apparently.
@tmilewski
tmilewski
changed the base branch from
main
to
release/v4November 17, 2023 21:10
@tmilewski
tmilewski
requested a review
from a team
as a code ownerNovember 17, 2023 21:10
@tmilewski
tmilewski
changed the base branch from
release/v4
to
mainNovember 17, 2023 21:13
@tmilewski
tmilewski
removed the request for review
from a teamNovember 17, 2023 21:15
@tmilewski
tmilewski
changed the base branch from
main
to
release/v4November 17, 2023 21:40
@tmilewski
tmilewski
changed the base branch from
release/v4
to
mainNovember 17, 2023 21:41
@tmilewskitmilewski
mentioned this pull request
Nov 22, 2023
 Merged

24 tasks
@nikosdouvlis
nikosdouvlis
commented
Nov 23, 2023

Copy link


Copy Markdown

Member
@flawnn, many thanks for the contribution and inciting an internal discussion about this!

I'm going to close this PR as it targets main which is the development branch of our next major release (v5)
@tmilewski will be backporting the change into v4 (the current version of our packages) - you can track the progress here: #2189
Thank you :)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nikosdouvlisnikosdouvlisnikosdouvlis requested changes
@tmilewskitmilewskitmilewski approved these changes

Assignees


No one assigned


Labels

backend

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@flawnn@LekoArts@nikosdouvlis@tmilewski@clerk-cookie

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(backend): Also export token-related errors - #1980
Closed
flawnn wants to merge 2 commits into
clerk:mainfrom 
flawnn:feat/tokenexport
Closed
feat(backend): Also export token-related errors#1980
flawnn wants to merge 2 commits into
clerk:mainfrom 
flawnn:feat/tokenexport
Conversation
@flawnn
@flawnnflawnn
commented
Oct 30, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Checklist
  • npm test runs as expected.
  • npm run build runs as expected.
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other: Developer Experience
Packages affected
  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore
@changeset-bot
changeset-botBot
commented
Oct 30, 2023•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 1cef899
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 6 packages
NameType
@clerk/backendMinor
@clerk/fastifyPatch
gatsby-plugin-clerkPatch
@clerk/nextjsPatch
@clerk/remixPatch
@clerk/clerk-sdk-nodePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
tmilewski
tmilewski
approved these changes
Oct 30, 2023
View reviewed changes
@tmilewskitmilewski
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flawnn Thanks for your PR! Looks good to me! Would you mind adding a changeset?
@flawnn
flawnn
commented
Oct 31, 2023

Copy link


Copy Markdown

ContributorAuthor
@tmilewski Done!
nikosdouvlis
nikosdouvlis
requested changes
Oct 31, 2023
View reviewed changes
@nikosdouvlisnikosdouvlis
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @flawnn :)

This PR makes total sense to me, however, it also exposes a few internal errors that should probably remain internal for the time being.
Could you please share more details about your use case so we can better understand the changes we need to make?
@LekoArts
LekoArts
commented
Oct 31, 2023

Copy link


Copy Markdown

Contributor
Please also add a description to your PR. Thanks!
@flawnn
flawnn
commented
Nov 2, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Hello @flawnn :) This PR makes total sense to me, however, it also exposes a few internal errors that should probably remain internal for the time being.
Could you please share more details about your use case so we can better understand the changes we need to make?
Hey! The reason why I was suggesting this PR was that I wanted to be able to catch JWT Verification errors when working with verifyJwt. As an example here a code snippet:
try{letv=awaitverifyJwt(authHeader.split(" ")[1],{}asVerifyJwtOptions);next();}catch(e){if(einstanceofTokenVerificationError){// Logic here doesn't make sense as there are multiple reasons obviously but just for sake of testingreturnres.status(401).send("Token has expired");}returnres.status(401).send("Invalid token");}
Maybe as a reason why I even decided doing that, is that the Clerk Middleware for Express actually just throws an error and doesn't pass that error on to following middlewares when decoding the JWT Token (in some cases). One case was, when the JWT Token expired. The problem with not passing it on to following middlewares is obviously that it doesn't allow for custom error handling.
EDIT:
https://clerk.com/docs/backend-requests/handling/nodejs#express-error-handlers
The paragraph here basically isn't true. I am not able to handle all errors apparently.
@tmilewski
tmilewski
changed the base branch from
main
to
release/v4November 17, 2023 21:10
@tmilewski
tmilewski
requested a review
from a team
as a code ownerNovember 17, 2023 21:10
@tmilewski
tmilewski
changed the base branch from
release/v4
to
mainNovember 17, 2023 21:13
@tmilewski
tmilewski
removed the request for review
from a teamNovember 17, 2023 21:15
@tmilewski
tmilewski
changed the base branch from
main
to
release/v4November 17, 2023 21:40
@tmilewski
tmilewski
changed the base branch from
release/v4
to
mainNovember 17, 2023 21:41
@tmilewskitmilewski
mentioned this pull request
Nov 22, 2023
 Merged

24 tasks
@nikosdouvlis
nikosdouvlis
commented
Nov 23, 2023

Copy link


Copy Markdown

Member
@flawnn, many thanks for the contribution and inciting an internal discussion about this!

I'm going to close this PR as it targets main which is the development branch of our next major release (v5)
@tmilewski will be backporting the change into v4 (the current version of our packages) - you can track the progress here: #2189
Thank you :)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nikosdouvlisnikosdouvlisnikosdouvlis requested changes
@tmilewskitmilewskitmilewski approved these changes

Assignees


No one assigned


Labels

backend

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@flawnn@LekoArts@nikosdouvlis@tmilewski@clerk-cookie

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
feat(backend): Also export token-related errors - #1980
Closed
flawnn wants to merge 2 commits into
clerk:mainfrom 
flawnn:feat/tokenexport
Closed
feat(backend): Also export token-related errors#1980
flawnn wants to merge 2 commits into
clerk:mainfrom 
flawnn:feat/tokenexport
Conversation
@flawnn
@flawnnflawnn
commented
Oct 30, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Checklist
  • npm test runs as expected.
  • npm run build runs as expected.
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other: Developer Experience
Packages affected
  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore
@changeset-bot
changeset-botBot
commented
Oct 30, 2023•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 1cef899
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 6 packages
NameType
@clerk/backendMinor
@clerk/fastifyPatch
gatsby-plugin-clerkPatch
@clerk/nextjsPatch
@clerk/remixPatch
@clerk/clerk-sdk-nodePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
tmilewski
tmilewski
approved these changes
Oct 30, 2023
View reviewed changes
@tmilewskitmilewski
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flawnn Thanks for your PR! Looks good to me! Would you mind adding a changeset?
@flawnn
flawnn
commented
Oct 31, 2023

Copy link


Copy Markdown

ContributorAuthor
@tmilewski Done!
nikosdouvlis
nikosdouvlis
requested changes
Oct 31, 2023
View reviewed changes
@nikosdouvlisnikosdouvlis
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @flawnn :)

This PR makes total sense to me, however, it also exposes a few internal errors that should probably remain internal for the time being.
Could you please share more details about your use case so we can better understand the changes we need to make?
@LekoArts
LekoArts
commented
Oct 31, 2023

Copy link


Copy Markdown

Contributor
Please also add a description to your PR. Thanks!
@flawnn
flawnn
commented
Nov 2, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Hello @flawnn :) This PR makes total sense to me, however, it also exposes a few internal errors that should probably remain internal for the time being.
Could you please share more details about your use case so we can better understand the changes we need to make?
Hey! The reason why I was suggesting this PR was that I wanted to be able to catch JWT Verification errors when working with verifyJwt. As an example here a code snippet:
try{letv=awaitverifyJwt(authHeader.split(" ")[1],{}asVerifyJwtOptions);next();}catch(e){if(einstanceofTokenVerificationError){// Logic here doesn't make sense as there are multiple reasons obviously but just for sake of testingreturnres.status(401).send("Token has expired");}returnres.status(401).send("Invalid token");}
Maybe as a reason why I even decided doing that, is that the Clerk Middleware for Express actually just throws an error and doesn't pass that error on to following middlewares when decoding the JWT Token (in some cases). One case was, when the JWT Token expired. The problem with not passing it on to following middlewares is obviously that it doesn't allow for custom error handling.
EDIT:
https://clerk.com/docs/backend-requests/handling/nodejs#express-error-handlers
The paragraph here basically isn't true. I am not able to handle all errors apparently.
@tmilewski
tmilewski
changed the base branch from
main
to
release/v4November 17, 2023 21:10
@tmilewski
tmilewski
requested a review
from a team
as a code ownerNovember 17, 2023 21:10
@tmilewski
tmilewski
changed the base branch from
release/v4
to
mainNovember 17, 2023 21:13
@tmilewski
tmilewski
removed the request for review
from a teamNovember 17, 2023 21:15
@tmilewski
tmilewski
changed the base branch from
main
to
release/v4November 17, 2023 21:40
@tmilewski
tmilewski
changed the base branch from
release/v4
to
mainNovember 17, 2023 21:41
@tmilewskitmilewski
mentioned this pull request
Nov 22, 2023
 Merged

24 tasks
@nikosdouvlis
nikosdouvlis
commented
Nov 23, 2023

Copy link


Copy Markdown

Member
@flawnn, many thanks for the contribution and inciting an internal discussion about this!

I'm going to close this PR as it targets main which is the development branch of our next major release (v5)
@tmilewski will be backporting the change into v4 (the current version of our packages) - you can track the progress here: #2189
Thank you :)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nikosdouvlisnikosdouvlisnikosdouvlis requested changes
@tmilewskitmilewskitmilewski approved these changes

Assignees


No one assigned


Labels

backend

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@flawnn@LekoArts@nikosdouvlis@tmilewski@clerk-cookie