') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); chore(repo): v5 extra cleanups by dimkl · Pull Request #2169 · clerk/javascript · GitHub
Skip to content

chore(repo): v5 extra cleanups - #2169

Merged
dimkl merged 16 commits into
mainfrom
sdk-782-extra-cleanup
Nov 22, 2023
Merged

chore(repo): v5 extra cleanups#2169
dimkl merged 16 commits into
mainfrom
sdk-782-extra-cleanup

Conversation

@dimkl

@dimkldimkl commented Nov 20, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Breaking Changes:

  • Drop isLegacyFrontendApiKey from @clerk/shared
  • Drop default exports from @clerk/clerk-js
    • on headless Clerk type
    • on ui and ui.retheme Portal
  • Use isProductionFromSecretKey instead of isProductionFromApiKey
  • Use isDevelopmentFromSecretKey instead of isDevelopmentFromApiKey

Changes:

  • Rename HeadlessBrowserClerkConstrutor / HeadlessBrowserClerkConstructor (typo)
  • Use isomorphicAtob / isomorhpicBtoa to replace base-64 in @clerk/expo
  • Refactor merging build-time and runtime props in @clerk/backend clerk client
  • Drop node-fetch dependency from @clerk/backend
  • Drop duplicate test in @clerk/backend

Review it per commit!

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

@dimkldimkl self-assigned this Nov 20, 2023
@changeset-bot

changeset-botBot commented Nov 20, 2023•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f97742f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
NameType
@clerk/clerk-jsMajor
@clerk/sharedMajor
@clerk/clerk-sdk-nodeMinor
@clerk/backendMinor
@clerk/nextjsMinor
@clerk/clerk-reactMinor
@clerk/clerk-expoMinor
@clerk/chrome-extensionPatch
@clerk/fastifyPatch
@clerk/remixPatch
gatsby-plugin-clerkPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dimkldimkl changed the title Sdk 782 extra cleanupchore(repo): Extra v5 cleanupsNov 20, 2023
@dimkldimkl changed the title chore(repo): Extra v5 cleanupschore(repo): v5 extra cleanupsNov 20, 2023
@dimkl
dimklforce-pushed the sdk-782-extra-cleanup branch from b719e6e to 40913ceCompareNovember 20, 2023 11:17
nikosdouvlis
nikosdouvlis approved these changes Nov 21, 2023
View reviewed changes

@nikosdouvlisnikosdouvlis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dimkl 👏🏻

@dimkl
dimkl added this pull request to the merge queue Nov 21, 2023
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Nov 21, 2023
@dimkl
dimklforce-pushed the sdk-782-extra-cleanup branch 2 times, most recently from e988adc to 83fc9ffCompareNovember 21, 2023 16:33
@dimkl
dimklforce-pushed the sdk-782-extra-cleanup branch from 83fc9ff to f97742fCompareNovember 21, 2023 16:34
@dimkl
dimkl added this pull request to the merge queue Nov 22, 2023
Merged via the queue into main with commit 4bb5705Nov 22, 2023
@dimkl
dimkl deleted the sdk-782-extra-cleanup branch November 22, 2023 10:16
@clerk-cookieclerk-cookie mentioned this pull request Nov 22, 2023
Merged
desiprisg pushed a commit that referenced this pull request Nov 23, 2023
@dimkl@desiprisg
chore(repo): v5 extra cleanups (#2169)
51197cb
* chore(clerk-expo): Use isomorphicAtob/isomorhpicBtoa to drop base-64 dep
* chore(clerk-sdk-node): Add comment and drop todo in interstitial response errors
* fix(clerk-react): Rename `HeadlessBrowserClerkConstrutor` / `HeadlessBrowserClerkConstructor` typo
* fix(clerk-react): Drop unused import
* chore(backend): Refactor merging of props in request/factory
* chore(clerk-react,nextjs): Update JSDoc examples with `withServerSideAuth`
* chore(shared): Drop `isLegacyFrontendApiKey`
* chore(clerk-js): Drop forgotten default exports
* chore(clerk-js): Drop node-fetch dependency
* chore(backend): Duplicate test
* chore(remix): Rename `noSecretKeyOrApiKeyError` to `noSecretKeyError`
* chore(clerk-sdk-node): Re-use `isDevelopmentFromApiKey` from `@clerk/shared`
* chore(backend): Drop unused `LoadResourcesOptions` export
* chore(*): Rename `isDevelopmentFromApiKey` to `isDevelopmentFromSecretKey`
* chore(*): Rename `isProductionFromApiKey` to `isProductionFromSecretKey`
* chore(repo): Add changeset
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikosdouvlisnikosdouvlisnikosdouvlis approved these changes

Assignees

@dimkldimkl

Labels

backendclerk-jsexponextjsreactremixsdk-node

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dimkl@nikosdouvlis@clerk-cookie