Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions .changeset/red-worms-fetch.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
---
'@clerk/clerk-js': major
'@clerk/shared': major
'@clerk/clerk-sdk-node': minor
'@clerk/backend': minor
'@clerk/nextjs': minor
'@clerk/clerk-react': minor
'@clerk/clerk-expo': minor
---

Breaking Changes:

- Drop `isLegacyFrontendApiKey` from `@clerk/shared`
- Drop default exports from `@clerk/clerk-js`
- on headless Clerk type
- on ui and ui.retheme `Portal`
- Use `isProductionFromSecretKey` instead of `isProductionFromApiKey`
- Use `isDevelopmentFromSecretKey` instead of `isDevelopmentFromApiKey`

Changes:

- Rename `HeadlessBrowserClerkConstrutor` / `HeadlessBrowserClerkConstructor` (typo)
- Use `isomorphicAtob` / `isomorhpicBtoa` to replace `base-64` in `@clerk/expo`
- Refactor merging build-time and runtime props in `@clerk/backend` clerk client
- Drop `node-fetch` dependency from `@clerk/backend`
- Drop duplicate test in `@clerk/backend`
14 changes: 1 addition & 13 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/backend/src/tokens/authStatus.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -81,7 +81,7 @@ export type AuthReason = AuthErrorReason | TokenVerificationErrorReason;

export type RequestState = SignedInState | SignedOutState | InterstitialState | UnknownState;

export type LoadResourcesOptions = {
type LoadResourcesOptions = {
loadSession?: boolean;
loadUser?: boolean;
loadOrganization?: boolean;
Expand Down
96 changes: 96 additions & 0 deletions packages/backend/src/tokens/factory.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,96 @@
import type QUnit from 'qunit';

import type { ApiClient } from '../api';
import { createAuthenticateRequest } from './factory';

export default (QUnit: QUnit) => {
const { module, test } = QUnit;

module('createAuthenticateRequest({ options, apiClient })', hooks => {
let fakeAuthenticateRequest;
hooks.afterEach(() => {
fakeAuthenticateRequest?.restore();
});

test('fallbacks to build-time options', async assert => {
const buildTimeOptions = {
secretKey: 'sk',
jwtKey: 'jwtKey',
apiUrl: 'apiUrl',
apiVersion: 'apiVersion',
proxyUrl: 'proxyUrl',
publishableKey: 'pk',
isSatellite: false,
domain: 'domain',
audience: 'domain',
};

const { authenticateRequest } = createAuthenticateRequest({
options: buildTimeOptions,
apiClient: {} as ApiClient,
});

const requestState = await authenticateRequest({ request: new Request('http://example.com/') });
assert.propContains(requestState.toAuth()?.debug(), buildTimeOptions);
});

test('overrides build-time options with runtime options', async assert => {
const buildTimeOptions = {
secretKey: 'sk',
jwtKey: 'jwtKey',
apiUrl: 'apiUrl',
apiVersion: 'apiVersion',
proxyUrl: 'proxyUrl',
publishableKey: 'pk',
isSatellite: false,
domain: 'domain',
audience: 'domain',
};

const { authenticateRequest } = createAuthenticateRequest({
options: buildTimeOptions,
apiClient: {} as ApiClient,
});

const overrides = {
secretKey: 'r-sk',
publishableKey: 'r-pk',
};
const requestState = await authenticateRequest({
request: new Request('http://example.com/'),
...overrides,
});
assert.propContains(requestState.toAuth()?.debug(), {
...buildTimeOptions,
...overrides,
});
});

test('ignore runtime apiUrl and apiVersion options', async assert => {
const buildTimeOptions = {
secretKey: 'sk',
jwtKey: 'jwtKey',
apiUrl: 'apiUrl',
apiVersion: 'apiVersion',
proxyUrl: 'proxyUrl',
publishableKey: 'pk',
isSatellite: false,
domain: 'domain',
audience: 'domain',
};

const { authenticateRequest } = createAuthenticateRequest({
options: buildTimeOptions,
apiClient: {} as ApiClient,
});

const requestState = await authenticateRequest({
request: new Request('http://example.com/'),
// @ts-expect-error is used to check runtime code
apiUrl: 'r-apiUrl',
apiVersion: 'r-apiVersion',
});
assert.propContains(requestState.toAuth()?.debug(), buildTimeOptions);
});
});
};
101 changes: 43 additions & 58 deletions packages/backend/src/tokens/factory.ts
Original file line numberDiff line numberDiff line change
@@ -1,80 +1,65 @@
import type { ApiClient } from '../api';
import { API_URL, API_VERSION } from '../constants';
import { mergePreDefinedOptions } from '../util/mergePreDefinedOptions';
import type { LoadInterstitialOptions } from './interstitial';
import { loadInterstitialFromLocal } from './interstitial';
import type { AuthenticateRequestOptions } from './request';
import { authenticateRequest as authenticateRequestOriginal, debugRequestState } from './request';

type RunTimeOptions = Omit<AuthenticateRequestOptions, 'apiUrl' | 'apiVersion'>;

type BuildTimeOptions = Partial<
Pick<
AuthenticateRequestOptions,
| 'apiUrl'
| 'apiVersion'
| 'audience'
| 'domain'
| 'isSatellite'
| 'jwtKey'
| 'proxyUrl'
| 'publishableKey'
| 'secretKey'
>
>;

const defaultOptions = {
secretKey: '',
jwtKey: '',
apiUrl: undefined,
apiVersion: undefined,
proxyUrl: '',
publishableKey: '',
isSatellite: false,
domain: '',
audience: '',
} satisfies BuildTimeOptions;

export type CreateAuthenticateRequestOptions = {
options: Partial<
Pick<
AuthenticateRequestOptions,
| 'audience'
| 'secretKey'
| 'apiUrl'
| 'apiVersion'
| 'publishableKey'
| 'jwtKey'
| 'proxyUrl'
| 'domain'
| 'isSatellite'
>
>;
options: BuildTimeOptions;
apiClient: ApiClient;
};

export function createAuthenticateRequest(params: CreateAuthenticateRequestOptions) {
const { apiClient } = params;
const {
secretKey: buildtimeSecretKey = '',
jwtKey: buildtimeJwtKey = '',
apiUrl = API_URL,
apiVersion = API_VERSION,
proxyUrl: buildProxyUrl = '',
publishableKey: buildtimePublishableKey = '',
isSatellite: buildtimeIsSatellite = false,
domain: buildtimeDomain = '',
audience: buildtimeAudience = '',
} = params.options;
const buildTimeOptions = mergePreDefinedOptions(defaultOptions, params.options);

const authenticateRequest = ({
secretKey: runtimeSecretKey,
audience: runtimeAudience,
proxyUrl: runtimeProxyUrl,
publishableKey: runtimePublishableKey,
jwtKey: runtimeJwtKey,
isSatellite: runtimeIsSatellite,
domain: runtimeDomain,
...rest
}: Omit<AuthenticateRequestOptions, 'apiUrl' | 'apiVersion'>) => {
const authenticateRequest = (options: RunTimeOptions) => {
const { apiUrl, apiVersion } = buildTimeOptions;
const runTimeOptions = mergePreDefinedOptions(buildTimeOptions, options);
return authenticateRequestOriginal({
...rest,
secretKey: runtimeSecretKey || buildtimeSecretKey,
audience: runtimeAudience || buildtimeAudience,
...options,
...runTimeOptions,
// We should add all the omitted props from options here (eg apiUrl / apiVersion)
// to avoid runtime options override them.
apiUrl,
apiVersion,
proxyUrl: runtimeProxyUrl || buildProxyUrl,
publishableKey: runtimePublishableKey || buildtimePublishableKey,
isSatellite: runtimeIsSatellite || buildtimeIsSatellite,
domain: runtimeDomain || buildtimeDomain,
jwtKey: runtimeJwtKey || buildtimeJwtKey,
});
};

const localInterstitial = ({
publishableKey: runtimePublishableKey,
proxyUrl: runtimeProxyUrl,
isSatellite: runtimeIsSatellite,
domain: runtimeDomain,
...rest
}: Omit<LoadInterstitialOptions, 'apiUrl'>) =>
loadInterstitialFromLocal({
...rest,
proxyUrl: runtimeProxyUrl || buildProxyUrl,
publishableKey: runtimePublishableKey || buildtimePublishableKey,
isSatellite: runtimeIsSatellite || buildtimeIsSatellite,
domain: runtimeDomain || buildtimeDomain,
});
const localInterstitial = (options: Omit<LoadInterstitialOptions, 'apiUrl'>) => {
const runTimeOptions = mergePreDefinedOptions(buildTimeOptions, options);
return loadInterstitialFromLocal({ ...options, ...runTimeOptions });
};

// TODO: Replace this function with remotePublicInterstitial
const remotePrivateInterstitial = () => apiClient.interstitial.getInterstitial();
Expand Down
12 changes: 6 additions & 6 deletions packages/backend/src/tokens/interstitialRule.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { checkCrossOrigin } from '../util/request';
import { isDevelopmentFromApiKey, isProductionFromApiKey } from '../util/shared';
import { isDevelopmentFromSecretKey, isProductionFromSecretKey } from '../util/shared';
import type { AuthStatusOptionsType, RequestState } from './authStatus';
import { AuthErrorReason, interstitial, signedIn, signedOut } from './authStatus';
import { verifyToken } from './verify';
Expand DownExpand Up@@ -45,7 +45,7 @@ const isBrowser = (userAgent: string | undefined) => VALID_USER_AGENTS.test(user
// automatically treated as signed out. This exception is needed for development, because the any // missing uat throws an interstitial in development.
export const nonBrowserRequestInDevRule: InterstitialRule = options => {
const { secretKey, userAgent } = options;
if (isDevelopmentFromApiKey(secretKey || '') && !isBrowser(userAgent)) {
if (isDevelopmentFromSecretKey(secretKey || '') && !isBrowser(userAgent)) {
return signedOut(options, AuthErrorReason.HeaderMissingNonBrowser);
}
return undefined;
Expand All@@ -70,7 +70,7 @@ export const crossOriginRequestWithoutHeader: InterstitialRule = options => {

export const isPrimaryInDevAndRedirectsToSatellite: InterstitialRule = options => {
const { secretKey = '', isSatellite, searchParams } = options;
const isDev = isDevelopmentFromApiKey(secretKey);
const isDev = isDevelopmentFromSecretKey(secretKey);

if (isDev && !isSatellite && shouldRedirectToSatelliteUrl(searchParams)) {
return interstitial(options, AuthErrorReason.PrimaryRespondsToSyncing);
Expand All@@ -80,7 +80,7 @@ export const isPrimaryInDevAndRedirectsToSatellite: InterstitialRule = options =

export const potentialFirstLoadInDevWhenUATMissing: InterstitialRule = options => {
const { secretKey = '', clientUat } = options;
const res = isDevelopmentFromApiKey(secretKey);
const res = isDevelopmentFromSecretKey(secretKey);
if (res && !clientUat) {
return interstitial(options, AuthErrorReason.CookieUATMissing);
}
Expand All@@ -96,7 +96,7 @@ export const potentialRequestAfterSignInOrOutFromClerkHostedUiInDev: Interstitia
const crossOriginReferrer =
referrer && checkCrossOrigin({ originURL: new URL(referrer), host, forwardedHost, forwardedProto });

if (isDevelopmentFromApiKey(secretKey) && crossOriginReferrer) {
if (isDevelopmentFromSecretKey(secretKey) && crossOriginReferrer) {
return interstitial(options, AuthErrorReason.CrossOriginReferrer);
}
return undefined;
Expand All@@ -105,7 +105,7 @@ export const potentialRequestAfterSignInOrOutFromClerkHostedUiInDev: Interstitia
export const potentialFirstRequestOnProductionEnvironment: InterstitialRule = options => {
const { secretKey = '', clientUat, cookieToken } = options;

if (isProductionFromApiKey(secretKey) && !clientUat && !cookieToken) {
if (isProductionFromSecretKey(secretKey) && !clientUat && !cookieToken) {
return signedOut(options, AuthErrorReason.CookieAndUATMissing);
}
return undefined;
Expand Down
6 changes: 3 additions & 3 deletions packages/backend/src/tokens/request.ts
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
import { constants } from '../constants';
import { assertValidSecretKey } from '../util/assertValidSecretKey';
import { buildRequest, stripAuthorizationHeader } from '../util/IsomorphicRequest';
import { isDevelopmentFromApiKey } from '../util/shared';
import type { AuthStatusOptionsType, LoadResourcesOptions, RequestState } from './authStatus';
import { isDevelopmentFromSecretKey } from '../util/shared';
import type { AuthStatusOptionsType, RequestState } from './authStatus';
import { AuthErrorReason, interstitial, signedOut, unknownState } from './authStatus';
import type { TokenCarrier } from './errors';
import { TokenVerificationError, TokenVerificationErrorReason } from './errors';
Expand DownExpand Up@@ -32,7 +32,7 @@ export type OptionalVerifyTokenOptions = Partial<
export type AuthenticateRequestOptions = AuthStatusOptionsType & OptionalVerifyTokenOptions & { request: Request };

function assertSignInUrlExists(signInUrl: string | undefined, key: string): asserts signInUrl is string {
if (!signInUrl && isDevelopmentFromApiKey(key)) {
if (!signInUrl && isDevelopmentFromSecretKey(key)) {
throw new Error(`Missing signInUrl. Pass a signInUrl for dev instances if an app is satellite`);
}
}
Expand Down
8 changes: 8 additions & 0 deletions packages/backend/src/util/mergePreDefinedOptions.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
export function mergePreDefinedOptions<T extends Record<string, any>>(preDefinedOptions: T, options: Partial<T>): T {
return Object.keys(preDefinedOptions).reduce(
(obj: T, key: string) => {
return { ...obj, [key]: options[key] || obj[key] };
},
{ ...preDefinedOptions },
);
}
2 changes: 1 addition & 1 deletion packages/backend/src/util/shared.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
export { addClerkPrefix, getScriptUrl, getClerkJsMajorVersionOrTag } from '@clerk/shared/url';
export { callWithRetry } from '@clerk/shared/callWithRetry';
export { isDevelopmentFromApiKey, isProductionFromApiKey, parsePublishableKey } from '@clerk/shared/keys';
export { isDevelopmentFromSecretKey, isProductionFromSecretKey, parsePublishableKey } from '@clerk/shared/keys';
export { deprecated, deprecatedProperty } from '@clerk/shared/deprecated';

import { buildErrorThrower } from '@clerk/shared/error';
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions .changeset/red-worms-fetch.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
---
'@clerk/clerk-js': major
'@clerk/shared': major
'@clerk/clerk-sdk-node': minor
'@clerk/backend': minor
'@clerk/nextjs': minor
'@clerk/clerk-react': minor
'@clerk/clerk-expo': minor
---

Breaking Changes:

- Drop `isLegacyFrontendApiKey` from `@clerk/shared`
- Drop default exports from `@clerk/clerk-js`
- on headless Clerk type
- on ui and ui.retheme `Portal`
- Use `isProductionFromSecretKey` instead of `isProductionFromApiKey`
- Use `isDevelopmentFromSecretKey` instead of `isDevelopmentFromApiKey`

Changes:

- Rename `HeadlessBrowserClerkConstrutor` / `HeadlessBrowserClerkConstructor` (typo)
- Use `isomorphicAtob` / `isomorhpicBtoa` to replace `base-64` in `@clerk/expo`
- Refactor merging build-time and runtime props in `@clerk/backend` clerk client
- Drop `node-fetch` dependency from `@clerk/backend`
- Drop duplicate test in `@clerk/backend`
14 changes: 1 addition & 13 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/backend/src/tokens/authStatus.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -81,7 +81,7 @@ export type AuthReason = AuthErrorReason | TokenVerificationErrorReason;

export type RequestState = SignedInState | SignedOutState | InterstitialState | UnknownState;

export type LoadResourcesOptions = {
type LoadResourcesOptions = {
loadSession?: boolean;
loadUser?: boolean;
loadOrganization?: boolean;
Expand Down
96 changes: 96 additions & 0 deletions packages/backend/src/tokens/factory.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,96 @@
import type QUnit from 'qunit';

import type { ApiClient } from '../api';
import { createAuthenticateRequest } from './factory';

export default (QUnit: QUnit) => {
const { module, test } = QUnit;

module('createAuthenticateRequest({ options, apiClient })', hooks => {
let fakeAuthenticateRequest;
hooks.afterEach(() => {
fakeAuthenticateRequest?.restore();
});

test('fallbacks to build-time options', async assert => {
const buildTimeOptions = {
secretKey: 'sk',
jwtKey: 'jwtKey',
apiUrl: 'apiUrl',
apiVersion: 'apiVersion',
proxyUrl: 'proxyUrl',
publishableKey: 'pk',
isSatellite: false,
domain: 'domain',
audience: 'domain',
};

const { authenticateRequest } = createAuthenticateRequest({
options: buildTimeOptions,
apiClient: {} as ApiClient,
});

const requestState = await authenticateRequest({ request: new Request('http://example.com/') });
assert.propContains(requestState.toAuth()?.debug(), buildTimeOptions);
});

test('overrides build-time options with runtime options', async assert => {
const buildTimeOptions = {
secretKey: 'sk',
jwtKey: 'jwtKey',
apiUrl: 'apiUrl',
apiVersion: 'apiVersion',
proxyUrl: 'proxyUrl',
publishableKey: 'pk',
isSatellite: false,
domain: 'domain',
audience: 'domain',
};

const { authenticateRequest } = createAuthenticateRequest({
options: buildTimeOptions,
apiClient: {} as ApiClient,
});

const overrides = {
secretKey: 'r-sk',
publishableKey: 'r-pk',
};
const requestState = await authenticateRequest({
request: new Request('http://example.com/'),
...overrides,
});
assert.propContains(requestState.toAuth()?.debug(), {
...buildTimeOptions,
...overrides,
});
});

test('ignore runtime apiUrl and apiVersion options', async assert => {
const buildTimeOptions = {
secretKey: 'sk',
jwtKey: 'jwtKey',
apiUrl: 'apiUrl',
apiVersion: 'apiVersion',
proxyUrl: 'proxyUrl',
publishableKey: 'pk',
isSatellite: false,
domain: 'domain',
audience: 'domain',
};

const { authenticateRequest } = createAuthenticateRequest({
options: buildTimeOptions,
apiClient: {} as ApiClient,
});

const requestState = await authenticateRequest({
request: new Request('http://example.com/'),
// @ts-expect-error is used to check runtime code
apiUrl: 'r-apiUrl',
apiVersion: 'r-apiVersion',
});
assert.propContains(requestState.toAuth()?.debug(), buildTimeOptions);
});
});
};
101 changes: 43 additions & 58 deletions packages/backend/src/tokens/factory.ts
Original file line numberDiff line numberDiff line change
@@ -1,80 +1,65 @@
import type { ApiClient } from '../api';
import { API_URL, API_VERSION } from '../constants';
import { mergePreDefinedOptions } from '../util/mergePreDefinedOptions';
import type { LoadInterstitialOptions } from './interstitial';
import { loadInterstitialFromLocal } from './interstitial';
import type { AuthenticateRequestOptions } from './request';
import { authenticateRequest as authenticateRequestOriginal, debugRequestState } from './request';

type RunTimeOptions = Omit<AuthenticateRequestOptions, 'apiUrl' | 'apiVersion'>;

type BuildTimeOptions = Partial<
Pick<
AuthenticateRequestOptions,
| 'apiUrl'
| 'apiVersion'
| 'audience'
| 'domain'
| 'isSatellite'
| 'jwtKey'
| 'proxyUrl'
| 'publishableKey'
| 'secretKey'
>
>;

const defaultOptions = {
secretKey: '',
jwtKey: '',
apiUrl: undefined,
apiVersion: undefined,
proxyUrl: '',
publishableKey: '',
isSatellite: false,
domain: '',
audience: '',
} satisfies BuildTimeOptions;

export type CreateAuthenticateRequestOptions = {
options: Partial<
Pick<
AuthenticateRequestOptions,
| 'audience'
| 'secretKey'
| 'apiUrl'
| 'apiVersion'
| 'publishableKey'
| 'jwtKey'
| 'proxyUrl'
| 'domain'
| 'isSatellite'
>
>;
options: BuildTimeOptions;
apiClient: ApiClient;
};

export function createAuthenticateRequest(params: CreateAuthenticateRequestOptions) {
const { apiClient } = params;
const {
secretKey: buildtimeSecretKey = '',
jwtKey: buildtimeJwtKey = '',
apiUrl = API_URL,
apiVersion = API_VERSION,
proxyUrl: buildProxyUrl = '',
publishableKey: buildtimePublishableKey = '',
isSatellite: buildtimeIsSatellite = false,
domain: buildtimeDomain = '',
audience: buildtimeAudience = '',
} = params.options;
const buildTimeOptions = mergePreDefinedOptions(defaultOptions, params.options);

const authenticateRequest = ({
secretKey: runtimeSecretKey,
audience: runtimeAudience,
proxyUrl: runtimeProxyUrl,
publishableKey: runtimePublishableKey,
jwtKey: runtimeJwtKey,
isSatellite: runtimeIsSatellite,
domain: runtimeDomain,
...rest
}: Omit<AuthenticateRequestOptions, 'apiUrl' | 'apiVersion'>) => {
const authenticateRequest = (options: RunTimeOptions) => {
const { apiUrl, apiVersion } = buildTimeOptions;
const runTimeOptions = mergePreDefinedOptions(buildTimeOptions, options);
return authenticateRequestOriginal({
...rest,
secretKey: runtimeSecretKey || buildtimeSecretKey,
audience: runtimeAudience || buildtimeAudience,
...options,
...runTimeOptions,
// We should add all the omitted props from options here (eg apiUrl / apiVersion)
// to avoid runtime options override them.
apiUrl,
apiVersion,
proxyUrl: runtimeProxyUrl || buildProxyUrl,
publishableKey: runtimePublishableKey || buildtimePublishableKey,
isSatellite: runtimeIsSatellite || buildtimeIsSatellite,
domain: runtimeDomain || buildtimeDomain,
jwtKey: runtimeJwtKey || buildtimeJwtKey,
});
};

const localInterstitial = ({
publishableKey: runtimePublishableKey,
proxyUrl: runtimeProxyUrl,
isSatellite: runtimeIsSatellite,
domain: runtimeDomain,
...rest
}: Omit<LoadInterstitialOptions, 'apiUrl'>) =>
loadInterstitialFromLocal({
...rest,
proxyUrl: runtimeProxyUrl || buildProxyUrl,
publishableKey: runtimePublishableKey || buildtimePublishableKey,
isSatellite: runtimeIsSatellite || buildtimeIsSatellite,
domain: runtimeDomain || buildtimeDomain,
});
const localInterstitial = (options: Omit<LoadInterstitialOptions, 'apiUrl'>) => {
const runTimeOptions = mergePreDefinedOptions(buildTimeOptions, options);
return loadInterstitialFromLocal({ ...options, ...runTimeOptions });
};

// TODO: Replace this function with remotePublicInterstitial
const remotePrivateInterstitial = () => apiClient.interstitial.getInterstitial();
Expand Down
12 changes: 6 additions & 6 deletions packages/backend/src/tokens/interstitialRule.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { checkCrossOrigin } from '../util/request';
import { isDevelopmentFromApiKey, isProductionFromApiKey } from '../util/shared';
import { isDevelopmentFromSecretKey, isProductionFromSecretKey } from '../util/shared';
import type { AuthStatusOptionsType, RequestState } from './authStatus';
import { AuthErrorReason, interstitial, signedIn, signedOut } from './authStatus';
import { verifyToken } from './verify';
Expand DownExpand Up@@ -45,7 +45,7 @@ const isBrowser = (userAgent: string | undefined) => VALID_USER_AGENTS.test(user
// automatically treated as signed out. This exception is needed for development, because the any // missing uat throws an interstitial in development.
export const nonBrowserRequestInDevRule: InterstitialRule = options => {
const { secretKey, userAgent } = options;
if (isDevelopmentFromApiKey(secretKey || '') && !isBrowser(userAgent)) {
if (isDevelopmentFromSecretKey(secretKey || '') && !isBrowser(userAgent)) {
return signedOut(options, AuthErrorReason.HeaderMissingNonBrowser);
}
return undefined;
Expand All@@ -70,7 +70,7 @@ export const crossOriginRequestWithoutHeader: InterstitialRule = options => {

export const isPrimaryInDevAndRedirectsToSatellite: InterstitialRule = options => {
const { secretKey = '', isSatellite, searchParams } = options;
const isDev = isDevelopmentFromApiKey(secretKey);
const isDev = isDevelopmentFromSecretKey(secretKey);

if (isDev && !isSatellite && shouldRedirectToSatelliteUrl(searchParams)) {
return interstitial(options, AuthErrorReason.PrimaryRespondsToSyncing);
Expand All@@ -80,7 +80,7 @@ export const isPrimaryInDevAndRedirectsToSatellite: InterstitialRule = options =

export const potentialFirstLoadInDevWhenUATMissing: InterstitialRule = options => {
const { secretKey = '', clientUat } = options;
const res = isDevelopmentFromApiKey(secretKey);
const res = isDevelopmentFromSecretKey(secretKey);
if (res && !clientUat) {
return interstitial(options, AuthErrorReason.CookieUATMissing);
}
Expand All@@ -96,7 +96,7 @@ export const potentialRequestAfterSignInOrOutFromClerkHostedUiInDev: Interstitia
const crossOriginReferrer =
referrer && checkCrossOrigin({ originURL: new URL(referrer), host, forwardedHost, forwardedProto });

if (isDevelopmentFromApiKey(secretKey) && crossOriginReferrer) {
if (isDevelopmentFromSecretKey(secretKey) && crossOriginReferrer) {
return interstitial(options, AuthErrorReason.CrossOriginReferrer);
}
return undefined;
Expand All@@ -105,7 +105,7 @@ export const potentialRequestAfterSignInOrOutFromClerkHostedUiInDev: Interstitia
export const potentialFirstRequestOnProductionEnvironment: InterstitialRule = options => {
const { secretKey = '', clientUat, cookieToken } = options;

if (isProductionFromApiKey(secretKey) && !clientUat && !cookieToken) {
if (isProductionFromSecretKey(secretKey) && !clientUat && !cookieToken) {
return signedOut(options, AuthErrorReason.CookieAndUATMissing);
}
return undefined;
Expand Down
6 changes: 3 additions & 3 deletions packages/backend/src/tokens/request.ts
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
import { constants } from '../constants';
import { assertValidSecretKey } from '../util/assertValidSecretKey';
import { buildRequest, stripAuthorizationHeader } from '../util/IsomorphicRequest';
import { isDevelopmentFromApiKey } from '../util/shared';
import type { AuthStatusOptionsType, LoadResourcesOptions, RequestState } from './authStatus';
import { isDevelopmentFromSecretKey } from '../util/shared';
import type { AuthStatusOptionsType, RequestState } from './authStatus';
import { AuthErrorReason, interstitial, signedOut, unknownState } from './authStatus';
import type { TokenCarrier } from './errors';
import { TokenVerificationError, TokenVerificationErrorReason } from './errors';
Expand DownExpand Up@@ -32,7 +32,7 @@ export type OptionalVerifyTokenOptions = Partial<
export type AuthenticateRequestOptions = AuthStatusOptionsType & OptionalVerifyTokenOptions & { request: Request };

function assertSignInUrlExists(signInUrl: string | undefined, key: string): asserts signInUrl is string {
if (!signInUrl && isDevelopmentFromApiKey(key)) {
if (!signInUrl && isDevelopmentFromSecretKey(key)) {
throw new Error(`Missing signInUrl. Pass a signInUrl for dev instances if an app is satellite`);
}
}
Expand Down
8 changes: 8 additions & 0 deletions packages/backend/src/util/mergePreDefinedOptions.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
export function mergePreDefinedOptions<T extends Record<string, any>>(preDefinedOptions: T, options: Partial<T>): T {
return Object.keys(preDefinedOptions).reduce(
(obj: T, key: string) => {
return { ...obj, [key]: options[key] || obj[key] };
},
{ ...preDefinedOptions },
);
}
2 changes: 1 addition & 1 deletion packages/backend/src/util/shared.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
export { addClerkPrefix, getScriptUrl, getClerkJsMajorVersionOrTag } from '@clerk/shared/url';
export { callWithRetry } from '@clerk/shared/callWithRetry';
export { isDevelopmentFromApiKey, isProductionFromApiKey, parsePublishableKey } from '@clerk/shared/keys';
export { isDevelopmentFromSecretKey, isProductionFromSecretKey, parsePublishableKey } from '@clerk/shared/keys';
export { deprecated, deprecatedProperty } from '@clerk/shared/deprecated';

import { buildErrorThrower } from '@clerk/shared/error';
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions .changeset/red-worms-fetch.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
---
'@clerk/clerk-js': major
'@clerk/shared': major
'@clerk/clerk-sdk-node': minor
'@clerk/backend': minor
'@clerk/nextjs': minor
'@clerk/clerk-react': minor
'@clerk/clerk-expo': minor
---

Breaking Changes:

- Drop `isLegacyFrontendApiKey` from `@clerk/shared`
- Drop default exports from `@clerk/clerk-js`
- on headless Clerk type
- on ui and ui.retheme `Portal`
- Use `isProductionFromSecretKey` instead of `isProductionFromApiKey`
- Use `isDevelopmentFromSecretKey` instead of `isDevelopmentFromApiKey`

Changes:

- Rename `HeadlessBrowserClerkConstrutor` / `HeadlessBrowserClerkConstructor` (typo)
- Use `isomorphicAtob` / `isomorhpicBtoa` to replace `base-64` in `@clerk/expo`
- Refactor merging build-time and runtime props in `@clerk/backend` clerk client
- Drop `node-fetch` dependency from `@clerk/backend`
- Drop duplicate test in `@clerk/backend`
14 changes: 1 addition & 13 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/backend/src/tokens/authStatus.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -81,7 +81,7 @@ export type AuthReason = AuthErrorReason | TokenVerificationErrorReason;

export type RequestState = SignedInState | SignedOutState | InterstitialState | UnknownState;

export type LoadResourcesOptions = {
type LoadResourcesOptions = {
loadSession?: boolean;
loadUser?: boolean;
loadOrganization?: boolean;
Expand Down
96 changes: 96 additions & 0 deletions packages/backend/src/tokens/factory.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,96 @@
import type QUnit from 'qunit';

import type { ApiClient } from '../api';
import { createAuthenticateRequest } from './factory';

export default (QUnit: QUnit) => {
const { module, test } = QUnit;

module('createAuthenticateRequest({ options, apiClient })', hooks => {
let fakeAuthenticateRequest;
hooks.afterEach(() => {
fakeAuthenticateRequest?.restore();
});

test('fallbacks to build-time options', async assert => {
const buildTimeOptions = {
secretKey: 'sk',
jwtKey: 'jwtKey',
apiUrl: 'apiUrl',
apiVersion: 'apiVersion',
proxyUrl: 'proxyUrl',
publishableKey: 'pk',
isSatellite: false,
domain: 'domain',
audience: 'domain',
};

const { authenticateRequest } = createAuthenticateRequest({
options: buildTimeOptions,
apiClient: {} as ApiClient,
});

const requestState = await authenticateRequest({ request: new Request('http://example.com/') });
assert.propContains(requestState.toAuth()?.debug(), buildTimeOptions);
});

test('overrides build-time options with runtime options', async assert => {
const buildTimeOptions = {
secretKey: 'sk',
jwtKey: 'jwtKey',
apiUrl: 'apiUrl',
apiVersion: 'apiVersion',
proxyUrl: 'proxyUrl',
publishableKey: 'pk',
isSatellite: false,
domain: 'domain',
audience: 'domain',
};

const { authenticateRequest } = createAuthenticateRequest({
options: buildTimeOptions,
apiClient: {} as ApiClient,
});

const overrides = {
secretKey: 'r-sk',
publishableKey: 'r-pk',
};
const requestState = await authenticateRequest({
request: new Request('http://example.com/'),
...overrides,
});
assert.propContains(requestState.toAuth()?.debug(), {
...buildTimeOptions,
...overrides,
});
});

test('ignore runtime apiUrl and apiVersion options', async assert => {
const buildTimeOptions = {
secretKey: 'sk',
jwtKey: 'jwtKey',
apiUrl: 'apiUrl',
apiVersion: 'apiVersion',
proxyUrl: 'proxyUrl',
publishableKey: 'pk',
isSatellite: false,
domain: 'domain',
audience: 'domain',
};

const { authenticateRequest } = createAuthenticateRequest({
options: buildTimeOptions,
apiClient: {} as ApiClient,
});

const requestState = await authenticateRequest({
request: new Request('http://example.com/'),
// @ts-expect-error is used to check runtime code
apiUrl: 'r-apiUrl',
apiVersion: 'r-apiVersion',
});
assert.propContains(requestState.toAuth()?.debug(), buildTimeOptions);
});
});
};
101 changes: 43 additions & 58 deletions packages/backend/src/tokens/factory.ts
Original file line numberDiff line numberDiff line change
@@ -1,80 +1,65 @@
import type { ApiClient } from '../api';
import { API_URL, API_VERSION } from '../constants';
import { mergePreDefinedOptions } from '../util/mergePreDefinedOptions';
import type { LoadInterstitialOptions } from './interstitial';
import { loadInterstitialFromLocal } from './interstitial';
import type { AuthenticateRequestOptions } from './request';
import { authenticateRequest as authenticateRequestOriginal, debugRequestState } from './request';

type RunTimeOptions = Omit<AuthenticateRequestOptions, 'apiUrl' | 'apiVersion'>;

type BuildTimeOptions = Partial<
Pick<
AuthenticateRequestOptions,
| 'apiUrl'
| 'apiVersion'
| 'audience'
| 'domain'
| 'isSatellite'
| 'jwtKey'
| 'proxyUrl'
| 'publishableKey'
| 'secretKey'
>
>;

const defaultOptions = {
secretKey: '',
jwtKey: '',
apiUrl: undefined,
apiVersion: undefined,
proxyUrl: '',
publishableKey: '',
isSatellite: false,
domain: '',
audience: '',
} satisfies BuildTimeOptions;

export type CreateAuthenticateRequestOptions = {
options: Partial<
Pick<
AuthenticateRequestOptions,
| 'audience'
| 'secretKey'
| 'apiUrl'
| 'apiVersion'
| 'publishableKey'
| 'jwtKey'
| 'proxyUrl'
| 'domain'
| 'isSatellite'
>
>;
options: BuildTimeOptions;
apiClient: ApiClient;
};

export function createAuthenticateRequest(params: CreateAuthenticateRequestOptions) {
const { apiClient } = params;
const {
secretKey: buildtimeSecretKey = '',
jwtKey: buildtimeJwtKey = '',
apiUrl = API_URL,
apiVersion = API_VERSION,
proxyUrl: buildProxyUrl = '',
publishableKey: buildtimePublishableKey = '',
isSatellite: buildtimeIsSatellite = false,
domain: buildtimeDomain = '',
audience: buildtimeAudience = '',
} = params.options;
const buildTimeOptions = mergePreDefinedOptions(defaultOptions, params.options);

const authenticateRequest = ({
secretKey: runtimeSecretKey,
audience: runtimeAudience,
proxyUrl: runtimeProxyUrl,
publishableKey: runtimePublishableKey,
jwtKey: runtimeJwtKey,
isSatellite: runtimeIsSatellite,
domain: runtimeDomain,
...rest
}: Omit<AuthenticateRequestOptions, 'apiUrl' | 'apiVersion'>) => {
const authenticateRequest = (options: RunTimeOptions) => {
const { apiUrl, apiVersion } = buildTimeOptions;
const runTimeOptions = mergePreDefinedOptions(buildTimeOptions, options);
return authenticateRequestOriginal({
...rest,
secretKey: runtimeSecretKey || buildtimeSecretKey,
audience: runtimeAudience || buildtimeAudience,
...options,
...runTimeOptions,
// We should add all the omitted props from options here (eg apiUrl / apiVersion)
// to avoid runtime options override them.
apiUrl,
apiVersion,
proxyUrl: runtimeProxyUrl || buildProxyUrl,
publishableKey: runtimePublishableKey || buildtimePublishableKey,
isSatellite: runtimeIsSatellite || buildtimeIsSatellite,
domain: runtimeDomain || buildtimeDomain,
jwtKey: runtimeJwtKey || buildtimeJwtKey,
});
};

const localInterstitial = ({
publishableKey: runtimePublishableKey,
proxyUrl: runtimeProxyUrl,
isSatellite: runtimeIsSatellite,
domain: runtimeDomain,
...rest
}: Omit<LoadInterstitialOptions, 'apiUrl'>) =>
loadInterstitialFromLocal({
...rest,
proxyUrl: runtimeProxyUrl || buildProxyUrl,
publishableKey: runtimePublishableKey || buildtimePublishableKey,
isSatellite: runtimeIsSatellite || buildtimeIsSatellite,
domain: runtimeDomain || buildtimeDomain,
});
const localInterstitial = (options: Omit<LoadInterstitialOptions, 'apiUrl'>) => {
const runTimeOptions = mergePreDefinedOptions(buildTimeOptions, options);
return loadInterstitialFromLocal({ ...options, ...runTimeOptions });
};

// TODO: Replace this function with remotePublicInterstitial
const remotePrivateInterstitial = () => apiClient.interstitial.getInterstitial();
Expand Down
12 changes: 6 additions & 6 deletions packages/backend/src/tokens/interstitialRule.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { checkCrossOrigin } from '../util/request';
import { isDevelopmentFromApiKey, isProductionFromApiKey } from '../util/shared';
import { isDevelopmentFromSecretKey, isProductionFromSecretKey } from '../util/shared';
import type { AuthStatusOptionsType, RequestState } from './authStatus';
import { AuthErrorReason, interstitial, signedIn, signedOut } from './authStatus';
import { verifyToken } from './verify';
Expand DownExpand Up@@ -45,7 +45,7 @@ const isBrowser = (userAgent: string | undefined) => VALID_USER_AGENTS.test(user
// automatically treated as signed out. This exception is needed for development, because the any // missing uat throws an interstitial in development.
export const nonBrowserRequestInDevRule: InterstitialRule = options => {
const { secretKey, userAgent } = options;
if (isDevelopmentFromApiKey(secretKey || '') && !isBrowser(userAgent)) {
if (isDevelopmentFromSecretKey(secretKey || '') && !isBrowser(userAgent)) {
return signedOut(options, AuthErrorReason.HeaderMissingNonBrowser);
}
return undefined;
Expand All@@ -70,7 +70,7 @@ export const crossOriginRequestWithoutHeader: InterstitialRule = options => {

export const isPrimaryInDevAndRedirectsToSatellite: InterstitialRule = options => {
const { secretKey = '', isSatellite, searchParams } = options;
const isDev = isDevelopmentFromApiKey(secretKey);
const isDev = isDevelopmentFromSecretKey(secretKey);

if (isDev && !isSatellite && shouldRedirectToSatelliteUrl(searchParams)) {
return interstitial(options, AuthErrorReason.PrimaryRespondsToSyncing);
Expand All@@ -80,7 +80,7 @@ export const isPrimaryInDevAndRedirectsToSatellite: InterstitialRule = options =

export const potentialFirstLoadInDevWhenUATMissing: InterstitialRule = options => {
const { secretKey = '', clientUat } = options;
const res = isDevelopmentFromApiKey(secretKey);
const res = isDevelopmentFromSecretKey(secretKey);
if (res && !clientUat) {
return interstitial(options, AuthErrorReason.CookieUATMissing);
}
Expand All@@ -96,7 +96,7 @@ export const potentialRequestAfterSignInOrOutFromClerkHostedUiInDev: Interstitia
const crossOriginReferrer =
referrer && checkCrossOrigin({ originURL: new URL(referrer), host, forwardedHost, forwardedProto });

if (isDevelopmentFromApiKey(secretKey) && crossOriginReferrer) {
if (isDevelopmentFromSecretKey(secretKey) && crossOriginReferrer) {
return interstitial(options, AuthErrorReason.CrossOriginReferrer);
}
return undefined;
Expand All@@ -105,7 +105,7 @@ export const potentialRequestAfterSignInOrOutFromClerkHostedUiInDev: Interstitia
export const potentialFirstRequestOnProductionEnvironment: InterstitialRule = options => {
const { secretKey = '', clientUat, cookieToken } = options;

if (isProductionFromApiKey(secretKey) && !clientUat && !cookieToken) {
if (isProductionFromSecretKey(secretKey) && !clientUat && !cookieToken) {
return signedOut(options, AuthErrorReason.CookieAndUATMissing);
}
return undefined;
Expand Down
6 changes: 3 additions & 3 deletions packages/backend/src/tokens/request.ts
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
import { constants } from '../constants';
import { assertValidSecretKey } from '../util/assertValidSecretKey';
import { buildRequest, stripAuthorizationHeader } from '../util/IsomorphicRequest';
import { isDevelopmentFromApiKey } from '../util/shared';
import type { AuthStatusOptionsType, LoadResourcesOptions, RequestState } from './authStatus';
import { isDevelopmentFromSecretKey } from '../util/shared';
import type { AuthStatusOptionsType, RequestState } from './authStatus';
import { AuthErrorReason, interstitial, signedOut, unknownState } from './authStatus';
import type { TokenCarrier } from './errors';
import { TokenVerificationError, TokenVerificationErrorReason } from './errors';
Expand DownExpand Up@@ -32,7 +32,7 @@ export type OptionalVerifyTokenOptions = Partial<
export type AuthenticateRequestOptions = AuthStatusOptionsType & OptionalVerifyTokenOptions & { request: Request };

function assertSignInUrlExists(signInUrl: string | undefined, key: string): asserts signInUrl is string {
if (!signInUrl && isDevelopmentFromApiKey(key)) {
if (!signInUrl && isDevelopmentFromSecretKey(key)) {
throw new Error(`Missing signInUrl. Pass a signInUrl for dev instances if an app is satellite`);
}
}
Expand Down
8 changes: 8 additions & 0 deletions packages/backend/src/util/mergePreDefinedOptions.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
export function mergePreDefinedOptions<T extends Record<string, any>>(preDefinedOptions: T, options: Partial<T>): T {
return Object.keys(preDefinedOptions).reduce(
(obj: T, key: string) => {
return { ...obj, [key]: options[key] || obj[key] };
},
{ ...preDefinedOptions },
);
}
2 changes: 1 addition & 1 deletion packages/backend/src/util/shared.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
export { addClerkPrefix, getScriptUrl, getClerkJsMajorVersionOrTag } from '@clerk/shared/url';
export { callWithRetry } from '@clerk/shared/callWithRetry';
export { isDevelopmentFromApiKey, isProductionFromApiKey, parsePublishableKey } from '@clerk/shared/keys';
export { isDevelopmentFromSecretKey, isProductionFromSecretKey, parsePublishableKey } from '@clerk/shared/keys';
export { deprecated, deprecatedProperty } from '@clerk/shared/deprecated';

import { buildErrorThrower } from '@clerk/shared/error';
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions .changeset/red-worms-fetch.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
---
'@clerk/clerk-js': major
'@clerk/shared': major
'@clerk/clerk-sdk-node': minor
'@clerk/backend': minor
'@clerk/nextjs': minor
'@clerk/clerk-react': minor
'@clerk/clerk-expo': minor
---

Breaking Changes:

- Drop `isLegacyFrontendApiKey` from `@clerk/shared`
- Drop default exports from `@clerk/clerk-js`
- on headless Clerk type
- on ui and ui.retheme `Portal`
- Use `isProductionFromSecretKey` instead of `isProductionFromApiKey`
- Use `isDevelopmentFromSecretKey` instead of `isDevelopmentFromApiKey`

Changes:

- Rename `HeadlessBrowserClerkConstrutor` / `HeadlessBrowserClerkConstructor` (typo)
- Use `isomorphicAtob` / `isomorhpicBtoa` to replace `base-64` in `@clerk/expo`
- Refactor merging build-time and runtime props in `@clerk/backend` clerk client
- Drop `node-fetch` dependency from `@clerk/backend`
- Drop duplicate test in `@clerk/backend`
14 changes: 1 addition & 13 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/backend/src/tokens/authStatus.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -81,7 +81,7 @@ export type AuthReason = AuthErrorReason | TokenVerificationErrorReason;

export type RequestState = SignedInState | SignedOutState | InterstitialState | UnknownState;

export type LoadResourcesOptions = {
type LoadResourcesOptions = {
loadSession?: boolean;
loadUser?: boolean;
loadOrganization?: boolean;
Expand Down
96 changes: 96 additions & 0 deletions packages/backend/src/tokens/factory.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,96 @@
import type QUnit from 'qunit';

import type { ApiClient } from '../api';
import { createAuthenticateRequest } from './factory';

export default (QUnit: QUnit) => {
const { module, test } = QUnit;

module('createAuthenticateRequest({ options, apiClient })', hooks => {
let fakeAuthenticateRequest;
hooks.afterEach(() => {
fakeAuthenticateRequest?.restore();
});

test('fallbacks to build-time options', async assert => {
const buildTimeOptions = {
secretKey: 'sk',
jwtKey: 'jwtKey',
apiUrl: 'apiUrl',
apiVersion: 'apiVersion',
proxyUrl: 'proxyUrl',
publishableKey: 'pk',
isSatellite: false,
domain: 'domain',
audience: 'domain',
};

const { authenticateRequest } = createAuthenticateRequest({
options: buildTimeOptions,
apiClient: {} as ApiClient,
});

const requestState = await authenticateRequest({ request: new Request('http://example.com/') });
assert.propContains(requestState.toAuth()?.debug(), buildTimeOptions);
});

test('overrides build-time options with runtime options', async assert => {
const buildTimeOptions = {
secretKey: 'sk',
jwtKey: 'jwtKey',
apiUrl: 'apiUrl',
apiVersion: 'apiVersion',
proxyUrl: 'proxyUrl',
publishableKey: 'pk',
isSatellite: false,
domain: 'domain',
audience: 'domain',
};

const { authenticateRequest } = createAuthenticateRequest({
options: buildTimeOptions,
apiClient: {} as ApiClient,
});

const overrides = {
secretKey: 'r-sk',
publishableKey: 'r-pk',
};
const requestState = await authenticateRequest({
request: new Request('http://example.com/'),
...overrides,
});
assert.propContains(requestState.toAuth()?.debug(), {
...buildTimeOptions,
...overrides,
});
});

test('ignore runtime apiUrl and apiVersion options', async assert => {
const buildTimeOptions = {
secretKey: 'sk',
jwtKey: 'jwtKey',
apiUrl: 'apiUrl',
apiVersion: 'apiVersion',
proxyUrl: 'proxyUrl',
publishableKey: 'pk',
isSatellite: false,
domain: 'domain',
audience: 'domain',
};

const { authenticateRequest } = createAuthenticateRequest({
options: buildTimeOptions,
apiClient: {} as ApiClient,
});

const requestState = await authenticateRequest({
request: new Request('http://example.com/'),
// @ts-expect-error is used to check runtime code
apiUrl: 'r-apiUrl',
apiVersion: 'r-apiVersion',
});
assert.propContains(requestState.toAuth()?.debug(), buildTimeOptions);
});
});
};
101 changes: 43 additions & 58 deletions packages/backend/src/tokens/factory.ts
Original file line numberDiff line numberDiff line change
@@ -1,80 +1,65 @@
import type { ApiClient } from '../api';
import { API_URL, API_VERSION } from '../constants';
import { mergePreDefinedOptions } from '../util/mergePreDefinedOptions';
import type { LoadInterstitialOptions } from './interstitial';
import { loadInterstitialFromLocal } from './interstitial';
import type { AuthenticateRequestOptions } from './request';
import { authenticateRequest as authenticateRequestOriginal, debugRequestState } from './request';

type RunTimeOptions = Omit<AuthenticateRequestOptions, 'apiUrl' | 'apiVersion'>;

type BuildTimeOptions = Partial<
Pick<
AuthenticateRequestOptions,
| 'apiUrl'
| 'apiVersion'
| 'audience'
| 'domain'
| 'isSatellite'
| 'jwtKey'
| 'proxyUrl'
| 'publishableKey'
| 'secretKey'
>
>;

const defaultOptions = {
secretKey: '',
jwtKey: '',
apiUrl: undefined,
apiVersion: undefined,
proxyUrl: '',
publishableKey: '',
isSatellite: false,
domain: '',
audience: '',
} satisfies BuildTimeOptions;

export type CreateAuthenticateRequestOptions = {
options: Partial<
Pick<
AuthenticateRequestOptions,
| 'audience'
| 'secretKey'
| 'apiUrl'
| 'apiVersion'
| 'publishableKey'
| 'jwtKey'
| 'proxyUrl'
| 'domain'
| 'isSatellite'
>
>;
options: BuildTimeOptions;
apiClient: ApiClient;
};

export function createAuthenticateRequest(params: CreateAuthenticateRequestOptions) {
const { apiClient } = params;
const {
secretKey: buildtimeSecretKey = '',
jwtKey: buildtimeJwtKey = '',
apiUrl = API_URL,
apiVersion = API_VERSION,
proxyUrl: buildProxyUrl = '',
publishableKey: buildtimePublishableKey = '',
isSatellite: buildtimeIsSatellite = false,
domain: buildtimeDomain = '',
audience: buildtimeAudience = '',
} = params.options;
const buildTimeOptions = mergePreDefinedOptions(defaultOptions, params.options);

const authenticateRequest = ({
secretKey: runtimeSecretKey,
audience: runtimeAudience,
proxyUrl: runtimeProxyUrl,
publishableKey: runtimePublishableKey,
jwtKey: runtimeJwtKey,
isSatellite: runtimeIsSatellite,
domain: runtimeDomain,
...rest
}: Omit<AuthenticateRequestOptions, 'apiUrl' | 'apiVersion'>) => {
const authenticateRequest = (options: RunTimeOptions) => {
const { apiUrl, apiVersion } = buildTimeOptions;
const runTimeOptions = mergePreDefinedOptions(buildTimeOptions, options);
return authenticateRequestOriginal({
...rest,
secretKey: runtimeSecretKey || buildtimeSecretKey,
audience: runtimeAudience || buildtimeAudience,
...options,
...runTimeOptions,
// We should add all the omitted props from options here (eg apiUrl / apiVersion)
// to avoid runtime options override them.
apiUrl,
apiVersion,
proxyUrl: runtimeProxyUrl || buildProxyUrl,
publishableKey: runtimePublishableKey || buildtimePublishableKey,
isSatellite: runtimeIsSatellite || buildtimeIsSatellite,
domain: runtimeDomain || buildtimeDomain,
jwtKey: runtimeJwtKey || buildtimeJwtKey,
});
};

const localInterstitial = ({
publishableKey: runtimePublishableKey,
proxyUrl: runtimeProxyUrl,
isSatellite: runtimeIsSatellite,
domain: runtimeDomain,
...rest
}: Omit<LoadInterstitialOptions, 'apiUrl'>) =>
loadInterstitialFromLocal({
...rest,
proxyUrl: runtimeProxyUrl || buildProxyUrl,
publishableKey: runtimePublishableKey || buildtimePublishableKey,
isSatellite: runtimeIsSatellite || buildtimeIsSatellite,
domain: runtimeDomain || buildtimeDomain,
});
const localInterstitial = (options: Omit<LoadInterstitialOptions, 'apiUrl'>) => {
const runTimeOptions = mergePreDefinedOptions(buildTimeOptions, options);
return loadInterstitialFromLocal({ ...options, ...runTimeOptions });
};

// TODO: Replace this function with remotePublicInterstitial
const remotePrivateInterstitial = () => apiClient.interstitial.getInterstitial();
Expand Down
12 changes: 6 additions & 6 deletions packages/backend/src/tokens/interstitialRule.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { checkCrossOrigin } from '../util/request';
import { isDevelopmentFromApiKey, isProductionFromApiKey } from '../util/shared';
import { isDevelopmentFromSecretKey, isProductionFromSecretKey } from '../util/shared';
import type { AuthStatusOptionsType, RequestState } from './authStatus';
import { AuthErrorReason, interstitial, signedIn, signedOut } from './authStatus';
import { verifyToken } from './verify';
Expand DownExpand Up@@ -45,7 +45,7 @@ const isBrowser = (userAgent: string | undefined) => VALID_USER_AGENTS.test(user
// automatically treated as signed out. This exception is needed for development, because the any // missing uat throws an interstitial in development.
export const nonBrowserRequestInDevRule: InterstitialRule = options => {
const { secretKey, userAgent } = options;
if (isDevelopmentFromApiKey(secretKey || '') && !isBrowser(userAgent)) {
if (isDevelopmentFromSecretKey(secretKey || '') && !isBrowser(userAgent)) {
return signedOut(options, AuthErrorReason.HeaderMissingNonBrowser);
}
return undefined;
Expand All@@ -70,7 +70,7 @@ export const crossOriginRequestWithoutHeader: InterstitialRule = options => {

export const isPrimaryInDevAndRedirectsToSatellite: InterstitialRule = options => {
const { secretKey = '', isSatellite, searchParams } = options;
const isDev = isDevelopmentFromApiKey(secretKey);
const isDev = isDevelopmentFromSecretKey(secretKey);

if (isDev && !isSatellite && shouldRedirectToSatelliteUrl(searchParams)) {
return interstitial(options, AuthErrorReason.PrimaryRespondsToSyncing);
Expand All@@ -80,7 +80,7 @@ export const isPrimaryInDevAndRedirectsToSatellite: InterstitialRule = options =

export const potentialFirstLoadInDevWhenUATMissing: InterstitialRule = options => {
const { secretKey = '', clientUat } = options;
const res = isDevelopmentFromApiKey(secretKey);
const res = isDevelopmentFromSecretKey(secretKey);
if (res && !clientUat) {
return interstitial(options, AuthErrorReason.CookieUATMissing);
}
Expand All@@ -96,7 +96,7 @@ export const potentialRequestAfterSignInOrOutFromClerkHostedUiInDev: Interstitia
const crossOriginReferrer =
referrer && checkCrossOrigin({ originURL: new URL(referrer), host, forwardedHost, forwardedProto });

if (isDevelopmentFromApiKey(secretKey) && crossOriginReferrer) {
if (isDevelopmentFromSecretKey(secretKey) && crossOriginReferrer) {
return interstitial(options, AuthErrorReason.CrossOriginReferrer);
}
return undefined;
Expand All@@ -105,7 +105,7 @@ export const potentialRequestAfterSignInOrOutFromClerkHostedUiInDev: Interstitia
export const potentialFirstRequestOnProductionEnvironment: InterstitialRule = options => {
const { secretKey = '', clientUat, cookieToken } = options;

if (isProductionFromApiKey(secretKey) && !clientUat && !cookieToken) {
if (isProductionFromSecretKey(secretKey) && !clientUat && !cookieToken) {
return signedOut(options, AuthErrorReason.CookieAndUATMissing);
}
return undefined;
Expand Down
6 changes: 3 additions & 3 deletions packages/backend/src/tokens/request.ts
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
import { constants } from '../constants';
import { assertValidSecretKey } from '../util/assertValidSecretKey';
import { buildRequest, stripAuthorizationHeader } from '../util/IsomorphicRequest';
import { isDevelopmentFromApiKey } from '../util/shared';
import type { AuthStatusOptionsType, LoadResourcesOptions, RequestState } from './authStatus';
import { isDevelopmentFromSecretKey } from '../util/shared';
import type { AuthStatusOptionsType, RequestState } from './authStatus';
import { AuthErrorReason, interstitial, signedOut, unknownState } from './authStatus';
import type { TokenCarrier } from './errors';
import { TokenVerificationError, TokenVerificationErrorReason } from './errors';
Expand DownExpand Up@@ -32,7 +32,7 @@ export type OptionalVerifyTokenOptions = Partial<
export type AuthenticateRequestOptions = AuthStatusOptionsType & OptionalVerifyTokenOptions & { request: Request };

function assertSignInUrlExists(signInUrl: string | undefined, key: string): asserts signInUrl is string {
if (!signInUrl && isDevelopmentFromApiKey(key)) {
if (!signInUrl && isDevelopmentFromSecretKey(key)) {
throw new Error(`Missing signInUrl. Pass a signInUrl for dev instances if an app is satellite`);
}
}
Expand Down
8 changes: 8 additions & 0 deletions packages/backend/src/util/mergePreDefinedOptions.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
export function mergePreDefinedOptions<T extends Record<string, any>>(preDefinedOptions: T, options: Partial<T>): T {
return Object.keys(preDefinedOptions).reduce(
(obj: T, key: string) => {
return { ...obj, [key]: options[key] || obj[key] };
},
{ ...preDefinedOptions },
);
}
2 changes: 1 addition & 1 deletion packages/backend/src/util/shared.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
export { addClerkPrefix, getScriptUrl, getClerkJsMajorVersionOrTag } from '@clerk/shared/url';
export { callWithRetry } from '@clerk/shared/callWithRetry';
export { isDevelopmentFromApiKey, isProductionFromApiKey, parsePublishableKey } from '@clerk/shared/keys';
export { isDevelopmentFromSecretKey, isProductionFromSecretKey, parsePublishableKey } from '@clerk/shared/keys';
export { deprecated, deprecatedProperty } from '@clerk/shared/deprecated';

import { buildErrorThrower } from '@clerk/shared/error';
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions .changeset/red-worms-fetch.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
---
'@clerk/clerk-js': major
'@clerk/shared': major
'@clerk/clerk-sdk-node': minor
'@clerk/backend': minor
'@clerk/nextjs': minor
'@clerk/clerk-react': minor
'@clerk/clerk-expo': minor
---

Breaking Changes:

- Drop `isLegacyFrontendApiKey` from `@clerk/shared`
- Drop default exports from `@clerk/clerk-js`
- on headless Clerk type
- on ui and ui.retheme `Portal`
- Use `isProductionFromSecretKey` instead of `isProductionFromApiKey`
- Use `isDevelopmentFromSecretKey` instead of `isDevelopmentFromApiKey`

Changes:

- Rename `HeadlessBrowserClerkConstrutor` / `HeadlessBrowserClerkConstructor` (typo)
- Use `isomorphicAtob` / `isomorhpicBtoa` to replace `base-64` in `@clerk/expo`
- Refactor merging build-time and runtime props in `@clerk/backend` clerk client
- Drop `node-fetch` dependency from `@clerk/backend`
- Drop duplicate test in `@clerk/backend`
14 changes: 1 addition & 13 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/backend/src/tokens/authStatus.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -81,7 +81,7 @@ export type AuthReason = AuthErrorReason | TokenVerificationErrorReason;

export type RequestState = SignedInState | SignedOutState | InterstitialState | UnknownState;

export type LoadResourcesOptions = {
type LoadResourcesOptions = {
loadSession?: boolean;
loadUser?: boolean;
loadOrganization?: boolean;
Expand Down
96 changes: 96 additions & 0 deletions packages/backend/src/tokens/factory.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,96 @@
import type QUnit from 'qunit';

import type { ApiClient } from '../api';
import { createAuthenticateRequest } from './factory';

export default (QUnit: QUnit) => {
const { module, test } = QUnit;

module('createAuthenticateRequest({ options, apiClient })', hooks => {
let fakeAuthenticateRequest;
hooks.afterEach(() => {
fakeAuthenticateRequest?.restore();
});

test('fallbacks to build-time options', async assert => {
const buildTimeOptions = {
secretKey: 'sk',
jwtKey: 'jwtKey',
apiUrl: 'apiUrl',
apiVersion: 'apiVersion',
proxyUrl: 'proxyUrl',
publishableKey: 'pk',
isSatellite: false,
domain: 'domain',
audience: 'domain',
};

const { authenticateRequest } = createAuthenticateRequest({
options: buildTimeOptions,
apiClient: {} as ApiClient,
});

const requestState = await authenticateRequest({ request: new Request('http://example.com/') });
assert.propContains(requestState.toAuth()?.debug(), buildTimeOptions);
});

test('overrides build-time options with runtime options', async assert => {
const buildTimeOptions = {
secretKey: 'sk',
jwtKey: 'jwtKey',
apiUrl: 'apiUrl',
apiVersion: 'apiVersion',
proxyUrl: 'proxyUrl',
publishableKey: 'pk',
isSatellite: false,
domain: 'domain',
audience: 'domain',
};

const { authenticateRequest } = createAuthenticateRequest({
options: buildTimeOptions,
apiClient: {} as ApiClient,
});

const overrides = {
secretKey: 'r-sk',
publishableKey: 'r-pk',
};
const requestState = await authenticateRequest({
request: new Request('http://example.com/'),
...overrides,
});
assert.propContains(requestState.toAuth()?.debug(), {
...buildTimeOptions,
...overrides,
});
});

test('ignore runtime apiUrl and apiVersion options', async assert => {
const buildTimeOptions = {
secretKey: 'sk',
jwtKey: 'jwtKey',
apiUrl: 'apiUrl',
apiVersion: 'apiVersion',
proxyUrl: 'proxyUrl',
publishableKey: 'pk',
isSatellite: false,
domain: 'domain',
audience: 'domain',
};

const { authenticateRequest } = createAuthenticateRequest({
options: buildTimeOptions,
apiClient: {} as ApiClient,
});

const requestState = await authenticateRequest({
request: new Request('http://example.com/'),
// @ts-expect-error is used to check runtime code
apiUrl: 'r-apiUrl',
apiVersion: 'r-apiVersion',
});
assert.propContains(requestState.toAuth()?.debug(), buildTimeOptions);
});
});
};
101 changes: 43 additions & 58 deletions packages/backend/src/tokens/factory.ts
Original file line numberDiff line numberDiff line change
@@ -1,80 +1,65 @@
import type { ApiClient } from '../api';
import { API_URL, API_VERSION } from '../constants';
import { mergePreDefinedOptions } from '../util/mergePreDefinedOptions';
import type { LoadInterstitialOptions } from './interstitial';
import { loadInterstitialFromLocal } from './interstitial';
import type { AuthenticateRequestOptions } from './request';
import { authenticateRequest as authenticateRequestOriginal, debugRequestState } from './request';

type RunTimeOptions = Omit<AuthenticateRequestOptions, 'apiUrl' | 'apiVersion'>;

type BuildTimeOptions = Partial<
Pick<
AuthenticateRequestOptions,
| 'apiUrl'
| 'apiVersion'
| 'audience'
| 'domain'
| 'isSatellite'
| 'jwtKey'
| 'proxyUrl'
| 'publishableKey'
| 'secretKey'
>
>;

const defaultOptions = {
secretKey: '',
jwtKey: '',
apiUrl: undefined,
apiVersion: undefined,
proxyUrl: '',
publishableKey: '',
isSatellite: false,
domain: '',
audience: '',
} satisfies BuildTimeOptions;

export type CreateAuthenticateRequestOptions = {
options: Partial<
Pick<
AuthenticateRequestOptions,
| 'audience'
| 'secretKey'
| 'apiUrl'
| 'apiVersion'
| 'publishableKey'
| 'jwtKey'
| 'proxyUrl'
| 'domain'
| 'isSatellite'
>
>;
options: BuildTimeOptions;
apiClient: ApiClient;
};

export function createAuthenticateRequest(params: CreateAuthenticateRequestOptions) {
const { apiClient } = params;
const {
secretKey: buildtimeSecretKey = '',
jwtKey: buildtimeJwtKey = '',
apiUrl = API_URL,
apiVersion = API_VERSION,
proxyUrl: buildProxyUrl = '',
publishableKey: buildtimePublishableKey = '',
isSatellite: buildtimeIsSatellite = false,
domain: buildtimeDomain = '',
audience: buildtimeAudience = '',
} = params.options;
const buildTimeOptions = mergePreDefinedOptions(defaultOptions, params.options);

const authenticateRequest = ({
secretKey: runtimeSecretKey,
audience: runtimeAudience,
proxyUrl: runtimeProxyUrl,
publishableKey: runtimePublishableKey,
jwtKey: runtimeJwtKey,
isSatellite: runtimeIsSatellite,
domain: runtimeDomain,
...rest
}: Omit<AuthenticateRequestOptions, 'apiUrl' | 'apiVersion'>) => {
const authenticateRequest = (options: RunTimeOptions) => {
const { apiUrl, apiVersion } = buildTimeOptions;
const runTimeOptions = mergePreDefinedOptions(buildTimeOptions, options);
return authenticateRequestOriginal({
...rest,
secretKey: runtimeSecretKey || buildtimeSecretKey,
audience: runtimeAudience || buildtimeAudience,
...options,
...runTimeOptions,
// We should add all the omitted props from options here (eg apiUrl / apiVersion)
// to avoid runtime options override them.
apiUrl,
apiVersion,
proxyUrl: runtimeProxyUrl || buildProxyUrl,
publishableKey: runtimePublishableKey || buildtimePublishableKey,
isSatellite: runtimeIsSatellite || buildtimeIsSatellite,
domain: runtimeDomain || buildtimeDomain,
jwtKey: runtimeJwtKey || buildtimeJwtKey,
});
};

const localInterstitial = ({
publishableKey: runtimePublishableKey,
proxyUrl: runtimeProxyUrl,
isSatellite: runtimeIsSatellite,
domain: runtimeDomain,
...rest
}: Omit<LoadInterstitialOptions, 'apiUrl'>) =>
loadInterstitialFromLocal({
...rest,
proxyUrl: runtimeProxyUrl || buildProxyUrl,
publishableKey: runtimePublishableKey || buildtimePublishableKey,
isSatellite: runtimeIsSatellite || buildtimeIsSatellite,
domain: runtimeDomain || buildtimeDomain,
});
const localInterstitial = (options: Omit<LoadInterstitialOptions, 'apiUrl'>) => {
const runTimeOptions = mergePreDefinedOptions(buildTimeOptions, options);
return loadInterstitialFromLocal({ ...options, ...runTimeOptions });
};

// TODO: Replace this function with remotePublicInterstitial
const remotePrivateInterstitial = () => apiClient.interstitial.getInterstitial();
Expand Down
12 changes: 6 additions & 6 deletions packages/backend/src/tokens/interstitialRule.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { checkCrossOrigin } from '../util/request';
import { isDevelopmentFromApiKey, isProductionFromApiKey } from '../util/shared';
import { isDevelopmentFromSecretKey, isProductionFromSecretKey } from '../util/shared';
import type { AuthStatusOptionsType, RequestState } from './authStatus';
import { AuthErrorReason, interstitial, signedIn, signedOut } from './authStatus';
import { verifyToken } from './verify';
Expand DownExpand Up@@ -45,7 +45,7 @@ const isBrowser = (userAgent: string | undefined) => VALID_USER_AGENTS.test(user
// automatically treated as signed out. This exception is needed for development, because the any // missing uat throws an interstitial in development.
export const nonBrowserRequestInDevRule: InterstitialRule = options => {
const { secretKey, userAgent } = options;
if (isDevelopmentFromApiKey(secretKey || '') && !isBrowser(userAgent)) {
if (isDevelopmentFromSecretKey(secretKey || '') && !isBrowser(userAgent)) {
return signedOut(options, AuthErrorReason.HeaderMissingNonBrowser);
}
return undefined;
Expand All@@ -70,7 +70,7 @@ export const crossOriginRequestWithoutHeader: InterstitialRule = options => {

export const isPrimaryInDevAndRedirectsToSatellite: InterstitialRule = options => {
const { secretKey = '', isSatellite, searchParams } = options;
const isDev = isDevelopmentFromApiKey(secretKey);
const isDev = isDevelopmentFromSecretKey(secretKey);

if (isDev && !isSatellite && shouldRedirectToSatelliteUrl(searchParams)) {
return interstitial(options, AuthErrorReason.PrimaryRespondsToSyncing);
Expand All@@ -80,7 +80,7 @@ export const isPrimaryInDevAndRedirectsToSatellite: InterstitialRule = options =

export const potentialFirstLoadInDevWhenUATMissing: InterstitialRule = options => {
const { secretKey = '', clientUat } = options;
const res = isDevelopmentFromApiKey(secretKey);
const res = isDevelopmentFromSecretKey(secretKey);
if (res && !clientUat) {
return interstitial(options, AuthErrorReason.CookieUATMissing);
}
Expand All@@ -96,7 +96,7 @@ export const potentialRequestAfterSignInOrOutFromClerkHostedUiInDev: Interstitia
const crossOriginReferrer =
referrer && checkCrossOrigin({ originURL: new URL(referrer), host, forwardedHost, forwardedProto });

if (isDevelopmentFromApiKey(secretKey) && crossOriginReferrer) {
if (isDevelopmentFromSecretKey(secretKey) && crossOriginReferrer) {
return interstitial(options, AuthErrorReason.CrossOriginReferrer);
}
return undefined;
Expand All@@ -105,7 +105,7 @@ export const potentialRequestAfterSignInOrOutFromClerkHostedUiInDev: Interstitia
export const potentialFirstRequestOnProductionEnvironment: InterstitialRule = options => {
const { secretKey = '', clientUat, cookieToken } = options;

if (isProductionFromApiKey(secretKey) && !clientUat && !cookieToken) {
if (isProductionFromSecretKey(secretKey) && !clientUat && !cookieToken) {
return signedOut(options, AuthErrorReason.CookieAndUATMissing);
}
return undefined;
Expand Down
6 changes: 3 additions & 3 deletions packages/backend/src/tokens/request.ts
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
import { constants } from '../constants';
import { assertValidSecretKey } from '../util/assertValidSecretKey';
import { buildRequest, stripAuthorizationHeader } from '../util/IsomorphicRequest';
import { isDevelopmentFromApiKey } from '../util/shared';
import type { AuthStatusOptionsType, LoadResourcesOptions, RequestState } from './authStatus';
import { isDevelopmentFromSecretKey } from '../util/shared';
import type { AuthStatusOptionsType, RequestState } from './authStatus';
import { AuthErrorReason, interstitial, signedOut, unknownState } from './authStatus';
import type { TokenCarrier } from './errors';
import { TokenVerificationError, TokenVerificationErrorReason } from './errors';
Expand DownExpand Up@@ -32,7 +32,7 @@ export type OptionalVerifyTokenOptions = Partial<
export type AuthenticateRequestOptions = AuthStatusOptionsType & OptionalVerifyTokenOptions & { request: Request };

function assertSignInUrlExists(signInUrl: string | undefined, key: string): asserts signInUrl is string {
if (!signInUrl && isDevelopmentFromApiKey(key)) {
if (!signInUrl && isDevelopmentFromSecretKey(key)) {
throw new Error(`Missing signInUrl. Pass a signInUrl for dev instances if an app is satellite`);
}
}
Expand Down
8 changes: 8 additions & 0 deletions packages/backend/src/util/mergePreDefinedOptions.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
export function mergePreDefinedOptions<T extends Record<string, any>>(preDefinedOptions: T, options: Partial<T>): T {
return Object.keys(preDefinedOptions).reduce(
(obj: T, key: string) => {
return { ...obj, [key]: options[key] || obj[key] };
},
{ ...preDefinedOptions },
);
}
2 changes: 1 addition & 1 deletion packages/backend/src/util/shared.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
export { addClerkPrefix, getScriptUrl, getClerkJsMajorVersionOrTag } from '@clerk/shared/url';
export { callWithRetry } from '@clerk/shared/callWithRetry';
export { isDevelopmentFromApiKey, isProductionFromApiKey, parsePublishableKey } from '@clerk/shared/keys';
export { isDevelopmentFromSecretKey, isProductionFromSecretKey, parsePublishableKey } from '@clerk/shared/keys';
export { deprecated, deprecatedProperty } from '@clerk/shared/deprecated';

import { buildErrorThrower } from '@clerk/shared/error';
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions .changeset/red-worms-fetch.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
---
'@clerk/clerk-js': major
'@clerk/shared': major
'@clerk/clerk-sdk-node': minor
'@clerk/backend': minor
'@clerk/nextjs': minor
'@clerk/clerk-react': minor
'@clerk/clerk-expo': minor
---

Breaking Changes:

- Drop `isLegacyFrontendApiKey` from `@clerk/shared`
- Drop default exports from `@clerk/clerk-js`
- on headless Clerk type
- on ui and ui.retheme `Portal`
- Use `isProductionFromSecretKey` instead of `isProductionFromApiKey`
- Use `isDevelopmentFromSecretKey` instead of `isDevelopmentFromApiKey`

Changes:

- Rename `HeadlessBrowserClerkConstrutor` / `HeadlessBrowserClerkConstructor` (typo)
- Use `isomorphicAtob` / `isomorhpicBtoa` to replace `base-64` in `@clerk/expo`
- Refactor merging build-time and runtime props in `@clerk/backend` clerk client
- Drop `node-fetch` dependency from `@clerk/backend`
- Drop duplicate test in `@clerk/backend`
14 changes: 1 addition & 13 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/backend/src/tokens/authStatus.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -81,7 +81,7 @@ export type AuthReason = AuthErrorReason | TokenVerificationErrorReason;

export type RequestState = SignedInState | SignedOutState | InterstitialState | UnknownState;

export type LoadResourcesOptions = {
type LoadResourcesOptions = {
loadSession?: boolean;
loadUser?: boolean;
loadOrganization?: boolean;
Expand Down
96 changes: 96 additions & 0 deletions packages/backend/src/tokens/factory.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,96 @@
import type QUnit from 'qunit';

import type { ApiClient } from '../api';
import { createAuthenticateRequest } from './factory';

export default (QUnit: QUnit) => {
const { module, test } = QUnit;

module('createAuthenticateRequest({ options, apiClient })', hooks => {
let fakeAuthenticateRequest;
hooks.afterEach(() => {
fakeAuthenticateRequest?.restore();
});

test('fallbacks to build-time options', async assert => {
const buildTimeOptions = {
secretKey: 'sk',
jwtKey: 'jwtKey',
apiUrl: 'apiUrl',
apiVersion: 'apiVersion',
proxyUrl: 'proxyUrl',
publishableKey: 'pk',
isSatellite: false,
domain: 'domain',
audience: 'domain',
};

const { authenticateRequest } = createAuthenticateRequest({
options: buildTimeOptions,
apiClient: {} as ApiClient,
});

const requestState = await authenticateRequest({ request: new Request('http://example.com/') });
assert.propContains(requestState.toAuth()?.debug(), buildTimeOptions);
});

test('overrides build-time options with runtime options', async assert => {
const buildTimeOptions = {
secretKey: 'sk',
jwtKey: 'jwtKey',
apiUrl: 'apiUrl',
apiVersion: 'apiVersion',
proxyUrl: 'proxyUrl',
publishableKey: 'pk',
isSatellite: false,
domain: 'domain',
audience: 'domain',
};

const { authenticateRequest } = createAuthenticateRequest({
options: buildTimeOptions,
apiClient: {} as ApiClient,
});

const overrides = {
secretKey: 'r-sk',
publishableKey: 'r-pk',
};
const requestState = await authenticateRequest({
request: new Request('http://example.com/'),
...overrides,
});
assert.propContains(requestState.toAuth()?.debug(), {
...buildTimeOptions,
...overrides,
});
});

test('ignore runtime apiUrl and apiVersion options', async assert => {
const buildTimeOptions = {
secretKey: 'sk',
jwtKey: 'jwtKey',
apiUrl: 'apiUrl',
apiVersion: 'apiVersion',
proxyUrl: 'proxyUrl',
publishableKey: 'pk',
isSatellite: false,
domain: 'domain',
audience: 'domain',
};

const { authenticateRequest } = createAuthenticateRequest({
options: buildTimeOptions,
apiClient: {} as ApiClient,
});

const requestState = await authenticateRequest({
request: new Request('http://example.com/'),
// @ts-expect-error is used to check runtime code
apiUrl: 'r-apiUrl',
apiVersion: 'r-apiVersion',
});
assert.propContains(requestState.toAuth()?.debug(), buildTimeOptions);
});
});
};
101 changes: 43 additions & 58 deletions packages/backend/src/tokens/factory.ts
Original file line numberDiff line numberDiff line change
@@ -1,80 +1,65 @@
import type { ApiClient } from '../api';
import { API_URL, API_VERSION } from '../constants';
import { mergePreDefinedOptions } from '../util/mergePreDefinedOptions';
import type { LoadInterstitialOptions } from './interstitial';
import { loadInterstitialFromLocal } from './interstitial';
import type { AuthenticateRequestOptions } from './request';
import { authenticateRequest as authenticateRequestOriginal, debugRequestState } from './request';

type RunTimeOptions = Omit<AuthenticateRequestOptions, 'apiUrl' | 'apiVersion'>;

type BuildTimeOptions = Partial<
Pick<
AuthenticateRequestOptions,
| 'apiUrl'
| 'apiVersion'
| 'audience'
| 'domain'
| 'isSatellite'
| 'jwtKey'
| 'proxyUrl'
| 'publishableKey'
| 'secretKey'
>
>;

const defaultOptions = {
secretKey: '',
jwtKey: '',
apiUrl: undefined,
apiVersion: undefined,
proxyUrl: '',
publishableKey: '',
isSatellite: false,
domain: '',
audience: '',
} satisfies BuildTimeOptions;

export type CreateAuthenticateRequestOptions = {
options: Partial<
Pick<
AuthenticateRequestOptions,
| 'audience'
| 'secretKey'
| 'apiUrl'
| 'apiVersion'
| 'publishableKey'
| 'jwtKey'
| 'proxyUrl'
| 'domain'
| 'isSatellite'
>
>;
options: BuildTimeOptions;
apiClient: ApiClient;
};

export function createAuthenticateRequest(params: CreateAuthenticateRequestOptions) {
const { apiClient } = params;
const {
secretKey: buildtimeSecretKey = '',
jwtKey: buildtimeJwtKey = '',
apiUrl = API_URL,
apiVersion = API_VERSION,
proxyUrl: buildProxyUrl = '',
publishableKey: buildtimePublishableKey = '',
isSatellite: buildtimeIsSatellite = false,
domain: buildtimeDomain = '',
audience: buildtimeAudience = '',
} = params.options;
const buildTimeOptions = mergePreDefinedOptions(defaultOptions, params.options);

const authenticateRequest = ({
secretKey: runtimeSecretKey,
audience: runtimeAudience,
proxyUrl: runtimeProxyUrl,
publishableKey: runtimePublishableKey,
jwtKey: runtimeJwtKey,
isSatellite: runtimeIsSatellite,
domain: runtimeDomain,
...rest
}: Omit<AuthenticateRequestOptions, 'apiUrl' | 'apiVersion'>) => {
const authenticateRequest = (options: RunTimeOptions) => {
const { apiUrl, apiVersion } = buildTimeOptions;
const runTimeOptions = mergePreDefinedOptions(buildTimeOptions, options);
return authenticateRequestOriginal({
...rest,
secretKey: runtimeSecretKey || buildtimeSecretKey,
audience: runtimeAudience || buildtimeAudience,
...options,
...runTimeOptions,
// We should add all the omitted props from options here (eg apiUrl / apiVersion)
// to avoid runtime options override them.
apiUrl,
apiVersion,
proxyUrl: runtimeProxyUrl || buildProxyUrl,
publishableKey: runtimePublishableKey || buildtimePublishableKey,
isSatellite: runtimeIsSatellite || buildtimeIsSatellite,
domain: runtimeDomain || buildtimeDomain,
jwtKey: runtimeJwtKey || buildtimeJwtKey,
});
};

const localInterstitial = ({
publishableKey: runtimePublishableKey,
proxyUrl: runtimeProxyUrl,
isSatellite: runtimeIsSatellite,
domain: runtimeDomain,
...rest
}: Omit<LoadInterstitialOptions, 'apiUrl'>) =>
loadInterstitialFromLocal({
...rest,
proxyUrl: runtimeProxyUrl || buildProxyUrl,
publishableKey: runtimePublishableKey || buildtimePublishableKey,
isSatellite: runtimeIsSatellite || buildtimeIsSatellite,
domain: runtimeDomain || buildtimeDomain,
});
const localInterstitial = (options: Omit<LoadInterstitialOptions, 'apiUrl'>) => {
const runTimeOptions = mergePreDefinedOptions(buildTimeOptions, options);
return loadInterstitialFromLocal({ ...options, ...runTimeOptions });
};

// TODO: Replace this function with remotePublicInterstitial
const remotePrivateInterstitial = () => apiClient.interstitial.getInterstitial();
Expand Down
12 changes: 6 additions & 6 deletions packages/backend/src/tokens/interstitialRule.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { checkCrossOrigin } from '../util/request';
import { isDevelopmentFromApiKey, isProductionFromApiKey } from '../util/shared';
import { isDevelopmentFromSecretKey, isProductionFromSecretKey } from '../util/shared';
import type { AuthStatusOptionsType, RequestState } from './authStatus';
import { AuthErrorReason, interstitial, signedIn, signedOut } from './authStatus';
import { verifyToken } from './verify';
Expand DownExpand Up@@ -45,7 +45,7 @@ const isBrowser = (userAgent: string | undefined) => VALID_USER_AGENTS.test(user
// automatically treated as signed out. This exception is needed for development, because the any // missing uat throws an interstitial in development.
export const nonBrowserRequestInDevRule: InterstitialRule = options => {
const { secretKey, userAgent } = options;
if (isDevelopmentFromApiKey(secretKey || '') && !isBrowser(userAgent)) {
if (isDevelopmentFromSecretKey(secretKey || '') && !isBrowser(userAgent)) {
return signedOut(options, AuthErrorReason.HeaderMissingNonBrowser);
}
return undefined;
Expand All@@ -70,7 +70,7 @@ export const crossOriginRequestWithoutHeader: InterstitialRule = options => {

export const isPrimaryInDevAndRedirectsToSatellite: InterstitialRule = options => {
const { secretKey = '', isSatellite, searchParams } = options;
const isDev = isDevelopmentFromApiKey(secretKey);
const isDev = isDevelopmentFromSecretKey(secretKey);

if (isDev && !isSatellite && shouldRedirectToSatelliteUrl(searchParams)) {
return interstitial(options, AuthErrorReason.PrimaryRespondsToSyncing);
Expand All@@ -80,7 +80,7 @@ export const isPrimaryInDevAndRedirectsToSatellite: InterstitialRule = options =

export const potentialFirstLoadInDevWhenUATMissing: InterstitialRule = options => {
const { secretKey = '', clientUat } = options;
const res = isDevelopmentFromApiKey(secretKey);
const res = isDevelopmentFromSecretKey(secretKey);
if (res && !clientUat) {
return interstitial(options, AuthErrorReason.CookieUATMissing);
}
Expand All@@ -96,7 +96,7 @@ export const potentialRequestAfterSignInOrOutFromClerkHostedUiInDev: Interstitia
const crossOriginReferrer =
referrer && checkCrossOrigin({ originURL: new URL(referrer), host, forwardedHost, forwardedProto });

if (isDevelopmentFromApiKey(secretKey) && crossOriginReferrer) {
if (isDevelopmentFromSecretKey(secretKey) && crossOriginReferrer) {
return interstitial(options, AuthErrorReason.CrossOriginReferrer);
}
return undefined;
Expand All@@ -105,7 +105,7 @@ export const potentialRequestAfterSignInOrOutFromClerkHostedUiInDev: Interstitia
export const potentialFirstRequestOnProductionEnvironment: InterstitialRule = options => {
const { secretKey = '', clientUat, cookieToken } = options;

if (isProductionFromApiKey(secretKey) && !clientUat && !cookieToken) {
if (isProductionFromSecretKey(secretKey) && !clientUat && !cookieToken) {
return signedOut(options, AuthErrorReason.CookieAndUATMissing);
}
return undefined;
Expand Down
6 changes: 3 additions & 3 deletions packages/backend/src/tokens/request.ts
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
import { constants } from '../constants';
import { assertValidSecretKey } from '../util/assertValidSecretKey';
import { buildRequest, stripAuthorizationHeader } from '../util/IsomorphicRequest';
import { isDevelopmentFromApiKey } from '../util/shared';
import type { AuthStatusOptionsType, LoadResourcesOptions, RequestState } from './authStatus';
import { isDevelopmentFromSecretKey } from '../util/shared';
import type { AuthStatusOptionsType, RequestState } from './authStatus';
import { AuthErrorReason, interstitial, signedOut, unknownState } from './authStatus';
import type { TokenCarrier } from './errors';
import { TokenVerificationError, TokenVerificationErrorReason } from './errors';
Expand DownExpand Up@@ -32,7 +32,7 @@ export type OptionalVerifyTokenOptions = Partial<
export type AuthenticateRequestOptions = AuthStatusOptionsType & OptionalVerifyTokenOptions & { request: Request };

function assertSignInUrlExists(signInUrl: string | undefined, key: string): asserts signInUrl is string {
if (!signInUrl && isDevelopmentFromApiKey(key)) {
if (!signInUrl && isDevelopmentFromSecretKey(key)) {
throw new Error(`Missing signInUrl. Pass a signInUrl for dev instances if an app is satellite`);
}
}
Expand Down
8 changes: 8 additions & 0 deletions packages/backend/src/util/mergePreDefinedOptions.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
export function mergePreDefinedOptions<T extends Record<string, any>>(preDefinedOptions: T, options: Partial<T>): T {
return Object.keys(preDefinedOptions).reduce(
(obj: T, key: string) => {
return { ...obj, [key]: options[key] || obj[key] };
},
{ ...preDefinedOptions },
);
}
2 changes: 1 addition & 1 deletion packages/backend/src/util/shared.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
export { addClerkPrefix, getScriptUrl, getClerkJsMajorVersionOrTag } from '@clerk/shared/url';
export { callWithRetry } from '@clerk/shared/callWithRetry';
export { isDevelopmentFromApiKey, isProductionFromApiKey, parsePublishableKey } from '@clerk/shared/keys';
export { isDevelopmentFromSecretKey, isProductionFromSecretKey, parsePublishableKey } from '@clerk/shared/keys';
export { deprecated, deprecatedProperty } from '@clerk/shared/deprecated';

import { buildErrorThrower } from '@clerk/shared/error';
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions .changeset/red-worms-fetch.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
---
'@clerk/clerk-js': major
'@clerk/shared': major
'@clerk/clerk-sdk-node': minor
'@clerk/backend': minor
'@clerk/nextjs': minor
'@clerk/clerk-react': minor
'@clerk/clerk-expo': minor
---

Breaking Changes:

- Drop `isLegacyFrontendApiKey` from `@clerk/shared`
- Drop default exports from `@clerk/clerk-js`
- on headless Clerk type
- on ui and ui.retheme `Portal`
- Use `isProductionFromSecretKey` instead of `isProductionFromApiKey`
- Use `isDevelopmentFromSecretKey` instead of `isDevelopmentFromApiKey`

Changes:

- Rename `HeadlessBrowserClerkConstrutor` / `HeadlessBrowserClerkConstructor` (typo)
- Use `isomorphicAtob` / `isomorhpicBtoa` to replace `base-64` in `@clerk/expo`
- Refactor merging build-time and runtime props in `@clerk/backend` clerk client
- Drop `node-fetch` dependency from `@clerk/backend`
- Drop duplicate test in `@clerk/backend`
14 changes: 1 addition & 13 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/backend/src/tokens/authStatus.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -81,7 +81,7 @@ export type AuthReason = AuthErrorReason | TokenVerificationErrorReason;

export type RequestState = SignedInState | SignedOutState | InterstitialState | UnknownState;

export type LoadResourcesOptions = {
type LoadResourcesOptions = {
loadSession?: boolean;
loadUser?: boolean;
loadOrganization?: boolean;
Expand Down
96 changes: 96 additions & 0 deletions packages/backend/src/tokens/factory.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,96 @@
import type QUnit from 'qunit';

import type { ApiClient } from '../api';
import { createAuthenticateRequest } from './factory';

export default (QUnit: QUnit) => {
const { module, test } = QUnit;

module('createAuthenticateRequest({ options, apiClient })', hooks => {
let fakeAuthenticateRequest;
hooks.afterEach(() => {
fakeAuthenticateRequest?.restore();
});

test('fallbacks to build-time options', async assert => {
const buildTimeOptions = {
secretKey: 'sk',
jwtKey: 'jwtKey',
apiUrl: 'apiUrl',
apiVersion: 'apiVersion',
proxyUrl: 'proxyUrl',
publishableKey: 'pk',
isSatellite: false,
domain: 'domain',
audience: 'domain',
};

const { authenticateRequest } = createAuthenticateRequest({
options: buildTimeOptions,
apiClient: {} as ApiClient,
});

const requestState = await authenticateRequest({ request: new Request('http://example.com/') });
assert.propContains(requestState.toAuth()?.debug(), buildTimeOptions);
});

test('overrides build-time options with runtime options', async assert => {
const buildTimeOptions = {
secretKey: 'sk',
jwtKey: 'jwtKey',
apiUrl: 'apiUrl',
apiVersion: 'apiVersion',
proxyUrl: 'proxyUrl',
publishableKey: 'pk',
isSatellite: false,
domain: 'domain',
audience: 'domain',
};

const { authenticateRequest } = createAuthenticateRequest({
options: buildTimeOptions,
apiClient: {} as ApiClient,
});

const overrides = {
secretKey: 'r-sk',
publishableKey: 'r-pk',
};
const requestState = await authenticateRequest({
request: new Request('http://example.com/'),
...overrides,
});
assert.propContains(requestState.toAuth()?.debug(), {
...buildTimeOptions,
...overrides,
});
});

test('ignore runtime apiUrl and apiVersion options', async assert => {
const buildTimeOptions = {
secretKey: 'sk',
jwtKey: 'jwtKey',
apiUrl: 'apiUrl',
apiVersion: 'apiVersion',
proxyUrl: 'proxyUrl',
publishableKey: 'pk',
isSatellite: false,
domain: 'domain',
audience: 'domain',
};

const { authenticateRequest } = createAuthenticateRequest({
options: buildTimeOptions,
apiClient: {} as ApiClient,
});

const requestState = await authenticateRequest({
request: new Request('http://example.com/'),
// @ts-expect-error is used to check runtime code
apiUrl: 'r-apiUrl',
apiVersion: 'r-apiVersion',
});
assert.propContains(requestState.toAuth()?.debug(), buildTimeOptions);
});
});
};
101 changes: 43 additions & 58 deletions packages/backend/src/tokens/factory.ts
Original file line numberDiff line numberDiff line change
@@ -1,80 +1,65 @@
import type { ApiClient } from '../api';
import { API_URL, API_VERSION } from '../constants';
import { mergePreDefinedOptions } from '../util/mergePreDefinedOptions';
import type { LoadInterstitialOptions } from './interstitial';
import { loadInterstitialFromLocal } from './interstitial';
import type { AuthenticateRequestOptions } from './request';
import { authenticateRequest as authenticateRequestOriginal, debugRequestState } from './request';

type RunTimeOptions = Omit<AuthenticateRequestOptions, 'apiUrl' | 'apiVersion'>;

type BuildTimeOptions = Partial<
Pick<
AuthenticateRequestOptions,
| 'apiUrl'
| 'apiVersion'
| 'audience'
| 'domain'
| 'isSatellite'
| 'jwtKey'
| 'proxyUrl'
| 'publishableKey'
| 'secretKey'
>
>;

const defaultOptions = {
secretKey: '',
jwtKey: '',
apiUrl: undefined,
apiVersion: undefined,
proxyUrl: '',
publishableKey: '',
isSatellite: false,
domain: '',
audience: '',
} satisfies BuildTimeOptions;

export type CreateAuthenticateRequestOptions = {
options: Partial<
Pick<
AuthenticateRequestOptions,
| 'audience'
| 'secretKey'
| 'apiUrl'
| 'apiVersion'
| 'publishableKey'
| 'jwtKey'
| 'proxyUrl'
| 'domain'
| 'isSatellite'
>
>;
options: BuildTimeOptions;
apiClient: ApiClient;
};

export function createAuthenticateRequest(params: CreateAuthenticateRequestOptions) {
const { apiClient } = params;
const {
secretKey: buildtimeSecretKey = '',
jwtKey: buildtimeJwtKey = '',
apiUrl = API_URL,
apiVersion = API_VERSION,
proxyUrl: buildProxyUrl = '',
publishableKey: buildtimePublishableKey = '',
isSatellite: buildtimeIsSatellite = false,
domain: buildtimeDomain = '',
audience: buildtimeAudience = '',
} = params.options;
const buildTimeOptions = mergePreDefinedOptions(defaultOptions, params.options);

const authenticateRequest = ({
secretKey: runtimeSecretKey,
audience: runtimeAudience,
proxyUrl: runtimeProxyUrl,
publishableKey: runtimePublishableKey,
jwtKey: runtimeJwtKey,
isSatellite: runtimeIsSatellite,
domain: runtimeDomain,
...rest
}: Omit<AuthenticateRequestOptions, 'apiUrl' | 'apiVersion'>) => {
const authenticateRequest = (options: RunTimeOptions) => {
const { apiUrl, apiVersion } = buildTimeOptions;
const runTimeOptions = mergePreDefinedOptions(buildTimeOptions, options);
return authenticateRequestOriginal({
...rest,
secretKey: runtimeSecretKey || buildtimeSecretKey,
audience: runtimeAudience || buildtimeAudience,
...options,
...runTimeOptions,
// We should add all the omitted props from options here (eg apiUrl / apiVersion)
// to avoid runtime options override them.
apiUrl,
apiVersion,
proxyUrl: runtimeProxyUrl || buildProxyUrl,
publishableKey: runtimePublishableKey || buildtimePublishableKey,
isSatellite: runtimeIsSatellite || buildtimeIsSatellite,
domain: runtimeDomain || buildtimeDomain,
jwtKey: runtimeJwtKey || buildtimeJwtKey,
});
};

const localInterstitial = ({
publishableKey: runtimePublishableKey,
proxyUrl: runtimeProxyUrl,
isSatellite: runtimeIsSatellite,
domain: runtimeDomain,
...rest
}: Omit<LoadInterstitialOptions, 'apiUrl'>) =>
loadInterstitialFromLocal({
...rest,
proxyUrl: runtimeProxyUrl || buildProxyUrl,
publishableKey: runtimePublishableKey || buildtimePublishableKey,
isSatellite: runtimeIsSatellite || buildtimeIsSatellite,
domain: runtimeDomain || buildtimeDomain,
});
const localInterstitial = (options: Omit<LoadInterstitialOptions, 'apiUrl'>) => {
const runTimeOptions = mergePreDefinedOptions(buildTimeOptions, options);
return loadInterstitialFromLocal({ ...options, ...runTimeOptions });
};

// TODO: Replace this function with remotePublicInterstitial
const remotePrivateInterstitial = () => apiClient.interstitial.getInterstitial();
Expand Down
12 changes: 6 additions & 6 deletions packages/backend/src/tokens/interstitialRule.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { checkCrossOrigin } from '../util/request';
import { isDevelopmentFromApiKey, isProductionFromApiKey } from '../util/shared';
import { isDevelopmentFromSecretKey, isProductionFromSecretKey } from '../util/shared';
import type { AuthStatusOptionsType, RequestState } from './authStatus';
import { AuthErrorReason, interstitial, signedIn, signedOut } from './authStatus';
import { verifyToken } from './verify';
Expand DownExpand Up@@ -45,7 +45,7 @@ const isBrowser = (userAgent: string | undefined) => VALID_USER_AGENTS.test(user
// automatically treated as signed out. This exception is needed for development, because the any // missing uat throws an interstitial in development.
export const nonBrowserRequestInDevRule: InterstitialRule = options => {
const { secretKey, userAgent } = options;
if (isDevelopmentFromApiKey(secretKey || '') && !isBrowser(userAgent)) {
if (isDevelopmentFromSecretKey(secretKey || '') && !isBrowser(userAgent)) {
return signedOut(options, AuthErrorReason.HeaderMissingNonBrowser);
}
return undefined;
Expand All@@ -70,7 +70,7 @@ export const crossOriginRequestWithoutHeader: InterstitialRule = options => {

export const isPrimaryInDevAndRedirectsToSatellite: InterstitialRule = options => {
const { secretKey = '', isSatellite, searchParams } = options;
const isDev = isDevelopmentFromApiKey(secretKey);
const isDev = isDevelopmentFromSecretKey(secretKey);

if (isDev && !isSatellite && shouldRedirectToSatelliteUrl(searchParams)) {
return interstitial(options, AuthErrorReason.PrimaryRespondsToSyncing);
Expand All@@ -80,7 +80,7 @@ export const isPrimaryInDevAndRedirectsToSatellite: InterstitialRule = options =

export const potentialFirstLoadInDevWhenUATMissing: InterstitialRule = options => {
const { secretKey = '', clientUat } = options;
const res = isDevelopmentFromApiKey(secretKey);
const res = isDevelopmentFromSecretKey(secretKey);
if (res && !clientUat) {
return interstitial(options, AuthErrorReason.CookieUATMissing);
}
Expand All@@ -96,7 +96,7 @@ export const potentialRequestAfterSignInOrOutFromClerkHostedUiInDev: Interstitia
const crossOriginReferrer =
referrer && checkCrossOrigin({ originURL: new URL(referrer), host, forwardedHost, forwardedProto });

if (isDevelopmentFromApiKey(secretKey) && crossOriginReferrer) {
if (isDevelopmentFromSecretKey(secretKey) && crossOriginReferrer) {
return interstitial(options, AuthErrorReason.CrossOriginReferrer);
}
return undefined;
Expand All@@ -105,7 +105,7 @@ export const potentialRequestAfterSignInOrOutFromClerkHostedUiInDev: Interstitia
export const potentialFirstRequestOnProductionEnvironment: InterstitialRule = options => {
const { secretKey = '', clientUat, cookieToken } = options;

if (isProductionFromApiKey(secretKey) && !clientUat && !cookieToken) {
if (isProductionFromSecretKey(secretKey) && !clientUat && !cookieToken) {
return signedOut(options, AuthErrorReason.CookieAndUATMissing);
}
return undefined;
Expand Down
6 changes: 3 additions & 3 deletions packages/backend/src/tokens/request.ts
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
import { constants } from '../constants';
import { assertValidSecretKey } from '../util/assertValidSecretKey';
import { buildRequest, stripAuthorizationHeader } from '../util/IsomorphicRequest';
import { isDevelopmentFromApiKey } from '../util/shared';
import type { AuthStatusOptionsType, LoadResourcesOptions, RequestState } from './authStatus';
import { isDevelopmentFromSecretKey } from '../util/shared';
import type { AuthStatusOptionsType, RequestState } from './authStatus';
import { AuthErrorReason, interstitial, signedOut, unknownState } from './authStatus';
import type { TokenCarrier } from './errors';
import { TokenVerificationError, TokenVerificationErrorReason } from './errors';
Expand DownExpand Up@@ -32,7 +32,7 @@ export type OptionalVerifyTokenOptions = Partial<
export type AuthenticateRequestOptions = AuthStatusOptionsType & OptionalVerifyTokenOptions & { request: Request };

function assertSignInUrlExists(signInUrl: string | undefined, key: string): asserts signInUrl is string {
if (!signInUrl && isDevelopmentFromApiKey(key)) {
if (!signInUrl && isDevelopmentFromSecretKey(key)) {
throw new Error(`Missing signInUrl. Pass a signInUrl for dev instances if an app is satellite`);
}
}
Expand Down
8 changes: 8 additions & 0 deletions packages/backend/src/util/mergePreDefinedOptions.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
export function mergePreDefinedOptions<T extends Record<string, any>>(preDefinedOptions: T, options: Partial<T>): T {
return Object.keys(preDefinedOptions).reduce(
(obj: T, key: string) => {
return { ...obj, [key]: options[key] || obj[key] };
},
{ ...preDefinedOptions },
);
}
2 changes: 1 addition & 1 deletion packages/backend/src/util/shared.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
export { addClerkPrefix, getScriptUrl, getClerkJsMajorVersionOrTag } from '@clerk/shared/url';
export { callWithRetry } from '@clerk/shared/callWithRetry';
export { isDevelopmentFromApiKey, isProductionFromApiKey, parsePublishableKey } from '@clerk/shared/keys';
export { isDevelopmentFromSecretKey, isProductionFromSecretKey, parsePublishableKey } from '@clerk/shared/keys';
export { deprecated, deprecatedProperty } from '@clerk/shared/deprecated';

import { buildErrorThrower } from '@clerk/shared/error';
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions .changeset/red-worms-fetch.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
---
'@clerk/clerk-js': major
'@clerk/shared': major
'@clerk/clerk-sdk-node': minor
'@clerk/backend': minor
'@clerk/nextjs': minor
'@clerk/clerk-react': minor
'@clerk/clerk-expo': minor
---

Breaking Changes:

- Drop `isLegacyFrontendApiKey` from `@clerk/shared`
- Drop default exports from `@clerk/clerk-js`
- on headless Clerk type
- on ui and ui.retheme `Portal`
- Use `isProductionFromSecretKey` instead of `isProductionFromApiKey`
- Use `isDevelopmentFromSecretKey` instead of `isDevelopmentFromApiKey`

Changes:

- Rename `HeadlessBrowserClerkConstrutor` / `HeadlessBrowserClerkConstructor` (typo)
- Use `isomorphicAtob` / `isomorhpicBtoa` to replace `base-64` in `@clerk/expo`
- Refactor merging build-time and runtime props in `@clerk/backend` clerk client
- Drop `node-fetch` dependency from `@clerk/backend`
- Drop duplicate test in `@clerk/backend`
14 changes: 1 addition & 13 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/backend/src/tokens/authStatus.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -81,7 +81,7 @@ export type AuthReason = AuthErrorReason | TokenVerificationErrorReason;

export type RequestState = SignedInState | SignedOutState | InterstitialState | UnknownState;

export type LoadResourcesOptions = {
type LoadResourcesOptions = {
loadSession?: boolean;
loadUser?: boolean;
loadOrganization?: boolean;
Expand Down
96 changes: 96 additions & 0 deletions packages/backend/src/tokens/factory.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,96 @@
import type QUnit from 'qunit';

import type { ApiClient } from '../api';
import { createAuthenticateRequest } from './factory';

export default (QUnit: QUnit) => {
const { module, test } = QUnit;

module('createAuthenticateRequest({ options, apiClient })', hooks => {
let fakeAuthenticateRequest;
hooks.afterEach(() => {
fakeAuthenticateRequest?.restore();
});

test('fallbacks to build-time options', async assert => {
const buildTimeOptions = {
secretKey: 'sk',
jwtKey: 'jwtKey',
apiUrl: 'apiUrl',
apiVersion: 'apiVersion',
proxyUrl: 'proxyUrl',
publishableKey: 'pk',
isSatellite: false,
domain: 'domain',
audience: 'domain',
};

const { authenticateRequest } = createAuthenticateRequest({
options: buildTimeOptions,
apiClient: {} as ApiClient,
});

const requestState = await authenticateRequest({ request: new Request('http://example.com/') });
assert.propContains(requestState.toAuth()?.debug(), buildTimeOptions);
});

test('overrides build-time options with runtime options', async assert => {
const buildTimeOptions = {
secretKey: 'sk',
jwtKey: 'jwtKey',
apiUrl: 'apiUrl',
apiVersion: 'apiVersion',
proxyUrl: 'proxyUrl',
publishableKey: 'pk',
isSatellite: false,
domain: 'domain',
audience: 'domain',
};

const { authenticateRequest } = createAuthenticateRequest({
options: buildTimeOptions,
apiClient: {} as ApiClient,
});

const overrides = {
secretKey: 'r-sk',
publishableKey: 'r-pk',
};
const requestState = await authenticateRequest({
request: new Request('http://example.com/'),
...overrides,
});
assert.propContains(requestState.toAuth()?.debug(), {
...buildTimeOptions,
...overrides,
});
});

test('ignore runtime apiUrl and apiVersion options', async assert => {
const buildTimeOptions = {
secretKey: 'sk',
jwtKey: 'jwtKey',
apiUrl: 'apiUrl',
apiVersion: 'apiVersion',
proxyUrl: 'proxyUrl',
publishableKey: 'pk',
isSatellite: false,
domain: 'domain',
audience: 'domain',
};

const { authenticateRequest } = createAuthenticateRequest({
options: buildTimeOptions,
apiClient: {} as ApiClient,
});

const requestState = await authenticateRequest({
request: new Request('http://example.com/'),
// @ts-expect-error is used to check runtime code
apiUrl: 'r-apiUrl',
apiVersion: 'r-apiVersion',
});
assert.propContains(requestState.toAuth()?.debug(), buildTimeOptions);
});
});
};
101 changes: 43 additions & 58 deletions packages/backend/src/tokens/factory.ts
Original file line numberDiff line numberDiff line change
@@ -1,80 +1,65 @@
import type { ApiClient } from '../api';
import { API_URL, API_VERSION } from '../constants';
import { mergePreDefinedOptions } from '../util/mergePreDefinedOptions';
import type { LoadInterstitialOptions } from './interstitial';
import { loadInterstitialFromLocal } from './interstitial';
import type { AuthenticateRequestOptions } from './request';
import { authenticateRequest as authenticateRequestOriginal, debugRequestState } from './request';

type RunTimeOptions = Omit<AuthenticateRequestOptions, 'apiUrl' | 'apiVersion'>;

type BuildTimeOptions = Partial<
Pick<
AuthenticateRequestOptions,
| 'apiUrl'
| 'apiVersion'
| 'audience'
| 'domain'
| 'isSatellite'
| 'jwtKey'
| 'proxyUrl'
| 'publishableKey'
| 'secretKey'
>
>;

const defaultOptions = {
secretKey: '',
jwtKey: '',
apiUrl: undefined,
apiVersion: undefined,
proxyUrl: '',
publishableKey: '',
isSatellite: false,
domain: '',
audience: '',
} satisfies BuildTimeOptions;

export type CreateAuthenticateRequestOptions = {
options: Partial<
Pick<
AuthenticateRequestOptions,
| 'audience'
| 'secretKey'
| 'apiUrl'
| 'apiVersion'
| 'publishableKey'
| 'jwtKey'
| 'proxyUrl'
| 'domain'
| 'isSatellite'
>
>;
options: BuildTimeOptions;
apiClient: ApiClient;
};

export function createAuthenticateRequest(params: CreateAuthenticateRequestOptions) {
const { apiClient } = params;
const {
secretKey: buildtimeSecretKey = '',
jwtKey: buildtimeJwtKey = '',
apiUrl = API_URL,
apiVersion = API_VERSION,
proxyUrl: buildProxyUrl = '',
publishableKey: buildtimePublishableKey = '',
isSatellite: buildtimeIsSatellite = false,
domain: buildtimeDomain = '',
audience: buildtimeAudience = '',
} = params.options;
const buildTimeOptions = mergePreDefinedOptions(defaultOptions, params.options);

const authenticateRequest = ({
secretKey: runtimeSecretKey,
audience: runtimeAudience,
proxyUrl: runtimeProxyUrl,
publishableKey: runtimePublishableKey,
jwtKey: runtimeJwtKey,
isSatellite: runtimeIsSatellite,
domain: runtimeDomain,
...rest
}: Omit<AuthenticateRequestOptions, 'apiUrl' | 'apiVersion'>) => {
const authenticateRequest = (options: RunTimeOptions) => {
const { apiUrl, apiVersion } = buildTimeOptions;
const runTimeOptions = mergePreDefinedOptions(buildTimeOptions, options);
return authenticateRequestOriginal({
...rest,
secretKey: runtimeSecretKey || buildtimeSecretKey,
audience: runtimeAudience || buildtimeAudience,
...options,
...runTimeOptions,
// We should add all the omitted props from options here (eg apiUrl / apiVersion)
// to avoid runtime options override them.
apiUrl,
apiVersion,
proxyUrl: runtimeProxyUrl || buildProxyUrl,
publishableKey: runtimePublishableKey || buildtimePublishableKey,
isSatellite: runtimeIsSatellite || buildtimeIsSatellite,
domain: runtimeDomain || buildtimeDomain,
jwtKey: runtimeJwtKey || buildtimeJwtKey,
});
};

const localInterstitial = ({
publishableKey: runtimePublishableKey,
proxyUrl: runtimeProxyUrl,
isSatellite: runtimeIsSatellite,
domain: runtimeDomain,
...rest
}: Omit<LoadInterstitialOptions, 'apiUrl'>) =>
loadInterstitialFromLocal({
...rest,
proxyUrl: runtimeProxyUrl || buildProxyUrl,
publishableKey: runtimePublishableKey || buildtimePublishableKey,
isSatellite: runtimeIsSatellite || buildtimeIsSatellite,
domain: runtimeDomain || buildtimeDomain,
});
const localInterstitial = (options: Omit<LoadInterstitialOptions, 'apiUrl'>) => {
const runTimeOptions = mergePreDefinedOptions(buildTimeOptions, options);
return loadInterstitialFromLocal({ ...options, ...runTimeOptions });
};

// TODO: Replace this function with remotePublicInterstitial
const remotePrivateInterstitial = () => apiClient.interstitial.getInterstitial();
Expand Down
12 changes: 6 additions & 6 deletions packages/backend/src/tokens/interstitialRule.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { checkCrossOrigin } from '../util/request';
import { isDevelopmentFromApiKey, isProductionFromApiKey } from '../util/shared';
import { isDevelopmentFromSecretKey, isProductionFromSecretKey } from '../util/shared';
import type { AuthStatusOptionsType, RequestState } from './authStatus';
import { AuthErrorReason, interstitial, signedIn, signedOut } from './authStatus';
import { verifyToken } from './verify';
Expand DownExpand Up@@ -45,7 +45,7 @@ const isBrowser = (userAgent: string | undefined) => VALID_USER_AGENTS.test(user
// automatically treated as signed out. This exception is needed for development, because the any // missing uat throws an interstitial in development.
export const nonBrowserRequestInDevRule: InterstitialRule = options => {
const { secretKey, userAgent } = options;
if (isDevelopmentFromApiKey(secretKey || '') && !isBrowser(userAgent)) {
if (isDevelopmentFromSecretKey(secretKey || '') && !isBrowser(userAgent)) {
return signedOut(options, AuthErrorReason.HeaderMissingNonBrowser);
}
return undefined;
Expand All@@ -70,7 +70,7 @@ export const crossOriginRequestWithoutHeader: InterstitialRule = options => {

export const isPrimaryInDevAndRedirectsToSatellite: InterstitialRule = options => {
const { secretKey = '', isSatellite, searchParams } = options;
const isDev = isDevelopmentFromApiKey(secretKey);
const isDev = isDevelopmentFromSecretKey(secretKey);

if (isDev && !isSatellite && shouldRedirectToSatelliteUrl(searchParams)) {
return interstitial(options, AuthErrorReason.PrimaryRespondsToSyncing);
Expand All@@ -80,7 +80,7 @@ export const isPrimaryInDevAndRedirectsToSatellite: InterstitialRule = options =

export const potentialFirstLoadInDevWhenUATMissing: InterstitialRule = options => {
const { secretKey = '', clientUat } = options;
const res = isDevelopmentFromApiKey(secretKey);
const res = isDevelopmentFromSecretKey(secretKey);
if (res && !clientUat) {
return interstitial(options, AuthErrorReason.CookieUATMissing);
}
Expand All@@ -96,7 +96,7 @@ export const potentialRequestAfterSignInOrOutFromClerkHostedUiInDev: Interstitia
const crossOriginReferrer =
referrer && checkCrossOrigin({ originURL: new URL(referrer), host, forwardedHost, forwardedProto });

if (isDevelopmentFromApiKey(secretKey) && crossOriginReferrer) {
if (isDevelopmentFromSecretKey(secretKey) && crossOriginReferrer) {
return interstitial(options, AuthErrorReason.CrossOriginReferrer);
}
return undefined;
Expand All@@ -105,7 +105,7 @@ export const potentialRequestAfterSignInOrOutFromClerkHostedUiInDev: Interstitia
export const potentialFirstRequestOnProductionEnvironment: InterstitialRule = options => {
const { secretKey = '', clientUat, cookieToken } = options;

if (isProductionFromApiKey(secretKey) && !clientUat && !cookieToken) {
if (isProductionFromSecretKey(secretKey) && !clientUat && !cookieToken) {
return signedOut(options, AuthErrorReason.CookieAndUATMissing);
}
return undefined;
Expand Down
6 changes: 3 additions & 3 deletions packages/backend/src/tokens/request.ts
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
import { constants } from '../constants';
import { assertValidSecretKey } from '../util/assertValidSecretKey';
import { buildRequest, stripAuthorizationHeader } from '../util/IsomorphicRequest';
import { isDevelopmentFromApiKey } from '../util/shared';
import type { AuthStatusOptionsType, LoadResourcesOptions, RequestState } from './authStatus';
import { isDevelopmentFromSecretKey } from '../util/shared';
import type { AuthStatusOptionsType, RequestState } from './authStatus';
import { AuthErrorReason, interstitial, signedOut, unknownState } from './authStatus';
import type { TokenCarrier } from './errors';
import { TokenVerificationError, TokenVerificationErrorReason } from './errors';
Expand DownExpand Up@@ -32,7 +32,7 @@ export type OptionalVerifyTokenOptions = Partial<
export type AuthenticateRequestOptions = AuthStatusOptionsType & OptionalVerifyTokenOptions & { request: Request };

function assertSignInUrlExists(signInUrl: string | undefined, key: string): asserts signInUrl is string {
if (!signInUrl && isDevelopmentFromApiKey(key)) {
if (!signInUrl && isDevelopmentFromSecretKey(key)) {
throw new Error(`Missing signInUrl. Pass a signInUrl for dev instances if an app is satellite`);
}
}
Expand Down
8 changes: 8 additions & 0 deletions packages/backend/src/util/mergePreDefinedOptions.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
export function mergePreDefinedOptions<T extends Record<string, any>>(preDefinedOptions: T, options: Partial<T>): T {
return Object.keys(preDefinedOptions).reduce(
(obj: T, key: string) => {
return { ...obj, [key]: options[key] || obj[key] };
},
{ ...preDefinedOptions },
);
}
2 changes: 1 addition & 1 deletion packages/backend/src/util/shared.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
export { addClerkPrefix, getScriptUrl, getClerkJsMajorVersionOrTag } from '@clerk/shared/url';
export { callWithRetry } from '@clerk/shared/callWithRetry';
export { isDevelopmentFromApiKey, isProductionFromApiKey, parsePublishableKey } from '@clerk/shared/keys';
export { isDevelopmentFromSecretKey, isProductionFromSecretKey, parsePublishableKey } from '@clerk/shared/keys';
export { deprecated, deprecatedProperty } from '@clerk/shared/deprecated';

import { buildErrorThrower } from '@clerk/shared/error';
Expand Down
Loading