Uh oh!
There was an error while loading. Please reload this page.
fix(clerk-js): SignIn/SignUp component spacing adjustment - #2716
Conversation
🦋 Changeset detectedLatest commit: c454ad8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
octoper
commented
Feb 2, 2024
!preview |
609d90b to
ab1f1f2CompareHey @octoper, your preview is available.
|
| }), | ||
| sx, | ||
| ]} | ||
| gap={gap} |
There was a problem hiding this comment.
🙃 This could be gap={8} without decontructing it from the rest of the props.
| <Header.Root showLogo> | ||
| <Card.Alert>{card.error}</Card.Alert> |
There was a problem hiding this comment.
Why is the error inside the Header? On all the other screens, the error is outside the Header.Root component. 🤔
ab1f1f2 to
51d8811Compareanagstef
commented
Feb 5, 2024
!preview |
octoper
commented
Feb 5, 2024
!preview |
Description
This PR applies some last fixes to align implementations with designs.
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore