Skip to content

fix(clerk-js): Application logo rendering size - #3959

Merged
LekoArts merged 2 commits into
mainfrom
alexcarpenter/sdki-576-logo-display-height-super-small
Aug 16, 2024
Merged

fix(clerk-js): Application logo rendering size#3959
LekoArts merged 2 commits into
mainfrom
alexcarpenter/sdki-576-logo-display-height-super-small

Conversation

@alexcarpenter

@alexcarpenteralexcarpenter commented Aug 14, 2024

Copy link
Copy Markdown
Member

Description

Fixes issue where application logos were rendering smaller then intended. Reverts the changes to application logo from #2716

Fixes SDKI-576

Square logo:

Screenshot 2024-08-14 at 3 53 42 PM

Horizontal logo:

Screenshot 2024-08-14 at 3 54 36 PM

Vertical logo:

Screenshot 2024-08-14 at 3 55 27 PM

Clerk logo before and after:

BeforeAfter
Screenshot 2024-08-14 at 3 58 19 PMScreenshot 2024-08-14 at 3 58 28 PM

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-botBot commented Aug 14, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 7f18829

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
NameType
@clerk/clerk-jsPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@octoperoctoper left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@octoper
octoperforce-pushed the alexcarpenter/sdki-576-logo-display-height-super-small branch from a1217c3 to 7f18829CompareAugust 16, 2024 10:22
@LekoArts
LekoArts merged commit d36b0e1 into mainAug 16, 2024
@LekoArts
LekoArts deleted the alexcarpenter/sdki-576-logo-display-height-super-small branch August 16, 2024 11:19
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@alexcarpenter@tmilewski@octoper@LekoArts@clerk-cookie